49827 2010-11-19 13:57:38 -0800 [chromium] Renderer is resizing IOSurfaces when accelerated compositing is disabled. 2010-11-23 13:07:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 backer webkit-unassigned backer commit-queue kbr simon.fraser webkit.review.bot oldest_to_newest 311675 0 backer 2010-11-19 13:57:38 -0800 Resizing too often. 311676 1 74423 backer 2010-11-19 13:58:35 -0800 Created attachment 74423 Patch 311678 2 backer 2010-11-19 14:00:58 -0800 When accelerated compositing is triggered, m_layerRenderer is created. If we fall back to software rendering, m_layerRenderer is still set. At this point, we are resizing unnecessarily. 311681 3 74423 backer 2010-11-19 14:04:46 -0800 Comment on attachment 74423 Patch If it looks OK, can you please commit because I don't have committer status. 311857 4 ap 2010-11-19 20:59:58 -0800 Even though this is platform-specific code, it still needs a regression test, or an explanation of why there is none. Is this a measurable performance improvement? 311864 5 simon.fraser 2010-11-19 21:39:08 -0800 This bug has the worst title ever. What is resizing too often, and why? 312310 6 backer 2010-11-22 05:55:34 -0800 Updated the title to be more descriptive. Accelerated compositing on the Mac OS X version of Chromium (the only port currently using this code path) is to IOSurfaces, which do not need to be resized when accelerated compositing is disabled. As these surfaces are not visible when accelerated compositing is disabled, it does not cause any display artifacts. Fixing this bug will improve performance, but that improvement will probably be slight. This change is intended as a code clean-up in preparation for using this code path on Linux (http://codereview.chromium.org/5105006/) and Windows (http://codereview.chromium.org/4815001/). On the Linux side, this change does cause a noticeable performance improvement (less lag when switching from software rendering to accelerated compositing after doing a bunch of resizes). An improvement was not noticed on the Windows side. 312528 7 74423 kbr 2010-11-22 14:33:46 -0800 Comment on attachment 74423 Patch Please update the ChangeLog with the new synopsis. 312797 8 74654 backer 2010-11-23 05:58:38 -0800 Created attachment 74654 Patch 312798 9 webkit.review.bot 2010-11-23 06:01:15 -0800 Attachment 74654 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1 WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 312799 10 74655 backer 2010-11-23 06:04:55 -0800 Created attachment 74655 Patch 312920 11 74655 kbr 2010-11-23 10:45:51 -0800 Comment on attachment 74655 Patch Looks good to me. 312943 12 commit-queue 2010-11-23 11:35:15 -0800 The commit-queue encountered the following flaky tests while processing attachment 74655: transitions/transition-timing-function.html fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by kmccullough@apple.com, oliver@apple.com, pol@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. 312985 13 commit-queue 2010-11-23 13:06:09 -0800 The commit-queue encountered the following flaky tests while processing attachment 74655: http/tests/security/xssAuditor/full-block-link-onclick.html Please file bugs against the tests. These tests were authored by dbates@webkit.org. The commit-queue is continuing to process your patch. 312986 14 74655 commit-queue 2010-11-23 13:07:22 -0800 Comment on attachment 74655 Patch Clearing flags on attachment: 74655 Committed r72623: <http://trac.webkit.org/changeset/72623> 312987 15 commit-queue 2010-11-23 13:07:28 -0800 All reviewed patches have been landed. Closing bug. 74423 2010-11-19 13:58:35 -0800 2010-11-23 05:58:32 -0800 Patch bug-49827-20101119165757.patch text/plain 1226 backer ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDNiMmRkZjQ2OGEwZjVkOGRjNmEyNmE1OWZmNTM5NzgxZDU3YWVjOTAu LmUwYjVkNzFmOGFjN2E1ZDg3NWQyMmNlYTQ2MGEwYzY3ZDIxNDJkNTkgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTExLTE5ICBKb25hdGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlc2l6aW5nIHRvbyBvZnRlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ5ODI3CisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6cmVzaXplKToKKwogMjAxMC0xMS0xOCAgWmhl bnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGgg UnVzc2VsbC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggNjYyNTk0OTM3NDIx M2NiZmExMzNkYWUxMThmMTM0ODcwNTQwMTljMS4uNmQwYjI2ODUzMmIyYWU1MTg0MGY2NGZmYjgz NjRjMzkxNmM2M2MyNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTkzNyw3 ICs5MzcsNyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpyZXNpemUoY29uc3QgV2ViU2l6ZSYgbmV3U2l6 ZSkKICAgICB9CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgaWYgKG1f bGF5ZXJSZW5kZXJlcikgeworICAgIGlmIChtX2xheWVyUmVuZGVyZXIgJiYgaXNBY2NlbGVyYXRl ZENvbXBvc2l0aW5nQWN0aXZlKCkpIHsKICAgICAgICAgbV9sYXllclJlbmRlcmVyLT5yZXNpemVP bnNjcmVlbkNvbnRlbnQoSW50U2l6ZShzdGQ6Om1heCgxLCBtX3NpemUud2lkdGgpLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZDo6bWF4 KDEsIG1fc2l6ZS5oZWlnaHQpKSk7CiAgICAgfQo= 74654 2010-11-23 05:58:38 -0800 2010-11-23 06:04:50 -0800 Patch bug-49827-20101123085755.patch text/plain 1459 backer ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGZjM2FkZmU4NTM3OTYzNGQ1NWUwOTU0ZWRkMzUxNDA1YjA3ZDk3NWUu LmIxMDdlYzc3YThiNWNkMWM4ZWRhOGUzMDA1NGM3NmY3YjZlMjZlYzcgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTExLTIzICBKb25hdGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbmRlcmVyIGlzIHJlc2l6aW5nIElPU3VyZmFjZXMgd2hlbiBhY2NlbGVyYXRlZCBjb21w b3NpdGluZyBpcyBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ5ODI3CisKKwktIElPU3VyZmFjZXMgYXJlIG9ubHkgcHJlc2VudGVkIHdo ZW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaXMgZW5hYmxlZC4KKwktIFNsaWdodCBwZXJmb3Jt YW5jZSBpbmNyZWFzZSAoYW5kIGNsZWFuLXVwIGZvciB1c2luZyB0aGlzIHBhdGggZm9yIExpbnV4 IGFuZCBXaW5kb3dzKS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlZpZXdJbXBsOjpyZXNpemUpOgorCiAyMDEwLTExLTIzICBTYXRpc2ggU2Ft cGF0aCAgPHNhdGlzaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgY2hyb21p dW0gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBmZjQ1ZDcx M2VmMGVkNjM3ZGViNTQ1NmVmOWUzOGUzYzI5Njc5MDlmLi5lZmNiMzZkZjY5OWNjZjI4ODdhN2I1 N2Y3OWRhYjc1OTdhZjA2NjRkIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAt OTM3LDcgKzkzNyw3IEBAIHZvaWQgV2ViVmlld0ltcGw6OnJlc2l6ZShjb25zdCBXZWJTaXplJiBu ZXdTaXplKQogICAgIH0KIAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBp ZiAobV9sYXllclJlbmRlcmVyKSB7CisgICAgaWYgKG1fbGF5ZXJSZW5kZXJlciAmJiBpc0FjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUoKSkgewogICAgICAgICBtX2xheWVyUmVuZGVyZXItPnJl c2l6ZU9uc2NyZWVuQ29udGVudChJbnRTaXplKHN0ZDo6bWF4KDEsIG1fc2l6ZS53aWR0aCksCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3Rk OjptYXgoMSwgbV9zaXplLmhlaWdodCkpKTsKICAgICB9Cg== 74655 2010-11-23 06:04:55 -0800 2010-11-23 13:07:22 -0800 Patch bug-49827-20101123090412.patch text/plain 1473 backer ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGZjM2FkZmU4NTM3OTYzNGQ1NWUwOTU0ZWRkMzUxNDA1YjA3ZDk3NWUu LjY2NTczN2Y2OTZlMjc4NjM1MDI3NGE4YzgxM2I0NmEyMDA4M2EyMzIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTExLTIzICBKb25hdGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbmRlcmVyIGlzIHJlc2l6aW5nIElPU3VyZmFjZXMgd2hlbiBhY2NlbGVyYXRlZCBjb21w b3NpdGluZyBpcyBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ5ODI3CisKKyAgICAgICAgLSBJT1N1cmZhY2VzIGFyZSBvbmx5IHByZXNl bnRlZCB3aGVuIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQuCisgICAgICAgIC0g U2xpZ2h0IHBlcmZvcm1hbmNlIGluY3JlYXNlIChhbmQgY2xlYW4tdXAgZm9yIHVzaW5nIHRoaXMg cGF0aCBmb3IgTGludXggYW5kIFdpbmRvd3MpLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnJlc2l6ZSk6CisKIDIwMTAtMTEt MjMgIFNhdGlzaCBTYW1wYXRoICA8c2F0aXNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCBjaHJvbWl1bSBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CmluZGV4IGZmNDVkNzEzZWYwZWQ2MzdkZWI1NDU2ZWY5ZTM4ZTNjMjk2NzkwOWYuLmVmY2IzNmRm Njk5Y2NmMjg4N2E3YjU3Zjc5ZGFiNzU5N2FmMDY2NGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwCkBAIC05MzcsNyArOTM3LDcgQEAgdm9pZCBXZWJWaWV3SW1wbDo6cmVzaXplKGNv bnN0IFdlYlNpemUmIG5ld1NpemUpCiAgICAgfQogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQotICAgIGlmIChtX2xheWVyUmVuZGVyZXIpIHsKKyAgICBpZiAobV9sYXllclJlbmRl cmVyICYmIGlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKSB7CiAgICAgICAgIG1fbGF5 ZXJSZW5kZXJlci0+cmVzaXplT25zY3JlZW5Db250ZW50KEludFNpemUoc3RkOjptYXgoMSwgbV9z aXplLndpZHRoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzdGQ6Om1heCgxLCBtX3NpemUuaGVpZ2h0KSkpOwogICAgIH0K