49799 2010-11-19 05:31:08 -0800 createImageBuffer fail should be handled in the same way as other fails 2022-02-28 03:59:01 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zherczeg webkit-unassigned krit mdelaney7 zimmermann oldest_to_newest 311383 0 zherczeg 2010-11-19 05:31:08 -0800 When the width of the absoluteDrawingRegion is less than 0.5 (and rounded to 0, but not empty), only a plain "return false" is executed. 311388 1 74375 zherczeg 2010-11-19 05:39:33 -0800 Created attachment 74375 patch 311392 2 74375 zimmermann 2010-11-19 05:47:30 -0800 Comment on attachment 74375 patch Patch looks great, one nitpick. I don't like the name of the test, filter-x.svg. How about 'filter-small-x-should-still-render.svg'? Or something alike... 311405 3 74375 krit 2010-11-19 06:12:27 -0800 Comment on attachment 74375 patch View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review > WebCore/ChangeLog:9 > + When createImageBuffer fails (i.e the image width or height is less than > + 0.5, which is rounded to 0) it just returs with false. Since the m_filter How can this happen? enclosingIntRect should cause a ImageBuffer of 1x1 for a width and height of 0.5x0.5? 311409 4 krit 2010-11-19 06:15:09 -0800 Hmm, saw the rounding suff in SVGImageBufferTools, Niko shouldn't we use enclosingIntSize here? 311411 5 zherczeg 2010-11-19 06:15:41 -0800 Landed in http://trac.webkit.org/changeset/72389 Closing bug. 311413 6 zherczeg 2010-11-19 06:17:36 -0800 Dirk, see the example. absoluteDrawingRegion.width < 0.5 in this case 311431 7 74375 krit 2010-11-19 06:58:58 -0800 Comment on attachment 74375 patch View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review Maybe I misunderstood the intention of the after reading the text in the ChangeLog. > LayoutTests/svg/filters/filter-x.svg:7 > +<filter id="filt" filterUnits="userSpaceOnUse" x="9.51" y="5" width="10" height="10"> > + <feFlood flood-color="red" /> > +</filter> > +</defs> > +<rect x="0" y="0" width="10" height="10" filter="url(#filt)"/> Why does it test the case, where width or height are < 0.5 like in the bug description? Just x has a fractional part. How is it related to the described problem? Also, the reference image is red. We prefer green rects of the size 100x100. (The size is not a dogma) > WebCore/rendering/RenderSVGResourceFilter.cpp:235 > + if (!SVGImageBufferTools::createImageBuffer(absoluteDrawingRegion, absoluteDrawingRegion, sourceGraphic, ColorSpaceLinearRGB)) { > + ASSERT(!m_filter.contains(object)); > + filterData->savedContext = context; > + m_filter.set(object, filterData.leakPtr()); > return false; > + } I agree, that the failure handling wasn't correct here. Just a bit confused why you were talking about width or height < 0.5 and how the test checks the correct handling. Since the test should return true here?!? :-P 311434 8 zimmermann 2010-11-19 07:03:39 -0800 (In reply to comment #7) > (From update of attachment 74375 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review > > Maybe I misunderstood the intention of the after reading the text in the ChangeLog. > > > LayoutTests/svg/filters/filter-x.svg:7 > > +<filter id="filt" filterUnits="userSpaceOnUse" x="9.51" y="5" width="10" height="10"> > > + <feFlood flood-color="red" /> > > +</filter> > > +</defs> > > +<rect x="0" y="0" width="10" height="10" filter="url(#filt)"/> > > Why does it test the case, where width or height are < 0.5 like in the bug description? Just x has a fractional part. How is it related to the described problem? width - x = 0.49 px. > > Also, the reference image is red. We prefer green rects of the size 100x100. (The size is not a dogma) True, we should have changed it to green. > > > WebCore/rendering/RenderSVGResourceFilter.cpp:235 > > + if (!SVGImageBufferTools::createImageBuffer(absoluteDrawingRegion, absoluteDrawingRegion, sourceGraphic, ColorSpaceLinearRGB)) { > > + ASSERT(!m_filter.contains(object)); > > + filterData->savedContext = context; > > + m_filter.set(object, filterData.leakPtr()); > > return false; > > + } > > I agree, that the failure handling wasn't correct here. Just a bit confused why you were talking about width or height < 0.5 and how the test checks the correct handling. Since the test should return true here?!? :-P 311436 9 krit 2010-11-19 07:05:07 -0800 (In reply to comment #7) > (From update of attachment 74375 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review > > Maybe I misunderstood the intention of the after reading the text in the ChangeLog. > > > LayoutTests/svg/filters/filter-x.svg:7 > > +<filter id="filt" filterUnits="userSpaceOnUse" x="9.51" y="5" width="10" height="10"> > > + <feFlood flood-color="red" /> > > +</filter> > > +</defs> > > +<rect x="0" y="0" width="10" height="10" filter="url(#filt)"/> > > Why does it test the case, where width or height are < 0.5 like in the bug description? Just x has a fractional part. How is it related to the described problem? Talked with Niko about the image size. Sorry the test _is_ correct for the check of the correct behavior _inside_ of SVGFilter.Nevertheless, a red reference image is not a good idea. Not related to this bug: We should create a ImageBuffer for 0.49 sized images. This is why I was talking about enclosingIntRect/size. 311441 10 zimmermann 2010-11-19 07:13:39 -0800 (In reply to comment #9) > (In reply to comment #7) > > (From update of attachment 74375 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review > > > > Maybe I misunderstood the intention of the after reading the text in the ChangeLog. > > > > > LayoutTests/svg/filters/filter-x.svg:7 > > > +<filter id="filt" filterUnits="userSpaceOnUse" x="9.51" y="5" width="10" height="10"> > > > + <feFlood flood-color="red" /> > > > +</filter> > > > +</defs> > > > +<rect x="0" y="0" width="10" height="10" filter="url(#filt)"/> > > > > Why does it test the case, where width or height are < 0.5 like in the bug description? Just x has a fractional part. How is it related to the described problem? > Talked with Niko about the image size. Sorry the test _is_ correct for the check of the correct behavior _inside_ of SVGFilter.Nevertheless, a red reference image is not a good idea. > > Not related to this bug: We should create a ImageBuffer for 0.49 sized images. This is why I was talking about enclosingIntRect/size. Really, do you think there's any gain, filtering a 0.49px image buffer? :-) Anyhow, however wants to work on it, be careful with the lroundfs, they're there on purpose. Suppose you want a 199.51 px image buffer, we'd now allocate a 199px image buffer, and _scale the context_ accordingly by 199/199.51, so it perfectly fits into the buffer. Otherwhise you'll get artefacts on zooming. 311461 11 krit 2010-11-19 07:55:12 -0800 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #7) > > > (From update of attachment 74375 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review > > > > > > Maybe I misunderstood the intention of the after reading the text in the ChangeLog. > > > > > > > LayoutTests/svg/filters/filter-x.svg:7 > > > > +<filter id="filt" filterUnits="userSpaceOnUse" x="9.51" y="5" width="10" height="10"> > > > > + <feFlood flood-color="red" /> > > > > +</filter> > > > > +</defs> > > > > +<rect x="0" y="0" width="10" height="10" filter="url(#filt)"/> > > > > > > Why does it test the case, where width or height are < 0.5 like in the bug description? Just x has a fractional part. How is it related to the described problem? > > Talked with Niko about the image size. Sorry the test _is_ correct for the check of the correct behavior _inside_ of SVGFilter.Nevertheless, a red reference image is not a good idea. > > > > Not related to this bug: We should create a ImageBuffer for 0.49 sized images. This is why I was talking about enclosingIntRect/size. > Really, do you think there's any gain, filtering a 0.49px image buffer? :-) > Anyhow, however wants to work on it, be careful with the lroundfs, they're there on purpose. > > Suppose you want a 199.51 px image buffer, we'd now allocate a 199px image buffer, and _scale the context_ accordingly by 199/199.51, so it perfectly fits into the buffer. Otherwhise you'll get artefacts on zooming. But is it really a big problem (performance and allocation) to make it 1px larger and scale it up instead, but have a correct result, always? 311510 12 zherczeg 2010-11-19 09:04:32 -0800 Sory for the red rect. Maybe this requires a rework, and when it is done, the image update can be submited with it. Or not? 311522 13 krit 2010-11-19 09:37:43 -0800 (In reply to comment #12) > Sory for the red rect. Maybe this requires a rework, and when it is done, the image update can be submited with it. Or not? Yes, would be great. Thanks! 74375 2010-11-19 05:39:33 -0800 2022-02-28 03:59:01 -0800 patch 0001-clip-bug.patch text/plain 7631 zherczeg RnJvbSA4YmUxYTlhMGY1MTMzNzgzMDc1ZmE4ZjY4ZDI0ODM1NGNiMTBiYzllIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDE5IE5vdiAyMDEwIDE0OjM3OjQyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gY2xpcC1idWcKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3plZ0BpbmYu dS1zemVnZWQuaHU+Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL21hYy9zdmcvZmlsdGVycy9maWx0 ZXIteC1leHBlY3RlZC5jaGVja3N1bSAgICAgfCAgICAxICsKIC4uLi9wbGF0Zm9ybS9tYWMvc3Zn L2ZpbHRlcnMvZmlsdGVyLXgtZXhwZWN0ZWQucG5nIHwgIEJpbiAwIC0+IDExMzU3IGJ5dGVzCiBM YXlvdXRUZXN0cy9zdmcvZmlsdGVycy9maWx0ZXIteC1leHBlY3RlZC50eHQgICAgICB8ICAgIDkg KysrKysrKysrCiBMYXlvdXRUZXN0cy9zdmcvZmlsdGVycy9maWx0ZXIteC5zdmcgICAgICAgICAg ICAgICB8ICAgIDggKysrKysrKysKIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBXZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRlci5jcHAgICAgICB8ICAgIDYgKysrKystCiA3IGZpbGVz IGNoYW5nZWQsIDUxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx MDA2NDQgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9maWx0ZXJzL2ZpbHRlci14LWV4cGVj dGVkLmNoZWNrc3VtCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L3N2Zy9maWx0ZXJzL2ZpbHRlci14LWV4cGVjdGVkLnBuZwogY3JlYXRlIG1vZGUgMTAwNjQ0IExh eW91dFRlc3RzL3N2Zy9maWx0ZXJzL2ZpbHRlci14LWV4cGVjdGVkLnR4dAogY3JlYXRlIG1vZGUg MTAwNjQ0IExheW91dFRlc3RzL3N2Zy9maWx0ZXJzL2ZpbHRlci14LnN2ZwoKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkMjA5 Y2I4Li4yNDI0YWE5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTkgIFpvbHRhbiBI ZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjcmVhdGVJbWFnZUJ1ZmZlciBmYWlsIHNob3VsZCBiZSBo YW5kbGVkIGluIHRoZSBzYW1lIHdheSBhcyBvdGhlciBmYWlscworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3OTkKKworICAgICAgICAqIHBsYXRmb3Jt L21hYy9zdmcvZmlsdGVycy9maWx0ZXIteC1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAg ICAgICogcGxhdGZvcm0vbWFjL3N2Zy9maWx0ZXJzL2ZpbHRlci14LWV4cGVjdGVkLnBuZzogQWRk ZWQuCisgICAgICAgICogc3ZnL2ZpbHRlcnMvZmlsdGVyLXgtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBzdmcvZmlsdGVycy9maWx0ZXIteC5zdmc6IEFkZGVkLgorCiAyMDEwLTExLTE3 ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBUd28gbW9yZSB0ZXN0 cyBuZWVkaW5nIG5ldyByZXN1bHRzIGFmdGVyIHI3MjE3My4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9zdmcvZmlsdGVycy9maWx0ZXIteC1leHBlY3RlZC5jaGVja3N1bSBi L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvZmlsdGVycy9maWx0ZXIteC1leHBlY3RlZC5j aGVja3N1bQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hNjc5MDcxCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9maWx0ZXJzL2ZpbHRl ci14LWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0wLDAgKzEgQEAKKzkxZWVjMjBmMGMwZmFlNWE4ZTU0 NjcwMTAxZjJiZWVkClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9maWx0ZXJzL2ZpbHRlci14LWV4cGVjdGVkLnBuZyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvZmlsdGVycy9maWx0ZXIteC1leHBlY3RlZC5w bmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNzExZTkzOTc4MWE4NTVjNDA4M2IzZWQ0ZWYwZDAyYjEzNmQyMjU4NApH SVQgYmluYXJ5IHBhdGNoCmxpdGVyYWwgMTEzNTcKemNtZUFTQE4/KG9sSHlgdVZCcSFpYTB5fnlV eyt2WVYyYT5pMUIlUWxZYnBRPVNaNnZyMlk1Tz1EK0NuZnIpQjEoCnpHQjh2eXdvZFdSeERwYEpf UDxCN1gtbV9KdHp1SWlJQ1hEUHdZJCgyYTY1REJ3VFhvaXpiYDFBRmV5JSNALTtTYAp6REprRks7 ZHRqflJGfH1UTjRNNF5yKEZSQk9TdmFIejBNOX5ET3tANTtiYjBrPzchTXVBRlZLYm03aGlEPmQo SiEKelYraUZCP25genhOd3sldF9zTWxEJTNnZUUqakIrNXkyODxQTV5NfUlFJFR3UVluTyVESnp4 S0ZkJSUqXk9gZ1pQCnp6Ukoke3VfZ0VHVSs/fjtfcGolRGAhKDw5dWdaSz1Kej1JVXg3U0BjMmNs S14rNGg4Z0k9TkBeQEBFfD4kckBBRAp6dGU/MVRTSEoxRiZvT1FtQDVoOVclWkgyYFIrKGlMd0xM Y1NPSlV1KUckU1NUT3lIKXg8LVc2UlJOclF2bXNyO0oKeipSQWVFPGJgOFhgeCkwfUhATkMrWik0 PF8qdnF7cER0QEVzNi1NcGZqVD8xRVo9WVhjRlRiP3gmZ3E8K1pgeS1iCnpFbmY0fGRGN1g0K1lM WFk0MnJqZ3szPX0/R0hkNXFuS2g0UnJpJEVJdl8zV1FsKHhiT15CWlM+b1YxTVVYcjVPUwp6JTNV eklfKVI/MTVqfT9NX0RzQHA0NSNJcEpFYXordm54SG5uT0VAaXNPQ0E9N2JoJjIjfk5FdHhvLUNR U0p+UlIKej8lR0BPWmZFM08zN1dSX3I9RVh0dE5OV3E5X0duNnY8bEFzaSNrQGxid2Y0KHI8NERi cDB7a1RvO0chMiQqUmVsCnpVNXMhNG5qfClOX3NRTlQpc25eajx+dGomaGE5X21TJGV+IWkpWUhl diZnKk15dz44cFluRD4hd31kfG9HZTMlNgp6Sj9afGBNeTA+dlh0VTk+ZUVWcylyWWxeKEprTXJj eDJMYn1faWJ8fVVwPHVjM3xuTERFYy1GQz95Y0EpcXhWKT4Kej88fVZNS2Y4SWBpREg+SFJ6X2o3 X2h1JDQ3aDUlRUp2aVhYQ3QybUE8ckIzdXt6QkhGIXlvcis+OGhPQ3Qpc1E7CnohXn4+Qy1fP0Uj NCV7YFdsVjRRV1Y9XyVTPENwY3srNWc9M3VlXlY4ZjgwdWFsTW94X2NZJjhCX1d6ayVuM0AqWgp6 K2FyQk48TUhXUE8rVk9IPVB0a1FIMEBlcW9UR25TPGI5RUtkZGN4Q157WSowST4rPyp4OTx7Sj07 SkdxVnNtcnIKem58JlZKZXlJSmFEWlZLLU9LeitGSWxHbXNwSHdhR2xieU15dUZ4IW9IfmF0USlk YG4ydF5WKyZjWT5aeF9RR3xjCno8fTJASmI/OylId2FZczxJUXB2SnpQQk9ZcjxaPnozUkNtamxz RW5BQCpCOyltJW9KaD9KfG1IYDdjJnlfKCM4Iwp6R2tWOWVnKHZHWDR4TFQpQCYze0c7RzJCOCQ0 fnR+eW97fSl5ZnhtfCkoaXteNDR5OElBcip7bz8+YyVwSkJxamoKekQhOzJndHJoOSR3IWkhS0B4 bGYxYjVBVzFgMXRrcnxJYmdgODVvJlpJME9fTjhoe0xianZEKDlaUiMqQ05jQEFDCnpma1RaVGwx UFFtMGZ4JCtUaDRHekVGMk9GYDxSaXFIZmtSfVUtVnZvLUNlJUF7PjEkKV4/NlN4QlZfZjJLUylu Rgp6JV9Ua15adG5xNE0mPjY9X0hFfmNJKWE1R01sR1FzQ1R6ekpnZjJmVzI/aDE5ZHdvSFUxZEJj fTAmM2NIPSVefiMKei01e1pZcGFUcStFOHBpTGReNFI+TFNlZTdvKnZ3VGpneSghUEklVmwzcXlQ aClVXlpYblZvQTIzSzRlQzUmN31QCnplJk8lOyYoeTZ5bklVeGNHfjkxVVN0WmZ9diVsZk16NlFv a19hfH5BYmYmUUlPekBmNzFvd3ImNFJIZzlaYE1WTQp6JGZodChTe1dwT2FOPSpFZ1gtTSVSTiVn dEFaWHhWNncyaVVfaD5APTBmdzlKUHFjITQ0SGgrR1YpSXokPCVvIXEKekh7MjJtemghcSRmVjw3 WD9FdTVjNUtSdCoja0d2Z0RmXlloaDJTMVAwZ1NZblRDOXEyaSNPO2VHYHVOKTspSE9VCnpCcU9z KkBLT2JZI290KFlDajlNLUBxb0tjS3s7VkdQKH1sVlgqOHVNakFrRFdmemRMQnA+ZWRKWjVYWTZT VTUoagp6V0cwcjtjOGJHajw0cihldl87RnZHfV9FKFh6WGJpP2ZaOyYyc3VXMyQpaUlEeiMpPitw I3Z0QyhlVl88KFYrdUAKeihWK3cyMjs9Q2AhUlhLZGFCTztYPXdOaXswNXBwK0kmPzVQYk80Oys4 WFk8cTlYYkZgUD52MkFhRjkyYntQVjl+CnoyP0dQaU1iS0orKFJ0PDNRTWwycDFYfHJOeC01ZmJi UUkyRWJRRXJNNmJgKFFYPj01QiRjQDYpaWA0TH1RKTt8aApSNHFQX087T1hrO3ZkJEA/Mj5gUmkz RT08JAoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3Zn L2ZpbHRlcnMvZmlsdGVyLXgtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2ZpbHRlcnMv ZmlsdGVyLXgtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LmY5Nzk3MzUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvZmlsdGVycy9maWx0 ZXIteC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgw MHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDAp IHNpemUgODAweDYwMAorICBSZW5kZXJTVkdSb290IHtzdmd9IGF0ICg5LDUpIHNpemUgMTF4MTAK KyAgICBSZW5kZXJTVkdIaWRkZW5Db250YWluZXIge2RlZnN9IGF0ICgwLDApIHNpemUgMHgwCisg ICAgICBSZW5kZXJTVkdSZXNvdXJjZUZpbHRlciB7ZmlsdGVyfSBbaWQ9ImZpbHQiXSBbZmlsdGVy VW5pdHM9dXNlclNwYWNlT25Vc2VdIFtwcmltaXRpdmVVbml0cz11c2VyU3BhY2VPblVzZV0KKyAg ICAgICAgW2ZlRmxvb2QgZmxvb2QtY29sb3I9IiNGRjAwMDAiIGZsb29kLW9wYWNpdHk9IjEuMDAi XQorICAgIFJlbmRlclNWR1BhdGgge3JlY3R9IGF0ICg5LDUpIHNpemUgMTF4MTAgW2ZpbGw9e1t0 eXBlPVNPTElEXSBbY29sb3I9IzAwMDAwMF19XSBbeD0wLjAwXSBbeT0wLjAwXSBbd2lkdGg9MTAu MDBdIFtoZWlnaHQ9MTAuMDBdCisgICAgICBbZmlsdGVyPSJmaWx0Il0gUmVuZGVyU1ZHUmVzb3Vy Y2VGaWx0ZXIge2ZpbHRlcn0gYXQgKDkuNTEsNSkgc2l6ZSAxMHgxMApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvc3ZnL2ZpbHRlcnMvZmlsdGVyLXguc3ZnIGIvTGF5b3V0VGVzdHMvc3ZnL2ZpbHRl cnMvZmlsdGVyLXguc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmZlNzVm NzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvZmlsdGVycy9maWx0ZXIteC5z dmcKQEAgLTAsMCArMSw4IEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2 ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPgorPGRlZnM+Cis8 ZmlsdGVyIGlkPSJmaWx0IiBmaWx0ZXJVbml0cz0idXNlclNwYWNlT25Vc2UiIHg9IjkuNTEiIHk9 IjUiIHdpZHRoPSIxMCIgaGVpZ2h0PSIxMCI+CisgICAgPGZlRmxvb2QgZmxvb2QtY29sb3I9InJl ZCIgLz4KKzwvZmlsdGVyPgorPC9kZWZzPgorPHJlY3QgeD0iMCIgeT0iMCIgd2lkdGg9IjEwIiBo ZWlnaHQ9IjEwIiBmaWx0ZXI9InVybCgjZmlsdCkiLz4KKzwvc3ZnPgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ODMwYTVjLi5hM2M5YjA0 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE5IEBACisyMDEwLTExLTE5ICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgY3JlYXRlSW1hZ2VCdWZmZXIgZmFpbCBzaG91bGQgYmUgaGFuZGxlZCBpbiB0aGUgc2FtZSB3 YXkgYXMgb3RoZXIgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ5Nzk5CisKKyAgICAgICAgV2hlbiBjcmVhdGVJbWFnZUJ1ZmZlciBmYWlscyAo aS5lIHRoZSBpbWFnZSB3aWR0aCBvciBoZWlnaHQgaXMgbGVzcyB0aGFuCisgICAgICAgIDAuNSwg d2hpY2ggaXMgcm91bmRlZCB0byAwKSBpdCBqdXN0IHJldHVycyB3aXRoIGZhbHNlLiBTaW5jZSB0 aGUgbV9maWx0ZXIKKyAgICAgICAgaGFzaCBtYXAgaXMgbm90IHVwZGF0ZWQgaW4gdGhpcyBjYXNl LCB0aGUgZmlsdGVyIGltYWdlIGlzIG5vdCBkcmF3bi4KKworICAgICAgICBUZXN0OiBzdmcvZmls dGVycy9maWx0ZXIteC5zdmcKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJTVkdSZXNvdXJj ZUZpbHRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdSZXNvdXJjZUZpbHRlcjo6 YXBwbHlSZXNvdXJjZSk6CisKIDIwMTAtMTEtMTYgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIE1vdmUgUVRNb3ZpZVdpbidzIHNldHRpbmdzIGludG8gYSB2c3Byb3Bz IGZpbGUKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jlc291cmNlRmls dGVyLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jlc291cmNlRmlsdGVyLmNwcApp bmRleCA1MGNmNjhlLi42MGJmNDUwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTVkdSZXNvdXJjZUZpbHRlci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZH UmVzb3VyY2VGaWx0ZXIuY3BwCkBAIC0yMjcsOCArMjI3LDEyIEBAIGJvb2wgUmVuZGVyU1ZHUmVz b3VyY2VGaWx0ZXI6OmFwcGx5UmVzb3VyY2UoUmVuZGVyT2JqZWN0KiBvYmplY3QsIFJlbmRlclN0 eWxlKiwKICAgICBhYnNvbHV0ZURyYXdpbmdSZWdpb24uc2NhbGUoc2NhbGUud2lkdGgoKSwgc2Nh bGUuaGVpZ2h0KCkpOwogCiAgICAgT3duUHRyPEltYWdlQnVmZmVyPiBzb3VyY2VHcmFwaGljOwot ICAgIGlmICghU1ZHSW1hZ2VCdWZmZXJUb29sczo6Y3JlYXRlSW1hZ2VCdWZmZXIoYWJzb2x1dGVE cmF3aW5nUmVnaW9uLCBhYnNvbHV0ZURyYXdpbmdSZWdpb24sIHNvdXJjZUdyYXBoaWMsIENvbG9y U3BhY2VMaW5lYXJSR0IpKQorICAgIGlmICghU1ZHSW1hZ2VCdWZmZXJUb29sczo6Y3JlYXRlSW1h Z2VCdWZmZXIoYWJzb2x1dGVEcmF3aW5nUmVnaW9uLCBhYnNvbHV0ZURyYXdpbmdSZWdpb24sIHNv dXJjZUdyYXBoaWMsIENvbG9yU3BhY2VMaW5lYXJSR0IpKSB7CisgICAgICAgIEFTU0VSVCghbV9m aWx0ZXIuY29udGFpbnMob2JqZWN0KSk7CisgICAgICAgIGZpbHRlckRhdGEtPnNhdmVkQ29udGV4 dCA9IGNvbnRleHQ7CisgICAgICAgIG1fZmlsdGVyLnNldChvYmplY3QsIGZpbHRlckRhdGEubGVh a1B0cigpKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KICAgICAKICAgICBHcmFwaGlj c0NvbnRleHQqIHNvdXJjZUdyYXBoaWNDb250ZXh0ID0gc291cmNlR3JhcGhpYy0+Y29udGV4dCgp OwogICAgIEFTU0VSVChzb3VyY2VHcmFwaGljQ29udGV4dCk7Ci0tIAoxLjYuMC40Cgo=