49781 2010-11-18 19:39:28 -0800 [GTK] fast/text/international tests are flaky on the bots 2010-11-19 10:03:07 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned alex dbates oldest_to_newest 311252 0 mrobinson 2010-11-18 19:39:28 -0800 Tests from fast/text/international fail inconsistently on the bots. Perhaps related we also see FontCache assertion failures such as this one: http://webkit-bots.igalia.com/amd64/svn_72340.core-when_1290124096-_-who_DumpRenderTree-_-why_11.trace.html . 311256 1 74348 mrobinson 2010-11-18 19:54:13 -0800 Created attachment 74348 Patch for this issue 311259 2 74348 dbates 2010-11-18 19:57:19 -0800 Comment on attachment 74348 Patch for this issue After talking with Martin about this issue and running layout tests repeatedly as a means to verify correctness, I feel that this patch is reasonable. 311536 3 mrobinson 2010-11-19 10:03:07 -0800 Committed r72413: <http://trac.webkit.org/changeset/72413> 74348 2010-11-18 19:54:13 -0800 2010-11-18 19:57:51 -0800 Patch for this issue bug-49781-20101118195411.patch text/plain 2024 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjg3YzdjM2E5OWUyZmNlNjYyNjA2YTMyNzExMjEyNjk3MWE0NDMzNC4uYTZiNWRkOWUxNTU1ZTM5 NzM5NTk1NmQzMWRiZmEyMjE3ODIzOTk0MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMS0xOCAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gZmFzdC90ZXh0L2ludGVybmF0aW9u YWwgdGVzdHMgYXJlIGZsYWt5IG9uIHRoZSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTc4MQorCisgICAgICAgIEJlZWYgdXAgdGhlID09IG9w ZXJhdG9yIG92ZXJsb2FkIGZvciBGcmVldHlwZSBGb250UGxhdGZvcm1EYXRhLiBCZWZvcmUKKyAg ICAgICAgaWYgdHdvIEZvbnRQbGF0Zm9ybURhdGFzIGhhZCBoYXNoIHZhbHVlcyB3aGljaCBmZWxs IGludG8gdGhlIHNhbWUgYnVja2V0CisgICAgICAgIGFuZCB3ZXJlIHNpbWlsYXIgZW5vdWdoLCB0 aGV5IHdvdWxkIGJlIGV2YWx1YXRlZCBhcyBiZWluZyBlcXVhbCwgbGVhZGluZworICAgICAgICB0 byBmYWlsdXJlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMgZm9yIHRoaXMgY2hhbmdlLiBJdCdz IHZlcnkgaGFyZCB0byB0ZXN0LCBiZWNhdXNlIGl0IGRlcGVuZHMKKyAgICAgICAgb24gdGhlIG1l bW9yeSBhZGRyZXNzIG9mIG5ldyBhbGxvY2F0aW9ucy4gSG9wZWZ1bGx5IGZsYWtpbmVzcyBvbiB0 aGUgYm90cworICAgICAgICB3aWxsIGdvIGF3YXkgYWZ0ZXIgcGF0Y2guCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6b3BlcmF0b3I9PSk6IEJlZWYgdXAg dGhlID09IG9wZXJhdG9yIG92ZXJsb2FkLgorCiAyMDEwLTExLTE3ICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0 YUZyZWVUeXBlLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBs YXRmb3JtRGF0YUZyZWVUeXBlLmNwcAppbmRleCAzOTQwODJkYmFmOGVkYjIzNzBhZDM5MTgzMjUx ZTM1YzIzOGUzMzlmLi5jMDc1NmVlYzhkMjI4ZGM1ZDgyZDU4NGZjNzQ1NTQ1ZGNhYmZmNmM4IDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9y bURhdGFGcmVlVHlwZS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlw ZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCkBAIC0yMjgsNyArMjI4LDkgQEAgYm9vbCBG b250UGxhdGZvcm1EYXRhOjpvcGVyYXRvcj09KGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIG90aGVy KSBjb25zdAogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAoIW1fcGF0dGVybiB8fCAhb3Ro ZXIubV9wYXR0ZXJuKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgcmV0dXJuIEZjUGF0dGVy bkVxdWFsKG1fcGF0dGVybi5nZXQoKSwgb3RoZXIubV9wYXR0ZXJuLmdldCgpKTsKKyAgICByZXR1 cm4gRmNQYXR0ZXJuRXF1YWwobV9wYXR0ZXJuLmdldCgpLCBvdGhlci5tX3BhdHRlcm4uZ2V0KCkp CisgICAgICAgICYmIG1fc2NhbGVkRm9udCA9PSBvdGhlci5tX3NjYWxlZEZvbnQgJiYgbV9zaXpl ID09IG90aGVyLm1fc2l6ZQorICAgICAgICAmJiBtX3N5bnRoZXRpY09ibGlxdWUgPT0gb3RoZXIu bV9zeW50aGV0aWNPYmxpcXVlICYmIG1fc3ludGhldGljQm9sZCA9PSBvdGhlci5tX3N5bnRoZXRp Y0JvbGQ7IAogfQogCiAjaWZuZGVmIE5ERUJVRwo=