49777 2010-11-18 17:53:51 -0800 nrwt multiprocessing - minor cleanup 2010-11-19 17:48:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 49566 1 dpranke dpranke abarth eric hayato ojan tony oldest_to_newest 311215 0 dpranke 2010-11-18 17:53:51 -0800 nrwt - multiprocessing minor cleanup 311216 1 74332 dpranke 2010-11-18 17:54:44 -0800 Created attachment 74332 Patch 311224 2 74332 ojan 2010-11-18 18:19:57 -0800 Comment on attachment 74332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74332&action=review > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:404 > + result = self._run_test_in_this_thread(test_input) nit: s/this/current/ I think is a more common word choice. Don't feel strongly though. 311782 3 74332 dpranke 2010-11-19 17:48:24 -0800 Comment on attachment 74332 Patch Clearing flags on attachment: 74332 Committed r72457: <http://trac.webkit.org/changeset/72457> 311783 4 dpranke 2010-11-19 17:48:31 -0800 All reviewed patches have been landed. Closing bug. 74332 2010-11-18 17:54:44 -0800 2010-11-19 17:48:24 -0800 Patch bug-49777-20101118175442.patch text/plain 4252 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwYjQ4ZWJiMmVmY2RmYmQ1ZGRiYThlOTBlMzhiMGJkYTZjMzExOGY1Li41MGYwMzAy MWNiOWNlMWI4MDA4OGRiZGYyMGY1Yzk4YWUwMGM3YzQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTAtMTEtMTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gc29tZSBtaW5vciBj bGVhbnVwIGFuZCBidWcgZml4aW5nLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00OTc3NworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvZHVtcF9yZW5kZXJfdHJlZV90aHJlYWQucHk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0 dGVzdC5weToKKworMjAxMC0xMS0xOCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgogCiAgICAgICAgIG5ldy1ydW4t d2Via2l0LXRlc3RzOiBjcmVhdGUgZmlyc3QgcGFydCBvZiAnbWVzc2FnZV9icm9rZXInIGNsYXNz IGZvciBtdWx0aXByb2Nlc3NpbmcgZml4ZXMKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVf dGhyZWFkLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvZHVtcF9yZW5kZXJfdHJlZV90aHJlYWQucHkKaW5kZXggZGU5N2FkNGU4YTcx N2Q0M2NiNDc5Mjk1OTdhNWUwNmZkNjVlNTA0NS4uNDhkZmIxNmNkOWZkMTBhZmFkN2Q4M2Q5ZGU2 ZTgwNDU5OTdmMTg3NyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvZHVtcF9yZW5kZXJfdHJlZV90aHJlYWQucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2th Z2UvZHVtcF9yZW5kZXJfdHJlZV90aHJlYWQucHkKQEAgLTM5OSw5ICszOTksOSBAQCBjbGFzcyBU ZXN0U2hlbGxUaHJlYWQoV2F0Y2hhYmxlVGhyZWFkKToKICAgICAgICAgICAgIGJhdGNoX2NvdW50 ICs9IDEKICAgICAgICAgICAgIHNlbGYuX251bV90ZXN0cyArPSAxCiAgICAgICAgICAgICBpZiBz ZWxmLl9vcHRpb25zLnJ1bl9zaW5nbHk6Ci0gICAgICAgICAgICAgICAgcmVzdWx0ID0gc2VsZi5f cnVuX3Rlc3Rfc2luZ2x5KHRlc3RfaW5wdXQpCisgICAgICAgICAgICAgICAgcmVzdWx0ID0gc2Vs Zi5fcnVuX3Rlc3RfaW5fYW5vdGhlcl90aHJlYWQodGVzdF9pbnB1dCkKICAgICAgICAgICAgIGVs c2U6Ci0gICAgICAgICAgICAgICAgcmVzdWx0ID0gc2VsZi5fcnVuX3Rlc3QodGVzdF9pbnB1dCkK KyAgICAgICAgICAgICAgICByZXN1bHQgPSBzZWxmLl9ydW5fdGVzdF9pbl90aGlzX3RocmVhZCh0 ZXN0X2lucHV0KQogCiAgICAgICAgICAgICBmaWxlbmFtZSA9IHRlc3RfaW5wdXQuZmlsZW5hbWUK ICAgICAgICAgICAgIHRlc3RzX3J1bl9maWxlLndyaXRlKGZpbGVuYW1lICsgIlxuIikKQEAgLTQz MSw3ICs0MzEsNyBAQCBjbGFzcyBUZXN0U2hlbGxUaHJlYWQoV2F0Y2hhYmxlVGhyZWFkKToKICAg ICAgICAgICAgIGlmIHRlc3RfcnVubmVyOgogICAgICAgICAgICAgICAgIHRlc3RfcnVubmVyLnVw ZGF0ZV9zdW1tYXJ5KHJlc3VsdF9zdW1tYXJ5KQogCi0gICAgZGVmIF9ydW5fdGVzdF9zaW5nbHko c2VsZiwgdGVzdF9pbnB1dCk6CisgICAgZGVmIF9ydW5fdGVzdF9pbl9hbm90aGVyX3RocmVhZChz ZWxmLCB0ZXN0X2lucHV0KToKICAgICAgICAgIiIiUnVuIGEgdGVzdCBpbiBhIHNlcGFyYXRlIHRo cmVhZCwgZW5mb3JjaW5nIGEgaGFyZCB0aW1lIGxpbWl0LgogCiAgICAgICAgIFNpbmNlIHdlIGNh biBvbmx5IGRldGVjdCB0aGUgdGVybWluYXRpb24gb2YgYSB0aHJlYWQsIG5vdCBhbnkgaW50ZXJu YWwKQEAgLTQ0Myw3ICs0NDMsNiBAQCBjbGFzcyBUZXN0U2hlbGxUaHJlYWQoV2F0Y2hhYmxlVGhy ZWFkKToKIAogICAgICAgICBSZXR1cm5zOgogICAgICAgICAgIEEgVGVzdFJlc3VsdAotCiAgICAg ICAgICIiIgogICAgICAgICB3b3JrZXIgPSBTaW5nbGVUZXN0VGhyZWFkKHNlbGYuX3BvcnQsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fb3B0aW9ucywKQEAgLTQ3OCwx MSArNDc3LDExIEBAIGNsYXNzIFRlc3RTaGVsbFRocmVhZChXYXRjaGFibGVUaHJlYWQpOgogICAg ICAgICAgICAgX2xvZy5lcnJvcignQ2Fubm90IGdldCByZXN1bHRzIG9mIHRlc3Q6ICVzJyAlCiAg ICAgICAgICAgICAgICAgICAgICAgIHRlc3RfaW5wdXQuZmlsZW5hbWUpCiAgICAgICAgICAgICBy ZXN1bHQgPSB0ZXN0X3Jlc3VsdHMuVGVzdFJlc3VsdCh0ZXN0X2lucHV0LmZpbGVuYW1lLCBmYWls dXJlcz1bXSwKLSAgICAgICAgICAgICAgICB0ZXN0X3J1bl90aW1lPTAsIHRvdGFsX3RpbWVfZm9y X2FsbF9kaWZmcz0wLCB0aW1lX2Zvcl9kaWZmcz0wKQorICAgICAgICAgICAgICAgIHRlc3RfcnVu X3RpbWU9MCwgdG90YWxfdGltZV9mb3JfYWxsX2RpZmZzPTAsIHRpbWVfZm9yX2RpZmZzPXt9KQog CiAgICAgICAgIHJldHVybiByZXN1bHQKIAotICAgIGRlZiBfcnVuX3Rlc3Qoc2VsZiwgdGVzdF9p bnB1dCk6CisgICAgZGVmIF9ydW5fdGVzdF9pbl90aGlzX3RocmVhZChzZWxmLCB0ZXN0X2lucHV0 KToKICAgICAgICAgIiIiUnVuIGEgc2luZ2xlIHRlc3QgZmlsZSB1c2luZyBhIHNoYXJlZCBEdW1w UmVuZGVyVHJlZSBwcm9jZXNzLgogCiAgICAgICAgIEFyZ3M6CmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0 ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0c191bml0dGVzdC5weQppbmRleCAwYmQxYjNhMzVjYTkxMjljMmI3YWM4ODIwNjdk Mzc2Mjk2YTg4YmIwLi4zZGZjM2U2MTI2MTRjNWI4YmQzYTMwZGYxY2VmOTU1NmE1MGZhNGM1IDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkKQEAgLTc3LDcgKzc3 LDcgQEAgZGVmIHBhc3NpbmdfcnVuKGV4dHJhX2FyZ3M9Tm9uZSwgcG9ydF9vYmo9Tm9uZSwgcmVj b3JkX3Jlc3VsdHM9RmFsc2UsCiAgICAgICAgICMgV2UgdXNlIHRoZSBnbG9iIHRvIHRlc3QgdGhh dCBnbG9iYmluZyB3b3Jrcy4KICAgICAgICAgYXJncy5leHRlbmQoWydwYXNzZXMnLAogICAgICAg ICAgICAgICAgICAgICAgJ2h0dHAvdGVzdHMnLAotICAgICAgICAgICAgICAgICAgICAgJ2h0dHAv dGVzdHMvd2Vic29ja2V0L3Rlc3RzJywKKyAgICAgICAgICAgICAgICAgICAgICd3ZWJzb2NrZXQv dGVzdHMnLAogICAgICAgICAgICAgICAgICAgICAgJ2ZhaWx1cmVzL2V4cGVjdGVkLyonXSkKICAg ICBvcHRpb25zLCBwYXJzZWRfYXJncyA9IHJ1bl93ZWJraXRfdGVzdHMucGFyc2VfYXJncyhhcmdz KQogICAgIGlmIG5vdCBwb3J0X29iajoKQEAgLTk2LDcgKzk2LDcgQEAgZGVmIGxvZ2dpbmdfcnVu KGV4dHJhX2FyZ3M9Tm9uZSwgcG9ydF9vYmo9Tm9uZSwgdGVzdHNfaW5jbHVkZWQ9RmFsc2UpOgog ICAgIGlmIG5vdCB0ZXN0c19pbmNsdWRlZDoKICAgICAgICAgYXJncy5leHRlbmQoWydwYXNzZXMn LAogICAgICAgICAgICAgICAgICAgICAgJ2h0dHAvdGVzdHMnLAotICAgICAgICAgICAgICAgICAg ICAgJ2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzJywKKyAgICAgICAgICAgICAgICAgICAgICd3 ZWJzb2NrZXQvdGVzdHMnLAogICAgICAgICAgICAgICAgICAgICAgJ2ZhaWx1cmVzL2V4cGVjdGVk LyonXSkKICAgICBvcHRpb25zLCBwYXJzZWRfYXJncyA9IHJ1bl93ZWJraXRfdGVzdHMucGFyc2Vf YXJncyhhcmdzKQogICAgIHVzZXIgPSBNb2NrVXNlcigpCg==