49765 2010-11-18 15:22:17 -0800 [Qt] Memory leak in QWebInspector 2010-11-19 21:20:44 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 1 max.hong.shen max.hong.shen commit-queue kling oldest_to_newest 311122 0 max.hong.shen 2010-11-18 15:22:17 -0800 should delete QWebInspectorPrivate in ~QWebInspector() 311128 1 74304 max.hong.shen 2010-11-18 15:28:26 -0800 Created attachment 74304 first try 311136 2 74306 max.hong.shen 2010-11-18 15:44:36 -0800 Created attachment 74306 prevent double delete by QWebPagePrivate 311283 3 74306 kling 2010-11-18 21:16:22 -0800 Comment on attachment 74306 prevent double delete by QWebPagePrivate View in context: https://bugs.webkit.org/attachment.cgi?id=74306&action=review Patch is fine, but: > WebKit/qt/Api/qwebinspector.cpp:94 > + if (d) { Unnecessary if- "delete d" is a no-op if !d. > WebKit/qt/Api/qwebinspector.cpp:96 > + // Prevent double delete by QWebPagePrivate Unnecessary comment. 311351 4 74367 max.hong.shen 2010-11-19 04:21:49 -0800 Created attachment 74367 remove unnecessary stuff Thanks Kling, u r right :) 311364 5 74367 laszlo.gombos 2010-11-19 04:53:04 -0800 Comment on attachment 74367 remove unnecessary stuff LGTM, r+. 311860 6 74367 commit-queue 2010-11-19 21:20:39 -0800 Comment on attachment 74367 remove unnecessary stuff Clearing flags on attachment: 74367 Committed r72466: <http://trac.webkit.org/changeset/72466> 311861 7 commit-queue 2010-11-19 21:20:44 -0800 All reviewed patches have been landed. Closing bug. 74304 2010-11-18 15:28:26 -0800 2010-11-18 15:44:36 -0800 first try 49765.patch text/plain 992 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzIzMzgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gTWVtb3J5IGxlYWsgaW4gUVdlYkluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3NjUKKworICAgICAgICBEZWxldGUgUVdlYklu c3BlY3RvclByaXZhdGUgaW4gflFXZWJJbnNwZWN0b3IoKQorCisgICAgICAgICogQXBpL3F3ZWJp bnNwZWN0b3IuY3BwOgorICAgICAgICAoUVdlYkluc3BlY3Rvcjo6flFXZWJJbnNwZWN0b3IpOgor CiAyMDEwLTExLTEyICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBvcGVuYm9zc2Eub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBXZWJLaXQvcXQv QXBpL3F3ZWJpbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmlu c3BlY3Rvci5jcHAJKHJldmlzaW9uIDcyMzM3KQorKysgV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVj dG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTEsNiArOTEsNyBAQCBRV2ViSW5zcGVjdG9yOjp+ UVdlYkluc3BlY3RvcigpCiB7CiAgICAgLy8gUmVtb3ZlIGFzc29jaWF0aW9uIHByaW5jaXBhbGx5 IHRvIHByZXZlbnQgZGVsZXRpbmcgYSBjaGlsZCBmcm9udGVuZAogICAgIHNldFBhZ2UoMCk7Cisg ICAgZGVsZXRlIGQ7CiB9CiAKIC8qIQo= 74306 2010-11-18 15:44:36 -0800 2010-11-19 04:21:49 -0800 prevent double delete by QWebPagePrivate 49765.patch text/plain 1087 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzIzMzgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gTWVtb3J5IGxlYWsgaW4gUVdlYkluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3NjUKKworICAgICAgICBEZWxldGUgUVdlYklu c3BlY3RvclByaXZhdGUgaW4gflFXZWJJbnNwZWN0b3IoKQorCisgICAgICAgICogQXBpL3F3ZWJp bnNwZWN0b3IuY3BwOgorICAgICAgICAoUVdlYkluc3BlY3Rvcjo6flFXZWJJbnNwZWN0b3IpOgor CiAyMDEwLTExLTEyICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBvcGVuYm9zc2Eub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBXZWJLaXQvcXQv QXBpL3F3ZWJpbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmlu c3BlY3Rvci5jcHAJKHJldmlzaW9uIDcyMzM3KQorKysgV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVj dG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTEsNiArOTEsMTEgQEAgUVdlYkluc3BlY3Rvcjo6 flFXZWJJbnNwZWN0b3IoKQogewogICAgIC8vIFJlbW92ZSBhc3NvY2lhdGlvbiBwcmluY2lwYWxs eSB0byBwcmV2ZW50IGRlbGV0aW5nIGEgY2hpbGQgZnJvbnRlbmQKICAgICBzZXRQYWdlKDApOwor ICAgIGlmIChkKSB7CisgICAgICAgIGRlbGV0ZSBkOworICAgICAgICAvLyBQcmV2ZW50IGRvdWJs ZSBkZWxldGUgYnkgUVdlYlBhZ2VQcml2YXRlCisgICAgICAgIGQgPSAwOworICAgIH0KIH0KIAog LyohCg== 74367 2010-11-19 04:21:49 -0800 2010-11-19 21:20:39 -0800 remove unnecessary stuff 49765.patch text/plain 1004 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzIzMzgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gTWVtb3J5IGxlYWsgaW4gUVdlYkluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3NjUKKworICAgICAgICBEZWxldGUgUVdlYklu c3BlY3RvclByaXZhdGUgaW4gflFXZWJJbnNwZWN0b3IoKQorCisgICAgICAgICogQXBpL3F3ZWJp bnNwZWN0b3IuY3BwOgorICAgICAgICAoUVdlYkluc3BlY3Rvcjo6flFXZWJJbnNwZWN0b3IpOgor CiAyMDEwLTExLTEyICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBvcGVuYm9zc2Eub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBXZWJLaXQvcXQv QXBpL3F3ZWJpbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmlu c3BlY3Rvci5jcHAJKHJldmlzaW9uIDcyMzM3KQorKysgV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVj dG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTEsNiArOTEsOCBAQCBRV2ViSW5zcGVjdG9yOjp+ UVdlYkluc3BlY3RvcigpCiB7CiAgICAgLy8gUmVtb3ZlIGFzc29jaWF0aW9uIHByaW5jaXBhbGx5 IHRvIHByZXZlbnQgZGVsZXRpbmcgYSBjaGlsZCBmcm9udGVuZAogICAgIHNldFBhZ2UoMCk7Cisg ICAgZGVsZXRlIGQ7CisgICAgZCA9IDA7CiB9CiAKIC8qIQo=