49761 2010-11-18 13:54:29 -0800 REGRESSION(r72299): Broke chromium ui test SessionHistoryTest.FrameBackForward. (Requested by dave_levin on #webkit). 2010-11-18 14:04:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 48809 1 webkit.review.bot webkit.review.bot fishd levin oldest_to_newest 311088 0 webkit.review.bot 2010-11-18 13:54:29 -0800 http://trac.webkit.org/changeset/72299 broke the build: Broke chromium ui test SessionHistoryTest.FrameBackForward. (Requested by dave_levin on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 311089 1 74290 webkit.review.bot 2010-11-18 13:54:54 -0800 Created attachment 74290 ROLLOUT of r72299 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 311090 2 74290 levin 2010-11-18 14:04:45 -0800 Comment on attachment 74290 ROLLOUT of r72299 Committed as http://trac.webkit.org/changeset/72334 74290 2010-11-18 13:54:54 -0800 2010-11-18 14:04:45 -0800 ROLLOUT of r72299 bug-49761-20101118215451.patch text/plain 5745 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODQ0ODUyN2UyZGVkMjQ0ZDUwNDE1MWI3MTAwZWNjNTkyMzhmYjQ2MC4uZTBkOWI1NjUzMzQ1YWJl MTk2YjZjNDI1YjQ4NjYwZjM0ZTdlYWRkMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0xMS0xOCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjcyMjk5LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC83MjI5OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDk3NjEKKworICAgICAgICBCcm9rZSBjaHJvbWl1bSB1aSB0ZXN0IFNlc3Npb25I aXN0b3J5VGVzdC5GcmFtZUJhY2tGb3J3YXJkLgorICAgICAgICAoUmVxdWVzdGVkIGJ5IGRhdmVf bGV2aW4gb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6Okhpc3RvcnlDb250cm9s bGVyKToKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlDb250cm9sbGVyOjpzYXZlRG9jdW1lbnRT dGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5Q29udHJvbGxlcjo6dXBkYXRlRm9yQmFj a0ZvcndhcmROYXZpZ2F0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlDb250cm9sbGVy Ojp1cGRhdGVGb3JDb21taXQpOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6 OnVwZGF0ZUZvckZyYW1lTG9hZENvbXBsZXRlZCk6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5 Q29udHJvbGxlcjo6c2V0Q3VycmVudEl0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNv bnRyb2xsZXI6OmNyZWF0ZUl0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xs ZXI6OmNyZWF0ZUl0ZW1UcmVlKToKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlDb250cm9sbGVy OjpyZWN1cnNpdmVHb1RvSXRlbSk6CisgICAgICAgICogbG9hZGVyL0hpc3RvcnlDb250cm9sbGVy Lmg6CisKIDIwMTAtMTEtMTggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29u dHJvbGxlci5jcHAKaW5kZXggNzJhY2FmZTgxMTBiNzhhMzMwYjRiYzM0YjQ5OWFjZjNiNWNkYTZi ZS4uMDdiZWNlNzlmZTVhYjQzZmU1NDE4ZjU2Nzc0NzRiNmZiNTY3Y2NlOSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVy L0hpc3RvcnlDb250cm9sbGVyLmNwcApAQCAtNjYsNyArNjYsNiBAQCBzdGF0aWMgaW5saW5lIHZv aWQgYWRkVmlzaXRlZExpbmsoUGFnZSogcGFnZSwgY29uc3QgS1VSTCYgdXJsKQogCiBIaXN0b3J5 Q29udHJvbGxlcjo6SGlzdG9yeUNvbnRyb2xsZXIoRnJhbWUqIGZyYW1lKQogICAgIDogbV9mcmFt ZShmcmFtZSkKLSAgICAsIG1fZnJhbWVMb2FkQ29tcGxldGUodHJ1ZSkKIHsKIH0KIApAQCAtMTM5 LDEwICsxMzgsMTAgQEAgdm9pZCBIaXN0b3J5Q29udHJvbGxlcjo6c2F2ZURvY3VtZW50U3RhdGUo KQogICAgIC8vIHRhcmdldCBvZiB0aGUgY3VycmVudCBuYXZpZ2F0aW9uIChpZiB3ZSBldmVuIGRl Y2lkZSB0byBzYXZlIHdpdGggdGhhdCBncmFudWxhcml0eSkuCiAKICAgICAvLyBCZWNhdXNlIG9m IHByZXZpb3VzSXRlbSdzICJtYXNraW5nIiBvZiBjdXJyZW50SXRlbSBmb3IgdGhpcyBwdXJwb3Nl LCBpdCdzIGltcG9ydGFudAotICAgIC8vIHRoYXQgd2Uga2VlcCB0cmFjayBvZiB0aGUgZW5kIG9m IGEgcGFnZSB0cmFuc2l0aW9uIHdpdGggbV9mcmFtZUxvYWRDb21wbGV0ZS4gIFdlCi0gICAgLy8g bGV2ZXJhZ2UgdGhlIGNoZWNrTG9hZENvbXBsZXRlIHJlY3Vyc2lvbiB0byBhY2hpZXZlIHRoaXMg Z29hbC4KKyAgICAvLyB0aGF0IHByZXZpb3VzSXRlbSBiZSBjbGVhcmVkIGF0IHRoZSBlbmQgb2Yg YSBwYWdlIHRyYW5zaXRpb24uICBXZSBsZXZlcmFnZSB0aGUKKyAgICAvLyBjaGVja0xvYWRDb21w bGV0ZSByZWN1cnNpb24gdG8gYWNoaWV2ZSB0aGlzIGdvYWwuCiAKLSAgICBIaXN0b3J5SXRlbSog aXRlbSA9IG1fZnJhbWVMb2FkQ29tcGxldGUgPyBtX2N1cnJlbnRJdGVtLmdldCgpIDogbV9wcmV2 aW91c0l0ZW0uZ2V0KCk7CisgICAgSGlzdG9yeUl0ZW0qIGl0ZW0gPSBtX3ByZXZpb3VzSXRlbSA/ IG1fcHJldmlvdXNJdGVtLmdldCgpIDogbV9jdXJyZW50SXRlbS5nZXQoKTsKICAgICBpZiAoIWl0 ZW0pCiAgICAgICAgIHJldHVybjsKIApAQCAtMjQ2LDggKzI0NSw3IEBAIHZvaWQgSGlzdG9yeUNv bnRyb2xsZXI6OnVwZGF0ZUZvckJhY2tGb3J3YXJkTmF2aWdhdGlvbigpCiAjZW5kaWYKIAogICAg IC8vIE11c3QgZ3JhYiB0aGUgY3VycmVudCBzY3JvbGwgcG9zaXRpb24gYmVmb3JlIGRpc3R1cmJp bmcgaXQKLSAgICBpZiAoIW1fZnJhbWVMb2FkQ29tcGxldGUpCi0gICAgICAgIHNhdmVTY3JvbGxQ b3NpdGlvbkFuZFZpZXdTdGF0ZVRvSXRlbShtX3ByZXZpb3VzSXRlbS5nZXQoKSk7CisgICAgc2F2 ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVtKG1fcHJldmlvdXNJdGVtLmdldCgpKTsK IH0KIAogdm9pZCBIaXN0b3J5Q29udHJvbGxlcjo6dXBkYXRlRm9yUmVsb2FkKCkKQEAgLTM5NCw3 ICszOTIsNiBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjp1cGRhdGVGb3JDb21taXQoKQogICAg ICAgICAvLyB0aGUgcHJvdmlzaW9uYWwgaXRlbSBmb3IgcmVzdG9yaW5nIHN0YXRlLgogICAgICAg ICAvLyBOb3RlIHByZXZpb3VzSXRlbSBtdXN0IGJlIHNldCBiZWZvcmUgd2UgY2xvc2UgdGhlIFVS TCwgd2hpY2ggd2lsbAogICAgICAgICAvLyBoYXBwZW4gd2hlbiB0aGUgZGF0YSBzb3VyY2UgaXMg bWFkZSBub24tcHJvdmlzaW9uYWwgYmVsb3cKLSAgICAgICAgbV9mcmFtZUxvYWRDb21wbGV0ZSA9 IGZhbHNlOwogICAgICAgICBtX3ByZXZpb3VzSXRlbSA9IG1fY3VycmVudEl0ZW07CiAgICAgICAg IEFTU0VSVChtX3Byb3Zpc2lvbmFsSXRlbSk7CiAgICAgICAgIG1fY3VycmVudEl0ZW0gPSBtX3By b3Zpc2lvbmFsSXRlbTsKQEAgLTQyMSwxNSArNDE4LDEyIEBAIHZvaWQgSGlzdG9yeUNvbnRyb2xs ZXI6OnVwZGF0ZUZvclNhbWVEb2N1bWVudE5hdmlnYXRpb24oKQogdm9pZCBIaXN0b3J5Q29udHJv bGxlcjo6dXBkYXRlRm9yRnJhbWVMb2FkQ29tcGxldGVkKCkKIHsKICAgICAvLyBFdmVuIGlmIGFs cmVhZHkgY29tcGxldGUsIHdlIG1pZ2h0IGhhdmUgc2V0IGEgcHJldmlvdXMgaXRlbSBvbiBhIGZy YW1lIHRoYXQKLSAgICAvLyBkaWRuJ3QgZG8gYW55IGRhdGEgbG9hZGluZyBvbiB0aGUgcGFzdCB0 cmFuc2FjdGlvbi4gTWFrZSBzdXJlIHRvIHRyYWNrIHRoYXQKLSAgICAvLyB0aGUgbG9hZCBpcyBj b21wbGV0ZSBzbyB0aGF0IHdlIHVzZSB0aGUgY3VycmVudCBpdGVtIGluc3RlYWQuCi0gICAgbV9m cmFtZUxvYWRDb21wbGV0ZSA9IHRydWU7CisgICAgLy8gZGlkbid0IGRvIGFueSBkYXRhIGxvYWRp bmcgb24gdGhlIHBhc3QgdHJhbnNhY3Rpb24uIE1ha2Ugc3VyZSB0byBjbGVhciB0aGVzZSBvdXQu CisgICAgbV9wcmV2aW91c0l0ZW0gPSAwOwogfQogCiB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpz ZXRDdXJyZW50SXRlbShIaXN0b3J5SXRlbSogaXRlbSkKIHsKLSAgICBtX2ZyYW1lTG9hZENvbXBs ZXRlID0gZmFsc2U7Ci0gICAgbV9wcmV2aW91c0l0ZW0gPSBtX2N1cnJlbnRJdGVtOwogICAgIG1f Y3VycmVudEl0ZW0gPSBpdGVtOwogfQogCkBAIC01MDQsNyArNDk4LDYgQEAgUGFzc1JlZlB0cjxI aXN0b3J5SXRlbT4gSGlzdG9yeUNvbnRyb2xsZXI6OmNyZWF0ZUl0ZW0oYm9vbCB1c2VPcmlnaW5h bCkKICAgICB9CiAgICAgCiAgICAgLy8gU2V0IHRoZSBpdGVtIGZvciB3aGljaCB3ZSB3aWxsIHNh dmUgZG9jdW1lbnQgc3RhdGUKLSAgICBtX2ZyYW1lTG9hZENvbXBsZXRlID0gZmFsc2U7CiAgICAg bV9wcmV2aW91c0l0ZW0gPSBtX2N1cnJlbnRJdGVtOwogICAgIG1fY3VycmVudEl0ZW0gPSBpdGVt OwogICAgIApAQCAtNTE0LDcgKzUwNyw3IEBAIFBhc3NSZWZQdHI8SGlzdG9yeUl0ZW0+IEhpc3Rv cnlDb250cm9sbGVyOjpjcmVhdGVJdGVtKGJvb2wgdXNlT3JpZ2luYWwpCiBQYXNzUmVmUHRyPEhp c3RvcnlJdGVtPiBIaXN0b3J5Q29udHJvbGxlcjo6Y3JlYXRlSXRlbVRyZWUoRnJhbWUqIHRhcmdl dEZyYW1lLCBib29sIGNsaXBBdFRhcmdldCkKIHsKICAgICBSZWZQdHI8SGlzdG9yeUl0ZW0+IGJm SXRlbSA9IGNyZWF0ZUl0ZW0obV9mcmFtZS0+dHJlZSgpLT5wYXJlbnQoKSA/IHRydWUgOiBmYWxz ZSk7Ci0gICAgaWYgKCFtX2ZyYW1lTG9hZENvbXBsZXRlKQorICAgIGlmIChtX3ByZXZpb3VzSXRl bSkKICAgICAgICAgc2F2ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVtKG1fcHJldmlv dXNJdGVtLmdldCgpKTsKIAogICAgIGlmICghY2xpcEF0VGFyZ2V0IHx8IG1fZnJhbWUgIT0gdGFy Z2V0RnJhbWUpIHsKQEAgLTU3MCw4ICs1NjMsOCBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpy ZWN1cnNpdmVHb1RvSXRlbShIaXN0b3J5SXRlbSogaXRlbSwgSGlzdG9yeUl0ZW0qIGZyb21JdAog ICAgICAgICAmJiBmcm9tSXRlbS0+aGFzU2FtZUZyYW1lcyhpdGVtKSkKICAgICB7CiAgICAgICAg IC8vIFRoaXMgY29udGVudCBpcyBnb29kLCBzbyBsZWF2ZSBpdCBhbG9uZSBhbmQgbG9vayBmb3Ig Y2hpbGRyZW4gdGhhdCBuZWVkIHJlbG9hZGluZwotICAgICAgICAvLyBTYXZlIGZvcm0gc3RhdGUg KHdvcmtzIGZyb20gY3VycmVudEl0ZW0sIHNpbmNlIG1fZnJhbWVMb2FkQ29tcGxldGUgaXMgdHJ1 ZSkKLSAgICAgICAgQVNTRVJUKG1fZnJhbWVMb2FkQ29tcGxldGUpOworICAgICAgICAvLyBTYXZl IGZvcm0gc3RhdGUgKHdvcmtzIGZyb20gY3VycmVudEl0ZW0sIHNpbmNlIHByZXZJdGVtIGlzIG5p bCkKKyAgICAgICAgQVNTRVJUKCFtX3ByZXZpb3VzSXRlbSk7CiAgICAgICAgIHNhdmVEb2N1bWVu dFN0YXRlKCk7CiAgICAgICAgIHNhdmVTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0ZVRvSXRlbSht X2N1cnJlbnRJdGVtLmdldCgpKTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvSGlzdG9y eUNvbnRyb2xsZXIuaCBiL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmgKaW5kZXgg MWJmNTA3MmMwZWRiOGQyOWIyODUwNGQzMDY1NThkMGY4NDZkZTQ4NS4uMTAwMmRiYzI4NWY4N2Y0 MWEwYTJiZjk3YmYxZTI5YjE3MmM5ZDYyYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvSGlz dG9yeUNvbnRyb2xsZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5o CkBAIC05Niw4ICs5Niw2IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPEhpc3RvcnlJdGVtPiBtX2N1 cnJlbnRJdGVtOwogICAgIFJlZlB0cjxIaXN0b3J5SXRlbT4gbV9wcmV2aW91c0l0ZW07CiAgICAg UmVmUHRyPEhpc3RvcnlJdGVtPiBtX3Byb3Zpc2lvbmFsSXRlbTsKLQotICAgIGJvb2wgbV9mcmFt ZUxvYWRDb21wbGV0ZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK