49757 2010-11-18 13:08:21 -0800 Complete support for Unix editing mode 2010-11-19 14:37:23 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 23351 0 avi webkit-unassigned commit-queue tonikitoo webkit-ews oldest_to_newest 311053 0 avi 2010-11-18 13:08:21 -0800 One bit isn't large enough to hold three values. 311056 1 74282 avi 2010-11-18 13:14:43 -0800 Created attachment 74282 Fix 311057 2 74283 avi 2010-11-18 13:16:10 -0800 Created attachment 74283 Fix try #2 311069 3 webkit-ews 2010-11-18 13:27:30 -0800 Attachment 74283 did not build on qt: Build output: http://queues.webkit.org/results/6171059 311072 4 74283 tonikitoo 2010-11-18 13:29:11 -0800 Comment on attachment 74283 Fix try #2 Yay! 311077 5 avi 2010-11-18 13:31:13 -0800 QT builder has a point. Will fix. 311079 6 tonikitoo 2010-11-18 13:31:35 -0800 (In reply to comment #3) > Attachment 74283 [details] did not build on qt: > Build output: http://queues.webkit.org/results/6171059 cc1plus: warnings being treated as errors ../../../WebCore/page/Settings.h: In constructor 'WebCore::Settings::Settings(WebCore::Page*)': ../../../WebCore/page/Settings.h:409: error: 'WebCore::Settings::m_allowScriptsToCloseWindows' will be initialized after ../../../WebCore/page/Settings.h:361: error: 'unsigned int WebCore::Settings::m_editingBehaviorType' ../../../WebCore/page/Settings.cpp:88: error: when initialized here The initialization order matters. 311081 7 74288 avi 2010-11-18 13:34:37 -0800 Created attachment 74288 Correct initialization order Yes, I realized this right after I'd uploaded the last one. 311391 8 74283 eric 2010-11-19 05:45:09 -0800 Comment on attachment 74283 Fix try #2 Cleared Antonio Gomes's review+ from obsolete attachment 74283 so that this bug does not appear in http://webkit.org/pending-commit. 311696 9 74288 commit-queue 2010-11-19 14:37:17 -0800 Comment on attachment 74288 Correct initialization order Clearing flags on attachment: 74288 Committed r72441: <http://trac.webkit.org/changeset/72441> 311698 10 commit-queue 2010-11-19 14:37:23 -0800 All reviewed patches have been landed. Closing bug. 74282 2010-11-18 13:14:43 -0800 2010-11-18 13:16:10 -0800 Fix unix.patch text/plain 3930 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTggIEF2aSBEcmlzc21hbiAgPGF2aUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBs ZXRlIHN1cHBvcnQgZm9yIFVuaXggZWRpdGluZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTc1NworCisgICAgICAgIFRlc3Q6IGVkaXRpbmcv c2VsZWN0aW9uL2NvbnRleHQtbWVudS10ZXh0LXNlbGVjdGlvbi5odG1sCisKKyAgICAgICAgKiBw YWdlL1NldHRpbmdzLmg6CisKIDIwMTAtMTEtMTggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBX ZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2V0dGlu Z3MuaAkocmV2aXNpb24gNzIzMjYpCisrKyBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzU4LDYgKzM1OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg aW50IG1fZGVmYXVsdEZvbnRTaXplOwogICAgICAgICBpbnQgbV9kZWZhdWx0Rml4ZWRGb250U2l6 ZTsKICAgICAgICAgc2l6ZV90IG1fbWF4aW11bURlY29kZWRJbWFnZVNpemU7CisgICAgICAgIHVu c2lnbmVkIG1fZWRpdGluZ0JlaGF2aW9yVHlwZTsKICNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCiAg ICAgICAgIHVuc2lnbmVkIG1fc2Vzc2lvblN0b3JhZ2VRdW90YTsKICNlbmRpZgpAQCAtNDA2LDcg KzQwNyw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgYm9vbCBtX2VuZm9yY2VDU1NN SU1FVHlwZUluTm9RdWlya3NNb2RlIDogMTsKICAgICAgICAgYm9vbCBtX3VzZXNFbmNvZGluZ0Rl dGVjdG9yIDogMTsKICAgICAgICAgYm9vbCBtX2FsbG93U2NyaXB0c1RvQ2xvc2VXaW5kb3dzIDog MTsKLSAgICAgICAgdW5zaWduZWQgbV9lZGl0aW5nQmVoYXZpb3JUeXBlIDogMTsKICAgICAgICAg Ym9vbCBtX2Rvd25sb2FkYWJsZUJpbmFyeUZvbnRzRW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wg bV94c3NBdWRpdG9yRW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV9hY2NlbGVyYXRlZENvbXBv c2l0aW5nRW5hYmxlZCA6IDE7CkluZGV4OiBXZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3MjMyNykKKysrIFdlYktpdFRv b2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTE4 ICBBdmkgRHJpc3NtYW4gIDxhdmlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21wbGV0ZSBzdXBwb3J0IGZvciBVbml4IGVkaXRp bmcgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDk3NTcKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKHNldEVkaXRpbmdCZWhhdmlvckNhbGxiYWNrKToKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChM YXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0RWRpdGluZ0JlaGF2aW9yKToKKwogMjAxMC0xMS0xOCAg RGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRh bSBSb2Jlbi4KSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250 cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9MYXlv dXRUZXN0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDcyMzI2KQorKysgV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x Nzg2LDggKzE3ODYsOCBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBzZXRFZGl0aW5nQmVoYXZpb3JDYWxs CiAgICAgY2hhciogYmVoYXZpb3JCdWZmZXIgPSBuZXcgY2hhclttYXhMZW5ndGggKyAxXTsKICAg ICBKU1N0cmluZ0dldFVURjhDU3RyaW5nKGVkaXRpbmdCZWhhdmlvci5nZXQoKSwgYmVoYXZpb3JC dWZmZXIsIG1heExlbmd0aCk7CiAKLSAgICBpZiAoc3RyY21wKGJlaGF2aW9yQnVmZmVyLCAibWFj IikgJiYgc3RyY21wKGJlaGF2aW9yQnVmZmVyLCAid2luIikpIHsKLSAgICAgICAgSlNSZXRhaW5Q dHI8SlNTdHJpbmdSZWY+IGludmFsaWRBcmd1bWVudChKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0 cmluZygiUGFzc2VkIGludmFsaWQgZWRpdGluZyBiZWhhdmlvci4gTXVzdCBiZSAnbWFjJyBvciAn d2luJy4iKSk7CisgICAgaWYgKHN0cmNtcChiZWhhdmlvckJ1ZmZlciwgIm1hYyIpICYmIHN0cmNt cChiZWhhdmlvckJ1ZmZlciwgIndpbiIpICYmIHN0cmNtcChiZWhhdmlvckJ1ZmZlciwgInVuaXgi KSkgeworICAgICAgICBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gaW52YWxpZEFyZ3VtZW50KEpT U3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJQYXNzZWQgaW52YWxpZCBlZGl0aW5nIGJlaGF2 aW9yLiBNdXN0IGJlICdtYWMnLCAnd2luJywgb3IgJ3VuaXgnLiIpKTsKICAgICAgICAgKmV4Y2Vw dGlvbiA9IEpTVmFsdWVNYWtlU3RyaW5nKGNvbnRleHQsIGludmFsaWRBcmd1bWVudC5nZXQoKSk7 CiAgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKICAgICB9Cklu ZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJv bGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA3MjMyNikKKysrIFdlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTQ5Miw3ICsxNDkyLDcgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0RWRpdGluZ0JlaAogICAgICAgICBtX3NoZWxsLT5wcmVmZXJlbmNlcygpLT5lZGl0aW5n QmVoYXZpb3IgPSBXZWJTZXR0aW5nczo6RWRpdGluZ0JlaGF2aW9yVW5peDsKICAgICAgICAgbV9z aGVsbC0+YXBwbHlQcmVmZXJlbmNlcygpOwogICAgIH0gZWxzZQotICAgICAgICBsb2dFcnJvclRv Q29uc29sZSgiUGFzc2VkIGludmFsaWQgZWRpdGluZyBiZWhhdmlvci4gU2hvdWxkIGJlICdtYWMn IG9yICd3aW4nLiIpOworICAgICAgICBsb2dFcnJvclRvQ29uc29sZSgiUGFzc2VkIGludmFsaWQg ZWRpdGluZyBiZWhhdmlvci4gU2hvdWxkIGJlICdtYWMnLCAnd2luJywgb3IgJ3VuaXgnLiIpOwog fQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRNb2NrRGV2aWNlT3JpZW50YXRpb24o Y29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkK 74283 2010-11-18 13:16:10 -0800 2010-11-19 05:45:09 -0800 Fix try #2 unix.patch text/plain 3862 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMTggIEF2aSBEcmlzc21hbiAgPGF2aUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBs ZXRlIHN1cHBvcnQgZm9yIFVuaXggZWRpdGluZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTc1NworCisgICAgICAgICogcGFnZS9TZXR0aW5n cy5oOgorCiAyMDEwLTExLTE4ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9wYWdl L1NldHRpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgJKHJldmlz aW9uIDcyMzI2KQorKysgV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAg LTM1OCw2ICszNTgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGludCBtX2RlZmF1 bHRGb250U2l6ZTsKICAgICAgICAgaW50IG1fZGVmYXVsdEZpeGVkRm9udFNpemU7CiAgICAgICAg IHNpemVfdCBtX21heGltdW1EZWNvZGVkSW1hZ2VTaXplOworICAgICAgICB1bnNpZ25lZCBtX2Vk aXRpbmdCZWhhdmlvclR5cGU7CiAjaWYgRU5BQkxFKERPTV9TVE9SQUdFKQogICAgICAgICB1bnNp Z25lZCBtX3Nlc3Npb25TdG9yYWdlUXVvdGE7CiAjZW5kaWYKQEAgLTQwNiw3ICs0MDcsNiBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgbV9lbmZvcmNlQ1NTTUlNRVR5cGVJbk5v UXVpcmtzTW9kZSA6IDE7CiAgICAgICAgIGJvb2wgbV91c2VzRW5jb2RpbmdEZXRlY3RvciA6IDE7 CiAgICAgICAgIGJvb2wgbV9hbGxvd1NjcmlwdHNUb0Nsb3NlV2luZG93cyA6IDE7Ci0gICAgICAg IHVuc2lnbmVkIG1fZWRpdGluZ0JlaGF2aW9yVHlwZSA6IDE7CiAgICAgICAgIGJvb2wgbV9kb3du bG9hZGFibGVCaW5hcnlGb250c0VuYWJsZWQgOiAxOwogICAgICAgICBib29sIG1feHNzQXVkaXRv ckVuYWJsZWQgOiAxOwogICAgICAgICBib29sIG1fYWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJs ZWQgOiAxOwpJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNzIzMjcpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0xOCAgQXZpIERyaXNz bWFuICA8YXZpQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ29tcGxldGUgc3VwcG9ydCBmb3IgVW5peCBlZGl0aW5nIG1vZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NzU3CisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAg IChzZXRFZGl0aW5nQmVoYXZpb3JDYWxsYmFjayk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENv bnRyb2xsZXI6OnNldEVkaXRpbmdCZWhhdmlvcik6CisKIDIwMTAtMTEtMTggIERhbmllbCBCYXRl cyAgPGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCklu ZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRy b2xsZXIuY3BwCShyZXZpc2lvbiA3MjMyNikKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L0xheW91dFRlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc4Niw4ICsxNzg2 LDggQEAgc3RhdGljIEpTVmFsdWVSZWYgc2V0RWRpdGluZ0JlaGF2aW9yQ2FsbAogICAgIGNoYXIq IGJlaGF2aW9yQnVmZmVyID0gbmV3IGNoYXJbbWF4TGVuZ3RoICsgMV07CiAgICAgSlNTdHJpbmdH ZXRVVEY4Q1N0cmluZyhlZGl0aW5nQmVoYXZpb3IuZ2V0KCksIGJlaGF2aW9yQnVmZmVyLCBtYXhM ZW5ndGgpOwogCi0gICAgaWYgKHN0cmNtcChiZWhhdmlvckJ1ZmZlciwgIm1hYyIpICYmIHN0cmNt cChiZWhhdmlvckJ1ZmZlciwgIndpbiIpKSB7Ci0gICAgICAgIEpTUmV0YWluUHRyPEpTU3RyaW5n UmVmPiBpbnZhbGlkQXJndW1lbnQoSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlBhc3Nl ZCBpbnZhbGlkIGVkaXRpbmcgYmVoYXZpb3IuIE11c3QgYmUgJ21hYycgb3IgJ3dpbicuIikpOwor ICAgIGlmIChzdHJjbXAoYmVoYXZpb3JCdWZmZXIsICJtYWMiKSAmJiBzdHJjbXAoYmVoYXZpb3JC dWZmZXIsICJ3aW4iKSAmJiBzdHJjbXAoYmVoYXZpb3JCdWZmZXIsICJ1bml4IikpIHsKKyAgICAg ICAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IGludmFsaWRBcmd1bWVudChKU1N0cmluZ0NyZWF0 ZVdpdGhVVEY4Q1N0cmluZygiUGFzc2VkIGludmFsaWQgZWRpdGluZyBiZWhhdmlvci4gTXVzdCBi ZSAnbWFjJywgJ3dpbicsIG9yICd1bml4Jy4iKSk7CiAgICAgICAgICpleGNlcHRpb24gPSBKU1Zh bHVlTWFrZVN0cmluZyhjb250ZXh0LCBpbnZhbGlkQXJndW1lbnQuZ2V0KCkpOwogICAgICAgICBy ZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiAgICAgfQpJbmRleDogV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRl c3RDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNzIzMjYpCisrKyBXZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE0OTIsNyArMTQ5Miw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEVkaXRp bmdCZWgKICAgICAgICAgbV9zaGVsbC0+cHJlZmVyZW5jZXMoKS0+ZWRpdGluZ0JlaGF2aW9yID0g V2ViU2V0dGluZ3M6OkVkaXRpbmdCZWhhdmlvclVuaXg7CiAgICAgICAgIG1fc2hlbGwtPmFwcGx5 UHJlZmVyZW5jZXMoKTsKICAgICB9IGVsc2UKLSAgICAgICAgbG9nRXJyb3JUb0NvbnNvbGUoIlBh c3NlZCBpbnZhbGlkIGVkaXRpbmcgYmVoYXZpb3IuIFNob3VsZCBiZSAnbWFjJyBvciAnd2luJy4i KTsKKyAgICAgICAgbG9nRXJyb3JUb0NvbnNvbGUoIlBhc3NlZCBpbnZhbGlkIGVkaXRpbmcgYmVo YXZpb3IuIFNob3VsZCBiZSAnbWFjJywgJ3dpbicsIG9yICd1bml4Jy4iKTsKIH0KIAogdm9pZCBM YXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0TW9ja0RldmljZU9yaWVudGF0aW9uKGNvbnN0IENwcEFy Z3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCg== 74288 2010-11-18 13:34:37 -0800 2010-11-19 14:37:16 -0800 Correct initialization order unix.patch text/plain 5003 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjMyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTggIEF2aSBEcmlzc21hbiAgPGF2aUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBs ZXRlIHN1cHBvcnQgZm9yIFVuaXggZWRpdGluZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTc1NworCisgICAgICAgICogcGFnZS9TZXR0aW5n cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6U2V0dGluZ3MpOgorICAgICAgICAq IHBhZ2UvU2V0dGluZ3MuaDoKKwogMjAxMC0xMS0xOCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6 IFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL1Nl dHRpbmdzLmNwcAkocmV2aXNpb24gNzIzMjYpCisrKyBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCw3IEBAIFNldHRpbmdzOjpTZXR0aW5ncyhQYWdl KiBwYWdlKQogICAgICwgbV9zZXNzaW9uU3RvcmFnZVF1b3RhKFN0b3JhZ2VNYXA6Om5vUXVvdGEp CiAjZW5kaWYKICAgICAsIG1fcGx1Z2luQWxsb3dlZFJ1blRpbWUobnVtZXJpY19saW1pdHM8dW5z aWduZWQ+OjptYXgoKSkKKyAgICAsIG1fZWRpdGluZ0JlaGF2aW9yVHlwZShlZGl0aW5nQmVoYXZp b3JUeXBlRm9yUGxhdGZvcm0oKSkKICAgICAsIG1faXNTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQo ZmFsc2UpCiAgICAgLCBtX2lzSmF2YUVuYWJsZWQoZmFsc2UpCiAgICAgLCBtX2xvYWRzSW1hZ2Vz QXV0b21hdGljYWxseShmYWxzZSkKQEAgLTE0Miw3ICsxNDMsNiBAQCBTZXR0aW5nczo6U2V0dGlu Z3MoUGFnZSogcGFnZSkKICAgICAsIG1fZW5mb3JjZUNTU01JTUVUeXBlSW5Ob1F1aXJrc01vZGUo dHJ1ZSkKICAgICAsIG1fdXNlc0VuY29kaW5nRGV0ZWN0b3IoZmFsc2UpCiAgICAgLCBtX2FsbG93 U2NyaXB0c1RvQ2xvc2VXaW5kb3dzKGZhbHNlKQotICAgICwgbV9lZGl0aW5nQmVoYXZpb3JUeXBl KGVkaXRpbmdCZWhhdmlvclR5cGVGb3JQbGF0Zm9ybSgpKQogICAgIC8vIEZJWE1FOiBUaGlzIHNo b3VsZCByZWFsbHkgYmUgZGlzYWJsZWQgYnkgZGVmYXVsdCBhcyBpdCBtYWtlcyBwbGF0Zm9ybXMg dGhhdCBkb24ndCBzdXBwb3J0IHRoZSBmZWF0dXJlIGRvd25sb2FkIGZpbGVzCiAgICAgLy8gdGhl eSBjYW4ndCB1c2UgYnkuIExlYXZpbmcgZW5hYmxlZCBmb3Igbm93IHRvIG5vdCBjaGFuZ2UgZXhp c3RpbmcgYmVoYXZpb3IuCiAgICAgLCBtX2Rvd25sb2FkYWJsZUJpbmFyeUZvbnRzRW5hYmxlZCh0 cnVlKQpJbmRleDogV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wYWdlL1NldHRpbmdzLmgJKHJldmlzaW9uIDcyMzI2KQorKysgV2ViQ29yZS9wYWdlL1NldHRp bmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2Miw2ICszNjIsNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIHVuc2lnbmVkIG1fc2Vzc2lvblN0b3JhZ2VRdW90YTsKICNlbmRpZgogICAg ICAgICB1bnNpZ25lZCBtX3BsdWdpbkFsbG93ZWRSdW5UaW1lOworICAgICAgICB1bnNpZ25lZCBt X2VkaXRpbmdCZWhhdmlvclR5cGU7CiAgICAgICAgIGJvb2wgbV9pc1NwYXRpYWxOYXZpZ2F0aW9u RW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV9pc0phdmFFbmFibGVkIDogMTsKICAgICAgICAg Ym9vbCBtX2xvYWRzSW1hZ2VzQXV0b21hdGljYWxseSA6IDE7CkBAIC00MDYsNyArNDA3LDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIG1fZW5mb3JjZUNTU01JTUVUeXBlSW5O b1F1aXJrc01vZGUgOiAxOwogICAgICAgICBib29sIG1fdXNlc0VuY29kaW5nRGV0ZWN0b3IgOiAx OwogICAgICAgICBib29sIG1fYWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3MgOiAxOwotICAgICAg ICB1bnNpZ25lZCBtX2VkaXRpbmdCZWhhdmlvclR5cGUgOiAxOwogICAgICAgICBib29sIG1fZG93 bmxvYWRhYmxlQmluYXJ5Rm9udHNFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX3hzc0F1ZGl0 b3JFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX2FjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFi bGVkIDogMTsKSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcyMzI5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTggIEF2aSBEcmlz c21hbiAgPGF2aUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvbXBsZXRlIHN1cHBvcnQgZm9yIFVuaXggZWRpdGluZyBtb2RlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTc1NworCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAg ICAoc2V0RWRpdGluZ0JlaGF2aW9yQ2FsbGJhY2spOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RD b250cm9sbGVyOjpzZXRFZGl0aW5nQmVoYXZpb3IpOgorCiAyMDEwLTExLTE4ICBEYW5pZWwgQmF0 ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJ bmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250 cm9sbGVyLmNwcAkocmV2aXNpb24gNzIzMjYpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3ODYsOCArMTc4 Niw4IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIHNldEVkaXRpbmdCZWhhdmlvckNhbGwKICAgICBjaGFy KiBiZWhhdmlvckJ1ZmZlciA9IG5ldyBjaGFyW21heExlbmd0aCArIDFdOwogICAgIEpTU3RyaW5n R2V0VVRGOENTdHJpbmcoZWRpdGluZ0JlaGF2aW9yLmdldCgpLCBiZWhhdmlvckJ1ZmZlciwgbWF4 TGVuZ3RoKTsKIAotICAgIGlmIChzdHJjbXAoYmVoYXZpb3JCdWZmZXIsICJtYWMiKSAmJiBzdHJj bXAoYmVoYXZpb3JCdWZmZXIsICJ3aW4iKSkgewotICAgICAgICBKU1JldGFpblB0cjxKU1N0cmlu Z1JlZj4gaW52YWxpZEFyZ3VtZW50KEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJQYXNz ZWQgaW52YWxpZCBlZGl0aW5nIGJlaGF2aW9yLiBNdXN0IGJlICdtYWMnIG9yICd3aW4nLiIpKTsK KyAgICBpZiAoc3RyY21wKGJlaGF2aW9yQnVmZmVyLCAibWFjIikgJiYgc3RyY21wKGJlaGF2aW9y QnVmZmVyLCAid2luIikgJiYgc3RyY21wKGJlaGF2aW9yQnVmZmVyLCAidW5peCIpKSB7CisgICAg ICAgIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBpbnZhbGlkQXJndW1lbnQoSlNTdHJpbmdDcmVh dGVXaXRoVVRGOENTdHJpbmcoIlBhc3NlZCBpbnZhbGlkIGVkaXRpbmcgYmVoYXZpb3IuIE11c3Qg YmUgJ21hYycsICd3aW4nLCBvciAndW5peCcuIikpOwogICAgICAgICAqZXhjZXB0aW9uID0gSlNW YWx1ZU1ha2VTdHJpbmcoY29udGV4dCwgaW52YWxpZEFyZ3VtZW50LmdldCgpKTsKICAgICAgICAg cmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwogICAgIH0KSW5kZXg6IFdlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRU ZXN0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDcyMzI2KQorKysgV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNDkyLDcgKzE0OTIsNyBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRFZGl0 aW5nQmVoCiAgICAgICAgIG1fc2hlbGwtPnByZWZlcmVuY2VzKCktPmVkaXRpbmdCZWhhdmlvciA9 IFdlYlNldHRpbmdzOjpFZGl0aW5nQmVoYXZpb3JVbml4OwogICAgICAgICBtX3NoZWxsLT5hcHBs eVByZWZlcmVuY2VzKCk7CiAgICAgfSBlbHNlCi0gICAgICAgIGxvZ0Vycm9yVG9Db25zb2xlKCJQ YXNzZWQgaW52YWxpZCBlZGl0aW5nIGJlaGF2aW9yLiBTaG91bGQgYmUgJ21hYycgb3IgJ3dpbicu Iik7CisgICAgICAgIGxvZ0Vycm9yVG9Db25zb2xlKCJQYXNzZWQgaW52YWxpZCBlZGl0aW5nIGJl aGF2aW9yLiBTaG91bGQgYmUgJ21hYycsICd3aW4nLCBvciAndW5peCcuIik7CiB9CiAKIHZvaWQg TGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldE1vY2tEZXZpY2VPcmllbnRhdGlvbihjb25zdCBDcHBB cmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3BwVmFyaWFudCogcmVzdWx0KQo=