49740 2010-11-18 10:14:48 -0800 [NRWT] '--new-baseline' doesn't work 2010-11-18 14:07:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hayato webkit-unassigned abarth dpranke eric hamaji mihaip oldest_to_newest 310917 0 hayato 2010-11-18 10:14:48 -0800 Including the '--new-baseline' flag in new-run-webkit-test causes the script to fail. 310919 1 74249 hayato 2010-11-18 10:18:21 -0800 Created attachment 74249 fix-new-baseline 310922 2 74249 hamaji 2010-11-18 10:21:22 -0800 Comment on attachment 74249 fix-new-baseline Thanks for the fix. 310929 3 74249 hayato 2010-11-18 10:29:16 -0800 Comment on attachment 74249 fix-new-baseline Clearing flags on attachment: 74249 Committed r72307: <http://trac.webkit.org/changeset/72307> 310930 4 hayato 2010-11-18 10:29:24 -0800 All reviewed patches have been landed. Closing bug. 311020 5 dpranke 2010-11-18 11:52:48 -0800 I was wondering why the unit tests didn't catch this ... of course, we disabled them because they wrote to the real file system :( I really need to land the patches in 48072. 311023 6 hayato 2010-11-18 11:57:55 -0800 As far as I remember, I ran ./WebKitTools/Scripts/test-webkit-scripts and it passed all tests. Could you tell me how do you guys run tests about new-run-webkit-tests? (In reply to comment #5) > I was wondering why the unit tests didn't catch this ... of course, we disabled them because they wrote to the real file system :( I really need to land the patches in 48072. 311091 7 dpranke 2010-11-18 14:07:03 -0800 (In reply to comment #6) > As far as I remember, I ran ./WebKitTools/Scripts/test-webkit-scripts and it passed all tests. > Could you tell me how do you guys run tests about new-run-webkit-tests? > That would be sufficient. Like I said, the tests that would've caught at least part of this were disabled (and had bit-rotted accordingly). The new patch will bring them back online. Typically I run a script I have that just runs the subset of test-webkitpy that includes the tests under layout_tests/*, and if that passes, then I'll usually run test-webkitpy to be sure nothing weird happened. I have some other patches to test-webkitpy that should make things a little better so that I don't my separate script, and of course the patch above will allow test-webkitpy to complete in ~ 4 seconds, so that'll help, too. 74249 2010-11-18 10:18:21 -0800 2010-11-18 10:29:16 -0800 fix-new-baseline bug-49740-20101119031820.patch text/plain 1629 hayato ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyMTNjOWJhYTc2NDE2MzY3NDk3OTZlNTQ4M2RlNTM5YmFmNTRjNjg3Li45YzFiZGI1 YWIzZWRmYTYwYjk0Mzg5YThlZjJkM2NmNjlhZDVkYjFhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMTggIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtOUldUXSBGaXggYSBicmVh ayBvZiAnLS1uZXctYmFzZWxpbmUnIGZlYXR1cmUgd2hpY2ggaXMgY2F1c2VkIGJ5IHI3MjI0OS4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3NDAK KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Rlc3RfdHlwZXMvdGV4 dF9kaWZmLnB5OgorCiAyMDEwLTExLTE3ICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Rlc3RfdHlwZXMvdGV4dF9k aWZmLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdGVzdF90 eXBlcy90ZXh0X2RpZmYucHkKaW5kZXggNjZlNDJiYTE0Y2E4MjZmNDU0MTFjNTE5NTQyODUzMmIw ZmE1YmUxMS4uY2E0YjE3ZDdlMWEzOWZjYjBhODZlYWMwMjcwN2VlMDFjYmY5NTc2NiAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdGVzdF90eXBl cy90ZXh0X2RpZmYucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvdGVzdF90eXBlcy90ZXh0X2RpZmYucHkKQEAgLTY2LDcgKzY2LDggQEAgY2xhc3MgVGVz dFRleHREaWZmKHRlc3RfdHlwZV9iYXNlLlRlc3RUeXBlQmFzZSk6CiAgICAgICAgICAgICAjIEFs dGhvdWdoIGFsbCB0ZXN0X3NoZWxsL0R1bXBSZW5kZXJUcmVlIG91dHB1dCBzaG91bGQgYmUgdXRm LTgsCiAgICAgICAgICAgICAjIHdlIGRvIG5vdCBldmVyIGRlY29kZSBpdCBpbnNpZGUgcnVuLXdl YmtpdC10ZXN0cy4gIEZvciBzb21lIHRlc3RzCiAgICAgICAgICAgICAjIER1bXBSZW5kZXJUcmVl IG1heSBub3Qgb3V0cHV0IHV0Zi04IHRleHQgKGUuZy4gd2ViYXJjaGl2ZXMpLgotICAgICAgICAg ICAgc2VsZi5fc2F2ZV9iYXNlbGluZV9kYXRhKGZpbGVuYW1lLCBvdXRwdXQsICIudHh0IiwgZW5j b2Rpbmc9Tm9uZSwKKyAgICAgICAgICAgIHNlbGYuX3NhdmVfYmFzZWxpbmVfZGF0YShmaWxlbmFt ZSwgYWN0dWFsX3Rlc3Rfb3V0cHV0LnRleHQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIi50eHQiLCBlbmNvZGluZz1Ob25lLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGdlbmVyYXRlX25ld19iYXNlbGluZT10ZXN0X2FyZ3MubmV3X2Jhc2VsaW5l KQogICAgICAgICAgICAgcmV0dXJuIGZhaWx1cmVzCiAK