49723 2010-11-18 03:31:09 -0800 Expose default value of maxLength in Chromium API 2010-11-19 14:14:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 isherman webkit-unassigned commit-queue fishd isherman tkent oldest_to_newest 310778 0 isherman 2010-11-18 03:31:09 -0800 Expose default value of maxLength in Chromium API 310784 1 74225 isherman 2010-11-18 04:07:14 -0800 Created attachment 74225 Patch 310800 2 74225 tkent 2010-11-18 05:12:33 -0800 Comment on attachment 74225 Patch ok 310895 3 74225 fishd 2010-11-18 09:37:50 -0800 Comment on attachment 74225 Patch This breaks the multi-DLL build! Exports need to be annotated with WEBKIT_API 311059 4 74284 isherman 2010-11-18 13:18:01 -0800 Created attachment 74284 Patch 311060 5 74284 isherman 2010-11-18 13:19:38 -0800 Comment on attachment 74284 Patch WEBKIT_API added 311063 6 74284 fishd 2010-11-18 13:22:52 -0800 Comment on attachment 74284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74284&action=review > WebKit/chromium/public/WebInputElement.h:83 > + WEBKIT_API static const int defaultMaximumLength; since this is related to the maxLength attribute, it'd probably be nice to name it defaultMaxLength. also, please add a comment indicating this relationship. the comment in your ChangeLog seems pretty good. it would be nice to have it in the code as well. > WebKit/chromium/src/WebInputElement.cpp:163 > +const int WebInputElement::defaultMaximumLength = nit: i would probably not insert a line break here as it is fine to exceed 80 chars in webkit code 311071 7 74286 isherman 2010-11-18 13:28:26 -0800 Created attachment 74286 Patch 311073 8 74286 isherman 2010-11-18 13:29:17 -0800 Comment on attachment 74286 Patch (In reply to comment #6) > (From update of attachment 74284 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74284&action=review > > > WebKit/chromium/public/WebInputElement.h:83 > > + WEBKIT_API static const int defaultMaximumLength; > > since this is related to the maxLength attribute, it'd probably be nice to name > it defaultMaxLength. also, please add a comment indicating this relationship. > the comment in your ChangeLog seems pretty good. it would be nice to have it > in the code as well. Done =) > > WebKit/chromium/src/WebInputElement.cpp:163 > > +const int WebInputElement::defaultMaximumLength = > > nit: i would probably not insert a line break here as it is fine to exceed 80 chars in webkit code Doh, keep forgetting that WebKit isn't 80-col -- thanks :) 311119 9 74286 tkent 2010-11-18 15:18:55 -0800 Comment on attachment 74286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74286&action=review Darin, thank you for following up my wrong r+. > WebKit/chromium/public/WebInputElement.h:84 > + WEBKIT_API static const int defaultMaxLength; It is better to make this a function. The hard limit value might be platform-dependent in the future. 311126 10 74286 isherman 2010-11-18 15:27:08 -0800 Comment on attachment 74286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74286&action=review >> WebKit/chromium/public/WebInputElement.h:84 >> + WEBKIT_API static const int defaultMaxLength; > > It is better to make this a function. > The hard limit value might be platform-dependent in the future. I'm confused -- why would a function be better than a constant in the face of platform dependencies? I'm probably overlooking something, but it makes more sense to me to leave this as a constant and update it if/when the underlying WebKit implementation changes. 311137 11 tkent 2010-11-18 15:45:17 -0800 (In reply to comment #10) > I'm confused -- why would a function be better than a constant in the face of platform dependencies? I'm probably overlooking something, but it makes more sense to me to leave this as a constant and update it if/when the underlying WebKit implementation changes. I was afraid the value would be calculated at runtime in the future. I think It's ok to commit this change as is for now. 311688 12 74286 commit-queue 2010-11-19 14:14:06 -0800 Comment on attachment 74286 Patch Clearing flags on attachment: 74286 Committed r72436: <http://trac.webkit.org/changeset/72436> 311689 13 commit-queue 2010-11-19 14:14:12 -0800 All reviewed patches have been landed. Closing bug. 74225 2010-11-18 04:07:14 -0800 2010-11-18 13:17:58 -0800 Patch bug-49723-20101118040713.patch text/plain 1985 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJlM2NlOGU3MGQyM2FhNmQyZDYyMzQ2MGZhZjIwZTdiODQyMmZkMzgu LjgyNGE3YWZkZTJmN2JkNTE0MTFmYjMzYzUzNjkwOTA1ZGQwYTBjOTIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTExLTE4ICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIGRlZmF1bHQgdmFsdWUgb2YgbWF4TGVuZ3RoIGluIENocm9taXVtIEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3MjMKKworICAg ICAgICAqIHB1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaDogQWRkZWQgY29uc3RhbnQgZGVmYXVsdE1h eGltdW1MZW5ndGgKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoKKwogMjAxMC0x MS0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcyMjI4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFbGVtZW50LmgKaW5kZXggMGMwNzY0Y2I5NWVlM2ZjNmJlYTZjMmIyMDc4MjNhY2Fh ODBmOTYxOS4uNjhmYzUzYWRlMjRhZmRjMmQxOWMwMjgzNzdkMmQ5OWMyYjU1N2NmMCAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCkBAIC04MCw2ICs4MCw4IEBAIG5h bWVzcGFjZSBXZWJLaXQgewogICAgICAgICBXRUJLSVRfQVBJIGludCBzZWxlY3Rpb25FbmQoKSBj b25zdDsKICAgICAgICAgV0VCS0lUX0FQSSBib29sIGlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJp bmcmKSBjb25zdDsKIAorICAgICAgICBzdGF0aWMgY29uc3QgaW50IGRlZmF1bHRNYXhpbXVtTGVu Z3RoOworCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAgICAgICAgIFdlYklucHV0RWxlbWVu dChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6SFRNTElucHV0RWxlbWVudD4mKTsKICAg ICAgICAgV2ViSW5wdXRFbGVtZW50JiBvcGVyYXRvcj0oY29uc3QgV1RGOjpQYXNzUmVmUHRyPFdl YkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ+Jik7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYklucHV0RWxlbWVudC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxl bWVudC5jcHAKaW5kZXggZDAzMmVmODQ5ZWZjNTk4ZGU2OWJjNDNkY2ZmNDJiNzk0NDFkM2JjOS4u NjJlNjU3YjBlMTUwYTRhODk0ODFhNTE3ZGNmOTljN2VlMWI0NzU0ZSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcApAQCAtMTYwLDYgKzE2MCw5IEBAIGJvb2wgV2ViSW5w dXRFbGVtZW50Ojppc1ZhbGlkVmFsdWUoY29uc3QgV2ViU3RyaW5nJiB2YWx1ZSkgY29uc3QKICAg ICByZXR1cm4gY29uc3RVbndyYXA8SFRNTElucHV0RWxlbWVudD4oKS0+aXNWYWxpZFZhbHVlKHZh bHVlKTsKIH0KIAorY29uc3QgaW50IFdlYklucHV0RWxlbWVudDo6ZGVmYXVsdE1heGltdW1MZW5n dGggPQorICAgIEhUTUxJbnB1dEVsZW1lbnQ6OnNfbWF4aW11bUxlbmd0aDsKKwogV2ViSW5wdXRF bGVtZW50OjpXZWJJbnB1dEVsZW1lbnQoY29uc3QgUGFzc1JlZlB0cjxIVE1MSW5wdXRFbGVtZW50 PiYgZWxlbSkKICAgICA6IFdlYkZvcm1Db250cm9sRWxlbWVudChlbGVtKQogewo= 74284 2010-11-18 13:18:01 -0800 2010-11-18 13:28:23 -0800 Patch bug-49723-20101118131800.patch text/plain 1996 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJlM2NlOGU3MGQyM2FhNmQyZDYyMzQ2MGZhZjIwZTdiODQyMmZkMzgu LjgyNGE3YWZkZTJmN2JkNTE0MTFmYjMzYzUzNjkwOTA1ZGQwYTBjOTIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTExLTE4ICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIGRlZmF1bHQgdmFsdWUgb2YgbWF4TGVuZ3RoIGluIENocm9taXVtIEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3MjMKKworICAg ICAgICAqIHB1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaDogQWRkZWQgY29uc3RhbnQgZGVmYXVsdE1h eGltdW1MZW5ndGgKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoKKwogMjAxMC0x MS0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcyMjI4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFbGVtZW50LmgKaW5kZXggMGMwNzY0Y2I5NWVlM2ZjNmJlYTZjMmIyMDc4MjNhY2Fh ODBmOTYxOS4uNDY2MjdiZDg5NTM4ZjZkY2IwYTliOGU3YWRkMWVkYjc2N2ExNjM1MCAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCkBAIC04MCw2ICs4MCw4IEBAIG5h bWVzcGFjZSBXZWJLaXQgewogICAgICAgICBXRUJLSVRfQVBJIGludCBzZWxlY3Rpb25FbmQoKSBj b25zdDsKICAgICAgICAgV0VCS0lUX0FQSSBib29sIGlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJp bmcmKSBjb25zdDsKIAorICAgICAgICBXRUJLSVRfQVBJIHN0YXRpYyBjb25zdCBpbnQgZGVmYXVs dE1heGltdW1MZW5ndGg7CisKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICAgICAgICAgV2Vi SW5wdXRFbGVtZW50KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpIVE1MSW5wdXRFbGVt ZW50PiYpOwogICAgICAgICBXZWJJbnB1dEVsZW1lbnQmIG9wZXJhdG9yPShjb25zdCBXVEY6OlBh c3NSZWZQdHI8V2ViQ29yZTo6SFRNTElucHV0RWxlbWVudD4mKTsKZGlmZiAtLWdpdCBhL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViSW5wdXRFbGVtZW50LmNwcAppbmRleCBkMDMyZWY4NDllZmM1OThkZTY5YmM0M2RjZmY0MmI3 OTQ0MWQzYmM5Li42MmU2NTdiMGUxNTBhNGE4OTQ4MWE1MTdkY2Y5OWM3ZWUxYjQ3NTRlIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKKysrIGIvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCkBAIC0xNjAsNiArMTYwLDkgQEAg Ym9vbCBXZWJJbnB1dEVsZW1lbnQ6OmlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJpbmcmIHZhbHVl KSBjb25zdAogICAgIHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5pc1Zh bGlkVmFsdWUodmFsdWUpOwogfQogCitjb25zdCBpbnQgV2ViSW5wdXRFbGVtZW50OjpkZWZhdWx0 TWF4aW11bUxlbmd0aCA9CisgICAgSFRNTElucHV0RWxlbWVudDo6c19tYXhpbXVtTGVuZ3RoOwor CiBXZWJJbnB1dEVsZW1lbnQ6OldlYklucHV0RWxlbWVudChjb25zdCBQYXNzUmVmUHRyPEhUTUxJ bnB1dEVsZW1lbnQ+JiBlbGVtKQogICAgIDogV2ViRm9ybUNvbnRyb2xFbGVtZW50KGVsZW0pCiB7 Cg== 74286 2010-11-18 13:28:26 -0800 2010-11-19 14:14:06 -0800 Patch bug-49723-20101118132825.patch text/plain 2049 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJlM2NlOGU3MGQyM2FhNmQyZDYyMzQ2MGZhZjIwZTdiODQyMmZkMzgu LjgyNGE3YWZkZTJmN2JkNTE0MTFmYjMzYzUzNjkwOTA1ZGQwYTBjOTIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTExLTE4ICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIGRlZmF1bHQgdmFsdWUgb2YgbWF4TGVuZ3RoIGluIENocm9taXVtIEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3MjMKKworICAg ICAgICAqIHB1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaDogQWRkZWQgY29uc3RhbnQgZGVmYXVsdE1h eGltdW1MZW5ndGgKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoKKwogMjAxMC0x MS0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcyMjI4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFbGVtZW50LmgKaW5kZXggMGMwNzY0Y2I5NWVlM2ZjNmJlYTZjMmIyMDc4MjNhY2Fh ODBmOTYxOS4uM2RkN2U0MGVhM2QzODU0ZmI0M2RmNWFhZGZmYzI4MTUzYzFhYTIxZSAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCkBAIC04MCw2ICs4MCw5IEBAIG5h bWVzcGFjZSBXZWJLaXQgewogICAgICAgICBXRUJLSVRfQVBJIGludCBzZWxlY3Rpb25FbmQoKSBj b25zdDsKICAgICAgICAgV0VCS0lUX0FQSSBib29sIGlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJp bmcmKSBjb25zdDsKIAorICAgICAgICAvLyBFeHBvc2VzIHRoZSBkZWZhdWx0IHZhbHVlIG9mIHRo ZSBtYXhMZW5ndGggYXR0cmlidXRlLgorICAgICAgICBXRUJLSVRfQVBJIHN0YXRpYyBjb25zdCBp bnQgZGVmYXVsdE1heExlbmd0aDsKKwogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogICAgICAg ICBXZWJJbnB1dEVsZW1lbnQoY29uc3QgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OkhUTUxJbnB1 dEVsZW1lbnQ+Jik7CiAgICAgICAgIFdlYklucHV0RWxlbWVudCYgb3BlcmF0b3I9KGNvbnN0IFdU Rjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50PiYpOwpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGQwMzJlZjg0OWVmYzU5OGRlNjliYzQzZGNm ZjQyYjc5NDQxZDNiYzkuLjhkODljNjAyOTg2MGU3ZGMxNWZjMGMxOTViYTU5YWIzMTZhY2JkODQg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcAorKysg Yi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKQEAgLTE2MCw2ICsxNjAs OCBAQCBib29sIFdlYklucHV0RWxlbWVudDo6aXNWYWxpZFZhbHVlKGNvbnN0IFdlYlN0cmluZyYg dmFsdWUpIGNvbnN0CiAgICAgcmV0dXJuIGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCkt PmlzVmFsaWRWYWx1ZSh2YWx1ZSk7CiB9CiAKK2NvbnN0IGludCBXZWJJbnB1dEVsZW1lbnQ6OmRl ZmF1bHRNYXhMZW5ndGggPSBIVE1MSW5wdXRFbGVtZW50OjpzX21heGltdW1MZW5ndGg7CisKIFdl YklucHV0RWxlbWVudDo6V2ViSW5wdXRFbGVtZW50KGNvbnN0IFBhc3NSZWZQdHI8SFRNTElucHV0 RWxlbWVudD4mIGVsZW0pCiAgICAgOiBXZWJGb3JtQ29udHJvbEVsZW1lbnQoZWxlbSkKIHsK