49701 2010-11-17 17:24:43 -0800 external script runs more than once in a XML document when the script element is cloned 2010-11-23 16:00:03 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED EasyFix P2 Normal --- 49703 1 rniwa rniwa abarth andersca ap darin eric sam tonyg zimmermann oldest_to_newest 310637 0 rniwa 2010-11-17 17:24:43 -0800 XMLDocumentParser::notifyFinished calls ScriptController::executeScript directly and fails to set isEvaluated flag to true. We should call ScriptElement's executeScript instead. 310645 1 74185 rniwa 2010-11-17 17:47:39 -0800 Created attachment 74185 Patch 310660 2 ap 2010-11-17 18:37:25 -0800 I'm wondering what should happen to scripts inside SVG <use>. 310662 3 rniwa 2010-11-17 18:39:32 -0800 From the bug 49647: (In reply to comment #2) > > WebCore/dom/ScriptElement.h:90 ... > > + bool m_isEvaluated; // HTML5: "already started" ... > > Better names for these data members, that would obviate the need for those HTML5 comments: > ... > m_wasAlreadyStarted ... This really annoyed me when I first looked at this code. I'm glad I can finally correct this. 310664 4 rniwa 2010-11-17 18:41:08 -0800 oops wrong bug, please ignore my comment #3. 313051 5 rniwa 2010-11-23 15:41:32 -0800 Thanks for the review, Adam. Will land. 313058 6 rniwa 2010-11-23 16:00:03 -0800 Committed r72638: <http://trac.webkit.org/changeset/72638> 74185 2010-11-17 17:47:39 -0800 2010-11-23 11:24:48 -0800 Patch bug-49701-20101117174737.patch text/plain 3953 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjI2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTEtMTcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgWE1M RG9jdW1lbnRQYXJzZXI6Om5vdGlmeUZpbmlzaGVkIGNhbGxzIFNjcmlwdENvbnRyb2xsZXIncyBl eGVjdXRlU2NyaXB0IHdpdGhvdXQgdXBkYXRpbmcgaXNFdmFsdWF0ZWQgZmxhZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk3MDEKKworICAgICAgICBG aXhlZCB0aGUgYnVnIGJ5IGNhbGxpbmcgU2NyaXB0RWxlbWVudCdzIGV4ZWN1dGVTY3JpcHQsIHdo aWNoIHNldHMgaXNFdmFsdWF0ZWQgZmxhZyB0byB0cnVlLgorCisgICAgICAgIFRlc3Q6IGZhc3Qv ZG9tL3NjcmlwdC1jbG9uZS1yZXJ1bi1zcmMueGh0bWwKKworICAgICAgICAqIGRvbS9YTUxEb2N1 bWVudFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVudFBhcnNlcjo6bm90 aWZ5RmluaXNoZWQpOgorCiAyMDEwLTExLTE3ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBX ZWJDb3JlL2RvbS9YTUxEb2N1bWVudFBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9k b20vWE1MRG9jdW1lbnRQYXJzZXIuY3BwCShyZXZpc2lvbiA3MjIyMikKKysrIFdlYkNvcmUvZG9t L1hNTERvY3VtZW50UGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU5LDcgKzM1OSw3IEBA IHZvaWQgWE1MRG9jdW1lbnRQYXJzZXI6Om5vdGlmeUZpbmlzaGVkKEMKICAgICBpZiAoZXJyb3JP Y2N1cnJlZCkKICAgICAgICAgc2NyaXB0RWxlbWVudC0+ZGlzcGF0Y2hFcnJvckV2ZW50KCk7CiAg ICAgZWxzZSB7Ci0gICAgICAgIG1fdmlldy0+ZnJhbWUoKS0+c2NyaXB0KCktPmV4ZWN1dGVTY3Jp cHQoc291cmNlQ29kZSk7CisgICAgICAgIHNjcmlwdEVsZW1lbnQtPmV4ZWN1dGVTY3JpcHQoc291 cmNlQ29kZSk7CiAgICAgICAgIHNjcmlwdEVsZW1lbnQtPmRpc3BhdGNoTG9hZEV2ZW50KCk7CiAg ICAgfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3MjI2NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEwLTExLTE3ICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFhNTERvY3VtZW50UGFyc2VyOjpub3RpZnlGaW5pc2hlZCBjYWxscyBT Y3JpcHRDb250cm9sbGVyJ3MgZXhlY3V0ZVNjcmlwdCB3aXRob3V0IHVwZGF0aW5nIGlzRXZhbHVh dGVkIGZsYWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ5NzAxCisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IHRvIGVuc3VyZSBXZWJLaXQgZG9lc24ndCBy dW4gdGhlIHNjcmlwdCB0d2ljZSB3aGVuIGEgc2NyaXB0IGVsZW1lbnQgd2l0aCBhbiBleHRlcm5h bCBzY3JpcHQgZmlsZQorICAgICAgICBpcyBjbG9uZWQgaW4gYSBYTUwgZG9jdW1lbnQuCisKKyAg ICAgICAgKiBmYXN0L2RvbS9yZXNvdXJjZXMvc2NyaXB0LWNsb25lLXJlcnVuLXNyYy5qczogQWRk ZWQuCisgICAgICAgICogZmFzdC9kb20vc2NyaXB0LWNsb25lLXJlcnVuLXNyYy54aHRtbDogQWRk ZWQuCisKIDIwMTAtMTEtMTcgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIENyZWF0ZSBMZW9wYXJkLXNwZWNpZmljIHJlc3VsdHMgZm9yIHRlc3RzIHRoYXQgZGlmZmVy IGJldHdlZW4gTGVvcGFyZApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LWNsb25l LXJlcnVuLXNyYy54aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3Jp cHQtY2xvbmUtcmVydW4tc3JjLnhodG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9kb20vc2NyaXB0LWNsb25lLXJlcnVuLXNyYy54aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw0NyBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KKzwhRE9DVFlQ RSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4xLy9FTiIKKyAgICAiaHR0cDovL3d3 dy53My5vcmcvVFIveGh0bWwxMS9EVEQveGh0bWwxMS5kdGQiPgorPGh0bWwgeG1sbnM9Imh0dHA6 Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIgPgorPGhlYWQ+Cis8c2NyaXB0 PgorCit2YXIgaSA9IDA7CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCit2YXIgZmlyc3RMb2FkID0gdHJ1ZTsKKworZnVu Y3Rpb24gbG9hZGVkKCkgeworICAgIGlmIChmaXJzdExvYWQpIHsKKyAgICAgICAgZmlyc3RMb2Fk ID0gZmFsc2U7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICByZXN1bHQgPSAnUEFTUyc7 CisgICAgaWYgKGkgPT0gMikKKyAgICAgIHJlc3VsdCA9ICdGQUlMOiBzY3JpcHQgcmFuIHR3aWNl JzsKKyAgICBlbHNlIGlmIChpID4gMikKKyAgICAgIHJlc3VsdCA9ICdGQUlMOiBzY3JpcHQgcmFu ICcgKyBpICsgJyB0aW1lcyc7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVu dC5jcmVhdGVUZXh0Tm9kZShyZXN1bHQpKTsKKworICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5v dGlmeURvbmUoKTsKK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRoaXMgdGVz dCBydW5zIGEgc2NyaXB0IHRoYXQgY2xvbmVzIGFuZCBpbnNlcnRzIGl0cyBzY3JpcHQgZWxlbWVu dC4gVGhlIHNjcmlwdCBzaG91bGQgcnVuIGV4YWN0bHkgb25jZSBhbmQgcHJpbnQgUEFTUzo8L3A+ Cis8ZGl2PjxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvc2NyaXB0LWNsb25lLXJlcnVuLXNyYy5qcyIg b25sb2FkPSJsb2FkZWQoKSI+PC9zY3JpcHQ+PC9kaXY+Cis8c2NyaXB0PgorCit2YXIgc2NyaXB0 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3NjcmlwdCcpWzFdOwordmFyIGRpdiA9 IHNjcmlwdC5wYXJlbnROb2RlOworZGl2LnJlbW92ZUNoaWxkKHNjcmlwdCk7CitkaXYuYXBwZW5k Q2hpbGQoc2NyaXB0LmNsb25lTm9kZSh0cnVlKSk7CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVzb3VyY2VzL3NjcmlwdC1jbG9uZS1y ZXJ1bi1zcmMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVzb3VyY2Vz L3NjcmlwdC1jbG9uZS1yZXJ1bi1zcmMuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9yZXNvdXJjZXMvc2NyaXB0LWNsb25lLXJlcnVuLXNyYy5qcwkocmV2aXNpb24gMCkK QEAgLTAsMCArMSBAQAoraSsrOwo=