49698 2010-11-17 16:36:06 -0800 [skia] assert when attempting to get (but not use) pointer to outside the canvas 2010-11-19 03:10:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 mikelawther webkit-unassigned commit-queue jamesr oldest_to_newest 310605 0 mikelawther 2010-11-17 16:36:06 -0800 [skia] assert when attempting to get (but not use) pointer to outside the canvas 310609 1 74177 mikelawther 2010-11-17 16:44:33 -0800 Created attachment 74177 Patch 310613 2 mikelawther 2010-11-17 16:51:13 -0800 This fixes the assert we see in canvas/philip/tests/2d.imageData.get.source.outside on Windows debug. 310614 3 74177 jamesr 2010-11-17 16:56:25 -0800 Comment on attachment 74177 Patch R=me 311335 4 74177 commit-queue 2010-11-19 03:10:01 -0800 Comment on attachment 74177 Patch Clearing flags on attachment: 74177 Committed r72374: <http://trac.webkit.org/changeset/72374> 311336 5 commit-queue 2010-11-19 03:10:06 -0800 All reviewed patches have been landed. Closing bug. 74177 2010-11-17 16:44:33 -0800 2010-11-19 03:10:01 -0800 Patch bug-49698-20101118114430.patch text/plain 3340 mikelawther ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2Y2Q5MjdkNGVmOTJjOGExYmU0MzEwZmM4NjU3ZDA3NjhjOWQyOWY1Li5lNzgxYTBi NzkxZGE4NGQ5NzMyZDBhM2Y3YWVkNDZkMzBjNjYwYjBhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTEtMTcgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbc2tpYV0gYXNz ZXJ0IHdoZW4gYXR0ZW1wdGluZyB0byBnZXQgKGJ1dCBub3QgdXNlKSBwb2ludGVyIHRvIG91dHNp ZGUgdGhlIGNhbnZhcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDk2OTgKKworICAgICAgICBSZW1vdmVkIGV4cGVjdGF0aW9uIG9mIGZhaWx1cmUgb24g V2luIGRiZworCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0OgorCiAyMDEwLTExLTE1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCB0ZXN0IGV4cGVjdGF0aW9uIHVwZGF0ZS4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA4 NmExNjBhZTE0MTQ2ZTgwNDE0MzZmYWFkYjdiMzllMjc1ZmRkODA4Li4yOGYwMTk2MjNmYWU3NmYy MDg2OTU4YjI2ZWY5ODliNmI2MTUxYzNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yNDg4LDggKzI0ODgsNyBAQCBC VUdXSzQ1OTkxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc3Ryb2tlUmVjdC56ZXJvLjQu aHRtbCA9IFRFWFQgUEFTUwogQlVHV0s0NTk5MSBNQUMgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LnRleHQuZHJhdy5iYXNlbGluZS5pZGVvZ3JhcGhpYy5odG1sID0gVEVYVCBQQVNTCiBCVUdXSzQ1 OTkxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvdG9EYXRhVVJMLmpwZWcuYWxwaGEuaHRtbCA9 IFRFWFQgUEFTUwogCi1CVUdXSzQ1OTkxIERFQlVHIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5p bWFnZURhdGEuZ2V0LnNvdXJjZS5vdXRzaWRlLmh0bWwgPSBURVhUCi1CVUdXSzQ1OTkxIE1BQyBS RUxFQVNFIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5vdXRz aWRlLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu aW1hZ2VEYXRhLmdldC5zb3VyY2Uub3V0c2lkZS5odG1sID0gVEVYVAogCiAvLyBUaGlzIHNlZW1z IHRvIGJlIGZhaWxpbmcgb24gd2luZG93cyBvbmx5LgogQlVHV0s0NTk5MSBXSU4gOiBjYW52YXMv cGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC50b3VjaDIuaHRtbCA9IFRFWFQKZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDVmNWQ1 Yzc4YzBhNmM1ZDExZjExYzQ1ZGYwZjU4Y2M0MDU0NWZmMi4uNTg2N2Y3ZTY4Y2VkNmM3N2JkZDFj ZjgzOWFhNmE1ZGZiODU0ZjM3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0xNyAgTWlrZSBMYXd0 aGVyICA8bWlrZWxhd3RoZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtza2lhXSBhc3NlcnQgd2hlbiBhdHRlbXB0aW5nIHRv IGdldCAoYnV0IG5vdCB1c2UpIHBvaW50ZXIgdG8gb3V0c2lkZSB0aGUgY2FudmFzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTY5OAorCisgICAgICAg IEVhcmx5IHJldHVybiB0byBhdm9pZCBnZXR0aW5nIGEgcG9pbnRlciB0byBvdXRzaWRlIHRoZSBj YW52YXMsIGFuZAorICAgICAgICBoZW5jZSB0cmlnZ2VyaW5nIGEgU2tpYSBhc3NlcnQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpnZXRJbWFnZURhdGEpOgorCiAyMDEwLTExLTE1ICBBZGVsZSBQZXRlcnNv biAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNr aWEuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5j cHAKaW5kZXggMGRiOTZjZjc4ZDI1OWM2MzI5NjNhODEzMjdlYTRjMTNlOTVmNmYzZC4uYWRiNzMy YmNhMWI5NTJlMGVhOTM3ZDVhZDkwMmE0YWU1ZWU3MGE5OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKQEAgLTE4Myw2ICsxODMs OSBAQCBQYXNzUmVmUHRyPEltYWdlRGF0YT4gZ2V0SW1hZ2VEYXRhKGNvbnN0IEludFJlY3QmIHJl Y3QsIGNvbnN0IFNrQml0bWFwJiBiaXRtYXAsCiAgICAgICAgIGVuZFggPSBzaXplLndpZHRoKCk7 CiAgICAgaW50IG51bUNvbHVtbnMgPSBlbmRYIC0gb3JpZ2luWDsKIAorICAgIGlmIChudW1Db2x1 bW5zIDw9IDApIAorICAgICAgICByZXR1cm4gcmVzdWx0OworCiAgICAgaW50IG9yaWdpblkgPSBy ZWN0LnkoKTsKICAgICBpbnQgZGVzdFkgPSAwOwogICAgIGlmIChvcmlnaW5ZIDwgMCkgewpAQCAt MTk0LDYgKzE5Nyw5IEBAIFBhc3NSZWZQdHI8SW1hZ2VEYXRhPiBnZXRJbWFnZURhdGEoY29uc3Qg SW50UmVjdCYgcmVjdCwgY29uc3QgU2tCaXRtYXAmIGJpdG1hcCwKICAgICAgICAgZW5kWSA9IHNp emUuaGVpZ2h0KCk7CiAgICAgaW50IG51bVJvd3MgPSBlbmRZIC0gb3JpZ2luWTsKIAorICAgIGlm IChudW1Sb3dzIDw9IDApIAorICAgICAgICByZXR1cm4gcmVzdWx0OworCiAgICAgQVNTRVJUKGJp dG1hcC5jb25maWcoKSA9PSBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcpOwogICAgIFNrQXV0 b0xvY2tQaXhlbHMgYml0bWFwTG9jayhiaXRtYXApOwogCg==