49666 2010-11-17 08:35:42 -0800 [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed" when using HTTP cache 2010-11-19 04:33:12 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 svillar webkit-unassigned commit-queue xan.lopez oldest_to_newest 310302 0 svillar 2010-11-17 08:35:42 -0800 People reported load errors when this critical is shown. It seems that clearing the cache helps, but it reappears later after some more browsing 310316 1 74120 svillar 2010-11-17 08:54:20 -0800 Created attachment 74120 Fix for the bug The assumption was wrong. We were assuming that the HTTP cache was the only one generating conditional requests to the server for its cached resources. WebKit has its own in memory resource cache. It is capable of detecting when a resource needs to be revalidated and thus it can create conditional requests by itself. The problem was that the cache code was not considering that possibility, cache clients should be allowed to issue their own conditional requests. In those cases the cache should not do anything special, just return the resource as provided by libsoup. 310319 2 svillar 2010-11-17 08:55:38 -0800 Adding Xan as he told me about this bug 310495 3 74120 xan.lopez 2010-11-17 13:41:25 -0800 Comment on attachment 74120 Fix for the bug >+ taken that into account by taking the assumption that any possible taking that into account... making the assumption? >+ conditional request was always generated by itself. >+ >+ * platform/network/soup/cache/webkit/soup-cache.c: >+ (webkit_soup_cache_entry_remove): added an assertion >+ (msg_got_headers_cb): >+ Rest makes sense to me, thanks for tracking it down. 310733 4 74210 svillar 2010-11-18 00:35:37 -0800 Created attachment 74210 Fix for the bug 310768 5 74120 eric 2010-11-18 03:18:30 -0800 Comment on attachment 74120 Fix for the bug Cleared Xan Lopez's review+ from obsolete attachment 74120 so that this bug does not appear in http://webkit.org/pending-commit. 310826 6 74210 xan.lopez 2010-11-18 06:26:17 -0800 Comment on attachment 74210 Fix for the bug r=me 311232 7 74210 xan.lopez 2010-11-18 18:44:12 -0800 Comment on attachment 74210 Fix for the bug Clearing flags, seems this got stuck in cq. 311233 8 74210 xan.lopez 2010-11-18 18:44:28 -0800 Comment on attachment 74210 Fix for the bug Hi? 311352 9 74210 commit-queue 2010-11-19 04:33:07 -0800 Comment on attachment 74210 Fix for the bug Clearing flags on attachment: 74210 Committed r72378: <http://trac.webkit.org/changeset/72378> 311353 10 commit-queue 2010-11-19 04:33:12 -0800 All reviewed patches have been landed. Closing bug. 74120 2010-11-17 08:54:20 -0800 2010-11-18 03:18:30 -0800 Fix for the bug 0001-Fix-for-49666.patch text/plain 3000 svillar RnJvbSBkMWIzYzk0NTAwODM1ZjIyY2FiOGZmMjIxNjBmOWI2MDkzNzY4YjkyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gVmlsbGFyIFNlbmluIDxzdmlsbGFyQGlnYWxpYS5j b20+CkRhdGU6IFdlZCwgMTcgTm92IDIwMTAgMTc6NDU6MDUgKzAxMDAKU3ViamVjdDogW1BBVENI XSBGaXggZm9yIDQ5NjY2CgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysKIC4uLi9uZXR3b3JrL3NvdXAvY2Fj aGUvd2Via2l0L3NvdXAtY2FjaGUuYyAgICAgICAgIHwgICAyNiArKysrKysrKysrKystLS0tLS0t CiAyIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMx ZWRhZi4uOWU2YWNlNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMS0xNyAgU2VyZ2lvIFZpbGxhciBT ZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR3RrXSAiQ1JJVElDQUwgKio6IG1zZ19nb3RfaGVhZGVyc19j YjogYXNzZXJ0aW9uIGBlbnRyeScgZmFpbGVkIiB3aGVuIHVzaW5nIEhUVFAgY2FjaGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NjY2CisKKyAgICAg ICAgV2ViS2l0IHJlc291cmNlIGxvYWQgY2FjaGUgZG9lcyB2YWxpZGF0ZSBpdHMgb3duIHJlc291 cmNlcyBieQorICAgICAgICBpc3N1aW5nIGNvbmRpdGlvbmFsIHJlcXVlc3RzIHRvIHRoZSBzZXJ2 ZXIuIFRoZSBIVFRQIGNhY2hlIHdhcyBub3QKKyAgICAgICAgdGFrZW4gdGhhdCBpbnRvIGFjY291 bnQgYnkgdGFraW5nIHRoZSBhc3N1bXB0aW9uIHRoYXQgYW55IHBvc3NpYmxlCisgICAgICAgIGNv bmRpdGlvbmFsIHJlcXVlc3Qgd2FzIGFsd2F5cyBnZW5lcmF0ZWQgYnkgaXRzZWxmLgorCisgICAg ICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmM6Cisg ICAgICAgICh3ZWJraXRfc291cF9jYWNoZV9lbnRyeV9yZW1vdmUpOiBhZGRlZCBhbiBhc3NlcnRp b24KKyAgICAgICAgKG1zZ19nb3RfaGVhZGVyc19jYik6CisKIDIwMTAtMTEtMTQgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEJhY2sgb3V0IHRoZSBpdGFsaWNzIHBv cnRpb24gb2YgdGhlIHByZXZpb3VzIHBhdGNoIHVudGlsIEkgY2FuIGZpZ3VyZSBvdXQgd2h5IGl0 CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQv c291cC1jYWNoZS5jIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0 L3NvdXAtY2FjaGUuYwppbmRleCA3M2IxNWJhLi5mYWE2MTE0IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMKQEAg LTcwMiw2ICs3MDIsNyBAQCB3ZWJraXRfc291cF9jYWNoZV9lbnRyeV9yZW1vdmUgKFdlYktpdFNv dXBDYWNoZSAqY2FjaGUsIFdlYktpdFNvdXBDYWNoZUVudHJ5ICplbgogCQlyZXR1cm4gRkFMU0U7 CiAJfQogCisJZ19hc3NlcnQgKCFlbnRyeS0+ZGlydHkpOwogCWdfYXNzZXJ0IChnX2xpc3RfbGVu Z3RoIChjYWNoZS0+cHJpdi0+bHJ1X3N0YXJ0KSA9PSBnX2hhc2hfdGFibGVfc2l6ZSAoY2FjaGUt PnByaXYtPmNhY2hlKSk7CiAKIAkvKiBSZW1vdmUgZnJvbSBjYWNoZSAqLwpAQCAtOTY1LDE2ICs5 NjYsMjEgQEAgbXNnX2dvdF9oZWFkZXJzX2NiIChTb3VwTWVzc2FnZSAqbXNnLCBncG9pbnRlciB1 c2VyX2RhdGEpCiAJCWVudHJ5ID0gZ19oYXNoX3RhYmxlX2xvb2t1cCAoY2FjaGUtPnByaXYtPmNh Y2hlLCBrZXkpOwogCQlnX2ZyZWUgKGtleSk7CiAKLQkJZ19yZXR1cm5faWZfZmFpbCAoZW50cnkp OwotCi0JCWVudHJ5LT5iZWluZ192YWxpZGF0ZWQgPSBGQUxTRTsKLQotCQkvKiBXZSB1cGRhdGUg dGhlIGhlYWRlcnMgb2YgdGhlIGV4aXN0aW5nIGNhY2hlIGl0ZW0sCi0JCSAgIHBsdXMgaXRzIGFn ZSAqLwotCQlzb3VwX21lc3NhZ2VfaGVhZGVyc19mb3JlYWNoIChtc2ctPnJlc3BvbnNlX2hlYWRl cnMsCi0JCQkJCSAgICAgIChTb3VwTWVzc2FnZUhlYWRlcnNGb3JlYWNoRnVuYyl1cGRhdGVfaGVh ZGVycywKLQkJCQkJICAgICAgZW50cnktPmhlYWRlcnMpOwotCQl3ZWJraXRfc291cF9jYWNoZV9l bnRyeV9zZXRfZnJlc2huZXNzIChlbnRyeSwgbXNnLCBjYWNoZSk7CisJCS8qIEl0J3MgcG9zc2li bGUgdG8gZ2V0IGEgQ0FDSEVfVkFMSURBVEVTIHdpdGggbm8KKwkJICogZW50cnkgaW4gdGhlIGhh c2ggdGFibGUuIFRoaXMgY291bGQgaGFwcGVuIGlmIGZvcgorCQkgKiBleGFtcGxlIHRoZSBzb3Vw IGNsaWVudCBpcyB0aGUgb25lIGNyZWF0aW5nIHRoZQorCQkgKiBjb25kaXRpb25hbCByZXF1ZXN0 LgorCQkgKi8KKwkJaWYgKGVudHJ5KSB7CisJCQllbnRyeS0+YmVpbmdfdmFsaWRhdGVkID0gRkFM U0U7CisKKwkJCS8qIFdlIHVwZGF0ZSB0aGUgaGVhZGVycyBvZiB0aGUgZXhpc3RpbmcgY2FjaGUg aXRlbSwKKwkJCSAgIHBsdXMgaXRzIGFnZSAqLworCQkJc291cF9tZXNzYWdlX2hlYWRlcnNfZm9y ZWFjaCAobXNnLT5yZXNwb25zZV9oZWFkZXJzLAorCQkJCQkJICAgICAgKFNvdXBNZXNzYWdlSGVh ZGVyc0ZvcmVhY2hGdW5jKXVwZGF0ZV9oZWFkZXJzLAorCQkJCQkJICAgICAgZW50cnktPmhlYWRl cnMpOworCQkJd2Via2l0X3NvdXBfY2FjaGVfZW50cnlfc2V0X2ZyZXNobmVzcyAoZW50cnksIG1z ZywgY2FjaGUpOworCQl9CiAJfQogfQogCi0tIAoxLjcuMQoK 74210 2010-11-18 00:35:37 -0800 2010-11-19 04:33:07 -0800 Fix for the bug 0001-Fix-for-49666.patch text/plain 2918 svillar RnJvbSAxZmIwNzM1MDA0NWIxNzYyMWFmYmRlMzU4Zjk0MDI0NmYxZDdlYzc1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gVmlsbGFyIFNlbmluIDxzdmlsbGFyQGlnYWxpYS5j b20+CkRhdGU6IFdlZCwgMTcgTm92IDIwMTAgMTc6NDU6MDUgKzAxMDAKU3ViamVjdDogW1BBVENI XSBGaXggZm9yIDQ5NjY2CgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysKIC4uLi9uZXR3b3JrL3NvdXAvY2Fj aGUvd2Via2l0L3NvdXAtY2FjaGUuYyAgICAgICAgIHwgICAyNiArKysrKysrKysrKystLS0tLS0t CiAyIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Ey MzJhNC4uMDI4NjU3NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMS0xNyAgU2VyZ2lvIFZpbGxhciBT ZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR3RrXSAiQ1JJVElDQUwgKio6IG1zZ19nb3RfaGVhZGVyc19j YjogYXNzZXJ0aW9uIGBlbnRyeScgZmFpbGVkIiB3aGVuIHVzaW5nIEhUVFAgY2FjaGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NjY2CisKKyAgICAg ICAgV2ViS2l0IHJlc291cmNlIGxvYWQgY2FjaGUgZG9lcyB2YWxpZGF0ZSBpdHMgb3duIHJlc291 cmNlcyBieQorICAgICAgICBpc3N1aW5nIGNvbmRpdGlvbmFsIHJlcXVlc3RzIHRvIHRoZSBzZXJ2 ZXIuIFRoZSBIVFRQIGNhY2hlIHdhcworICAgICAgICBtYWtpbmcgdGhlIGFzc3VtcHRpb24gdGhh dCBhbnkgcG9zc2libGUgY29uZGl0aW9uYWwgcmVxdWVzdCB3YXMKKyAgICAgICAgYWx3YXlzIGdl bmVyYXRlZCBieSBpdHNlbGYuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2Fj aGUvd2Via2l0L3NvdXAtY2FjaGUuYzoKKyAgICAgICAgKHdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5 X3JlbW92ZSk6IGFkZGVkIGFuIGFzc2VydGlvbgorICAgICAgICAobXNnX2dvdF9oZWFkZXJzX2Ni KToKKwogMjAxMC0xMS0xNyAgVGVuZ2h1aSBaaHUgIDx6dGVuZ2h1aUBnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMgYi9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jCmluZGV4IDczYjE1 YmEuLmZhYTYxMTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2Nh Y2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYwpAQCAtNzAyLDYgKzcwMiw3IEBAIHdlYmtpdF9z b3VwX2NhY2hlX2VudHJ5X3JlbW92ZSAoV2ViS2l0U291cENhY2hlICpjYWNoZSwgV2ViS2l0U291 cENhY2hlRW50cnkgKmVuCiAJCXJldHVybiBGQUxTRTsKIAl9CiAKKwlnX2Fzc2VydCAoIWVudHJ5 LT5kaXJ0eSk7CiAJZ19hc3NlcnQgKGdfbGlzdF9sZW5ndGggKGNhY2hlLT5wcml2LT5scnVfc3Rh cnQpID09IGdfaGFzaF90YWJsZV9zaXplIChjYWNoZS0+cHJpdi0+Y2FjaGUpKTsKIAogCS8qIFJl bW92ZSBmcm9tIGNhY2hlICovCkBAIC05NjUsMTYgKzk2NiwyMSBAQCBtc2dfZ290X2hlYWRlcnNf Y2IgKFNvdXBNZXNzYWdlICptc2csIGdwb2ludGVyIHVzZXJfZGF0YSkKIAkJZW50cnkgPSBnX2hh c2hfdGFibGVfbG9va3VwIChjYWNoZS0+cHJpdi0+Y2FjaGUsIGtleSk7CiAJCWdfZnJlZSAoa2V5 KTsKIAotCQlnX3JldHVybl9pZl9mYWlsIChlbnRyeSk7Ci0KLQkJZW50cnktPmJlaW5nX3ZhbGlk YXRlZCA9IEZBTFNFOwotCi0JCS8qIFdlIHVwZGF0ZSB0aGUgaGVhZGVycyBvZiB0aGUgZXhpc3Rp bmcgY2FjaGUgaXRlbSwKLQkJICAgcGx1cyBpdHMgYWdlICovCi0JCXNvdXBfbWVzc2FnZV9oZWFk ZXJzX2ZvcmVhY2ggKG1zZy0+cmVzcG9uc2VfaGVhZGVycywKLQkJCQkJICAgICAgKFNvdXBNZXNz YWdlSGVhZGVyc0ZvcmVhY2hGdW5jKXVwZGF0ZV9oZWFkZXJzLAotCQkJCQkgICAgICBlbnRyeS0+ aGVhZGVycyk7Ci0JCXdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X3NldF9mcmVzaG5lc3MgKGVudHJ5 LCBtc2csIGNhY2hlKTsKKwkJLyogSXQncyBwb3NzaWJsZSB0byBnZXQgYSBDQUNIRV9WQUxJREFU RVMgd2l0aCBubworCQkgKiBlbnRyeSBpbiB0aGUgaGFzaCB0YWJsZS4gVGhpcyBjb3VsZCBoYXBw ZW4gaWYgZm9yCisJCSAqIGV4YW1wbGUgdGhlIHNvdXAgY2xpZW50IGlzIHRoZSBvbmUgY3JlYXRp bmcgdGhlCisJCSAqIGNvbmRpdGlvbmFsIHJlcXVlc3QuCisJCSAqLworCQlpZiAoZW50cnkpIHsK KwkJCWVudHJ5LT5iZWluZ192YWxpZGF0ZWQgPSBGQUxTRTsKKworCQkJLyogV2UgdXBkYXRlIHRo ZSBoZWFkZXJzIG9mIHRoZSBleGlzdGluZyBjYWNoZSBpdGVtLAorCQkJICAgcGx1cyBpdHMgYWdl ICovCisJCQlzb3VwX21lc3NhZ2VfaGVhZGVyc19mb3JlYWNoIChtc2ctPnJlc3BvbnNlX2hlYWRl cnMsCisJCQkJCQkgICAgICAoU291cE1lc3NhZ2VIZWFkZXJzRm9yZWFjaEZ1bmMpdXBkYXRlX2hl YWRlcnMsCisJCQkJCQkgICAgICBlbnRyeS0+aGVhZGVycyk7CisJCQl3ZWJraXRfc291cF9jYWNo ZV9lbnRyeV9zZXRfZnJlc2huZXNzIChlbnRyeSwgbXNnLCBjYWNoZSk7CisJCX0KIAl9CiB9CiAK LS0gCjEuNy4xCgo=