49664 2010-11-17 07:17:00 -0800 [Qt] [WK2] WebKit 2 would not compile for Qt without ENABLE_TOUCH_EVENT 2010-11-18 11:49:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P5 Trivial --- 1 benjamin benjamin commit-queue eric oldest_to_newest 310268 0 benjamin 2010-11-17 07:17:00 -0800 The #defines for ENABLE_TOUCH_EVENT seem a bit chaotic. It looks like the library would not compile. 310283 1 74114 benjamin 2010-11-17 07:54:51 -0800 Created attachment 74114 Patch 310304 2 74114 laszlo.gombos 2010-11-17 08:37:49 -0800 Comment on attachment 74114 Patch LGTM, r+. Laszlo 310744 3 commit-queue 2010-11-18 01:05:47 -0800 The commit-queue encountered the following flaky tests while processing attachment 74114: fast/loader/recursive-before-unload-crash.html fast/dom/onerror-img.html Please file bugs against the tests. These tests were authored by beidson@apple.com and eric@webkit.org. The commit-queue is continuing to process your patch. 310831 4 74114 commit-queue 2010-11-18 06:34:21 -0800 Comment on attachment 74114 Patch Rejecting patch 74114 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: itBuild/Debug/WebProcess.app /Projects/CommitQueue/WebKitBuild/Debug/WebKit2.framework ** BUILD FAILED ** The following build commands failed: WebKit2: CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKeyboardEvent.o /Projects/CommitQueue/WebKit2/Shared/WebKeyboardEvent.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (1 failure) Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81. Full output: http://queues.webkit.org/results/6178063 310848 5 74114 benjamin 2010-11-18 07:11:22 -0800 Comment on attachment 74114 Patch cq+, this patch has nothing to do with the build failure on Mac. 310911 6 74114 commit-queue 2010-11-18 10:09:26 -0800 Comment on attachment 74114 Patch Clearing flags on attachment: 74114 Committed r72305: <http://trac.webkit.org/changeset/72305> 310912 7 commit-queue 2010-11-18 10:09:31 -0800 All reviewed patches have been landed. Closing bug. 311017 8 eric 2010-11-18 11:49:33 -0800 Odd. I'm not sure how the cq got confused like that. It should have tried to build again and failed and then not commented. I've not seen it have a false-positive build failure in a long long time. 74114 2010-11-17 07:54:51 -0800 2010-11-18 10:09:26 -0800 Patch 49664.patch text/plain 1982 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NTY3NWQ3YS4uNjc5Y2ExMiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0xMS0xNyAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1dLMl0gV2ViS2l0IDIgd291bGQgbm90 IGNvbXBpbGUgZm9yIFF0IHdpdGhvdXQgRU5BQkxFX1RPVUNIX0VWRU5UCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTY2NAorCisgICAgICAgIE1vdmUg dGhlIEVOQUJMRShUT1VDSF9FVkVOVFMpIHRvIHRoZSBjb2RlIHdoZXJlIGludGVybmFsIFdlYktp dCB0b3VjaAorICAgICAgICB0eXBlcyBhcmUgdXNlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvcXQvcWdyYXBoaWNzd2t2aWV3LmNwcDoKKyAgICAgICAgKFFHcmFwaGljc1dLVmlldzo6dG91 Y2hFdmVudCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcDoKKyAgICAg ICAgKFFXS1BhZ2VQcml2YXRlOjp0b3VjaEV2ZW50KToKKworMjAxMC0xMS0xNyAgQmVuamFtaW4g UG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgogCiAgICAgICAgIFtRdF0gW1dLMl0gVGhl IGZvY3VzIHN3aXRjaGluZyBkb2VzIG5vdCBzZWVtcyB0byB3b3JrIHdpdGggUUdyYXBoaWNzV0tW aWV3CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3 LmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCmluZGV4 IDA4YmRiYmIuLmFhY2FkZTkgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x Z3JhcGhpY3N3a3ZpZXcuY3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhp Y3N3a3ZpZXcuY3BwCkBAIC0zMDUsMTIgKzMwNSwxMCBAQCB2b2lkIFFHcmFwaGljc1dLVmlldzo6 d2hlZWxFdmVudChRR3JhcGhpY3NTY2VuZVdoZWVsRXZlbnQqIGV2KQogICAgICAgICBRR3JhcGhp Y3NJdGVtOjp3aGVlbEV2ZW50KGV2KTsKIH0KIAotI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiB2 b2lkIFFHcmFwaGljc1dLVmlldzo6dG91Y2hFdmVudChRVG91Y2hFdmVudCogZXYpCiB7CiAgICAg cGFnZSgpLT5kLT50b3VjaEV2ZW50KGV2KTsKIH0KLSNlbmRpZgogCiB2b2lkIFFHcmFwaGljc1dL Vmlldzo6Zm9jdXNJbkV2ZW50KFFGb2N1c0V2ZW50KikKIHsKZGlmZiAtLWdpdCBhL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x d2twYWdlLmNwcAppbmRleCAyZWI1MDdhLi44MjY4MTczIDEwMDY0NAotLS0gYS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2UuY3BwCkBAIC0yOTUsOCArMjk1LDEyIEBAIHZvaWQgUVdLUGFnZVByaXZhdGU6Ol9x X3dlYkFjdGlvblRyaWdnZXJlZChib29sIGNoZWNrZWQpCiAKIHZvaWQgUVdLUGFnZVByaXZhdGU6 OnRvdWNoRXZlbnQoUVRvdWNoRXZlbnQqIGV2ZW50KQogeworI2lmIEVOQUJMRShUT1VDSF9FVkVO VFMpCiAgICAgV2ViVG91Y2hFdmVudCB0b3VjaEV2ZW50ID0gV2ViRXZlbnRGYWN0b3J5OjpjcmVh dGVXZWJUb3VjaEV2ZW50KGV2ZW50KTsKICAgICBwYWdlLT5oYW5kbGVUb3VjaEV2ZW50KHRvdWNo RXZlbnQpOworI2Vsc2UKKyAgICBldmVudC0+aWdub3JlKCk7CisjZW5kaWYKIH0KIAogUVdLUGFn ZTo6UVdLUGFnZShXS1BhZ2VOYW1lc3BhY2VSZWYgbmFtZXNwYWNlUmVmKQo=