49656 2010-11-17 05:28:14 -0800 [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189 2010-11-18 08:12:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 antonm apavlov apavlov levin pfeldman tkent yurys oldest_to_newest 310216 0 antonm 2010-11-17 05:28:14 -0800 Alexander is tracking it down, for now just disabling the test 310330 1 apavlov 2010-11-17 09:19:09 -0800 Seems related to the bug 33193 patch by tkent@chromium.org, which explicitly cancels HasIndexGetter for WebKitCSSTransformValue (CodeGeneratorV8.pm). The code that manifests the issue is (element.style having "-webkit-transform: rotate(90deg)"): element.style.getPropertyCSSValue("-webkit-transform")[0][0] returns "undefined", while Safari returns the property CSSPrimitiveValue instance on which you can invoke e.g. getFloatValue(CSSPrimitiveValue.CSS_RAD). I believe tkent@chromium.org may have some insight in this regard. 310732 2 tkent 2010-11-18 00:34:18 -0800 I remember V8WebKitCSSTransformValue class inherited something (maybe V8CSSValueList?) at that time and no need to implement index getter functions. But with the current CodeGeneratorV8.pm, V8WebKitCSSTransformValue inherits nothing. So my hack in Bug 33193 is not effective now. We should remove the change of Bug 33193, and implement index getter functions for V8WebKitCSSTransformValue. 310817 3 74229 apavlov 2010-11-18 06:05:59 -0800 Created attachment 74229 [PATCH] Suggested fix 310823 4 74229 antonm 2010-11-18 06:19:53 -0800 Comment on attachment 74229 [PATCH] Suggested fix LGTM, but I cannot r+ 310862 5 apavlov 2010-11-18 08:12:19 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/chromium/test_expectations.txt M WebCore/ChangeLog M WebCore/bindings/scripts/CodeGeneratorV8.pm Committed r72290 74229 2010-11-18 06:05:59 -0800 2010-11-18 06:20:58 -0800 [PATCH] Suggested fix binding.patch text/plain 3817 apavlov Y29tbWl0IGQ3NzgwNTJiYTMxMzRjNmJjMTZmYWU4YzRiZTIzNDNiNzIzMDg1NDAKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUaHUgTm92IDE4 IDE2OjQxOjUwIDIwMTAgKzAzMDAKCiAgICBmaXgKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWQ2OTMxZS4uMTFmODA4ZiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTExLTE4ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW3Y4XSBmYXN0L2Nzcy9nZXRGbG9hdFZhbHVlRm9yVW5pdC5odG1sIGZhaWxz IHNpbmNlIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzcyMTg5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTY1NgorCisgICAgICAgIFJl LWVuYWJsZSBmYXN0L2Nzcy9nZXRGbG9hdFZhbHVlRm9yVW5pdC5odG1sIG9uY2UgdGhlIGdlbmVy YXRlZCBXZWJDb3JlIGJpbmRpbmcgaXMgZml4ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAtMTEtMTggIEFudG9uIE11aGluICA8 YW50b25tQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQsIHJlYmFzZWxpbmlu ZyBmYXN0L2RvbS9zZXRQcmltaXRpdmVWYWx1ZS5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggMTdlNjI2ZS4uMGE4 NGI1ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dApAQCAtMzE5NiwxMCArMzE5Niw2IEBAIEJVR1dLNDk0NzcgV0lOIExJTlVY IDogZmFzdC9jYW52YXMvY2FudmFzLWFyYy0zNjAtd2luZGluZy5odG1sID0gVEVYVAogQlVHV0s0 OTY1MyBXSU4gTElOVVggTUFDIDogZmFzdC9kb20vc2V0UHJpbWl0aXZlVmFsdWUtZXhjZXB0aW9u cy5odG1sID0gVEVYVCBDUkFTSCBJTUFHRQogQlVHV0s0OTY1MyBXSU4gTElOVVggTUFDIDogZmFz dC9jc3MvbGluZS1oZWlnaHQtZGV0ZXJtaW5lZC1ieS1wcmltYXJ5LWZvbnQuaHRtbCA9IElNQUdF K1RFWFQgSU1BR0UKIAotLy8gUmVncmVzc2lvbiBhZnRlciBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC83MjE4OQotQlVHV0s0OTY1MyBXSU4gTElOVVggTUFDIDogZmFzdC9jc3MvZ2V0 RmxvYXRWYWx1ZUZvclVuaXQuaHRtbCA9IFRFWFQKLQotCiAvLyBEdWUgdG8gV2ViS2l0IHI3MjE0 MSAobmVlZHMgcmViYXNlbGluZSB1cHN0cmVhbT8pLgogQlVHX0xFVklOIDogZmFzdC9jb21wYWN0 LzAwMS5odG1sID0gSU1BR0UrVEVYVCBJTUFHRQogQlVHX0xFVklOIExJTlVYIFdJTiA6IGZhc3Qv cGFyc2VyL3N0eWxlLXNjcmlwdC1oZWFkLXRlc3QuaHRtbCA9IFRFWFQKZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTRkMjI3NC4uODQ2Njgy MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0xOCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFt2OF0gZmFzdC9jc3MvZ2V0RmxvYXRWYWx1ZUZvclVuaXQuaHRtbCBmYWlscyBzaW5j ZSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC83MjE4OQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk2NTYKKworICAgICAgICBFeHBsaWNp dGx5IHNwZWNpZnkgaW5kZXhlclR5cGUgZm9yIHRoZSBnZW5lcmF0aW9uIG9mIFY4V2ViS2l0Q1NT VHJhbnNmb3JtVmFsdWUgYmluZGluZy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvclY4LnBtOgorCiAyMDEwLTExLTE4ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNh bmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24u CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt IGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCAyNmMx ZGM3Li45ODVlY2QyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvclY4LnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KQEAgLTE1MzYsMTEgKzE1MzYsNiBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbklu ZGV4ZXIKICAgICBpZiAoJGludGVyZmFjZU5hbWUgZXEgIkhUTUxPcHRpb25zQ29sbGVjdGlvbiIp IHsKICAgICAgICAgJGhhc0dldHRlciA9IDE7CiAgICAgfQotICAgICMgRklYTUU6IElmIHRoZSBw YXJlbnQgaW50ZXJmYWNlIG9mICRkYXRhTm9kZSBhbHJlYWR5IGhhcwotICAgICMgSGFzSW5kZXhH ZXR0ZXIsIHdlIGRvbid0IG5lZWQgdG8gaGFuZGxlIHRoZSBnZXR0ZXIgaGVyZS4KLSAgICBpZiAo JGludGVyZmFjZU5hbWUgZXEgIldlYktpdENTU1RyYW5zZm9ybVZhbHVlIikgewotICAgICAgICAk aGFzR2V0dGVyID0gMDsKLSAgICB9CiAKICAgICAjIEZJWE1FOiBJbnZlc3RpZ2F0ZSBhbmQgcmVt b3ZlIHRoaXMgbmFzdGluZXNzcy4gSW4gVjgsIG5hbWVkIHByb3BlcnR5IGhhbmRsaW5nIGFuZCBp bmRleGVyIGhhbmRsaW5nIGFyZSBhcHBhcmVudGx5IGRlY291cGxlZCwKICAgICAjIHdoaWNoIG1l YW5zIHRoYXQgb2JqZWN0W1hdIHdoZXJlIFggaXMgYSBudW1iZXIgZG9lc24ndCByZWFjaCBuYW1l ZCBwcm9wZXJ0eSBpbmRleGVyLiBTbyB3ZSBuZWVkIHRvIHByb3ZpZGUKQEAgLTE1NjYsNiArMTU2 MSwxMyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbkluZGV4ZXIKICAgICAgICAgJGluZGV4 ZXJUeXBlID0gIldlYktpdENTU0tleWZyYW1lUnVsZSI7CiAgICAgfQogCisgICAgIyBGSVhNRTog VGhlIGl0ZW0oKSBnZXR0ZXIgaXMgbm90IGluaGVyaXRlZCBmcm9tIENTU1ZhbHVlTGlzdCwgc2Vl bWluZ2x5IGR1ZSB0byB0aGUgd2F5CisgICAgIyB0aGUgQ29kZUdlbmVyYXRvci0+QWRkTWV0aG9k c0NvbnN0YW50c0FuZEF0dHJpYnV0ZXNGcm9tUGFyZW50Q2xhc3NlcygpIG1ldGhvZCB3b3JrcywK KyAgICAjIHNvIHdlIG5lZWQgdG8gc2V0IHRoZSBpbmRleGVyVHlwZSBtYW51YWxseSBpbiB0aGlz IGNhc2UuCisgICAgaWYgKCRpbnRlcmZhY2VOYW1lIGVxICJXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1 ZSIpIHsKKyAgICAgICAgJGluZGV4ZXJUeXBlID0gIkNTU1ZhbHVlIjsKKyAgICB9CisKICAgICBp ZiAoJGluZGV4ZXJUeXBlICYmICEkaGFzQ3VzdG9tU2V0dGVyKSB7CiAgICAgICAgIGlmICgkaW5k ZXhlclR5cGUgZXEgIkRPTVN0cmluZyIpIHsKICAgICAgICAgICAgIG15ICRjb252ZXJzaW9uID0g JGluZGV4ZXItPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb252ZXJ0TnVsbFN0cmluZ1RvIn07Cg==