49637 2010-11-16 18:06:57 -0800 JSC::UString and WTF::String should use size_t instead of unsigned 2010-11-17 23:11:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All NEW InRadar P2 Normal --- 34952 1 ddkilzer webkit-unassigned barraclough cevans darin ggaren mjs oldest_to_newest 310070 0 ddkilzer 2010-11-16 18:06:57 -0800 JSC::UString and WTF::String should use size_t instead of unsigned since unsigned is only 4 bytes on 64-bit, but size_t is 8 bytes. 310071 1 ddkilzer 2010-11-16 18:07:21 -0800 <rdar://problem/5861044> 310074 2 darin 2010-11-16 18:11:09 -0800 I suspect this will make every string object a bit larger on 64-bit systems. Do the benefits outweigh that cost? 310720 3 cevans 2010-11-17 23:11:25 -0800 The current use of "unsigned" even on 64-bit seems very deliberate: StringImpl.cpp:COMPILE_ASSERT(sizeof(StringImpl) == 2 * sizeof(int) + 3 * sizeof(void*), StringImpl_should_stay_small); Given that we're careful to not truncate lengths, I see costs but not many benefits.