49623 2010-11-16 14:13:49 -0800 profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCRIPT_DEBUGGER 2010-11-17 09:56:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Linux RESOLVED FIXED P2 Normal --- 0 webkittenghui webkit-unassigned benm commit-queue jorlow steveblock ztenghui oldest_to_newest 309934 0 webkittenghui 2010-11-16 14:13:49 -0800 With changeset r71515, 2 functions profileCallback and profileEndCallback get added with guarded in the .idl file. But not the V8ConsoleCustom.cpp. This will cause android build break. I will have a patch shortly submit for review. 309964 1 74046 webkittenghui 2010-11-16 15:10:40 -0800 Created attachment 74046 proposed patch Just a compiling error fix. Thanks for reviewing. 310236 2 74046 jorlow 2010-11-17 06:27:10 -0800 Comment on attachment 74046 proposed patch r=me 310348 3 commit-queue 2010-11-17 09:54:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 74046: inspector/styles-iframe.html Please file bugs against the tests. These tests were authored by loislo@chromium.org, pfeldman@chromium.org, and yurys@chromium.org. The commit-queue is continuing to process your patch. 310349 4 74046 commit-queue 2010-11-17 09:56:52 -0800 Comment on attachment 74046 proposed patch Clearing flags on attachment: 74046 Committed r72216: <http://trac.webkit.org/changeset/72216> 310350 5 commit-queue 2010-11-17 09:56:58 -0800 All reviewed patches have been landed. Closing bug. 74046 2010-11-16 15:10:40 -0800 2010-11-17 09:56:52 -0800 proposed patch myCallbackPatch.txt text/plain 1432 webkittenghui SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjEzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTYgIFRlbmdodWkgWmh1ICA8enRlbmdodWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBw cm9maWxlQ2FsbGJhY2sgYW5kIHByb2ZpbGVFbmRDYWxsYmFjayAgc2hvdWxkIGJlIGd1YXJkZWQg d2l0aCBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk2MjMKKworICAgICAgICBObyBuZXcgdGVzdHMuIEp1 c3QgYSBjb21waWxpbmcgZXJyb3IgZml4LgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9t L1Y4Q29uc29sZUN1c3RvbS5jcHA6CisgICAgICAgICAgQWRkIHRoZSBndWFyZCBFTkFCTEVfSkFW QV9TQ1JJUFRfREVCVUdHRVIgdG8gcHJvZmlsZUNhbGxiYWNrIGFuZCBwcm9maWxlRW5kQ2FsbGJh Y2sKKwogMjAxMC0xMS0xNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4Q29uc29sZUN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhDb25zb2xlQ3VzdG9tLmNwcAkocmV2aXNpb24gNzIxMzQpCisrKyBXZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENvbnNvbGVDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC04Miw2ICs4Miw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOENvbnNvbGU6OmFzc2Vy dEMKICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7CiB9CiAKKyNpZiBFTkFCTEUo SkFWQVNDUklQVF9ERUJVR0dFUikKIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOENvbnNvbGU6OnBy b2ZpbGVDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogewogICAgIElOQ19TVEFU UygiRE9NLkNvbnNvbGUucHJvZmlsZSIpOwpAQCAtMTA1LDUgKzEwNiw2IEBAIHY4OjpIYW5kbGU8 djg6OlZhbHVlPiBWOENvbnNvbGU6OnByb2ZpbGUKICAgICBpbXAtPnByb2ZpbGVFbmQodGl0bGUs IFNjcmlwdFN0YXRlOjpjdXJyZW50KCksIGNhbGxTdGFjay5yZWxlYXNlKCkpOwogICAgIHJldHVy biB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKTsKIH0KKyNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCg==