49617 2010-11-16 13:16:32 -0800 [Chromium] Resize initiated by renderer. 2010-11-17 04:20:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 backer backer commit-queue kbr nduca webkit.review.bot oldest_to_newest 309898 0 backer 2010-11-16 13:16:32 -0800 [Chromium] Resize initiated by renderer. 309902 1 74033 backer 2010-11-16 13:21:11 -0800 Created attachment 74033 Patch 309903 2 webkit.review.bot 2010-11-16 13:23:55 -0800 Attachment 74033 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1 WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 309907 3 74034 backer 2010-11-16 13:27:56 -0800 Created attachment 74034 Patch 309909 4 74034 kbr 2010-11-16 13:32:25 -0800 Comment on attachment 74034 Patch Looks good assuming it's been tested on the other platforms. 309911 5 backer 2010-11-16 13:38:10 -0800 It doesn't change the path on OSX. I've tested it on Linux. Nat's tested it on Windows. For all platforms other than OSX, it currently terminates in a NOP in the gl_context level. Additional Chromium patches will add implementations for different platforms. Then we can ditch the NOP. 310206 6 74034 commit-queue 2010-11-17 04:20:10 -0800 Comment on attachment 74034 Patch Clearing flags on attachment: 74034 Committed r72192: <http://trac.webkit.org/changeset/72192> 310207 7 commit-queue 2010-11-17 04:20:16 -0800 All reviewed patches have been landed. Closing bug. 74033 2010-11-16 13:21:11 -0800 2010-11-16 13:27:51 -0800 Patch bug-49617-20101116162037.patch text/plain 1362 backer ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDM5NmU1ZjRkNTI1MzYwMDdhNTYyM2Y5OWMyNTcxNmFmMTg2MjJkNmYu LjJmMGFlOWY4M2I4N2I5NTY3ZGM3N2Y2MTg0MjA2ZDVlMjg3N2VkZjYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTExLTE2ICBKb25hdGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtDaHJvbWl1bV0gUmVzaXplIGluaXRpYXRlZCBieSByZW5kZXJlci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NjE3CisKKwlUbyBhZGRyZXNz IHN5bmNocm9uaXphdGlvbiBpc3N1ZXMgd2l0aCByZXNpemluZywgbWFrZSByZXNpemUgd29yayBs aWtlIERBUldJTi4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlZpZXdJbXBsOjpyZXNpemUpOgorCiAyMDEwLTExLTEyICBaaGVueWFvIE1vICA8 em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA3YmQ5NmQ0MTJmOWRkM2Y2MmE0NmNj ZDQ3M2M2MDU2NWM2ZGQ5NDE4Li5mZDYxZmEyNjBhZGI1OWI4NzdhZGRlNjJlZGJiYTQ2M2EyZGQz M2E4IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysg Yi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtOTM2LDcgKzkzNiw3IEBA IHZvaWQgV2ViVmlld0ltcGw6OnJlc2l6ZShjb25zdCBXZWJTaXplJiBuZXdTaXplKQogICAgICAg ICAgICAgbV9jbGllbnQtPmRpZEludmFsaWRhdGVSZWN0KGRhbWFnZWRSZWN0KTsKICAgICB9CiAK LSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYmIE9TKERBUldJTikKKyNpZiBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgaWYgKG1fbGF5ZXJSZW5kZXJlcikgewogICAg ICAgICBtX2xheWVyUmVuZGVyZXItPnJlc2l6ZU9uc2NyZWVuQ29udGVudChJbnRTaXplKHN0ZDo6 bWF4KDEsIG1fc2l6ZS53aWR0aCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc3RkOjptYXgoMSwgbV9zaXplLmhlaWdodCkpKTsK 74034 2010-11-16 13:27:56 -0800 2010-11-17 04:20:10 -0800 Patch bug-49617-20101116162722.patch text/plain 1369 backer ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDM5NmU1ZjRkNTI1MzYwMDdhNTYyM2Y5OWMyNTcxNmFmMTg2MjJkNmYu LmQ2YzZlYjdlYmVmZDFiYWI1ZDM5ZjZhMDAyYzUxYjJhMWM2Yzc2ZWEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTExLTE2ICBKb25hdGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtDaHJvbWl1bV0gUmVzaXplIGluaXRpYXRlZCBieSByZW5kZXJlci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NjE3CisKKyAgICAgICAgVG8g YWRkcmVzcyBzeW5jaHJvbml6YXRpb24gaXNzdWVzIHdpdGggcmVzaXppbmcsIG1ha2UgcmVzaXpl IHdvcmsgbGlrZSBEQVJXSU4uCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6cmVzaXplKToKKwogMjAxMC0xMS0xMiAgWmhlbnlh byBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVz c2VsbC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggN2JkOTZkNDEyZjlkZDNm NjJhNDZjY2Q0NzNjNjA1NjVjNmRkOTQxOC4uZmQ2MWZhMjYwYWRiNTliODc3YWRkZTYyZWRiYmE0 NjNhMmRkMzNhOCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTkzNiw3ICs5 MzYsNyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpyZXNpemUoY29uc3QgV2ViU2l6ZSYgbmV3U2l6ZSkK ICAgICAgICAgICAgIG1fY2xpZW50LT5kaWRJbnZhbGlkYXRlUmVjdChkYW1hZ2VkUmVjdCk7CiAg ICAgfQogCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKSAmJiBPUyhEQVJXSU4pCisj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChtX2xheWVyUmVuZGVyZXIp IHsKICAgICAgICAgbV9sYXllclJlbmRlcmVyLT5yZXNpemVPbnNjcmVlbkNvbnRlbnQoSW50U2l6 ZShzdGQ6Om1heCgxLCBtX3NpemUud2lkdGgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZDo6bWF4KDEsIG1fc2l6ZS5oZWlnaHQpKSk7 Cg==