4959 2005-09-12 16:37:51 -0700 inline style not terminated properly after <form> 2006-02-01 22:43:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED http://etuovi.com/ P2 Normal --- 1 koivisto timothy oldest_to_newest 19544 0 koivisto 2005-09-12 16:37:51 -0700 In http://etuovi.com/ the content of the box under headline "pikahaku" is missing. This is because in a following kind of construct <span style="display:none"><form></span>this stuff should be visible but is not the style specified in inline element does not terminate on close tag, but continues to be a applied to following elements Works on IE/Gecko 19545 1 3882 koivisto 2005-09-12 16:39:24 -0700 Created attachment 3882 test case 19547 2 3883 koivisto 2005-09-12 17:56:48 -0700 Created attachment 3883 add span as a residual style tag and form as an affected tag add <span> as residual style tag add <form> as tag affected by residual style Actually the second one is enough to fix the page refferred in the bug report (it uses <font>) but the first one is needed to fix the linked test case. The first one causes changes in the results of some regression tests (but those may be harmless as the cases are still visually correct): editing/deleting/delete-image-003 editing/undo/redo-typing-001 editing/undo/undo-typing-001 fast/block/float/031 21585 3 3883 darin 2005-10-08 11:13:36 -0700 Comment on attachment 3883 add span as a residual style tag and form as an affected tag I'm pretty sure this is not exactly right, because there are many other tags besides spans that can result in an inline element, for example any custom non-HTML tag will create an element with the same behavior as the one created by a span. But Dave Hyatt is the expert in this area, so waiting for input from him. 21653 4 koivisto 2005-10-09 20:07:08 -0700 Agreed, it is probably not right. However the whole mechanism of special casing some html tags for different treatment looks rather suspicious to me. At least based on this test case <span> and <b> shouln't be treated any differently, as they are now. 21659 5 3883 hyatt 2005-10-09 20:52:06 -0700 Comment on attachment 3883 add span as a residual style tag and form as an affected tag r=me, but performance tests will need to be run for this one, since it will probably result in the creation of more elements in our page load tests. 29509 6 darin 2006-01-22 18:55:28 -0800 I asked Tim to land a couple patches that have been here for a long time, and he agreed to do it. 30827 7 timothy 2006-01-31 17:17:32 -0800 Performance tests not affected. Landed in r12508. 31032 8 hyatt 2006-02-01 22:29:42 -0800 fast/block/float/031.html fails right now with actual visual differences in rendering. Given that this is one of the tests listed as being supposedly unaffected visually, I'm highly suspicious. :) 31033 9 hyatt 2006-02-01 22:33:21 -0800 Yes, <span> cannot be reopened due to residual style. I verified that this fix broke fast/block/float/031.html, and that the rendering of fast/block/float/031.html is correct without this fix. I am going to back out only the <span> portion of this bug fix, since as the reporter described, it was not needed for this bug anyway. (The snippet in fast/block/float/031.html with its crazy mismatched span/a nonsense came from a real-world Web site.) 31034 10 hyatt 2006-02-01 22:43:38 -0800 I backed out the <span> portion of this fix. 3882 2005-09-12 16:39:24 -0700 2005-09-12 16:39:24 -0700 test case etuovi.html text/html 72 koivisto PGh0bWw+Cjxib2R5Pgo8c3BhbiBzdHlsZT0iY29sb3I6cmVkIj48Zm9ybT48L3NwYW4+dGhpcyBz aG91bGQgYmUgYmxhY2sK 3883 2005-09-12 17:56:48 -0700 2005-10-09 20:52:06 -0700 add span as a residual style tag and form as an affected tag residual-style.patch text/plain 1153 koivisto SW5kZXg6IHNyYy9XZWJDb3JlL2todG1sL2h0bWwvaHRtbHBhcnNlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1scGFyc2VyLmNwcCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xMTEKZGlmZiAtcCAtdSAtcjEuMTExIHNyYy9XZWJDb3JlL2to dG1sL2h0bWwvaHRtbHBhcnNlci5jcHAKLS0tIHNyYy9XZWJDb3JlL2todG1sL2h0bWwvaHRtbHBh cnNlci5jcHAJMTAgU2VwIDIwMDUgMjE6MDM6NDQgLTAwMDAJMS4xMTEKKysrIHNyYy9XZWJDb3Jl L2todG1sL2h0bWwvaHRtbHBhcnNlci5jcHAJMTMgU2VwIDIwMDUgMDA6NDg6NDggLTAwMDAKQEAg LTkzMyw2ICs5MzMsNyBAQCBib29sIEhUTUxQYXJzZXI6OmlzUmVzaWR1YWxTdHlsZVRhZyhjb25z CiAgICAgICAgIHJlc2lkdWFsU3R5bGVUYWdzLmluc2VydCh2YXJUYWcubG9jYWxOYW1lKCkuaW1w bCgpKTsKICAgICAgICAgcmVzaWR1YWxTdHlsZVRhZ3MuaW5zZXJ0KG5vYnJUYWcubG9jYWxOYW1l KCkuaW1wbCgpKTsKICAgICAgICAgcmVzaWR1YWxTdHlsZVRhZ3MuaW5zZXJ0KHdiclRhZy5sb2Nh bE5hbWUoKS5pbXBsKCkpOworICAgICAgICByZXNpZHVhbFN0eWxlVGFncy5pbnNlcnQoc3BhblRh Zy5sb2NhbE5hbWUoKS5pbXBsKCkpOwogICAgIH0KICAgICAKICAgICByZXR1cm4gcmVzaWR1YWxT dHlsZVRhZ3MuY29udGFpbnModGFnTmFtZS5pbXBsKCkpOwpAQCAtOTYzLDYgKzk2NCw3IEBAIGJv b2wgSFRNTFBhcnNlcjo6aXNBZmZlY3RlZEJ5UmVzaWR1YWxTdHkKICAgICAgICAgYWZmZWN0ZWRC bG9ja1RhZ3MuaW5zZXJ0KGR0VGFnLmxvY2FsTmFtZSgpLmltcGwoKSk7CiAgICAgICAgIGFmZmVj dGVkQmxvY2tUYWdzLmluc2VydChkZFRhZy5sb2NhbE5hbWUoKS5pbXBsKCkpOwogICAgICAgICBh ZmZlY3RlZEJsb2NrVGFncy5pbnNlcnQocHJlVGFnLmxvY2FsTmFtZSgpLmltcGwoKSk7CisgICAg ICAgIGFmZmVjdGVkQmxvY2tUYWdzLmluc2VydChmb3JtVGFnLmxvY2FsTmFtZSgpLmltcGwoKSk7 CiAgICAgfQogICAgIAogICAgIHJldHVybiBhZmZlY3RlZEJsb2NrVGFncy5jb250YWlucyh0YWdO YW1lLmltcGwoKSk7Cg==