49587 2010-11-16 02:48:51 -0800 [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser 2010-11-16 05:23:54 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned oldest_to_newest 309645 0 kbalazs 2010-11-16 02:48:51 -0800 It is annoying that you need to change code to turn on tiled backing store to test it. Let's add API to do that and use it in the MiniBrowser to add a way to turn it on by a command line option. 309672 1 kbalazs 2010-11-16 04:31:53 -0800 I have changed my mind, there is no need to extra API to do this. 309675 2 73982 kbalazs 2010-11-16 04:50:19 -0800 Created attachment 73982 Patch 309680 3 73982 kling 2010-11-16 05:11:32 -0800 Comment on attachment 73982 Patch Whoa, this TODO just disappeared from my queue! <3 309683 4 73982 kbalazs 2010-11-16 05:23:46 -0800 Comment on attachment 73982 Patch Clearing flags on attachment: 73982 Committed r72089: <http://trac.webkit.org/changeset/72089> 309685 5 kbalazs 2010-11-16 05:23:54 -0800 All reviewed patches have been landed. Closing bug. 73982 2010-11-16 04:50:19 -0800 2010-11-16 05:23:46 -0800 Patch bug-49587-20101116135018.patch text/plain 6289 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMzE2NzE3ZGFmOWU5NDkzM2RmZDVhNzBiNDllNzlmZTI5ZGUyY2Y5Li4zZGZhZWVi MWVhZjRjYzQxMDliM2ViZWY3YzI5MmZiN2Y3MmUxNzgyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTAtMTEtMTYgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBBZGQg YSB3YXkgdG8gdHVybiBvbiB0aWxlZCBiYWNraW5nIHN0b3JlIGluIE1pbmlCcm93c2VyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU4NworCisgICAg ICAgICogTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuY3BwOgorICAgICAgICAoQnJvd3NlclZp ZXc6OkJyb3dzZXJWaWV3KTogQWRkZWQgQmFja2luZ1N0b3JlVHlwZQorICAgICAgICBhcmd1bWVu dCB0byBjdG9yLiBQcm9wYWdhdGluZyBpdCB0byB0aGUgUUdyYXBoaWNzV0tWaWV3LgorICAgICAg ICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3Lmg6CisgICAgICAgICogTWluaUJyb3dzZXIv cXQvQnJvd3NlcldpbmRvdy5jcHA6CisgICAgICAgIChCcm93c2VyV2luZG93OjpCcm93c2VyV2lu ZG93KToKKyAgICAgICAgKEJyb3dzZXJXaW5kb3c6Om5ld1dpbmRvdyk6IENyZWF0ZSB0aGUgbmV3 IEJyb3dzZXJXaW5kb3cKKyAgICAgICAgd2l0aCB0aGUgc2FtZSBCYWNraW5nU3RvcmVUeXBlIHRo YXQgdGhpcyBpbnN0YW5jZSBoYXMuCisgICAgICAgICogTWluaUJyb3dzZXIvcXQvQnJvd3Nlcldp bmRvdy5oOiBBZGRlZCBCYWNraW5nU3RvcmVUeXBlIG1lbWJlci4KKyAgICAgICAgKiBNaW5pQnJv d3Nlci9xdC9tYWluLmNwcDoKKyAgICAgICAgKG1haW4pOiBVc2UgdGlsZWQgYmFja2luZyBzdG9y ZSBpZiBnb3QgLXRpbGVkIGNvbW1hbmQgbGluZSBhcmd1bWVudC4KKyAgICAgICAgQXZvaWQgcmVk dW5kYW50IGNvcHkgb2YgY29tbWFuZCBsaW5lIGFyZ3MuCisKIDIwMTAtMTEtMTUgIEFuZHJhcyBC ZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMg S2xpbmcuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmll dy5jcHAgYi9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5jcHAKaW5kZXgg Y2UxMDFjMjRkMDEyMDNhY2Q1YzRlOTg4MjkzOTQxNzMwZGIyZDRhOC4uYzg4NWEzOWEwMzhjMzEy MzNiYjY2Yzg1MjVlNDQzZTY5MzBmYjFiMSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvTWluaUJy b3dzZXIvcXQvQnJvd3NlclZpZXcuY3BwCisrKyBiL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0 L0Jyb3dzZXJWaWV3LmNwcApAQCAtMzYsMTQgKzM2LDE0IEBAIHN0YXRpYyBRV0tQYWdlKiBjcmVh dGVOZXdQYWdlKFFXS1BhZ2UqIHBhZ2UpCiAgICAgcmV0dXJuIHBhZ2U7CiB9CiAKLUJyb3dzZXJW aWV3OjpCcm93c2VyVmlldyhRV2lkZ2V0KiBwYXJlbnQpCitCcm93c2VyVmlldzo6QnJvd3NlclZp ZXcoUUdyYXBoaWNzV0tWaWV3OjpCYWNraW5nU3RvcmVUeXBlIGJhY2tpbmdTdG9yZVR5cGUsIFFX aWRnZXQqIHBhcmVudCkKICAgICA6IFFHcmFwaGljc1ZpZXcocGFyZW50KQogICAgICwgbV9pdGVt KDApCiAgICAgLCBtX2NvbnRleHQoV0tDb250ZXh0R2V0U2hhcmVkUHJvY2Vzc0NvbnRleHQoKSkK IHsKICAgICBXS1JldGFpblB0cjxXS1BhZ2VOYW1lc3BhY2VSZWY+IHBhZ2VOYW1lc3BhY2UoQWRv cHRXSywgV0tQYWdlTmFtZXNwYWNlQ3JlYXRlKG1fY29udGV4dC5nZXQoKSkpOwogCi0gICAgbV9p dGVtID0gbmV3IFFHcmFwaGljc1dLVmlldyhwYWdlTmFtZXNwYWNlLmdldCgpLCBRR3JhcGhpY3NX S1ZpZXc6OlNpbXBsZSwgMCk7CisgICAgbV9pdGVtID0gbmV3IFFHcmFwaGljc1dLVmlldyhwYWdl TmFtZXNwYWNlLmdldCgpLCBiYWNraW5nU3RvcmVUeXBlLCAwKTsKICAgICBzZXRTY2VuZShuZXcg UUdyYXBoaWNzU2NlbmUodGhpcykpOwogICAgIHNjZW5lKCktPmFkZEl0ZW0obV9pdGVtKTsKIApk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuaCBiL1dl YktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmgKaW5kZXggNDJiNzY1OGY0ZWRk MTI0ZThmZjNmMmE2NTBkMTE3MTAwNjkzOGYyMC4uN2U4Mjg4ZTc2M2IxYjRiOTdlYWM2MWZlMGFm YmYxMzcyZDk1ODcxOCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJv d3NlclZpZXcuaAorKysgYi9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5o CkBAIC0zNyw3ICszNyw3IEBAIGNsYXNzIEJyb3dzZXJWaWV3IDogcHVibGljIFFHcmFwaGljc1Zp ZXcgewogICAgIFFfT0JKRUNUCiAKIHB1YmxpYzoKLSAgICBCcm93c2VyVmlldyhRV2lkZ2V0KiBw YXJlbnQgPSAwKTsKKyAgICBCcm93c2VyVmlldyhRR3JhcGhpY3NXS1ZpZXc6OkJhY2tpbmdTdG9y ZVR5cGUsIFFXaWRnZXQqIHBhcmVudCA9IDApOwogICAgIHZpcnR1YWwgfkJyb3dzZXJWaWV3KCkg eyBkZWxldGUgbV9pdGVtOyB9CiAKICAgICB2b2lkIGxvYWQoY29uc3QgUVN0cmluZyYpOwpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAgYi9X ZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcAppbmRleCA5ODVkODhi Nzg1M2VlZTExZjMyMWMwN2VjZDk0YmEwZDg2YzQyOGUyLi4xYWYxOGEzZTA2NWVjYTMwOGRiNzY2 YzFjMmIyMDc5MGRmNWI5N2VkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9x dC9Ccm93c2VyV2luZG93LmNwcAorKysgYi9XZWJLaXRUb29scy9NaW5pQnJvd3Nlci9xdC9Ccm93 c2VyV2luZG93LmNwcApAQCAtMzAsMTIgKzMwLDEzIEBACiAKICNpbmNsdWRlICJXS1BhZ2VOYW1l c3BhY2UuaCIKIAotQnJvd3NlcldpbmRvdzo6QnJvd3NlcldpbmRvdygpCitCcm93c2VyV2luZG93 OjpCcm93c2VyV2luZG93KFFHcmFwaGljc1dLVmlldzo6QmFja2luZ1N0b3JlVHlwZSB0eXBlKQor ICAgIDogbV9iYWNraW5nU3RvcmVUeXBlKHR5cGUpCiB7CiAgICAgc2V0QXR0cmlidXRlKFF0OjpX QV9EZWxldGVPbkNsb3NlKTsKIAogICAgIG1fbWVudSA9IG5ldyBRTWVudUJhcigpOwotICAgIG1f YnJvd3NlciA9IG5ldyBCcm93c2VyVmlldygpOworICAgIG1fYnJvd3NlciA9IG5ldyBCcm93c2Vy VmlldyhtX2JhY2tpbmdTdG9yZVR5cGUpOwogICAgIG1fYWRkcmVzc0JhciA9IG5ldyBRTGluZUVk aXQoKTsKIAogICAgIG1fbWVudS0+YWRkQWN0aW9uKCJOZXcgV2luZG93IiwgdGhpcywgU0xPVChu ZXdXaW5kb3coKSkpOwpAQCAtNzUsNyArNzYsNyBAQCB2b2lkIEJyb3dzZXJXaW5kb3c6OmxvYWQo Y29uc3QgUVN0cmluZyYgdXJsKQogCiBCcm93c2VyV2luZG93KiBCcm93c2VyV2luZG93OjpuZXdX aW5kb3coY29uc3QgUVN0cmluZyYgdXJsKQogewotICAgIEJyb3dzZXJXaW5kb3cqIHdpbmRvdyA9 IG5ldyBCcm93c2VyV2luZG93KCk7CisgICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gbmV3IEJy b3dzZXJXaW5kb3cobV9iYWNraW5nU3RvcmVUeXBlKTsKICAgICB3aW5kb3ctPmxvYWQodXJsKTsK ICAgICByZXR1cm4gd2luZG93OwogfQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvTWluaUJyb3dz ZXIvcXQvQnJvd3NlcldpbmRvdy5oIGIvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3Nl cldpbmRvdy5oCmluZGV4IDc5YmEyOTE2YmUwNDZmMmE3ZGQ0MTgyMjgxZDYzMjBkNGUzZTY3MDIu LmIxNzFhNTBhYTM0ZDdkYzJkYTk3ZThlYzdiOTM5MjBjNWQyN2VkZDAgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaAorKysgYi9XZWJLaXRUb29s cy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmgKQEAgLTMyLDEzICszMiwxNCBAQAogI2Rl ZmluZSBQTEFURk9STSh4KSAwCiAKICNpbmNsdWRlICJCcm93c2VyVmlldy5oIgorI2luY2x1ZGUg PHFncmFwaGljc3drdmlldy5oPgogI2luY2x1ZGUgPFF0R3VpPgogCiBjbGFzcyBCcm93c2VyV2lu ZG93IDogcHVibGljIFFNYWluV2luZG93IHsKICAgICBRX09CSkVDVAogCiBwdWJsaWM6Ci0gICAg QnJvd3NlcldpbmRvdygpOworICAgIEJyb3dzZXJXaW5kb3coUUdyYXBoaWNzV0tWaWV3OjpCYWNr aW5nU3RvcmVUeXBlKTsKICAgICB+QnJvd3NlcldpbmRvdygpOwogICAgIHZvaWQgbG9hZChjb25z dCBRU3RyaW5nJiB1cmwpOwogCkBAIC01Niw2ICs1Nyw3IEBAIHByaXZhdGU6CiAgICAgQnJvd3Nl clZpZXcqIG1fYnJvd3NlcjsKICAgICBRTWVudUJhciogbV9tZW51OwogICAgIFFMaW5lRWRpdCog bV9hZGRyZXNzQmFyOworICAgIFFHcmFwaGljc1dLVmlldzo6QmFja2luZ1N0b3JlVHlwZSBtX2Jh Y2tpbmdTdG9yZVR5cGU7CiB9OwogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL01p bmlCcm93c2VyL3F0L21haW4uY3BwIGIvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQvbWFpbi5j cHAKaW5kZXggOGZmM2RlOGI5NGVjNmEyOGQ3NmQ2MjViMDY0ZTMyZTFlNTk0NjE3Yy4uMjBmNGZm NTRmYWQyOTJiMGM4MzJmNjMwNGRkODI4ZGU4ZDI5MjRhOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvTWluaUJyb3dzZXIvcXQvbWFpbi5jcHAKKysrIGIvV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIv cXQvbWFpbi5jcHAKQEAgLTI3LDI4ICsyNywzNyBAQAogICovCiAKICNpbmNsdWRlICJCcm93c2Vy V2luZG93LmgiCisjaW5jbHVkZSA8UUxhdGluMVN0cmluZz4KKyNpbmNsdWRlIDxRUmVnRXhwPgor I2luY2x1ZGUgPHFncmFwaGljc3drdmlldy5oPgogI2luY2x1ZGUgPFF0R3VpPgogCiBpbnQgbWFp bihpbnQgYXJnYywgY2hhcioqIGFyZ3YpIHsKICAgICBRQXBwbGljYXRpb24gYXBwKGFyZ2MsIGFy Z3YpOwogCiAgICAgUVN0cmluZ0xpc3QgYXJncyA9IFFBcHBsaWNhdGlvbjo6YXJndW1lbnRzKCk7 Ci0gICAgUVN0cmluZ0xpc3QgdXJscyA9IGFyZ3M7Ci0gICAgdXJscy5yZW1vdmVBdCgwKTsKKyAg ICBhcmdzLnJlbW92ZUF0KDApOwogCi0gICAgaWYgKHVybHMuaXNFbXB0eSgpKSB7CisgICAgUUdy YXBoaWNzV0tWaWV3OjpCYWNraW5nU3RvcmVUeXBlIGJhY2tpbmdTdG9yZVR5cGVUb1VzZSA9IFFH cmFwaGljc1dLVmlldzo6U2ltcGxlOworICAgIGludCBpbmRleE9mVGlsZWRPcHRpb247CisgICAg aWYgKChpbmRleE9mVGlsZWRPcHRpb24gPSBhcmdzLmluZGV4T2YoUVJlZ0V4cChRTGF0aW4xU3Ry aW5nKCItdGlsZWQiKSkpKSAhPSAtMSkgeworICAgICAgICBiYWNraW5nU3RvcmVUeXBlVG9Vc2Ug PSBRR3JhcGhpY3NXS1ZpZXc6OlRpbGVkOworICAgICAgICBhcmdzLnJlbW92ZUF0KGluZGV4T2ZU aWxlZE9wdGlvbik7CisgICAgfQorCisgICAgaWYgKGFyZ3MuaXNFbXB0eSgpKSB7CiAgICAgICAg IFFTdHJpbmcgZGVmYXVsdFVybCA9IFFTdHJpbmcoImZpbGU6Ly8lMS8lMiIpLmFyZyhRRGlyOjpo b21lUGF0aCgpKS5hcmcoUUxhdGluMVN0cmluZygiaW5kZXguaHRtbCIpKTsKICAgICAgICAgaWYg KFFEaXIoZGVmYXVsdFVybCkuZXhpc3RzKCkpCi0gICAgICAgICAgICB1cmxzLmFwcGVuZChkZWZh dWx0VXJsKTsKKyAgICAgICAgICAgIGFyZ3MuYXBwZW5kKGRlZmF1bHRVcmwpOwogICAgICAgICBl bHNlCi0gICAgICAgICAgICB1cmxzLmFwcGVuZCgiaHR0cDovL3d3dy5nb29nbGUuY29tIik7Cisg ICAgICAgICAgICBhcmdzLmFwcGVuZCgiaHR0cDovL3d3dy5nb29nbGUuY29tIik7CiAgICAgfQog Ci0gICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gbmV3IEJyb3dzZXJXaW5kb3coKTsKLSAgICB3 aW5kb3ctPmxvYWQodXJsc1swXSk7CisgICAgQnJvd3NlcldpbmRvdyogd2luZG93ID0gbmV3IEJy b3dzZXJXaW5kb3coYmFja2luZ1N0b3JlVHlwZVRvVXNlKTsKKyAgICB3aW5kb3ctPmxvYWQoYXJn c1swXSk7CiAKLSAgICBmb3IgKGludCBpID0gMTsgaSA8IHVybHMuc2l6ZSgpOyArK2kpCi0gICAg ICAgIHdpbmRvdy0+bmV3V2luZG93KHVybHNbaV0pOworICAgIGZvciAoaW50IGkgPSAxOyBpIDwg YXJncy5zaXplKCk7ICsraSkKKyAgICAgICAgd2luZG93LT5uZXdXaW5kb3coYXJnc1tpXSk7CiAK ICAgICBhcHAuZXhlYygpOwogCg==