49585 2010-11-16 02:40:00 -0800 [gtk] r69119 modified just the gtk2 version of the scrolled_window_paint function but not the gtk3 version 2010-11-17 04:29:40 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned mrobinson oldest_to_newest 309643 0 alex 2010-11-16 02:40:00 -0800 Apparently the patch in r69119 did not included the fixes for the gtk3 version of the moz_gtk_scrolled_window_paint, they are causing problems because we are using uninitialized variables and rendering with the wrong function. 309651 1 73975 alex 2010-11-16 03:06:17 -0800 Created attachment 73975 Proposed patch 310209 2 alex 2010-11-17 04:29:40 -0800 Landed http://trac.webkit.org/changeset/72191 73975 2010-11-16 03:06:17 -0800 2010-11-16 08:17:06 -0800 Proposed patch scroll_view.patch text/plain 2712 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWM3NDkyNi4uMjRkZjVlNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMS0xNiAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbZ3RrXSByNjkxMTkgbW9kaWZpZWQganVzdCB0aGUgZ3RrMiB2 ZXJzaW9uIG9mIHRoZQorICAgICAgICBzY3JvbGxlZF93aW5kb3dfcGFpbnQgZnVuY3Rpb24gYnV0 IG5vdCB0aGUgZ3RrMyB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00OTU4NQorCisgICAgICAgIFVzZSBndGtfcGFpbnRfc2hhZG93IHRoZSBz YW1lIGFzIHRoZSBhY3R1YWwgY29kZSBmcm9tIEdUSysuIEF2b2lkCisgICAgICAgIHVzaW5nIHN0 YXRlIGFuZCB1c2UgdGhlIHNhbWUgdmFsdWVzIHdlIGFyZSB1c2luZyBmb3IgZ3RrMiBpbiB0aGUK KyAgICAgICAgcGFpbnQgZnVuY3Rpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2Nyb2xs YmFyVGhlbWVHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVHdGs6OnBh aW50QnV0dG9uKTogSW5pdGlhbGl6ZWQgdGhlCisgICAgICAgIGRlcHJlc3NlZCBhdHRyaWJ1dGUg b2YgdGhlIHN0YXRlIHZhcmlhYmxlIHRvIGF2b2lkIHVzaW5nIGl0CisgICAgICAgIHdpdGhvdXQg aW5pdGlhbGl6YXRpb24uCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2d0azNkcmF3aW5nLmM6Cisg ICAgICAgIChtb3pfZ3RrX3Njcm9sbGVkX3dpbmRvd19wYWludCk6CisKIDIwMTAtMTEtMTYgIE1p aGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh clRoZW1lR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNw cAppbmRleCBmOTJkZDIwLi4xMGY3ZTcxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xs YmFyVGhlbWVHdGsuY3BwCkBAIC0zNDEsNiArMzQxLDcgQEAgdm9pZCBTY3JvbGxiYXJUaGVtZUd0 azo6cGFpbnRCdXR0b24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBTY3JvbGxiYXIqIHNjcm9s bGIKICAgICBzdGF0ZS5mb2N1c2VkID0gVFJVRTsKICAgICBzdGF0ZS5pc0RlZmF1bHQgPSBUUlVF OwogICAgIHN0YXRlLmNhbkRlZmF1bHQgPSBUUlVFOworICAgIHN0YXRlLmRlcHJlc3NlZCA9IEZB TFNFOwogCiAgICAgaWYgKChCYWNrQnV0dG9uU3RhcnRQYXJ0ID09IHBhcnQgJiYgc2Nyb2xsYmFy LT5jdXJyZW50UG9zKCkpCiAgICAgICAgIHx8IChCYWNrQnV0dG9uRW5kUGFydCA9PSBwYXJ0ICYm IHNjcm9sbGJhci0+Y3VycmVudFBvcygpKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvZ3RrM2RyYXdpbmcuYyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0azNkcmF3aW5nLmMKaW5k ZXggZGRhMTEwZC4uODgwZWI2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvZ3Rr M2RyYXdpbmcuYworKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGszZHJhd2luZy5jCkBAIC02 NDIsOCArNjQyLDYgQEAgc3RhdGljIGdpbnQKIG1vel9ndGtfc2Nyb2xsZWRfd2luZG93X3BhaW50 KGNhaXJvX3QqIGNyLCBHZGtSZWN0YW5nbGUqIHJlY3QsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBHdGtXaWRnZXRTdGF0ZSogc3RhdGUpCiB7Ci0gICAgR3RrU3RhdGVUeXBlIHN0YXRl X3R5cGUgPSBDb252ZXJ0R3RrU3RhdGUoc3RhdGUpOwotICAgIEd0a1NoYWRvd1R5cGUgc2hhZG93 X3R5cGUgPSAoc3RhdGUtPmFjdGl2ZSkgPyAgR1RLX1NIQURPV19JTiA6IEdUS19TSEFET1dfT1VU OwogICAgIEd0a1N0eWxlKiBzdHlsZTsKICAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb247CiAg ICAgR3RrV2lkZ2V0KiB3aWRnZXQ7CkBAIC02NTksOSArNjU3LDkgQEAgbW96X2d0a19zY3JvbGxl ZF93aW5kb3dfcGFpbnQoY2Fpcm9fdCogY3IsIEdka1JlY3RhbmdsZSogcmVjdCwKICAgICBndGtf d2lkZ2V0X3NldF9hbGxvY2F0aW9uKHdpZGdldCwgJmFsbG9jYXRpb24pOwogCiAgICAgc3R5bGUg PSBndGtfd2lkZ2V0X2dldF9zdHlsZSh3aWRnZXQpOwotICAgIGd0a19wYWludF9ib3goc3R5bGUs IGNyLCBzdGF0ZV90eXBlLCBzaGFkb3dfdHlwZSwKLSAgICAgICAgICAgICAgICAgIHdpZGdldCwg InNjcm9sbGVkX3dpbmRvdyIsIHJlY3QtPnggLSAxLCByZWN0LT55IC0gMSwKLSAgICAgICAgICAg ICAgICAgIHJlY3QtPndpZHRoICsgMiwgcmVjdC0+aGVpZ2h0ICsgMik7CisgICAgZ3RrX3BhaW50 X3NoYWRvdyhzdHlsZSwgY3IsIEdUS19TVEFURV9OT1JNQUwsIEdUS19TSEFET1dfSU4sCisgICAg ICAgICAgICAgICAgICAgICB3aWRnZXQsICJzY3JvbGxlZF93aW5kb3ciLCByZWN0LT54ICwgcmVj dC0+eSwKKyAgICAgICAgICAgICAgICAgICAgIHJlY3QtPndpZHRoLCByZWN0LT5oZWlnaHQpOwog ICAgIHJldHVybiBNT1pfR1RLX1NVQ0NFU1M7CiB9CiAK