49576 2010-11-15 20:42:12 -0800 jsc does not ignore shebang 2025-09-27 17:06:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Trivial --- 0 john.tantalo webkit-unassigned commit-queue splash_library_8y oldest_to_newest 309559 0 73956 john.tantalo 2010-11-15 20:42:12 -0800 Created attachment 73956 JavaScript source with shebang. Various other JavaScript engines [1] correctly ignore a shebang [2] as the first line of a file. Invoking jsc with a source file that contains a shebang generates a lex error. It should instead ignore the shebang. [1] nodejs, narwhal, ringo [2] http://en.wikipedia.org/wiki/Shebang_(Unix) 309564 1 73957 john.tantalo 2010-11-15 20:55:41 -0800 Created attachment 73957 svn diff JavaScriptCore/parser/Lexer.cpp I added a new character type for a hash, i.e., #, ASCII 35. When this character was previously encountered, it would have immediately triggered a lexical error. My change is to first check if this character is at the start of the line. If not, it is an error. Next, I check if the next character is a bang, i.e,. !, ASCII 33. If it is, then the rest of the line is treated as a comment. If not, then it is an error. Since the hash character was previously illegal, the only potential danger of this patch is that source which previously failed to lex may now be executed This patch does not enforce that the shebang occurs on the first line of the source. Any occurrence of a hash other than the first character of the source should be illegal. I don't know how to do this, so I will submit my current patch as a viable solution to the bug. 309579 2 73960 john.tantalo 2010-11-15 21:49:31 -0800 Created attachment 73960 proposed patch Replaced diff with a real patch, with a test, changelog, and correct style. 309824 3 73960 ggaren 2010-11-16 10:58:58 -0800 Comment on attachment 73960 proposed patch I think you've made this change at the wrong level of abstraction. Accounting for shebang in the lexer applies this Unix-only rule to all web pages and operating systems. I think a better fix would be for the jsc tool itself to strip out shebang before evaluating a source file. 309837 4 74017 john.tantalo 2010-11-16 11:18:27 -0800 Created attachment 74017 proposed patch This patch modifies jsc's file load function to detect a shebang in the first two characters of the file buffer. If it finds a shebang, it replaces it with "//", which causes the rest of the line to be interpreted as a JavaScript comment. 314536 5 74017 ggaren 2010-11-29 11:40:03 -0800 Comment on attachment 74017 proposed patch r=me 317712 6 74017 commit-queue 2010-12-06 10:47:50 -0800 Comment on attachment 74017 proposed patch Clearing flags on attachment: 74017 Committed r73377: <http://trac.webkit.org/changeset/73377> 317713 7 commit-queue 2010-12-06 10:47:56 -0800 All reviewed patches have been landed. Closing bug. 2146527 8 splash_library_8y 2025-09-27 17:06:08 -0700 When a script is run with jsc in the shebang it can't receive arguments due to jsc needing '--' before arguments and the file is passed at the end of the command when running a file with a shebang. You can technically just put -- before the arguments but it would make more sense to be able to run without that. A new flag to simply read the first thing after it as the file and everything else after the file as arguments might be sufficient as a solution. 73956 2010-11-15 20:42:12 -0800 2010-11-15 20:42:12 -0800 JavaScript source with shebang. test.js text/javascript 32 john.tantalo IyEgL3Vzci9sb2NhbC9iaW4vanNjCnByaW50KDEpOwo= 73957 2010-11-15 20:55:41 -0800 2010-11-15 21:49:31 -0800 svn diff JavaScriptCore/parser/Lexer.cpp Lexer.cpp.diff text/plain 1625 john.tantalo SW5kZXg6IEphdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAkocmV2aXNpb24gNzIwNDQpCisrKyBKYXZhU2Ny aXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zLDYgKzMsNyBAQAog ICogIENvcHlyaWdodCAoQykgMjAwNiwgMjAwNywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCBS aWdodHMgUmVzZXJ2ZWQuCiAgKiAgQ29weXJpZ2h0IChDKSAyMDA3IENhbWVyb24gWndhcmljaCAo Y3d6d2FyaWNoQHV3YXRlcmxvby5jYSkKICAqICBDb3B5cmlnaHQgKEMpIDIwMTAgWm9sdGFuIEhl cmN6ZWcgKHpoZXJjemVnQGluZi51LXN6ZWdlZC5odSkKKyAqICBDb3B5cmlnaHQgKEMpIDIwMTAg Sm9obiBUYW50YWxvIChqb2huLnRhbnRhbG9AZ21haWwuY29tKQogICoKICAqICBUaGlzIGxpYnJh cnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAg bW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJs aWMKQEAgLTY3LDYgKzY4LDcgQEAKICAgICBDaGFyYWN0ZXJRdWVzdGlvbiwKICAgICBDaGFyYWN0 ZXJUaWxkZSwKICAgICBDaGFyYWN0ZXJRdW90ZSwKKyAgICBDaGFyYWN0ZXJIYXNoLAogICAgIENo YXJhY3RlckRvdCwKICAgICBDaGFyYWN0ZXJTbGFzaCwKICAgICBDaGFyYWN0ZXJCYWNrU2xhc2gs CkBAIC0xMjYsNyArMTI4LDcgQEAKIC8qICAzMiAtIFNwYWNlICAgICAgICAgICAgICAqLyBDaGFy YWN0ZXJXaGl0ZVNwYWNlLAogLyogIDMzIC0gISAgICAgICAgICAgICAgICAgICovIENoYXJhY3Rl ckV4Y2xhbWF0aW9uTWFyaywKIC8qICAzNCAtICIgICAgICAgICAgICAgICAgICAqLyBDaGFyYWN0 ZXJRdW90ZSwKLS8qICAzNSAtICMgICAgICAgICAgICAgICAgICAqLyBDaGFyYWN0ZXJJbnZhbGlk LAorLyogIDM1IC0gIyAgICAgICAgICAgICAgICAgICovIENoYXJhY3Rlckhhc2gsCiAvKiAgMzYg LSAkICAgICAgICAgICAgICAgICAgKi8gQ2hhcmFjdGVySWRlbnRpZmllclN0YXJ0LAogLyogIDM3 IC0gJSAgICAgICAgICAgICAgICAgICovIENoYXJhY3Rlck1vZHVsbywKIC8qICAzOCAtICYgICAg ICAgICAgICAgICAgICAqLyBDaGFyYWN0ZXJBbmQsCkBAIC0xMDI5LDYgKzEwMzEsMTYgQEAKICAg ICAgICAgbV9hdExpbmVTdGFydCA9IHRydWU7CiAgICAgICAgIG1fdGVybWluYXRvciA9IHRydWU7 CiAgICAgICAgIGdvdG8gc3RhcnQ7CisgICAgY2FzZSBDaGFyYWN0ZXJIYXNoOgorICAgICAgaWYg KCFtX2F0TGluZVN0YXJ0KSB7CisgICAgICAgIGdvdG8gcmV0dXJuRXJyb3I7CisgICAgICB9Cisg ICAgICBzaGlmdCgpOworICAgICAgaWYgKG1fY3VycmVudCA9PSAnIScpIHsKKyAgICAgICAgc2hp ZnQoKTsKKyAgICAgICAgZ290byBpblNpbmdsZUxpbmVDb21tZW50OworICAgICAgfQorCSAgICBn b3RvIHJldHVybkVycm9yOwogICAgIGNhc2UgQ2hhcmFjdGVySW52YWxpZDoKICAgICAgICAgZ290 byByZXR1cm5FcnJvcjsKICAgICBkZWZhdWx0Ogo= 73960 2010-11-15 21:49:31 -0800 2010-11-16 11:18:27 -0800 proposed patch patch.txt text/plain 2745 john.tantalo SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcyMDYyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTUgIEpvaG4gVGFu dGFsbyAgPGpvaG4udGFudGFsb0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAganNjIGRvZXMgbm90IGlnbm9yZSBzaGViYW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU3NgorCisgICAg ICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuanM6CisgICAgICAgICogcGFyc2VyL0xleGVyLmNwcDoK KyAgICAgICAgKEpTQzo6TGV4ZXI6OmxleCk6CisKIDIwMTAtMTEtMTUgIEdhdmluIEJhcnJhY2xv dWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2Zm IEdhcmVuLgpJbmRleDogSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuanMJKHJldmlzaW9uIDcy MDQ0KQorKysgSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuanMJKHdvcmtpbmcgY29w eSkKQEAgLTI0Niw2ICsyNDYsOCBAQCBzaG91bGRUaHJvdygiU3RyaW5nKEV2aWxFeGNlcHRpb25P YmplY3QpCiAKIHNob3VsZEJlKCJFbXB0eU9iamVjdCIsICJbb2JqZWN0IENhbGxiYWNrT2JqZWN0 XSIpOwogCitzaG91bGRCZSgiIyEvdXNyL2Jpbi9qc2NcbidzaGViYW5nJzsiLCAic2hlYmFuZyIp CisKIGlmIChmYWlsZWQpCiAgICAgdGhyb3cgIlNvbWUgdGVzdHMgZmFpbGVkIjsKIApJbmRleDog SmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCShyZXZpc2lvbiA3MjA0NCkKKysrIEphdmFTY3JpcHRDb3Jl L3BhcnNlci9MZXhlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMsNiArMyw3IEBACiAgKiAgQ29w eXJpZ2h0IChDKSAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIFJpZ2h0cyBS ZXNlcnZlZC4KICAqICBDb3B5cmlnaHQgKEMpIDIwMDcgQ2FtZXJvbiBad2FyaWNoIChjd3p3YXJp Y2hAdXdhdGVybG9vLmNhKQogICogIENvcHlyaWdodCAoQykgMjAxMCBab2x0YW4gSGVyY3plZyAo emhlcmN6ZWdAaW5mLnUtc3plZ2VkLmh1KQorICogIENvcHlyaWdodCAoQykgMjAxMCBKb2huIFRh bnRhbG8gKGpvaG4udGFudGFsb0BnbWFpbC5jb20pCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkg aXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAt NjcsNiArNjgsNyBAQCBlbnVtIENoYXJhY3RlclR5cGUgewogICAgIENoYXJhY3RlclF1ZXN0aW9u LAogICAgIENoYXJhY3RlclRpbGRlLAogICAgIENoYXJhY3RlclF1b3RlLAorICAgIENoYXJhY3Rl ckhhc2gsCiAgICAgQ2hhcmFjdGVyRG90LAogICAgIENoYXJhY3RlclNsYXNoLAogICAgIENoYXJh Y3RlckJhY2tTbGFzaCwKQEAgLTEyNiw3ICsxMjgsNyBAQCBzdGF0aWMgY29uc3QgdW5zaWduZWQg c2hvcnQgdHlwZXNPZkFTQ0lJCiAvKiAgMzIgLSBTcGFjZSAgICAgICAgICAgICAgKi8gQ2hhcmFj dGVyV2hpdGVTcGFjZSwKIC8qICAzMyAtICEgICAgICAgICAgICAgICAgICAqLyBDaGFyYWN0ZXJF eGNsYW1hdGlvbk1hcmssCiAvKiAgMzQgLSAiICAgICAgICAgICAgICAgICAgKi8gQ2hhcmFjdGVy UXVvdGUsCi0vKiAgMzUgLSAjICAgICAgICAgICAgICAgICAgKi8gQ2hhcmFjdGVySW52YWxpZCwK Ky8qICAzNSAtICMgICAgICAgICAgICAgICAgICAqLyBDaGFyYWN0ZXJIYXNoLAogLyogIDM2IC0g JCAgICAgICAgICAgICAgICAgICovIENoYXJhY3RlcklkZW50aWZpZXJTdGFydCwKIC8qICAzNyAt ICUgICAgICAgICAgICAgICAgICAqLyBDaGFyYWN0ZXJNb2R1bG8sCiAvKiAgMzggLSAmICAgICAg ICAgICAgICAgICAgKi8gQ2hhcmFjdGVyQW5kLApAQCAtMTAyOSw2ICsxMDMxLDE1IEBAIGluTnVt YmVyQWZ0ZXJEZWNpbWFsUG9pbnQ6CiAgICAgICAgIG1fYXRMaW5lU3RhcnQgPSB0cnVlOwogICAg ICAgICBtX3Rlcm1pbmF0b3IgPSB0cnVlOwogICAgICAgICBnb3RvIHN0YXJ0OworICAgIGNhc2Ug Q2hhcmFjdGVySGFzaDoKKyAgICAgICAgaWYgKCFtX2F0TGluZVN0YXJ0KQorICAgICAgICAgICAg Z290byByZXR1cm5FcnJvcjsKKyAgICAgICAgc2hpZnQoKTsKKyAgICAgICAgaWYgKG1fY3VycmVu dCA9PSAnIScpIHsKKyAgICAgICAgICAgIHNoaWZ0KCk7CisgICAgICAgICAgICBnb3RvIGluU2lu Z2xlTGluZUNvbW1lbnQ7CisgICAgICAgIH0KKyAgICAgICAgZ290byByZXR1cm5FcnJvcjsKICAg ICBjYXNlIENoYXJhY3RlckludmFsaWQ6CiAgICAgICAgIGdvdG8gcmV0dXJuRXJyb3I7CiAgICAg ZGVmYXVsdDoK 74017 2010-11-16 11:18:27 -0800 2010-12-06 10:47:49 -0800 proposed patch patch.txt text/plain 1026 john.tantalo SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcyMTIyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTYgIEpvaG4gVGFu dGFsbyAgPGpvaG4udGFudGFsb0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAganNjIGRvZXMgbm90IGlnbm9yZSBzaGViYW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU3NgorCisgICAg ICAgICoganNjLmNwcDoKKyAgICAgICAgKGZpbGxCdWZmZXJXaXRoQ29udGVudHNPZkZpbGUpOgor ICAgICAgICAgIC0gdHJhbnNsYXRlIHNoZWJhbmcgaW50byBhIHZhbGlkIEphdmFTY3JpcHQgY29t bWVudCBzbyB0aGUgbGV4ZXIgaWdub3JlcyBpdAorCiAyMDEwLTExLTE1ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRl eDogSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9q c2MuY3BwCShyZXZpc2lvbiA3MjA0NCkKKysrIEphdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTU1Niw1ICs1NTYsOCBAQCBzdGF0aWMgYm9vbCBmaWxsQnVmZmVyV2l0aENv bnRlbnRzT2ZGaWxlCiAgICAgZmNsb3NlKGYpOwogICAgIGJ1ZmZlcltidWZmZXJTaXplXSA9ICdc MCc7CiAKKyAgICBpZiAoYnVmZmVyWzBdID09ICcjJyAmJiBidWZmZXJbMV0gPT0gJyEnKQorICAg ICAgICBidWZmZXJbMF0gPSBidWZmZXJbMV0gPSAnLyc7CisKICAgICByZXR1cm4gdHJ1ZTsKIH0K