49568 2010-11-15 15:25:16 -0800 [Qt] ZoomTextOnly doesn't work 2010-11-17 06:29:27 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 max.hong.shen max.hong.shen abarth commit-queue eric kling ossy webkit.review.bot oldest_to_newest 309471 0 max.hong.shen 2010-11-15 15:25:16 -0800 User can set ZoomTextOnly in the QWebSetting, however, qwebframe doesn't check the ZoomTextOnly attribute when applying the zoom... 309477 1 73938 max.hong.shen 2010-11-15 15:35:41 -0800 Created attachment 73938 first try 309481 2 73938 kling 2010-11-15 15:45:48 -0800 Comment on attachment 73938 first try Nice catch! r=me 309490 3 max.hong.shen 2010-11-15 15:56:39 -0800 (In reply to comment #2) > (From update of attachment 73938 [details]) > Nice catch! r=me Thanks for quick review, kling :) 309554 4 73938 commit-queue 2010-11-15 20:14:01 -0800 Comment on attachment 73938 first try Clearing flags on attachment: 73938 Committed r72055: <http://trac.webkit.org/changeset/72055> 309555 5 commit-queue 2010-11-15 20:14:07 -0800 All reviewed patches have been landed. Closing bug. 309569 6 webkit.review.bot 2010-11-15 21:13:09 -0800 http://trac.webkit.org/changeset/72055 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/block/float/015.html 309641 7 ossy 2010-11-16 02:35:29 -0800 And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ... Guys, could you watch the bots next time after commit? 309676 8 max.hong.shen 2010-11-16 04:52:45 -0800 (In reply to comment #7) > And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ... > Guys, could you watch the bots next time after commit? oops, Sorry, I will look at the tests failed issue ASAP. 309700 9 max.hong.shen 2010-11-16 06:17:32 -0800 (In reply to comment #7) > And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ... > Guys, could you watch the bots next time after commit? Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch. 309707 10 ossy 2010-11-16 06:30:20 -0800 (In reply to comment #9) > Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch. I meant minor pixel differences caused by your patch and not this flakey test. 309933 11 max.hong.shen 2010-11-16 14:13:36 -0800 (In reply to comment #10) > (In reply to comment #9) > > Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch. > > I meant minor pixel differences caused by your patch and not this flakey test. I rolled back my changes but still see this test failed... hmmm, need take more time to look at it. 310241 12 max.hong.shen 2010-11-17 06:29:27 -0800 The test failure is introduced by r72040 and fixed in <http://trac.webkit.org/changeset/72135> 73938 2010-11-15 15:35:41 -0800 2010-11-15 20:14:01 -0800 first try 49568.patch text/plain 2615 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzIwNDMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMTUgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gWm9vbVRleHRPbmx5IGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk1NjgKKworICAgICAgICBDaGVjayBRV2ViU2V0dGlu Z3M6Olpvb21UZXh0T25seSBhdHRyaWJ1dGUgYmVmb3JlIGFwcGx5aW5nIHpvb20KKworICAgICAg ICAqIEFwaS9xd2ViZnJhbWUuY3BwOgorICAgICAgICAoUVdlYkZyYW1lOjp0ZXh0U2l6ZU11bHRp cGxpZXIpOgorICAgICAgICAoUVdlYkZyYW1lOjpzZXRab29tRmFjdG9yKToKKyAgICAgICAgKFFX ZWJGcmFtZTo6em9vbUZhY3Rvcik6CisgICAgICAgICogQXBpL3F3ZWJmcmFtZV9wLmg6CisgICAg ICAgIChRV2ViRnJhbWVQcml2YXRlOjpRV2ViRnJhbWVQcml2YXRlKToKKwogMjAxMC0xMS0xNCAg QW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW50b25pbyBHb21lcy4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAJKHJldmlzaW9uIDcyMDMwKQorKysg V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTg5LDcgKzEx ODksNyBAQCB2b2lkIFFXZWJGcmFtZTo6c2V0VGV4dFNpemVNdWx0aXBsaWVyKHFyCiAqLwogcXJl YWwgUVdlYkZyYW1lOjp0ZXh0U2l6ZU11bHRpcGxpZXIoKSBjb25zdAogewotICAgIHJldHVybiBk LT56b29tVGV4dE9ubHkgPyBkLT5mcmFtZS0+dGV4dFpvb21GYWN0b3IoKSA6IGQtPmZyYW1lLT5w YWdlWm9vbUZhY3RvcigpOworICAgIHJldHVybiBwYWdlKCktPnNldHRpbmdzKCktPnRlc3RBdHRy aWJ1dGUoUVdlYlNldHRpbmdzOjpab29tVGV4dE9ubHkpID8gZC0+ZnJhbWUtPnRleHRab29tRmFj dG9yKCkgOiBkLT5mcmFtZS0+cGFnZVpvb21GYWN0b3IoKTsKIH0KIAogLyohCkBAIC0xMjAwLDcg KzEyMDAsNyBAQCBxcmVhbCBRV2ViRnJhbWU6OnRleHRTaXplTXVsdGlwbGllcigpIGNvCiAKIHZv aWQgUVdlYkZyYW1lOjpzZXRab29tRmFjdG9yKHFyZWFsIGZhY3RvcikKIHsKLSAgICBpZiAoZC0+ em9vbVRleHRPbmx5KQorICAgIGlmIChwYWdlKCktPnNldHRpbmdzKCktPnRlc3RBdHRyaWJ1dGUo UVdlYlNldHRpbmdzOjpab29tVGV4dE9ubHkpKQogICAgICAgICBkLT5mcmFtZS0+c2V0VGV4dFpv b21GYWN0b3IoZmFjdG9yKTsKICAgICBlbHNlCiAgICAgICAgIGQtPmZyYW1lLT5zZXRQYWdlWm9v bUZhY3RvcihmYWN0b3IpOwpAQCAtMTIwOCw3ICsxMjA4LDcgQEAgdm9pZCBRV2ViRnJhbWU6OnNl dFpvb21GYWN0b3IocXJlYWwgZmFjdAogCiBxcmVhbCBRV2ViRnJhbWU6Onpvb21GYWN0b3IoKSBj b25zdAogewotICAgIHJldHVybiBkLT56b29tVGV4dE9ubHkgPyBkLT5mcmFtZS0+dGV4dFpvb21G YWN0b3IoKSA6IGQtPmZyYW1lLT5wYWdlWm9vbUZhY3RvcigpOworICAgIHJldHVybiBwYWdlKCkt PnNldHRpbmdzKCktPnRlc3RBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpab29tVGV4dE9ubHkpID8g ZC0+ZnJhbWUtPnRleHRab29tRmFjdG9yKCkgOiBkLT5mcmFtZS0+cGFnZVpvb21GYWN0b3IoKTsK IH0KIAogLyohCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZV9wLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWVfcC5oCShyZXZpc2lvbiA3MjAzMCkKKysrIFdlYktp dC9xdC9BcGkvcXdlYmZyYW1lX3AuaAkod29ya2luZyBjb3B5KQpAQCAtODAsNyArODAsNiBAQCBw dWJsaWM6CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKSAmJiBVU0UoVEVYVFVSRV9N QVBQRVIpCiAgICAgICAgICwgcm9vdEdyYXBoaWNzTGF5ZXIoMCkKICNlbmRpZgotICAgICAgICAs IHpvb21UZXh0T25seShmYWxzZSkKICAgICAgICAge30KICAgICB2b2lkIGluaXQoUVdlYkZyYW1l KiBxZnJhbWUsIFFXZWJGcmFtZURhdGEqIGZyYW1lRGF0YSk7CiAgICAgdm9pZCBzZXRQYWdlKFFX ZWJQYWdlKik7CkBAIC0xMTUsNyArMTE0LDYgQEAgcHVibGljOgogICAgIFdlYkNvcmU6OlRleHR1 cmVNYXBwZXJDb250ZW50TGF5ZXIqIHJvb3RHcmFwaGljc0xheWVyOwogICAgIE93blB0cjxXZWJD b3JlOjpUZXh0dXJlTWFwcGVyPiB0ZXh0dXJlTWFwcGVyOwogI2VuZGlmCi0gICAgYm9vbCB6b29t VGV4dE9ubHk7CiB9OwogCiBjbGFzcyBRV2ViSGl0VGVzdFJlc3VsdFByaXZhdGUgewo=