49567 2010-11-15 15:21:39 -0800 nrwt multiprocessing - remove port-specific child process restrictions 2010-12-02 02:54:48 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 50381 P2 Normal --- 49566 1 dpranke dpranke abarth eric hayato ojan tony oldest_to_newest 309468 0 dpranke 2010-11-15 15:21:39 -0800 need to remove the platform-specific restrictions on the default # of child processes when we fix the threading/multiprocessing issues. 309472 1 73936 dpranke 2010-11-15 15:27:10 -0800 Created attachment 73936 Patch 309474 2 dpranke 2010-11-15 15:28:55 -0800 Note that this should actually be the *last* of the MP (multiprocess) patches to land, after all the code is working and tested. The GPU tests (in chromium_gpu.py) will still default to 1, since there's GPU-related stability with parallel testing. 309701 3 73936 ojan 2010-11-16 06:25:12 -0800 Comment on attachment 73936 Patch Marking r- for now just because it's blocked on other patches. Maybe r? this patch once it's actually possible to commit it? The patch looks fine, although I expect the assumption is that another patch removes the default_child_processes call somewhere. 309851 4 dpranke 2010-11-16 11:39:01 -0800 (In reply to comment #0) > need to remove the platform-specific restrictions on the default # of child processes when we fix the threading/multiprocessing issues. r- for now is fine. We still need the call, though, which will fall through to the base class implementation, which gives us the # of CPUs. 316061 5 dpranke 2010-12-02 02:54:48 -0800 closing as wontfix - 50381 is now the way to do this. *** This bug has been marked as a duplicate of bug 50381 *** 73936 2010-11-15 15:27:10 -0800 2010-11-16 06:25:12 -0800 Patch bug-49567-20101115152708.patch text/plain 2716 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMzE2NzE3ZGFmOWU5NDkzM2RmZDVhNzBiNDllNzlmZTI5ZGUyY2Y5Li5jMzc2N2Ey YzJkNDZjYjY2MjlmNDZjY2Q0NjMzZDYwZDI3MTRjZmEzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dCAtIHJlbW92ZSBw b3J0LXNwZWNpZmljIGNoaWxkIHByb2Nlc3MgcmVzdHJpY3Rpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU2NworCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHk6CisKIDIwMTAtMTEtMTUg IEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5CmluZGV4IGQxYzM4M2Mx M2VjMmYxM2FmNWZiMWYxNTQwNTc5YzRjODg5ZmRkNjMuLjdkNzA0YzNhODlhZjU0YWQwZGFmMDc0 OGI0ZDg4OWE2MjJhY2U0Y2QgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5CkBAIC02Miwx NSArNjIsNiBAQCBjbGFzcyBDaHJvbWl1bU1hY1BvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToK ICAgICAgICAgICAgICAgICAgICAgICAgJ01hY0J1aWxkSW5zdHJ1Y3Rpb25zJykKICAgICAgICAg cmV0dXJuIHJlc3VsdAogCi0gICAgZGVmIGRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKHNlbGYpOgot ICAgICAgICAjIEZJWE1FOiB3ZSBuZWVkIHRvIHJ1biBzaW5nbGUtdGhyZWFkZWQgZm9yIG5vdy4g U2VlCi0gICAgICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4 NTUzLiBVbmZvcnR1bmF0ZWx5IHRoaXMKLSAgICAgICAgIyByb3V0aW5lIGlzIGNhbGxlZCByaWdo dCBiZWZvcmUgdGhlIGxvZ2dlciBpcyBjb25maWd1cmVkLCBzbyBpZiB3ZQotICAgICAgICAjIHRy eSB0byBfbG9nLndhcm5pbmcoKSwgaXQgZ2V0cyB0aHJvd24gYXdheS4KLSAgICAgICAgaW1wb3J0 IHN5cwotICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCJEZWZhdWx0aW5nIHRvIG9uZSBjaGlsZCAt IHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1NTNcbiIpCi0g ICAgICAgIHJldHVybiAxCi0KICAgICBkZWYgZHJpdmVyX25hbWUoc2VsZik6CiAgICAgICAgICIi Im5hbWUgZm9yIHRoaXMgcG9ydCdzIGVxdWl2YWxlbnQgb2YgRHVtcFJlbmRlclRyZWUuIiIiCiAg ICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbigndXNlX2RydCcpOgpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQppbmRleCA2OTZl MzM5OGVhNGIyOGFjNzYyMjU5MDdkYzM2MmZmYzNmYjg2ZjllLi43MmY5MWQ4MzgyMTVhZjRiYzQ0 ZjFkYzFmMDY1NWRhZGM3ZDMzNmZmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQpAQCAtNDcsMTUgKzQ3LDYgQEAgY2xh c3MgTWFjUG9ydChXZWJLaXRQb3J0KToKICAgICAgICAga3dhcmdzLnNldGRlZmF1bHQoJ3BvcnRf bmFtZScsICdtYWMnICsgc2VsZi52ZXJzaW9uKCkpCiAgICAgICAgIFdlYktpdFBvcnQuX19pbml0 X18oc2VsZiwgKiprd2FyZ3MpCiAKLSAgICBkZWYgZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMoc2Vs Zik6Ci0gICAgICAgICMgRklYTUU6IG5ldy1ydW4td2Via2l0LXRlc3RzIGlzIHVuc3RhYmxlIG9u IE1hYyBydW5uaW5nIG1vcmUgdGhhbgotICAgICAgICAjIGZvdXIgdGhyZWFkcyBpbiBwYXJhbGxl bC4KLSAgICAgICAgIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM2NjIyCi0gICAgICAgIGNoaWxkX3Byb2Nlc3NlcyA9IFdlYktpdFBvcnQuZGVmYXVsdF9jaGls ZF9wcm9jZXNzZXMoc2VsZikKLSAgICAgICAgaWYgY2hpbGRfcHJvY2Vzc2VzID4gNDoKLSAgICAg ICAgICAgIHJldHVybiA0Ci0gICAgICAgIHJldHVybiBjaGlsZF9wcm9jZXNzZXMKLQogICAgIGRl ZiBiYXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKToKICAgICAgICAgcG9ydF9uYW1lcyA9IFtdCiAg ICAgICAgIGlmIHNlbGYuX25hbWUgPT0gJ21hYy10aWdlcic6Cg==