49559 2010-11-15 13:08:42 -0800 DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString 2010-11-15 13:52:38 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 1 ap ap commit-queue darin oldest_to_newest 309402 0 ap 2010-11-15 13:08:42 -0800 Per MDC, it "must be null (or not specified) for regular elements." As far as I can tell, this makes no difference in practice, because "null" and "undefined" are not pseudo element names, and don't even start with ":". But it seems cleaner not to pass them to DOM code. 309404 1 73924 ap 2010-11-15 13:11:01 -0800 Created attachment 73924 proposed patch 309409 2 73924 darin 2010-11-15 13:13:52 -0800 Comment on attachment 73924 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=73924&action=review > WebCore/ChangeLog:8 > + No observable change in behavior, so no tests. Why do this if there is no observable change in behavior? 309411 3 73924 darin 2010-11-15 13:14:44 -0800 Comment on attachment 73924 proposed patch Maybe we can change the default some day. I can’t remember how this relates to the similar properties in WebIDL. 309416 4 73924 ap 2010-11-15 13:20:55 -0800 Comment on attachment 73924 proposed patch Well, basically it's just that I was surprised and confused to see "null" and "undefined" passed to DOM code when debugging. 309435 5 73924 commit-queue 2010-11-15 13:52:33 -0800 Comment on attachment 73924 proposed patch Clearing flags on attachment: 73924 Committed r72036: <http://trac.webkit.org/changeset/72036> 309436 6 commit-queue 2010-11-15 13:52:38 -0800 All reviewed patches have been landed. Closing bug. 73924 2010-11-15 13:11:01 -0800 2010-11-15 13:52:33 -0800 proposed patch UndefinedPseudoElement.txt text/plain 1279 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjAyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NTU5CisgICAgICAgIERP TVdpbmRvdy5nZXRDb21wdXRlZFN0eWxlIHBzZXVkbyBlbGVtZW50IGFyZ3VtZW50IGxhY2tzIENv bnZlcnRVbmRlZmluZWRPck51bGxUb051bGxTdHJpbmcKKworICAgICAgICBObyBvYnNlcnZhYmxl IGNoYW5nZSBpbiBiZWhhdmlvciwgc28gbm8gdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0RPTVdp bmRvdy5pZGw6IEFkZGVkIENvbnZlcnRVbmRlZmluZWRPck51bGxUb051bGxTdHJpbmcuCisKIDIw MTAtMTEtMTUgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IFdlYkNvcmUvcGFnZS9E T01XaW5kb3cuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCShy ZXZpc2lvbiA3MTkzNCkKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCSh3b3JraW5nIGNv cHkpCkBAIC0xNDQsNyArMTQ0LDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAKICAgICAgICAgLy8gRE9N IExldmVsIDIgU3R5bGUgSW50ZXJmYWNlCiAgICAgICAgIENTU1N0eWxlRGVjbGFyYXRpb24gZ2V0 Q29tcHV0ZWRTdHlsZShpbiBFbGVtZW50IGVsZW1lbnQsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpbiBET01TdHJpbmcgcHNldWRvRWxlbWVudCk7CisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbiBbQ29udmVydFVuZGVm aW5lZE9yTnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIHBzZXVkb0VsZW1lbnQpOwogCiAgICAg ICAgIC8vIFdlYktpdCBleHRlbnNpb25zCiAjaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBU KSAmJiBMQU5HVUFHRV9KQVZBU0NSSVBUCg==