49549 2010-11-15 10:37:15 -0800 [GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds 2010-11-15 12:17:22 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 49532 1 mrobinson webkit-unassigned oldest_to_newest 309344 0 mrobinson 2010-11-15 10:37:15 -0800 The line: g_return_val_if_fail(!surface, NULL); is incorrectly causing the method to fail if the surface is not null. The condition should be reversed. This causes problems loading custom cursors. For example, loading LayoutTests/fast/blockflow/broken-ideographic-font.html causes many CRITICAL GLib assertions when trying to select the vertically oriented text. 309349 1 73910 mrobinson 2010-11-15 10:43:58 -0800 Created attachment 73910 Patch for this issue 309389 2 73910 kling 2010-11-15 12:12:45 -0800 Comment on attachment 73910 Patch for this issue LGTM. 309390 3 mrobinson 2010-11-15 12:17:22 -0800 Committed r72020: <http://trac.webkit.org/changeset/72020> 73910 2010-11-15 10:43:58 -0800 2010-11-15 12:12:45 -0800 Patch for this issue bug-49549-20101115104357.patch text/plain 1525 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDdkNDY0ZDk1MjY3NGU1NjlmN2ZmZDUyMjQ1NDU3MDY5NmE5MzNkMi4uNjE1NWFkNjZhNWJjMzBj NDYyYmEyYzMwMDY1OTFhZDhiMGY3MWM0YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMS0xNSAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gZ2RrX3BpeGJ1Zl9nZXRfZnJvbV9z dXJmYWNlIGZyb20gR3RrVmVyc2lvbmluZy5oIGlzIGJyb2tlbiBvbiBHVEsrIDIgYnVpbGRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU0OQorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBjYW4gYmUgdmVyaWZpZWQgYnkgbG9hZGluZyBhbnkg ZXhpc3RpbmcgdmVydGljYWwgdGV4dCB0ZXN0CisgICAgICAgIGluIEd0a0xhdW5jaGVyIGFuZCBu b3RpY2luZyB0aGUgbGFjayBvZiBDUklUSUNBTCBHTGliIGV4Y2VwdGlvbnMuIFRoZXJlJ3MgY3Vy cmVudGx5CisgICAgICAgIG5vIGF1dG9tYXRpYyB3YXkgb2YgdmVyaWZ5aW5nIGN1c3RvbSBjdXJz b3JzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuYzoKKyAgICAgICAg KGdka19waXhidWZfZ2V0X2Zyb21fc3VyZmFjZSk6IFJldmVyc2UgYSBzYW5pdHkgY2hlY2sgaW4g dGhpcyBtZXRob2QgdG8gYmUgY29ycmVjdC4KKwogMjAxMC0xMS0xNSAgUGF0cmljayBHYW5zdGVy ZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9i aW5zb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmMg Yi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmMKaW5kZXggMDcxYzVlNTJiYjdl ZjlkZWUyM2NlNzM4ZjUwYzY1ZjEyYjlkYzIyMC4uMDc3NmMxMGMxMjhhMTA4NGQxMWZmNTU1ZWI3 MWRiYzQ4Y2VmOTE4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVmVyc2lv bmluZy5jCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuYwpAQCAtMjI1 LDcgKzIyNSw3IEBAIGdka19waXhidWZfZ2V0X2Zyb21fc3VyZmFjZShjYWlyb19zdXJmYWNlX3Qg KiBzdXJmYWNlLAogICAgIEdka1BpeGJ1ZiAqIGRlc3Q7CiAKICAgICAvKiBHZW5lcmFsIHNhbml0 eSBjaGVja3MgKi8KLSAgICBnX3JldHVybl92YWxfaWZfZmFpbCghc3VyZmFjZSwgTlVMTCk7Cisg ICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoc3VyZmFjZSwgTlVMTCk7CiAgICAgZ19yZXR1cm5fdmFs X2lmX2ZhaWwoc3JjWCA+PSAwICYmIHNyY1kgPj0gMCwgTlVMTCk7CiAgICAgZ19yZXR1cm5fdmFs X2lmX2ZhaWwod2lkdGggPiAwICYmIGhlaWdodCA+IDAsIE5VTEwpOwogCg==