49545 2010-11-15 08:33:27 -0800 [Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView 2010-11-17 09:36:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P4 Minor --- 1 benjamin webkit-unassigned commit-queue kbalazs oldest_to_newest 309293 0 73902 benjamin 2010-11-15 08:33:27 -0800 Created attachment 73902 Inputs for testing It seems tabbing between fields does not work with QGraphicsWKView. To reproduce, open Minibrowser on the attached file and enjoy :) 309782 1 74006 benjamin 2010-11-16 09:49:42 -0800 Created attachment 74006 Patch The FriendlyWidget of QGraphicsWKView::focusNextPrevChildCallback() is one hell of a ugly hack. Any idea to do that better is welcome. 310179 2 74006 kenneth 2010-11-17 01:56:48 -0800 Comment on attachment 74006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74006&action=review > WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:146 > +class FriendlyWidget : public QWidget Simon says that this is OK :-) 310186 3 74006 commit-queue 2010-11-17 02:40:33 -0800 Comment on attachment 74006 Patch Rejecting patch 74006 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 74006]" exit_code: 2 Last 500 characters of output: ceeded at 81 (offset 6 lines). patching file WebKit2/UIProcess/API/qt/qwkpage.cpp patching file WebKit2/UIProcess/API/qt/qwkpage.h Hunk #1 FAILED at 112. 1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/API/qt/qwkpage.h.rej patching file WebKit2/UIProcess/API/qt/qwkpage_p.h Hunk #1 succeeded at 55 with fuzz 1 (offset 1 line). Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6182013 310223 4 benjamin 2010-11-17 05:51:35 -0800 Committed r72202: <http://trac.webkit.org/changeset/72202> 310312 5 kbalazs 2010-11-17 08:48:06 -0800 (In reply to comment #1) > Created an attachment (id=74006) [details] > Patch > > The FriendlyWidget of QGraphicsWKView::focusNextPrevChildCallback() is one hell of a ugly hack. Any idea to do that better is welcome. What is the purpose of that? We are assuming the concrete type of the QWidget, right? Why not qobject_cast? Or am I misinterpreting it? 310338 6 benjamin 2010-11-17 09:36:48 -0800 (In reply to comment #5) > > The FriendlyWidget of QGraphicsWKView::focusNextPrevChildCallback() is one hell of a ugly hack. Any idea to do that better is welcome. > > What is the purpose of that? We are assuming the concrete type of the QWidget, > right? Why not qobject_cast? Or am I misinterpreting it? It is to change the visibility of a method. This method is usually available through QWidget, but here we are in a QGraphicsWidget, so we can't access it directly. This cast is a way to make a protected method public. 73902 2010-11-15 08:33:27 -0800 2010-11-15 08:33:27 -0800 Inputs for testing inputs.html text/html 27 benjamin PGlucHV0Lz4KPGlucHV0Lz4KPGlucHV0Lz4K 74006 2010-11-16 09:49:42 -0800 2010-11-17 02:40:33 -0800 Patch 49545.patch text/plain 5655 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YmNiZjU1Ni4uYWI4NzdkMSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMC0xMS0xNiAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1dLMl0gVGhlIGZvY3VzIHN3aXRjaGlu ZyBkb2VzIG5vdCBzZWVtcyB0byB3b3JrIHdpdGggUUdyYXBoaWNzV0tWaWV3CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTU0NQorCisgICAgICAgIElt cGxlbWVudCBmb2N1cyBzd2l0Y2hpbmcgd2l0aCBUYWIuIFRoaXMgaXMgbm93IGRvbmUgYXN5bmNo cm9ub3VzbHksCisgICAgICAgIHdhaXRpbmcgZm9yIHdlYmtpdCB0byBjYWxsIHRha2VGb2N1cygp IGFuZCBzd2l0Y2hpbmcgdGhlIHdpZGdldC4KKworICAgICAgICBTaW5jZSB0aGUgZm9jdXMgY2Fu IGNoYW5nZSBiZXR3ZWVuIHRoZSBUYWIgcHJlc3MgYW5kIHRoZSBjYWxsYmFjaywKKyAgICAgICAg UUdyYXBoaWNzV0tWaWV3Ojpmb2N1c05leHRQcmV2Q2hpbGRDYWxsYmFjaygpIG1ha2Ugc3VyZSB0 aGUgdmlldyBzdGlsbCBoYXMKKyAgICAgICAgZm9jdXMgYmVmb3JlIHBhc3NpbmcgaXQgdG8gdGhl IG5leHQgd2lkZ2V0LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3Zp ZXcuY3BwOgorICAgICAgICAoUUdyYXBoaWNzV0tWaWV3OjpRR3JhcGhpY3NXS1ZpZXcpOgorICAg ICAgICAoUUdyYXBoaWNzV0tWaWV3Ojpmb2N1c05leHRQcmV2Q2hpbGRDYWxsYmFjayk6CisgICAg ICAgIChRR3JhcGhpY3NXS1ZpZXc6OmZvY3VzTmV4dFByZXZDaGlsZCk6CisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3F3a3BhZ2UuY3BwOgorICAgICAgICAoUVdLUGFnZVByaXZhdGU6OnRha2VGb2N1cyk6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmg6CisgICAgICAgICogVUlQcm9jZXNz L0FQSS9xdC9xd2twYWdlX3AuaDoKKwogMjAxMC0xMS0xMiAgQmVuamFtaW4gUG91bGFpbiAgPGJl bmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMg S2xpbmcuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2 aWV3LmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCmlu ZGV4IDkyYzQzY2EuLjdhMTIxM2IgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3Jh cGhpY3N3a3ZpZXcuY3BwCkBAIC02NSw2ICs2NSw3IEBAIFFHcmFwaGljc1dLVmlldzo6UUdyYXBo aWNzV0tWaWV3KFdLUGFnZU5hbWVzcGFjZVJlZiBwYWdlTmFtZXNwYWNlUmVmLCBCYWNraW5nU3Rv CiAgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwoaW5pdGlhbExheW91dENvbXBsZXRlZCgpKSwg dGhpcywgU0lHTkFMKGluaXRpYWxMYXlvdXRDb21wbGV0ZWQoKSkpOwogICAgIGNvbm5lY3QoZC0+ cGFnZSwgU0lHTkFMKHVybENoYW5nZWQoY29uc3QgUVVybCYpKSwgdGhpcywgU0lHTkFMKHVybENo YW5nZWQoY29uc3QgUVVybCYpKSk7CiAgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwoY3Vyc29y Q2hhbmdlZChjb25zdCBRQ3Vyc29yJikpLCB0aGlzLCBTTE9UKHVwZGF0ZUN1cnNvcihjb25zdCBR Q3Vyc29yJikpKTsKKyAgICBjb25uZWN0KGQtPnBhZ2UsIFNJR05BTChmb2N1c05leHRQcmV2Q2hp bGQoYm9vbCkpLCB0aGlzLCBTTE9UKGZvY3VzTmV4dFByZXZDaGlsZENhbGxiYWNrKGJvb2wpKSk7 CiB9CiAKIFFHcmFwaGljc1dLVmlldzo6flFHcmFwaGljc1dLVmlldygpCkBAIC0xNDIsNiArMTQz LDQzIEBAIHZvaWQgUUdyYXBoaWNzV0tWaWV3Ojp1cGRhdGVDdXJzb3IoY29uc3QgUUN1cnNvciYg Y3Vyc29yKQogICAgIHNldEN1cnNvcihjdXJzb3IpOwogfQogCitjbGFzcyBGcmllbmRseVdpZGdl dCA6IHB1YmxpYyBRV2lkZ2V0Cit7CitwdWJsaWM6CisgICAgYm9vbCBmb2N1c05leHRQcmV2Q2hp bGQoYm9vbCBuZXh0KTsKK307CisKK3ZvaWQgUUdyYXBoaWNzV0tWaWV3Ojpmb2N1c05leHRQcmV2 Q2hpbGRDYWxsYmFjayhib29sIG5leHQpCit7CisgICAgaWYgKGhhc0ZvY3VzKCkpIHsKKyAgICAg ICAgLy8gZmluZCB0aGUgdmlldyB3aGljaCBoYXMgdGhlIGZvY3VzOgorICAgICAgICBRTGlzdDxR R3JhcGhpY3NWaWV3Kj4gdmlld3MgPSBzY2VuZSgpLT52aWV3cygpOworICAgICAgICBjb25zdCBp bnQgdmlld0NvdW50ID0gdmlld3MuY291bnQoKTsKKyAgICAgICAgUUdyYXBoaWNzVmlldyogZm9j dXNlZFZpZXcgPSAwOworICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IHZpZXdDb3VudDsgKytp KSB7CisgICAgICAgICAgICBpZiAodmlld3NbaV0tPmhhc0ZvY3VzKCkpIHsKKyAgICAgICAgICAg ICAgICBmb2N1c2VkVmlldyA9IHZpZXdzW2ldOworICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICAgICAgfQorICAgICAgICB9CisKKyAgICAgICAgaWYgKGZvY3VzZWRWaWV3KSB7CisgICAg ICAgICAgICBRV2lkZ2V0KiB3aW5kb3cgPSBmb2N1c2VkVmlldy0+d2luZG93KCk7CisgICAgICAg ICAgICBGcmllbmRseVdpZGdldCogZnJpZW5kbHlXaW5kb3cgPSBzdGF0aWNfY2FzdDxGcmllbmRs eVdpZGdldCo+KHdpbmRvdyk7CisgICAgICAgICAgICBmcmllbmRseVdpbmRvdy0+Zm9jdXNOZXh0 UHJldkNoaWxkKG5leHQpOworICAgICAgICB9CisgICAgfQorfQorCisvKiEgXHJlaW1wCisqLwor Ym9vbCBRR3JhcGhpY3NXS1ZpZXc6OmZvY3VzTmV4dFByZXZDaGlsZChib29sIG5leHQpCit7Cisg ICAgUUtleUV2ZW50IGV2KFFFdmVudDo6S2V5UHJlc3MsIFF0OjpLZXlfVGFiLCBRdDo6S2V5Ym9h cmRNb2RpZmllcnMobmV4dCA/IFF0OjpOb01vZGlmaWVyIDogUXQ6OlNoaWZ0TW9kaWZpZXIpKTsK KyAgICBwYWdlKCktPmQtPmtleVByZXNzRXZlbnQoJmV2KTsKKyAgICByZXR1cm4gdHJ1ZTsKK30K KwogLyohIFxyZWltcAogKi8KIFFWYXJpYW50IFFHcmFwaGljc1dLVmlldzo6aXRlbUNoYW5nZShH cmFwaGljc0l0ZW1DaGFuZ2UgY2hhbmdlLCBjb25zdCBRVmFyaWFudCYgdmFsdWUpCmRpZmYgLS1n aXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmggYi9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmgKaW5kZXggYzVlNDNiMi4uMWIzOTUz MiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5o CisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaApAQCAtNzUs NyArNzUsOSBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGhvdmVyTW92ZUV2ZW50KFFH cmFwaGljc1NjZW5lSG92ZXJFdmVudCopOwogCiAgICAgUV9TTE9UIHZvaWQgdXBkYXRlQ3Vyc29y KGNvbnN0IFFDdXJzb3ImKTsKKyAgICBRX1NMT1Qgdm9pZCBmb2N1c05leHRQcmV2Q2hpbGRDYWxs YmFjayhib29sIG5leHQpOwogCisgICAgdmlydHVhbCBib29sIGZvY3VzTmV4dFByZXZDaGlsZChi b29sIG5leHQpOwogICAgIHZpcnR1YWwgdm9pZCBmb2N1c0luRXZlbnQoUUZvY3VzRXZlbnQqKTsK ICAgICB2aXJ0dWFsIHZvaWQgZm9jdXNPdXRFdmVudChRRm9jdXNFdmVudCopOwogCmRpZmYgLS1n aXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggZjQ3YmJjMy4uNThlY2ViNyAxMDA2NDQKLS0t IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtOTgsNiArOTgsMTEgQEAgdm9pZCBRV0tQYWdl UHJpdmF0ZTo6c2V0Vmlld3BvcnRBcmd1bWVudHMoY29uc3QgVmlld3BvcnRBcmd1bWVudHMmIGFy Z3MpCiAgICAgZW1pdCBxLT52aWV3cG9ydENoYW5nZVJlcXVlc3RlZCgpOwogfQogCit2b2lkIFFX S1BhZ2VQcml2YXRlOjp0YWtlRm9jdXMoYm9vbCBkaXJlY3Rpb24pCit7CisgICAgZW1pdCBxLT5m b2N1c05leHRQcmV2Q2hpbGQoZGlyZWN0aW9uKTsKK30KKwogdm9pZCBRV0tQYWdlUHJpdmF0ZTo6 cGFnZURpZFJlcXVlc3RTY3JvbGwoY29uc3QgSW50U2l6ZSYgZGVsdGEpCiB7CiAgICAgZW1pdCBx LT5zY3JvbGxSZXF1ZXN0ZWQoZGVsdGEud2lkdGgoKSwgZGVsdGEuaGVpZ2h0KCkpOwpkaWZmIC0t Z2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuaCBiL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xd2twYWdlLmgKaW5kZXggOTU4Y2ZiOS4uMzE1OGU5NSAxMDA2NDQKLS0tIGEv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZS5oCkBAIC0xMTIsNiArMTEyLDcgQEAgcHVibGljOgogICAgIFFfU0lH TkFMIHZvaWQgc2Nyb2xsUmVxdWVzdGVkKGludCBkeCwgaW50IGR5KTsKICAgICBRX1NJR05BTCB2 b2lkIGN1cnNvckNoYW5nZWQoY29uc3QgUUN1cnNvciYpOwogICAgIFFfU0lHTkFMIHZvaWQgdmll d3BvcnRDaGFuZ2VSZXF1ZXN0ZWQoKTsKKyAgICBRX1NJR05BTCB2b2lkIGZvY3VzTmV4dFByZXZD aGlsZChib29sKTsKIAogcHJvdGVjdGVkOgogICAgIHZvaWQgdGltZXJFdmVudChRVGltZXJFdmVu dCopOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2VfcC5oIGIv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2VfcC5oCmluZGV4IDZiZWY3NDUuLjE2YWM0 MTMgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaAorKysg Yi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZV9wLmgKQEAgLTU0LDcgKzU0LDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VDb250ZW50c1NpemUoY29uc3QgV2Vi Q29yZTo6SW50U2l6ZSYpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJzb3IoY29uc3QgV2ViQ29y ZTo6Q3Vyc29yJik7CiAgICAgdmlydHVhbCB2b2lkIHNldFZpZXdwb3J0QXJndW1lbnRzKGNvbnN0 IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzJik7Ci0gICAgdmlydHVhbCB2b2lkIHRha2VGb2N1 cyhib29sIGRpcmVjdGlvbikgeyB9CisgICAgdmlydHVhbCB2b2lkIHRha2VGb2N1cyhib29sIGRp cmVjdGlvbik7CiAgICAgdmlydHVhbCB2b2lkIHRvb2xUaXBDaGFuZ2VkKGNvbnN0IFdURjo6U3Ry aW5nJiwgY29uc3QgV1RGOjpTdHJpbmcmKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJFZGl0 Q29tbWFuZChQYXNzUmVmUHRyPFdlYktpdDo6V2ViRWRpdENvbW1hbmRQcm94eT4sIFdlYktpdDo6 V2ViUGFnZVByb3h5OjpVbmRvT3JSZWRvKTsKICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJBbGxFZGl0 Q29tbWFuZHMoKTsK