49542 2010-11-15 07:25:36 -0800 [Qt][WK2] Avoid polling in WebKitTestRunner 2010-11-15 13:37:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 abecsi abecsi benjamin kling ossy oldest_to_newest 309271 0 abecsi 2010-11-15 07:25:36 -0800 In the Qt implementation of TestController we are currently using a polling mechanism to check whether the condition is met. By refactoring RunUntilConditionLoop to avoid polling we can make the WK2 testing session about 10-15% faster and decrease random flackyness resulting from timing skew. 309274 1 73894 abecsi 2010-11-15 07:48:57 -0800 Created attachment 73894 proposed patch 309414 2 73894 kling 2010-11-15 13:19:06 -0800 Comment on attachment 73894 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=73894&action=review Much better, r=me! > WebKitTools/ChangeLog:8 > + Make the WK2 testing session about 10-15% faster and decrease random flackyness s/flackyness/flakiness/ 309423 3 abecsi 2010-11-15 13:36:54 -0800 (In reply to comment #2) > s/flackyness/flakiness/ Fixed and committed in r72031: <http://trac.webkit.org/changeset/72031> Closing bug. 309424 4 73894 abecsi 2010-11-15 13:37:27 -0800 Comment on attachment 73894 proposed patch Clearing flags. 73894 2010-11-15 07:48:57 -0800 2010-11-15 13:37:27 -0800 proposed patch patch.diff text/plain 7274 abecsi ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxZWY2MTllLi4wM2Y0YzY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTAtMTEt MTUgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBBdm9pZCBwb2xsaW5nIGlu IFdlYktpdFRlc3RSdW5uZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00OTU0MgorCisgICAgICAgIE1ha2UgdGhlIFdLMiB0ZXN0aW5nIHNlc3Npb24g YWJvdXQgMTAtMTUlIGZhc3RlciBhbmQgZGVjcmVhc2UgcmFuZG9tIGZsYWNreW5lc3MKKyAgICAg ICAgcmVzdWx0aW5nIGZyb20gdGltaW5nIHNrZXcgYnkgcmVtb3ZpbmcgdGhlIG1pbGxpc2Vjb25k IHBvbGxpbmcgZnJvbSBUZXN0Q29udHJvbGxlclF0LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpk aWRGaW5pc2hMb2FkRm9yRnJhbWUpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENv bnRyb2xsZXIuaDoKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNw cDoKKyAgICAgICAgKFdUUjo6VGVzdEludm9jYXRpb246OmRpZFJlY2VpdmVNZXNzYWdlRnJvbUlu amVjdGVkQnVuZGxlKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL21hYy9UZXN0Q29udHJv bGxlck1hYy5tbToKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6Om5vdGlmeURvbmUpOiBB ZGQgbWV0aG9kIHN0dWIuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0Q29udHJv bGxlclF0LmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXJSdW5Mb29wOjppbnN0YW5j ZSk6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyUnVuTG9vcDo6c3RhcnQpOgorICAgICAg ICAoV1RSOjpUZXN0Q29udHJvbGxlclJ1bkxvb3A6OnN0b3ApOgorICAgICAgICAoV1RSOjpUZXN0 Q29udHJvbGxlclJ1bkxvb3A6OlRlc3RDb250cm9sbGVyUnVuTG9vcCk6CisgICAgICAgIChXVFI6 OlRlc3RDb250cm9sbGVyUnVuTG9vcDo6dGltZXJFdmVudCk6CisgICAgICAgIChXVFI6OlRlc3RD b250cm9sbGVyOjpub3RpZnlEb25lKToKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OnBs YXRmb3JtUnVuVW50aWwpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvd2luL1Rlc3RDb250 cm9sbGVyV2luLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6Om5vdGlmeURvbmUp OiBBZGQgbWV0aG9kIHN0dWIuCisKIDIwMTAtMTEtMTQgIERhdmlkIExldmluICA8bGV2aW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvV2Vi S2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggOGNhMDUy OS4uM2ZjOTJmMiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0 Q29udHJvbGxlci5jcHAKKysrIGIvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29u dHJvbGxlci5jcHAKQEAgLTM4OCw2ICszODgsNyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpkaWRG aW5pc2hMb2FkRm9yRnJhbWUoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJhbWUpCiAgICAg ICAgIHJldHVybjsKIAogICAgIG1fZG9uZVJlc2V0dGluZyA9IHRydWU7CisgICAgc2hhcmVkKCku bm90aWZ5RG9uZSgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXVFIKZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaCBiL1dlYktpdFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaAppbmRleCAxMzk2Yzk0Li40YzA1YmY0IDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmgK KysrIGIvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCkBAIC01 Niw2ICs1Niw3IEBAIHB1YmxpYzoKICAgICAvLyBSdW5zIHRoZSBydW4gbG9vcCB1bnRpbCBgZG9u ZWAgaXMgdHJ1ZSBvciB0aGUgdGltZW91dCBlbGFwc2VzLgogICAgIGVudW0gVGltZW91dER1cmF0 aW9uIHsgU2hvcnRUaW1lb3V0LCBMb25nVGltZW91dCB9OwogICAgIHZvaWQgcnVuVW50aWwoYm9v bCYgZG9uZSwgVGltZW91dER1cmF0aW9uKTsKKyAgICB2b2lkIG5vdGlmeURvbmUoKTsKIAogcHJp dmF0ZToKICAgICB2b2lkIGluaXRpYWxpemUoaW50IGFyZ2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSk7 CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9u LmNwcCBiL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCmlu ZGV4IGU4OGRlNTMuLjI2ZWNmYzAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdEludm9jYXRpb24uY3BwCisrKyBiL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdEludm9jYXRpb24uY3BwCkBAIC0xNjMsNiArMTYzLDcgQEAgdm9pZCBUZXN0SW52b2Nh dGlvbjo6ZGlkUmVjZWl2ZU1lc3NhZ2VGcm9tSW5qZWN0ZWRCdW5kbGUoV0tTdHJpbmdSZWYgbWVz c2FnZU5hbWUKICAgICAgICAgbV9nb3RJbml0aWFsUmVzcG9uc2UgPSB0cnVlOwogICAgICAgICBt X2dvdEZpbmFsTWVzc2FnZSA9IHRydWU7CiAgICAgICAgIG1fZXJyb3IgPSB0cnVlOworICAgICAg ICBUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkubm90aWZ5RG9uZSgpOwogICAgICAgICByZXR1cm47 CiAgICAgfQogCkBAIC0xNzEsNiArMTcyLDcgQEAgdm9pZCBUZXN0SW52b2NhdGlvbjo6ZGlkUmVj ZWl2ZU1lc3NhZ2VGcm9tSW5qZWN0ZWRCdW5kbGUoV0tTdHJpbmdSZWYgbWVzc2FnZU5hbWUKICAg ICAgICAgV0tTdHJpbmdSZWYgbWVzc2FnZUJvZHlTdHJpbmcgPSBzdGF0aWNfY2FzdDxXS1N0cmlu Z1JlZj4obWVzc2FnZUJvZHkpOwogICAgICAgICBpZiAoV0tTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0 cmluZyhtZXNzYWdlQm9keVN0cmluZywgIkJlZ2luVGVzdCIpKSB7CiAgICAgICAgICAgICBtX2dv dEluaXRpYWxSZXNwb25zZSA9IHRydWU7CisgICAgICAgICAgICBUZXN0Q29udHJvbGxlcjo6c2hh cmVkKCkubm90aWZ5RG9uZSgpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKQEAg LTE4NCw2ICsxODYsNyBAQCB2b2lkIFRlc3RJbnZvY2F0aW9uOjpkaWRSZWNlaXZlTWVzc2FnZUZy b21JbmplY3RlZEJ1bmRsZShXS1N0cmluZ1JlZiBtZXNzYWdlTmFtZQogICAgICAgICBkdW1wKHRv U1REKG1lc3NhZ2VCb2R5U3RyaW5nKS5jX3N0cigpKTsKIAogICAgICAgICBtX2dvdEZpbmFsTWVz c2FnZSA9IHRydWU7CisgICAgICAgIFRlc3RDb250cm9sbGVyOjpzaGFyZWQoKS5ub3RpZnlEb25l KCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250cm9sbGVyTWFjLm1tIGIvV2ViS2l0VG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9tYWMvVGVzdENvbnRyb2xsZXJNYWMubW0KaW5kZXggMjY4ZjcxOC4uZmVl MDA3MCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvVGVzdENv bnRyb2xsZXJNYWMubW0KKysrIGIvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvVGVz dENvbnRyb2xsZXJNYWMubW0KQEAgLTMwLDYgKzMwLDEwIEBACiAKIG5hbWVzcGFjZSBXVFIgewog Cit2b2lkIFRlc3RDb250cm9sbGVyOjpub3RpZnlEb25lKCkKK3sKK30KKwogdm9pZCBUZXN0Q29u dHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIHsKIH0KZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdENvbnRyb2xsZXJRdC5jcHAgYi9XZWJLaXRUb29s cy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RDb250cm9sbGVyUXQuY3BwCmluZGV4IGQzZmM1YmYu LmNhMGEwMGMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVz dENvbnRyb2xsZXJRdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9U ZXN0Q29udHJvbGxlclF0LmNwcApAQCAtMzAsMTEgKzMwLDYgQEAKIAogI2luY2x1ZGUgPGNzdGRs aWI+CiAjaW5jbHVkZSA8UUNvcmVBcHBsaWNhdGlvbj4KLSNpZiAoUVRfVkVSU0lPTiA+PSAweDA0 MDcwMCkKLSMgICAgaW5jbHVkZSA8UUVsYXBzZWRUaW1lcj4KLSNlbHNlCi0jICAgIGluY2x1ZGUg PFFUaW1lPgotI2VuZGlmCiAjaW5jbHVkZSA8UUV2ZW50TG9vcD4KICNpbmNsdWRlIDxRRmlsZUlu Zm8+CiAjaW5jbHVkZSA8UUxpYnJhcnk+CkBAIC00NSw2MCArNDAsNTIgQEAKIAogbmFtZXNwYWNl IFdUUiB7CiAKLS8vIFdpdGggYSBiaWdnZXIgaW50ZXJ2YWwgd2Ugd291bGQgd2FzdGUgdG8gbXVj aCB0aW1lCi0vLyBhZnRlciB0aGUgdGVzdCBoYWQgYmVlbiBmaW5pc2hlZC4KLXN0YXRpYyBjb25z dCB1bnNpZ25lZCBrVGltZXJJbnRlcnZhbE1TID0gMTsKLQotY2xhc3MgUnVuVW50aWxDb25kaXRp b25Mb29wIDogcHVibGljIFFPYmplY3QgeworY2xhc3MgVGVzdENvbnRyb2xsZXJSdW5Mb29wIDog cHVibGljIFFPYmplY3QgewogICAgIFFfT0JKRUNUCi0KIHB1YmxpYzoKLSAgICBzdGF0aWMgdm9p ZCBzdGFydChib29sJiBkb25lLCBpbnQgdGltZW91dCkKKyAgICBzdGF0aWMgVGVzdENvbnRyb2xs ZXJSdW5Mb29wKiBpbnN0YW5jZSgpCiAgICAgewotICAgICAgICBzdGF0aWMgUnVuVW50aWxDb25k aXRpb25Mb29wKiBpbnN0YW5jZSA9IG5ldyBSdW5VbnRpbENvbmRpdGlvbkxvb3A7Ci0gICAgICAg IGluc3RhbmNlLT5ydW4oZG9uZSwgdGltZW91dCk7CisgICAgICAgIHN0YXRpYyBUZXN0Q29udHJv bGxlclJ1bkxvb3AqIHJlc3VsdCA9IG5ldyBUZXN0Q29udHJvbGxlclJ1bkxvb3A7CisgICAgICAg IHJldHVybiByZXN1bHQ7CiAgICAgfQogCi1wcml2YXRlOgotICAgIFJ1blVudGlsQ29uZGl0aW9u TG9vcCgpIHt9Ci0KLSAgICB2b2lkIHJ1bihib29sJiBkb25lLCBpbnQgdGltZW91dCkKKyAgICB2 b2lkIHN0YXJ0KGludCBtc2VjKQogICAgIHsKLSAgICAgICAgbV9jb25kaXRpb24gPSAmZG9uZTsK LSAgICAgICAgbV90aW1lb3V0ID0gdGltZW91dDsKLSAgICAgICAgbV9lbGFwc2VkVGltZS5zdGFy dCgpOwotICAgICAgICBtX3RpbWVySUQgPSBzdGFydFRpbWVyKGtUaW1lckludGVydmFsTVMpOwor ICAgICAgICBtX3RpbWVySUQgPSBzdGFydFRpbWVyKG1zZWMpOwogICAgICAgICBBU1NFUlQobV90 aW1lcklEKTsKICAgICAgICAgbV9ldmVudExvb3AuZXhlYyhRRXZlbnRMb29wOjpFeGNsdWRlVXNl cklucHV0RXZlbnRzKTsKICAgICB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgdGltZXJFdmVudChRVGlt ZXJFdmVudCopCisgICAgdm9pZCBzdG9wKCkKICAgICB7Ci0gICAgICAgIGlmICghKm1fY29uZGl0 aW9uICYmIG1fZWxhcHNlZFRpbWUuZWxhcHNlZCgpIDwgbV90aW1lb3V0KQotICAgICAgICAgICAg cmV0dXJuOwotCiAgICAgICAgIGtpbGxUaW1lcihtX3RpbWVySUQpOwotICAgICAgICBtX2V2ZW50 TG9vcC5leGl0KCk7CisgICAgICAgIG1fZXZlbnRMb29wLnF1aXQoKTsKKyAgICB9Citwcml2YXRl OgorICAgIFRlc3RDb250cm9sbGVyUnVuTG9vcCgpIHt9CisKKyAgICB2b2lkIHRpbWVyRXZlbnQo UVRpbWVyRXZlbnQqKQorICAgIHsKKyAgICAgICAgZnByaW50ZihzdGRlcnIsICJGQUlMOiBUZXN0 Q29udHJvbGxlclJ1bkxvb3AgdGltZWQgb3V0LlxuIik7CisgICAgICAgIHN0b3AoKTsKICAgICB9 CiAKICAgICBRRXZlbnRMb29wIG1fZXZlbnRMb29wOwotICAgIGJvb2wqIG1fY29uZGl0aW9uOwog ICAgIGludCBtX3RpbWVySUQ7Ci0gICAgaW50IG1fdGltZW91dDsKLSNpZiAoUVRfVkVSU0lPTiA+ PSAweDA0MDcwMCkKLSAgICBRRWxhcHNlZFRpbWVyIG1fZWxhcHNlZFRpbWU7Ci0jZWxzZQotICAg IFFUaW1lIG1fZWxhcHNlZFRpbWU7Ci0jZW5kaWYKIH07CiAKK3ZvaWQgVGVzdENvbnRyb2xsZXI6 Om5vdGlmeURvbmUoKQoreworICAgIFRlc3RDb250cm9sbGVyUnVuTG9vcDo6aW5zdGFuY2UoKS0+ c3RvcCgpOworfQorCiB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemUoKQog ewogfQogCi12b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybVJ1blVudGlsKGJvb2wmIGRvbmUs IGRvdWJsZSB0aW1lb3V0KQordm9pZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1SdW5VbnRpbChi b29sJiwgZG91YmxlIHRpbWVvdXQpCiB7Ci0gICAgUnVuVW50aWxDb25kaXRpb25Mb29wOjpzdGFy dChkb25lLCBzdGF0aWNfY2FzdDxpbnQ+KHRpbWVvdXQgKiAxMDAwKSk7CisgICAgVGVzdENvbnRy b2xsZXJSdW5Mb29wOjppbnN0YW5jZSgpLT5zdGFydChzdGF0aWNfY2FzdDxpbnQ+KHRpbWVvdXQg KiAxMDAwKSk7CiB9CiAKIHN0YXRpYyBib29sIGlzRXhpc3RpbmdMaWJyYXJ5KGNvbnN0IFFTdHJp bmcmIHBhdGgpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9U ZXN0Q29udHJvbGxlcldpbi5jcHAgYi9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9U ZXN0Q29udHJvbGxlcldpbi5jcHAKaW5kZXggM2ZkODUzZi4uODllMjlmZCAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93aW4vVGVzdENvbnRyb2xsZXJXaW4uY3BwCisr KyBiL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvd2luL1Rlc3RDb250cm9sbGVyV2luLmNw cApAQCAtOTAsNiArOTAsMTAgQEAgc3RhdGljIExPTkcgV0lOQVBJIGV4Y2VwdGlvbkZpbHRlcihF WENFUFRJT05fUE9JTlRFUlMqKQogICAgIHJldHVybiBFWENFUFRJT05fQ09OVElOVUVfU0VBUkNI OwogfQogCit2b2lkIFRlc3RDb250cm9sbGVyOjpub3RpZnlEb25lKCkKK3sKK30KKwogdm9pZCBU ZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIHsKICAgICA6OlNldFVuaGFuZGxl ZEV4Y2VwdGlvbkZpbHRlcihleGNlcHRpb25GaWx0ZXIpOwo=