49529 2010-11-15 02:31:01 -0800 [gtk] SVGLineElement-dom-requiredFeatures.html and SVGLineElement-svgdom-requiredFeatures.html failing in the bots 2010-11-30 19:38:50 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned commit-queue krit rwlbuis oldest_to_newest 309213 0 alex 2010-11-15 02:31:01 -0800 They work for me locally but apparently the startTest does not start the test in the bots. I'm skipping the tests until we find the issue. Dirk do you have any clue about why this could happen? 309399 1 rwlbuis 2010-11-15 13:00:30 -0800 Hi, (In reply to comment #0) > They work for me locally but apparently the startTest does not start the test in the bots. I'm skipping the tests until we find the issue. Dirk do you have any clue about why this could happen? This sounds like the onclick is not triggered. You could try such a change to see if it helps: diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js index b1f8e95..ccbc735 100644 --- a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js +++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js @@ -9,6 +9,7 @@ lineElement.setAttribute("y1", "20"); lineElement.setAttribute("x2", "200"); lineElement.setAttribute("y2", "200"); lineElement.setAttribute("fill", "green"); +lineElement.setAttribute("style", "stroke-width:10px"); rootSVGElement.appendChild(lineElement); diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js index 2350445..ffab290 100644 --- a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js +++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js @@ -9,6 +9,7 @@ lineElement.setAttribute("y1", "20"); lineElement.setAttribute("x2", "200"); lineElement.setAttribute("y2", "200"); lineElement.setAttribute("fill", "green"); +lineElement.setAttribute("style", "stroke-width:10px"); rootSVGElement.appendChild(lineElement); Cheers, Rob. 310210 2 alex 2010-11-17 04:34:10 -0800 (In reply to comment #1) > Hi, > > (In reply to comment #0) > > They work for me locally but apparently the startTest does not start the test in the bots. I'm skipping the tests until we find the issue. Dirk do you have any clue about why this could happen? > > This sounds like the onclick is not triggered. You could try such a change to see if it helps: > Thanks for the help, I tried the change in the bots and apparently did not fix the issue, I also tried to change the point of the onclick but without success. 310391 3 krit 2010-11-17 11:03:06 -0800 (In reply to comment #2) > (In reply to comment #1) > > Hi, > > > > (In reply to comment #0) > > > They work for me locally but apparently the startTest does not start the test in the bots. I'm skipping the tests until we find the issue. Dirk do you have any clue about why this could happen? > > > > This sounds like the onclick is not triggered. You could try such a change to see if it helps: > > > > Thanks for the help, I tried the change in the bots and apparently did not fix the issue, I also tried to change the point of the onclick but without success. Does it work manually for you? Means opening the test in the browser and click manually on the element? (I'm not sure if the element is visible at the beginning of the test, so..) 310455 4 rwlbuis 2010-11-17 12:39:43 -0800 Hi, (In reply to comment #2) > (In reply to comment #1) > > Hi, > > > > (In reply to comment #0) > > > They work for me locally but apparently the startTest does not start the test in the bots. I'm skipping the tests until we find the issue. Dirk do you have any clue about why this could happen? > > > > This sounds like the onclick is not triggered. You could try such a change to see if it helps: > > > > Thanks for the help, I tried the change in the bots and apparently did not fix the issue, I also tried to change the point of the onclick but without success. Dirks tip to try it manually is a good idea. Also I noticed setting fill is probably not correct for the line, could you try this patch instead: diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js index b1f8e95..3a54c7a 100644 --- a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js +++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js @@ -8,7 +8,8 @@ lineElement.setAttribute("x1", "20"); lineElement.setAttribute("y1", "20"); lineElement.setAttribute("x2", "200"); lineElement.setAttribute("y2", "200"); -lineElement.setAttribute("fill", "green"); +lineElement.setAttribute("stroke", "green"); +lineElement.setAttribute("stroke-width", "10px"); rootSVGElement.appendChild(lineElement); diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js index 2350445..2c0b9d0 100644 --- a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js +++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js @@ -8,7 +8,8 @@ lineElement.setAttribute("x1", "20"); lineElement.setAttribute("y1", "20"); lineElement.setAttribute("x2", "200"); lineElement.setAttribute("y2", "200"); -lineElement.setAttribute("fill", "green"); +lineElement.setAttribute("stroke", "green"); +lineElement.setAttribute("stroke-width", "10px"); rootSVGElement.appendChild(lineElement); Cheers, Rob. 312757 5 alex 2010-11-23 04:41:06 -0800 (In reply to comment #3) > > [...] > > Does it work manually for you? Means opening the test in the browser and click manually on the element? (I'm not sure if the element is visible at the beginning of the test, so..) Sorry for the late answer, too much things in my plate, you are right it even did not show the element so I could not click. With the patch sent by Rob it worked manually. 312758 6 alex 2010-11-23 04:42:39 -0800 (In reply to comment #4) > > [...] > > Dirks tip to try it manually is a good idea. Also I noticed setting fill is probably not correct for the line, could you try this patch instead: > Awesome, it worked, both manually and in the bots :). Thanks again for taking care and sorry for the late reply. 312976 7 rwlbuis 2010-11-23 12:40:42 -0800 Hi Alejandro, (In reply to comment #6) > (In reply to comment #4) > > > > [...] > > > > Dirks tip to try it manually is a good idea. Also I noticed setting fill is probably not correct for the line, could you try this patch instead: > > > > Awesome, it worked, both manually and in the bots :). Thanks again for taking care and sorry for the late reply. No problem, I created the problem in the first place so I may as well clean it up :) So I guess you'll commit the fix soon? Cheers, Rob. 313206 8 74738 alex 2010-11-24 04:03:24 -0800 Created attachment 74738 Proposed patch I've created the patch on your behalf because I think we need a review for this one. 315487 9 commit-queue 2010-11-30 19:15:07 -0800 The commit-queue encountered the following flaky tests while processing attachment 74738: fast/history/history-subframe-with-name.html fast/preloader/script.html Please file bugs against the tests. These tests were authored by abarth@webkit.org and mihaip@chromium.org. The commit-queue is continuing to process your patch. 315493 10 74738 commit-queue 2010-11-30 19:38:45 -0800 Comment on attachment 74738 Proposed patch Clearing flags on attachment: 74738 Committed r73005: <http://trac.webkit.org/changeset/73005> 315494 11 commit-queue 2010-11-30 19:38:50 -0800 All reviewed patches have been landed. Closing bug. 74738 2010-11-24 04:03:24 -0800 2010-11-30 19:38:44 -0800 Proposed patch svg.patch text/plain 3050 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYTNlY2FlLi4yMmYwNmFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTEt MjQgIFJvYiBCdWlzICA8cndsYnVpc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2d0a10gU1ZHTGluZUVsZW1lbnQtZG9tLXJlcXVp cmVkRmVhdHVyZXMuaHRtbCBhbmQKKyAgICAgICAgU1ZHTGluZUVsZW1lbnQtc3ZnZG9tLXJlcXVp cmVkRmVhdHVyZXMuaHRtbCBmYWlsaW5nIGluIHRoZSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTUyOQorCisgICAgICAgIFJlcGxhY2VkIGZp bGwgd2l0aCBzdHJva2UgYW5kIGluY3JlYXNlZCB0aGUgbGluZSBzaXplLiBUaGlzIGZpeGVzCisg ICAgICAgIHRoZSBwcm9ibGVtIGNsaWNraW5nIHRoZSBlbGVtZW50LgorCisgICAgICAgICogcGxh dGZvcm0vZ3RrL1NraXBwZWQ6CisgICAgICAgICogc3ZnL2R5bmFtaWMtdXBkYXRlcy9zY3JpcHQt dGVzdHMvU1ZHTGluZUVsZW1lbnQtZG9tLXJlcXVpcmVkRmVhdHVyZXMuanM6CisgICAgICAgICog c3ZnL2R5bmFtaWMtdXBkYXRlcy9zY3JpcHQtdGVzdHMvU1ZHTGluZUVsZW1lbnQtc3ZnZG9tLXJl cXVpcmVkRmVhdHVyZXMuanM6CisKIDIwMTAtMTEtMjMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggOThjOTI0Yi4uZmZkMGIzZCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKQEAgLTU2NDMsMTAgKzU2NDMsNiBAQCBmYXN0L2V2ZW50cy9zY3Jv bGwtYWZ0ZXItY2xpY2stb24tdGFiLWluZGV4Lmh0bWwKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ5MTc5CiBhbmltYXRpb25zL3N0b3AtYW5pbWF0aW9uLW9uLXN1 c3BlbmQuaHRtbAogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 OTUyOQotc3ZnL2R5bmFtaWMtdXBkYXRlcy9TVkdMaW5lRWxlbWVudC1kb20tcmVxdWlyZWRGZWF0 dXJlcy5odG1sCi1zdmcvZHluYW1pYy11cGRhdGVzL1NWR0xpbmVFbGVtZW50LXN2Z2RvbS1yZXF1 aXJlZEZlYXR1cmVzLmh0bWwKLQogIyBjb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRlZEluZm8g aXMgbm90IGltcGxlbWVudGVkCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNzMzNgogZmFzdC9oaXN0b3J5L25lc3RlZC12aXNpdGVkLXRlc3QuaHRtbApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2R5bmFtaWMtdXBkYXRlcy9zY3JpcHQtdGVzdHMvU1ZHTGlu ZUVsZW1lbnQtZG9tLXJlcXVpcmVkRmVhdHVyZXMuanMgYi9MYXlvdXRUZXN0cy9zdmcvZHluYW1p Yy11cGRhdGVzL3NjcmlwdC10ZXN0cy9TVkdMaW5lRWxlbWVudC1kb20tcmVxdWlyZWRGZWF0dXJl cy5qcwppbmRleCBiMWY4ZTk1Li4zYTU0YzdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdmcv ZHluYW1pYy11cGRhdGVzL3NjcmlwdC10ZXN0cy9TVkdMaW5lRWxlbWVudC1kb20tcmVxdWlyZWRG ZWF0dXJlcy5qcworKysgYi9MYXlvdXRUZXN0cy9zdmcvZHluYW1pYy11cGRhdGVzL3NjcmlwdC10 ZXN0cy9TVkdMaW5lRWxlbWVudC1kb20tcmVxdWlyZWRGZWF0dXJlcy5qcwpAQCAtOCw3ICs4LDgg QEAgbGluZUVsZW1lbnQuc2V0QXR0cmlidXRlKCJ4MSIsICIyMCIpOwogbGluZUVsZW1lbnQuc2V0 QXR0cmlidXRlKCJ5MSIsICIyMCIpOwogbGluZUVsZW1lbnQuc2V0QXR0cmlidXRlKCJ4MiIsICIy MDAiKTsKIGxpbmVFbGVtZW50LnNldEF0dHJpYnV0ZSgieTIiLCAiMjAwIik7Ci1saW5lRWxlbWVu dC5zZXRBdHRyaWJ1dGUoImZpbGwiLCAiZ3JlZW4iKTsKK2xpbmVFbGVtZW50LnNldEF0dHJpYnV0 ZSgic3Ryb2tlIiwgImdyZWVuIik7CitsaW5lRWxlbWVudC5zZXRBdHRyaWJ1dGUoInN0cm9rZS13 aWR0aCIsICIxMHB4Iik7CiAKIHJvb3RTVkdFbGVtZW50LmFwcGVuZENoaWxkKGxpbmVFbGVtZW50 KTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2R5bmFtaWMtdXBkYXRlcy9zY3JpcHQt dGVzdHMvU1ZHTGluZUVsZW1lbnQtc3ZnZG9tLXJlcXVpcmVkRmVhdHVyZXMuanMgYi9MYXlvdXRU ZXN0cy9zdmcvZHluYW1pYy11cGRhdGVzL3NjcmlwdC10ZXN0cy9TVkdMaW5lRWxlbWVudC1zdmdk b20tcmVxdWlyZWRGZWF0dXJlcy5qcwppbmRleCAyMzUwNDQ1Li4yYzBiOWQwIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9zdmcvZHluYW1pYy11cGRhdGVzL3NjcmlwdC10ZXN0cy9TVkdMaW5lRWxl bWVudC1zdmdkb20tcmVxdWlyZWRGZWF0dXJlcy5qcworKysgYi9MYXlvdXRUZXN0cy9zdmcvZHlu YW1pYy11cGRhdGVzL3NjcmlwdC10ZXN0cy9TVkdMaW5lRWxlbWVudC1zdmdkb20tcmVxdWlyZWRG ZWF0dXJlcy5qcwpAQCAtOCw3ICs4LDggQEAgbGluZUVsZW1lbnQuc2V0QXR0cmlidXRlKCJ4MSIs ICIyMCIpOwogbGluZUVsZW1lbnQuc2V0QXR0cmlidXRlKCJ5MSIsICIyMCIpOwogbGluZUVsZW1l bnQuc2V0QXR0cmlidXRlKCJ4MiIsICIyMDAiKTsKIGxpbmVFbGVtZW50LnNldEF0dHJpYnV0ZSgi eTIiLCAiMjAwIik7Ci1saW5lRWxlbWVudC5zZXRBdHRyaWJ1dGUoImZpbGwiLCAiZ3JlZW4iKTsK K2xpbmVFbGVtZW50LnNldEF0dHJpYnV0ZSgic3Ryb2tlIiwgImdyZWVuIik7CitsaW5lRWxlbWVu dC5zZXRBdHRyaWJ1dGUoInN0cm9rZS13aWR0aCIsICIxMHB4Iik7CiAKIHJvb3RTVkdFbGVtZW50 LmFwcGVuZENoaWxkKGxpbmVFbGVtZW50KTsKIAo=