49527 2010-11-15 01:55:26 -0800 Web Inspector: Do not hide default Ctrl+A behavior on non-Mac 2010-11-15 04:10:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 309202 0 pfeldman 2010-11-15 01:55:26 -0800 Otherwise select all in console does not work. 309203 1 73878 pfeldman 2010-11-15 02:00:43 -0800 Created attachment 73878 [PATCH] Proposed change. 309215 2 73878 yurys 2010-11-15 02:39:00 -0800 Comment on attachment 73878 [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=73878&action=review I personally find these shortcuts quite useful and think that it would be nice to provide a shortcut for go-to-{start, end} on other platforms. > WebCore/inspector/front-end/TextPrompt.js:-111 > - case "U+0045": // Ctrl+E = Move caret to the end of prompt on non-Mac. does this conflict with some other action as well? 309217 3 pfeldman 2010-11-15 02:43:20 -0800 (In reply to comment #2) > (From update of attachment 73878 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73878&action=review > > I personally find these shortcuts quite useful and think that it would be nice to provide a shortcut for go-to-{start, end} on other platforms. > Home and End works. > > WebCore/inspector/front-end/TextPrompt.js:-111 > > - case "U+0045": // Ctrl+E = Move caret to the end of prompt on non-Mac. > > does this conflict with some other action as well? No, just for consistency. 309231 4 73878 commit-queue 2010-11-15 04:10:06 -0800 Comment on attachment 73878 [PATCH] Proposed change. Clearing flags on attachment: 73878 Committed r72002: <http://trac.webkit.org/changeset/72002> 309232 5 commit-queue 2010-11-15 04:10:12 -0800 All reviewed patches have been landed. Closing bug. 73878 2010-11-15 02:00:43 -0800 2010-11-15 04:10:06 -0800 [PATCH] Proposed change. ctrla text/plain 2416 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWMxZWRhZi4uZjAyZmViMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0xNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBEbyBub3QgaGlkZSBkZWZhdWx0IEN0 cmwrQSBiZWhhdmlvciBvbiBub24tTWFjLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDk1MjcKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv VGV4dFByb21wdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlw ZS5fb25LZXlEb3duKToKKwogMjAxMC0xMS0xNCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgQmFjayBvdXQgdGhlIGl0YWxpY3MgcG9ydGlvbiBvZiB0aGUgcHJldmlv dXMgcGF0Y2ggdW50aWwgSSBjYW4gZmlndXJlIG91dCB3aHkgaXQKZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggYjZiY2Q1Mi4uZTlhNzNmZSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAgLTEwMCwyMiArMTAwLDYgQEAg V2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICBkZWZhdWx0QWN0aW9uLmNhbGwodGhpcyk7CiAgICAgICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgICAgICBjYXNlICJVKzAwNDEiOiAvLyBDdHJsK0EgPSBNb3ZlIGNh cmV0IHRvIHRoZSBzdGFydCBvZiBwcm9tcHQgb24gbm9uLU1hYy4KLSAgICAgICAgICAgICAgICBp ZiAoIVdlYkluc3BlY3Rvci5pc01hYygpICYmIGV2ZW50LmN0cmxLZXkgJiYgIWV2ZW50Lm1ldGFL ZXkgJiYgIWV2ZW50LmFsdEtleSAmJiAhZXZlbnQuc2hpZnRLZXkpIHsKLSAgICAgICAgICAgICAg ICAgICAgaGFuZGxlZCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgICAgIHRoaXMuX21vdmVDYXJl dFRvU3RhcnRPZlByb21wdCgpOwotICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAg ICAgICAgICB9Ci0gICAgICAgICAgICAgICAgZGVmYXVsdEFjdGlvbi5jYWxsKHRoaXMpOwotICAg ICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgY2FzZSAiVSswMDQ1IjogLy8gQ3RybCtF ID0gTW92ZSBjYXJldCB0byB0aGUgZW5kIG9mIHByb21wdCBvbiBub24tTWFjLgotICAgICAgICAg ICAgICAgIGlmICghV2ViSW5zcGVjdG9yLmlzTWFjKCkgJiYgZXZlbnQuY3RybEtleSAmJiAhZXZl bnQubWV0YUtleSAmJiAhZXZlbnQuYWx0S2V5ICYmICFldmVudC5zaGlmdEtleSkgewotICAgICAg ICAgICAgICAgICAgICBoYW5kbGVkID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICAgICAgdGhpcy5t b3ZlQ2FyZXRUb0VuZE9mUHJvbXB0KCk7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAg ICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBkZWZhdWx0QWN0aW9uLmNhbGwodGhpcyk7 Ci0gICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAg ICAgICAgIGRlZmF1bHRBY3Rpb24uY2FsbCh0aGlzKTsKICAgICAgICAgICAgICAgICBicmVhazsK QEAgLTM3OSwxOCArMzYzLDYgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0g ewogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCi0gICAgX21vdmVDYXJldFRvU3RhcnRP ZlByb21wdDogZnVuY3Rpb24oKQotICAgIHsKLSAgICAgICAgdmFyIHNlbGVjdGlvbiA9IHdpbmRv dy5nZXRTZWxlY3Rpb24oKTsKLSAgICAgICAgdmFyIHNlbGVjdGlvblJhbmdlID0gZG9jdW1lbnQu Y3JlYXRlUmFuZ2UoKTsKLQotICAgICAgICBzZWxlY3Rpb25SYW5nZS5zZXRTdGFydCh0aGlzLmVs ZW1lbnQsIDApOwotICAgICAgICBzZWxlY3Rpb25SYW5nZS5zZXRFbmQodGhpcy5lbGVtZW50LCAw KTsKLQotICAgICAgICBzZWxlY3Rpb24ucmVtb3ZlQWxsUmFuZ2VzKCk7Ci0gICAgICAgIHNlbGVj dGlvbi5hZGRSYW5nZShzZWxlY3Rpb25SYW5nZSk7Ci0gICAgfSwKLQogICAgIG1vdmVDYXJldFRv RW5kT2ZQcm9tcHQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHZhciBzZWxlY3Rpb24gPSB3 aW5kb3cuZ2V0U2VsZWN0aW9uKCk7Cg==