49517 2010-11-14 15:48:48 -0800 [BREWMP] Replace MALLOC, FREE and REALLOC macros with IEnv 2012-07-26 05:18:51 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED WONTFIX P2 Normal --- 48597 0 skyul webkit-unassigned oldest_to_newest 309118 0 skyul 2010-11-14 15:48:48 -0800 MALLOC, FREE and REALLOC macros are prohibited in Mod1. Use IEnv interface to allocate and free memory. 309119 1 73861 skyul 2010-11-14 15:50:41 -0800 Created attachment 73861 Patch 312164 2 73861 paroga 2010-11-21 14:30:52 -0800 Comment on attachment 73861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73861&action=review > JavaScriptCore/wtf/brew/SystemMallocBrew.h:39 > + IEnv* env; > + int result = env_GetCurrent(&env); > + ASSERT_UNUSED(result, result == AEE_SUCCESS); You do the same code 4 times. Seams to be a good candidate for an extra functon. Is it possible to cache IEnv? Do we get an different IEnv for every call/thread/process? 320023 3 73861 eric 2010-12-10 01:35:22 -0800 Comment on attachment 73861 Patch YEah. please add a helper function. Like currentIEnv() or similar. 679182 4 skyul 2012-07-26 05:18:51 -0700 Brew MP port is no longer maintained. 73861 2010-11-14 15:50:41 -0800 2010-12-10 01:35:22 -0800 Patch malloc.patch text/plain 2650 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcxOTg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTEtMTQgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBSZXBsYWNlIE1BTExPQywgRlJFRSBhbmQg UkVBTExPQyBtYWNyb3Mgd2l0aCBJRW52CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00OTUxNworCisgICAgICAgIE1BTExPQywgRlJFRSBhbmQgUkVBTExP QyBtYWNyb3MgYXJlIHByb2hpYml0ZWQgaW4gTW9kMS4gVXNlIElFbnYgaW50ZXJmYWNlIHRvIGFs bG9jYXRlIGFuZCBmcmVlIG1lbW9yeS4KKworICAgICAgICAqIHd0Zi9icmV3L1N5c3RlbU1hbGxv Y0JyZXcuaDoKKyAgICAgICAgKG1hbGxvY0JyZXcpOgorICAgICAgICAoY2FsbG9jQnJldyk6Cisg ICAgICAgIChmcmVlQnJldyk6CisgICAgICAgIChyZWFsbG9jQnJldyk6CisKIDIwMTAtMTEtMTIg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIFJvYmVuLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL2JyZXcvU3lzdGVtTWFs bG9jQnJldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L1N5c3RlbU1h bGxvY0JyZXcuaAkocmV2aXNpb24gNzE5ODcpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvYnJldy9T eXN0ZW1NYWxsb2NCcmV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTI5LDI5ICsyOSw1NCBAQAogI2lm bmRlZiBTeXN0ZW1NYWxsb2NCcmV3X2gKICNkZWZpbmUgU3lzdGVtTWFsbG9jQnJld19oCiAKLSNp bmNsdWRlIDxBRUVTdGRMaWIuaD4KKyNpbmNsdWRlIDxBRUVJRW52Lmg+CisjaW5jbHVkZSA8QUVF ZW52Lmg+CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCogbWFsbG9jQnJldyhzaXplX3QgbikKIHsKLSAg ICAvLyBCeSBkZWZhdWx0LCBtZW1vcnkgYWxsb2NhdGVkIHVzaW5nIE1BTExPQygpIGlzIGluaXRp YWxpemVkCi0gICAgLy8gdG8gemVyby4gVGhpcyBiZWhhdmlvciBjYW4gYmUgZGlzYWJsZWQgYnkg cGVyZm9ybWluZyBhIGJpdHdpc2UKLSAgICAvLyBPUiBvZiB0aGUgZmxhZyBBTExPQ19OT19aTUVN IHdpdGggdGhlIGR3U2l6ZSBwYXJhbWV0ZXIuCi0gICAgcmV0dXJuIE1BTExPQyhuIHwgQUxMT0Nf Tk9fWk1FTSk7CisgICAgSUVudiogZW52OworICAgIGludCByZXN1bHQgPSBlbnZfR2V0Q3VycmVu dCgmZW52KTsKKyAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0ID09IEFFRV9TVUNDRVNT KTsKKworICAgIHZvaWQqIHA7CisgICAgcmVzdWx0ID0gSUVudl9FcnJNYWxsb2NOb1pJKGVudiwg biwgJnApOworICAgIEFTU0VSVF9VTlVTRUQocmVzdWx0LCByZXN1bHQgPT0gQUVFX1NVQ0NFU1Mp OworCisgICAgcmV0dXJuIHA7CiB9CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCogY2FsbG9jQnJldyhz aXplX3QgbnVtRWxlbWVudHMsIHNpemVfdCBlbGVtZW50U2l6ZSkKIHsKLSAgICByZXR1cm4gTUFM TE9DKG51bUVsZW1lbnRzICogZWxlbWVudFNpemUpOworICAgIElFbnYqIGVudjsKKyAgICBpbnQg cmVzdWx0ID0gZW52X0dldEN1cnJlbnQoJmVudik7CisgICAgQVNTRVJUX1VOVVNFRChyZXN1bHQs IHJlc3VsdCA9PSBBRUVfU1VDQ0VTUyk7CisKKyAgICB2b2lkKiBwOworICAgIHJlc3VsdCA9IElF bnZfRXJyTWFsbG9jKGVudiwgbnVtRWxlbWVudHMgKiBlbGVtZW50U2l6ZSwgJnApOworICAgIEFT U0VSVF9VTlVTRUQocmVzdWx0LCByZXN1bHQgPT0gQUVFX1NVQ0NFU1MpOworCisgICAgcmV0dXJu IHA7CiB9CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBmcmVlQnJldyh2b2lkKiBwKQogewotICAgIHJl dHVybiBGUkVFKHApOworICAgIElFbnYqIGVudjsKKyAgICBpbnQgcmVzdWx0ID0gZW52X0dldEN1 cnJlbnQoJmVudik7CisgICAgQVNTRVJUX1VOVVNFRChyZXN1bHQsIHJlc3VsdCA9PSBBRUVfU1VD Q0VTUyk7CisKKyAgICBJRW52X0ZyZWUoZW52LCBwKTsKIH0KIAogc3RhdGljIGlubGluZSB2b2lk KiByZWFsbG9jQnJldyh2b2lkKiBwLCBzaXplX3QgbikKIHsKLSAgICByZXR1cm4gUkVBTExPQyhw LCBuIHwgQUxMT0NfTk9fWk1FTSk7CisgICAgSUVudiogZW52OworICAgIGludCByZXN1bHQgPSBl bnZfR2V0Q3VycmVudCgmZW52KTsKKyAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0ID09 IEFFRV9TVUNDRVNTKTsKKworICAgIHJlc3VsdCA9IElFbnZfRXJyUmVhbGxvY05vWkkoZW52LCBu LCAmcCk7CisgICAgQVNTRVJUX1VOVVNFRChyZXN1bHQsIHJlc3VsdCA9PSBBRUVfU1VDQ0VTUyk7 CisKKyAgICByZXR1cm4gcDsKIH0KIAogLy8gVXNlIE1BTExPQyBtYWNybyBpbnN0ZWFkIG9mIHRo ZSBzdGFuZGFyZCBtYWxsb2MgZnVuY3Rpb24uCg==