49510 2010-11-14 09:33:07 -0800 Only inject fullscreen.css when in fullscreen 2010-12-06 09:36:27 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned abarth eric jer.noble pnormand rwlbuis webkit.review.bot oldest_to_newest 309075 0 simon.fraser 2010-11-14 09:33:07 -0800 Adding the fullscreen UA stylesheet to all pages at all times adds some additional overhead to CSS style resolution that we can avoid. This is important because we try to match :-webkit-full-screen against every element. 310984 1 74265 rwlbuis 2010-11-18 11:15:52 -0800 Created attachment 74265 Patch 310990 2 74265 simon.fraser 2010-11-18 11:23:17 -0800 Comment on attachment 74265 Patch Thank you! 311044 3 webkit.review.bot 2010-11-18 12:40:00 -0800 http://trac.webkit.org/changeset/72321 might have broken Qt Linux Release 311058 4 rwlbuis 2010-11-18 13:16:55 -0800 Landed in r72321. 317675 5 pnormand 2010-12-06 09:36:27 -0800 It seems that with this patch the fullscreen css is never loaded because when the document is initially created it is not in fullscreen state. Or did I miss something? 74265 2010-11-18 11:15:52 -0800 2010-11-18 11:23:16 -0800 Patch bug-49510-20101118202101.patch text/plain 3733 rwlbuis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWQwYzVkMzhmNjQxOGRkNjRhNTgyNTdiZjI3ZjAzZWIxMmQ5ZjFhOC4uZTFlMTdhMjI5MTdkNGQ5 ZWFjOTU2ODBiZDE2MzkyNDRlNThhZjU1YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMS0xOCAgUm9i IEJ1aXMgIDxyd2xidWlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBPbmx5IGluamVjdCBmdWxsc2NyZWVuLmNzcyB3aGVuIGluIGZ1 bGxzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ5NTEwCisKKyAgICAgICAgUmVmYWN0b3IgdG8gb25seSBhZGQgZnVsbHNjcmVlbiBzaGVldCBy dWxlcyB3aGVuIGRvY3VtZW50IGlzIGluIGZ1bGxzY3JlZW4gbW9kZS4KKworICAgICAgICBObyBu ZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OkNTU1N0eWxlU2VsZWN0b3IpOgor ICAgICAgICAoV2ViQ29yZTo6bG9hZEZ1bGxEZWZhdWx0U3R5bGUpOgorICAgICAgICAoV2ViQ29y ZTo6bG9hZEZ1bGxTY3JlZW5SdWxlc0lmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0 eWxlU2VsZWN0b3I6OnN0eWxlRm9yRWxlbWVudCk6CisKIDIwMTAtMTEtMTIgIFpoZW55YW8gTW8g IDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwu CmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1dlYkNvcmUv Y3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IGEzYzk0ZGM5M2I2M2ZmY2RkZTgzYjZiZDlk MWM0ZjY5ODYyOTQ3YzcuLjE3MmEzMzFlNWZiNDk4ZDE0ZDFkYWIyMWJiYzY2ZDY5NjVkZjBmN2Yg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCisrKyBiL1dlYkNv cmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC0zODksNiArMzg5LDkgQEAgc3RhdGljIENT U1N0eWxlU2hlZXQqIHNpbXBsZURlZmF1bHRTdHlsZVNoZWV0OwogUmVuZGVyU3R5bGUqIENTU1N0 eWxlU2VsZWN0b3I6OnNfc3R5bGVOb3RZZXRBdmFpbGFibGU7CiAKIHN0YXRpYyB2b2lkIGxvYWRG dWxsRGVmYXVsdFN0eWxlKCk7CisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorc3RhdGljIHZv aWQgbG9hZEZ1bGxTY3JlZW5SdWxlc0lmTmVlZGVkKERvY3VtZW50Kik7CisjZW5kaWYKIHN0YXRp YyB2b2lkIGxvYWRTaW1wbGVEZWZhdWx0U3R5bGUoKTsKIC8vIEZJWE1FOiBJdCB3b3VsZCBiZSBu aWNlIHRvIHVzZSBzb21lIG1lY2hhbmlzbSB0aGF0IGd1YXJhbnRlZXMgdGhpcyBpcyBpbiBzeW5j IHdpdGggdGhlIHJlYWwgVUEgc3R5bGVzaGVldC4KIHN0YXRpYyBjb25zdCBjaGFyKiBzaW1wbGVV c2VyQWdlbnRTdHlsZVNoZWV0ID0gImh0bWwsYm9keSxkaXZ7ZGlzcGxheTpibG9ja31ib2R5e21h cmdpbjo4cHh9ZGl2OmZvY3VzLHNwYW46Zm9jdXN7b3V0bGluZTphdXRvIDVweCAtd2Via2l0LWZv Y3VzLXJpbmctY29sb3J9YTotd2Via2l0LWFueS1saW5re2NvbG9yOi13ZWJraXQtbGluazt0ZXh0 LWRlY29yYXRpb246dW5kZXJsaW5lfWE6LXdlYmtpdC1hbnktbGluazphY3RpdmV7Y29sb3I6LXdl YmtpdC1hY3RpdmVsaW5rfSI7CkBAIC00MjcsOCArNDMwLDEyIEBAIENTU1N0eWxlU2VsZWN0b3I6 OkNTU1N0eWxlU2VsZWN0b3IoRG9jdW1lbnQqIGRvY3VtZW50LCBTdHlsZVNoZWV0TGlzdCogc3R5 bGVTaGVlCiAgICAgaWYgKCFkZWZhdWx0U3R5bGUpIHsKICAgICAgICAgaWYgKCFyb290IHx8IGVs ZW1lbnRDYW5Vc2VTaW1wbGVEZWZhdWx0U3R5bGUocm9vdCkpCiAgICAgICAgICAgICBsb2FkU2lt cGxlRGVmYXVsdFN0eWxlKCk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgZWxzZSB7CiAgICAgICAg ICAgICBsb2FkRnVsbERlZmF1bHRTdHlsZSgpOworI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK KyAgICAgICAgICAgIGxvYWRGdWxsU2NyZWVuUnVsZXNJZk5lZWRlZChkb2N1bWVudCk7CisjZW5k aWYKKyAgICAgICAgfQogICAgIH0KIAogICAgIC8vIGNvbnN0cnVjdCBkb2N1bWVudCByb290IGVs ZW1lbnQgZGVmYXVsdCBzdHlsZS4gdGhpcyBpcyBuZWVkZWQKQEAgLTUzNCwxNSArNTQxLDIwIEBA IHN0YXRpYyB2b2lkIGxvYWRGdWxsRGVmYXVsdFN0eWxlKCkKICAgICBTdHJpbmcgcXVpcmtzUnVs ZXMgPSBTdHJpbmcocXVpcmtzVXNlckFnZW50U3R5bGVTaGVldCwgc2l6ZW9mKHF1aXJrc1VzZXJB Z2VudFN0eWxlU2hlZXQpKSArIFJlbmRlclRoZW1lOjpkZWZhdWx0VGhlbWUoKS0+ZXh0cmFRdWly a3NTdHlsZVNoZWV0KCk7CiAgICAgQ1NTU3R5bGVTaGVldCogcXVpcmtzU2hlZXQgPSBwYXJzZVVB U2hlZXQocXVpcmtzUnVsZXMpOwogICAgIGRlZmF1bHRRdWlya3NTdHlsZS0+YWRkUnVsZXNGcm9t U2hlZXQocXVpcmtzU2hlZXQsIHNjcmVlbkV2YWwoKSk7Ci0gICAgCit9CisKICNpZiBFTkFCTEUo RlVMTFNDUkVFTl9BUEkpCitzdGF0aWMgdm9pZCBsb2FkRnVsbFNjcmVlblJ1bGVzSWZOZWVkZWQo RG9jdW1lbnQqIGRvY3VtZW50KQoreworICAgIGlmICghZG9jdW1lbnQtPndlYmtpdEZ1bGxTY3Jl ZW4oKSkKKyAgICAgICAgcmV0dXJuOwogICAgIC8vIEZ1bGwtc2NyZWVuIHJ1bGVzLgogICAgIFN0 cmluZyBmdWxsc2NyZWVuUnVsZXMgPSBTdHJpbmcoZnVsbHNjcmVlblVzZXJBZ2VudFN0eWxlU2hl ZXQsIHNpemVvZihmdWxsc2NyZWVuVXNlckFnZW50U3R5bGVTaGVldCkpICsgUmVuZGVyVGhlbWU6 OmRlZmF1bHRUaGVtZSgpLT5leHRyYURlZmF1bHRTdHlsZVNoZWV0KCk7CiAgICAgQ1NTU3R5bGVT aGVldCogZnVsbHNjcmVlblNoZWV0ID0gcGFyc2VVQVNoZWV0KGZ1bGxzY3JlZW5SdWxlcyk7CiAg ICAgZGVmYXVsdFN0eWxlLT5hZGRSdWxlc0Zyb21TaGVldChmdWxsc2NyZWVuU2hlZXQsIHNjcmVl bkV2YWwoKSk7CiAgICAgZGVmYXVsdFF1aXJrc1N0eWxlLT5hZGRSdWxlc0Zyb21TaGVldChmdWxs c2NyZWVuU2hlZXQsIHNjcmVlbkV2YWwoKSk7Ci0jZW5kaWYKIH0KKyNlbmRpZgogCiBzdGF0aWMg dm9pZCBsb2FkU2ltcGxlRGVmYXVsdFN0eWxlKCkKIHsKQEAgLTExNDEsOCArMTE1MywxMiBAQCBQ YXNzUmVmUHRyPFJlbmRlclN0eWxlPiBDU1NTdHlsZVNlbGVjdG9yOjpzdHlsZUZvckVsZW1lbnQo RWxlbWVudCogZSwgUmVuZGVyU3R5bAogICAgICAgICBtX3N0eWxlLT5zZXRJbnNpZGVMaW5rKG1f ZWxlbWVudExpbmtTdGF0ZSk7CiAgICAgfQogICAgIAotICAgIGlmIChzaW1wbGVEZWZhdWx0U3R5 bGVTaGVldCAmJiAhZWxlbWVudENhblVzZVNpbXBsZURlZmF1bHRTdHlsZShlKSkKKyAgICBpZiAo c2ltcGxlRGVmYXVsdFN0eWxlU2hlZXQgJiYgIWVsZW1lbnRDYW5Vc2VTaW1wbGVEZWZhdWx0U3R5 bGUoZSkpIHsKICAgICAgICAgbG9hZEZ1bGxEZWZhdWx0U3R5bGUoKTsKKyNpZiBFTkFCTEUoRlVM TFNDUkVFTl9BUEkpCisgICAgICAgIGxvYWRGdWxsU2NyZWVuUnVsZXNJZk5lZWRlZChlLT5kb2N1 bWVudCgpKTsKKyNlbmRpZgorICAgIH0KIAogI2lmIEVOQUJMRShTVkcpCiAgICAgc3RhdGljIGJv b2wgbG9hZGVkU1ZHVXNlckFnZW50U2hlZXQ7Cg==