49498 2010-11-13 14:43:51 -0800 focus issue with links that have tooltips 2010-11-23 12:40:50 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 ht990332 webkit-unassigned cgarcia mrobinson oldest_to_newest 309009 0 ht990332 2010-11-13 14:43:51 -0800 I found a bug in webkit gtk .If there are many images with links on the same horizontal line. If I hover over first one and it shows the title (tooltip) then move the mouse horizontally to the next link right of it, the second tooltip will appear on first link. A workaround is moving the mouse vertically a bit then moving it to next link. I'm using 1.3.6 from git. 309010 1 ht990332 2010-11-13 14:45:50 -0800 This happens only when the links are directly adjacent. sometimes second link tooltiip doesn't show till I move the mouse around then back to second link 310914 2 ht990332 2010-11-18 10:10:54 -0800 To reproduce, open http://en.wikipedia.org/wiki/Webkit 1. Put mouse over "Discussion" first (not "Article"). 2. Move the mouse horizontally (not vertically) over "Article". 3. Watch tooltip over wrong link. 311327 3 cgarcia 2010-11-19 02:29:23 -0800 Yes, this is because tooltip position is not updated for the same widget unless an area of the widget is set for the tooltip. 311328 4 74364 cgarcia 2010-11-19 02:31:02 -0800 Created attachment 74364 Patch to set the tooltip area Set the area of the widget where the tooltip should be shown when a new tooltip is set. Since the widget is the same (the view), if the tooltip area is not set and a new tooltip is triggered while the previous one is still visible, the text of the tooltip is updated but its position doesn't change 311502 5 74364 mrobinson 2010-11-19 08:49:01 -0800 Comment on attachment 74364 Patch to set the tooltip area View in context: https://bugs.webkit.org/attachment.cgi?id=74364&action=review Great! Just a couple suggestions. > WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:526 > + if (Node* node = hit.innerNonSharedNode()) > + webkit_web_view_set_tooltip_area(m_webView, node->getRect()); > + else > + webkit_web_view_set_tooltip_area(m_webView, IntRect()); I think it might be cleaner to simply have this code update the WebView private data structure. > WebKit/gtk/webkit/webkitwebview.cpp:1645 > + gtk_tooltip_set_tip_area(tooltip, NULL); NULL should be 0 here. > WebKit/gtk/webkit/webkitwebview.cpp:4756 > +void webkit_web_view_set_tooltip_area(WebKitWebView* webView, const IntRect& area) > +{ > +#if GTK_CHECK_VERSION(2, 12, 0) > + WebKitWebViewPrivate* priv = webView->priv; > + priv->tooltipArea = area; > + // query-tooltip will be triggered by webkit_web_view_set_tooltip_text(). > +#else > + // TODO: Support older GTK+ versions > + // See http://bugs.webkit.org/show_bug.cgi?id=15793 > + notImplemented(); > +#endif > +} > + > /** I think the conditional logic is unnecessarily here. It's technically correct, but this method doesn't use any GTK+ API calls that don't exist in < 2.12.0. I prefer simply scrapping this and fiddling the private structure directly. Mainly this is because webkitwebview.cpp is bordering on 5000 lines. 312232 6 74531 cgarcia 2010-11-22 00:25:56 -0800 Created attachment 74531 Updated patch 312972 7 74531 mrobinson 2010-11-23 12:35:51 -0800 Comment on attachment 74531 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=74531&action=review Looks great. There is only one tiny thing that I'll change before landing. > WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:526 > + WebKitWebViewPrivate* priv = m_webView->priv; > + Node* node = hit.innerNonSharedNode(); > + priv->tooltipArea = node ? node->getRect() : IntRect(); This should probably just be m_webView->priv->tooltipArea = ... I'll fix that and land it. 312977 8 mrobinson 2010-11-23 12:40:50 -0800 Committed r72621: <http://trac.webkit.org/changeset/72621> 74364 2010-11-19 02:31:02 -0800 2010-11-22 00:25:56 -0800 Patch to set the tooltip area tooltip-area.diff text/plain 4168 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNDYxMTc3NS4uMzVjM2I4NiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0xMS0xOSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZm9jdXMgaXNzdWUgd2l0aCBsaW5r cyB0aGF0IGhhdmUgdG9vbHRpcHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ5NDk4CisKKyAgICAgICAgU2V0IHRoZSBhcmVhIG9mIHRoZSB3aWRnZXQg d2hlcmUgdGhlIHRvb2x0aXAgc2hvdWxkIGJlIHNob3duIHdoZW4KKyAgICAgICAgYSBuZXcgdG9v bHRpcCBpcyBzZXQuIFNpbmNlIHRoZSB3aWRnZXQgaXMgdGhlIHNhbWUgKHRoZSB2aWV3KSwgaWYK KyAgICAgICAgdGhlIHRvb2x0aXAgYXJlYSBpcyBub3Qgc2V0IGFuZCBhIG5ldyB0b29sdGlwIGlz IHRyaWdnZXJlZCB3aGlsZQorICAgICAgICB0aGUgcHJldmlvdXMgb25lIGlzIHN0aWxsIHZpc2li bGUsIHRoZSB0ZXh0IG9mIHRoZSB0b29sdGlwIGlzCisgICAgICAgIHVwZGF0ZWQgYnV0IGl0cyBw b3NpdGlvbiBkb2Vzbid0IGNoYW5nZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudDo6bW91c2VEaWRN b3ZlT3ZlckVsZW1lbnQpOgorICAgICAgICAqIHdlYmtpdC93ZWJraXRwcml2YXRlLmg6CisgICAg ICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3 X3F1ZXJ5X3Rvb2x0aXApOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X3NldF90b29sdGlwX2Fy ZWEpOgorCiAyMDEwLTExLTE2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAgYi9XZWJLaXQv Z3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKaW5kZXggZDYzMzE3Yy4uY2M3 NWFhZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRH dGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNw cApAQCAtNTIwLDYgKzUyMCwxMCBAQCB2b2lkIENocm9tZUNsaWVudDo6bW91c2VEaWRNb3ZlT3Zl ckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYgaGl0LCB1bnNpZ25lZCBtbwogICAgICAgICBn X3NpZ25hbF9lbWl0X2J5X25hbWUobV93ZWJWaWV3LCAiaG92ZXJpbmctb3Zlci1saW5rIiwgMCwg MCk7CiAgICAgICAgIG1faG92ZXJlZExpbmtVUkwgPSBLVVJMKCk7CiAgICAgfQorICAgIGlmIChO b2RlKiBub2RlID0gaGl0LmlubmVyTm9uU2hhcmVkTm9kZSgpKQorICAgICAgICB3ZWJraXRfd2Vi X3ZpZXdfc2V0X3Rvb2x0aXBfYXJlYShtX3dlYlZpZXcsIG5vZGUtPmdldFJlY3QoKSk7CisgICAg ZWxzZQorICAgICAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3Rvb2x0aXBfYXJlYShtX3dlYlZpZXcs IEludFJlY3QoKSk7CiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50OjpzZXRUb29sVGlwKGNvbnN0IFN0 cmluZyYgdG9vbFRpcCwgVGV4dERpcmVjdGlvbikKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHByaXZhdGUuaCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuaApp bmRleCA3Mzg1Njc3Li4xOGE1ZmU1IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXRwcml2YXRlLmgKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0cHJpdmF0ZS5oCkBAIC01 NSw2ICs1NSw3IEBACiAjaW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIKICNpbmNsdWRlICJJbnNwZWN0 b3JDbGllbnRHdGsuaCIKICNpbmNsdWRlICJJbnRQb2ludC5oIgorI2luY2x1ZGUgIkludFJlY3Qu aCIKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIkZ1bGxzY3JlZW5W aWRlb0NvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJOb2RlLmgiCkBAIC0xODEsNiArMTgyLDcgQEAg ZXh0ZXJuICJDIiB7CiAgICAgICAgIENTdHJpbmcgbWFpblJlc291cmNlSWRlbnRpZmllcjsKICAg ICAgICAgUGxhdGZvcm1SZWZQdHI8R0hhc2hUYWJsZT4gc3ViUmVzb3VyY2VzOwogICAgICAgICBD U3RyaW5nIHRvb2x0aXBUZXh0OworICAgICAgICBXZWJDb3JlOjpJbnRSZWN0IHRvb2x0aXBBcmVh OwogCiAgICAgICAgIGludCBjdXJyZW50Q2xpY2tDb3VudDsKICAgICAgICAgV2ViQ29yZTo6SW50 UG9pbnQgcHJldmlvdXNDbGlja1BvaW50OwpAQCAtMjk2LDYgKzI5OCw5IEBAIGV4dGVybiAiQyIg ewogICAgIHZvaWQKICAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3Rvb2x0aXBfdGV4dChXZWJLaXRX ZWJWaWV3KiwgY29uc3QgY2hhciopOwogCisgICAgdm9pZAorICAgIHdlYmtpdF93ZWJfdmlld19z ZXRfdG9vbHRpcF9hcmVhKFdlYktpdFdlYlZpZXcqLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7 CisKICAgICBHdGtNZW51KgogICAgIHdlYmtpdF93ZWJfdmlld19nZXRfY29udGV4dF9tZW51KFdl YktpdFdlYlZpZXcqKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi dmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCA5YmRk NGI3Li4wMjUwNjg4IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3 LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTYzNyw2 ICsxNjM3LDEzIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfcXVlcnlfdG9vbHRp cChHdGtXaWRnZXQgKndpZGdldCwgZ2ludCB4LCBnaW50IHksCiAgICAgV2ViS2l0V2ViVmlld1By aXZhdGUqIHByaXYgPSBXRUJLSVRfV0VCX1ZJRVdfR0VUX1BSSVZBVEUod2lkZ2V0KTsKIAogICAg IGlmIChwcml2LT50b29sdGlwVGV4dC5sZW5ndGgoKSA+IDApIHsKKyAgICAgICAgaWYgKCFrZXli b2FyZF9tb2RlKSB7CisgICAgICAgICAgICBpZiAoIXByaXYtPnRvb2x0aXBBcmVhLmlzRW1wdHko KSkgeworICAgICAgICAgICAgICAgIEdka1JlY3RhbmdsZSBhcmVhID0gcHJpdi0+dG9vbHRpcEFy ZWE7CisgICAgICAgICAgICAgICAgZ3RrX3Rvb2x0aXBfc2V0X3RpcF9hcmVhKHRvb2x0aXAsICZh cmVhKTsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIGd0a190b29sdGlwX3Nl dF90aXBfYXJlYSh0b29sdGlwLCBOVUxMKTsKKyAgICAgICAgfQogICAgICAgICBndGtfdG9vbHRp cF9zZXRfdGV4dCh0b29sdGlwLCBwcml2LT50b29sdGlwVGV4dC5kYXRhKCkpOwogICAgICAgICBy ZXR1cm4gVFJVRTsKICAgICB9CkBAIC00NzMzLDYgKzQ3NDAsMTkgQEAgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfc2V0X3Rvb2x0aXBfdGV4dChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBjb25zdCBjaGFy KiB0b29sdGkKICNlbmRpZgogfQogCit2b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfdG9vbHRpcF9h cmVhKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IEludFJlY3QmIGFyZWEpCit7CisjaWYg R1RLX0NIRUNLX1ZFUlNJT04oMiwgMTIsIDApCisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHBy aXYgPSB3ZWJWaWV3LT5wcml2OworICAgIHByaXYtPnRvb2x0aXBBcmVhID0gYXJlYTsKKyAgICAv LyBxdWVyeS10b29sdGlwIHdpbGwgYmUgdHJpZ2dlcmVkIGJ5IHdlYmtpdF93ZWJfdmlld19zZXRf dG9vbHRpcF90ZXh0KCkuCisjZWxzZQorICAgIC8vIFRPRE86IFN1cHBvcnQgb2xkZXIgR1RLKyB2 ZXJzaW9ucworICAgIC8vIFNlZSBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTc5MworICAgIG5vdEltcGxlbWVudGVkKCk7CisjZW5kaWYKK30KKwogLyoqCiAgKiB3ZWJr aXRfd2ViX3ZpZXdfZ2V0X2hpdF90ZXN0X3Jlc3VsdDoKICAqIEB3ZWJWaWV3OiBhICNXZWJLaXRX ZWJWaWV3Cg== 74531 2010-11-22 00:25:56 -0800 2010-11-23 12:35:51 -0800 Updated patch tooltips-area2.diff text/plain 3181 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYmMwMGI4NS4uZjAwMDU3YiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMS0yMiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZm9jdXMgaXNzdWUgd2l0aCBsaW5r cyB0aGF0IGhhdmUgdG9vbHRpcHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ5NDk4CisKKyAgICAgICAgU2V0IHRoZSBhcmVhIG9mIHRoZSB3aWRnZXQg d2hlcmUgdGhlIHRvb2x0aXAgc2hvdWxkIGJlIHNob3duIHdoZW4KKyAgICAgICAgYSBuZXcgdG9v bHRpcCBpcyBzZXQuIFNpbmNlIHRoZSB3aWRnZXQgaXMgdGhlIHNhbWUgKHRoZSB2aWV3KSwgaWYK KyAgICAgICAgdGhlIHRvb2x0aXAgYXJlYSBpcyBub3Qgc2V0IGFuZCBhIG5ldyB0b29sdGlwIGlz IHRyaWdnZXJlZCB3aGlsZQorICAgICAgICB0aGUgcHJldmlvdXMgb25lIGlzIHN0aWxsIHZpc2li bGUsIHRoZSB0ZXh0IG9mIHRoZSB0b29sdGlwIGlzCisgICAgICAgIHVwZGF0ZWQgYnV0IGl0cyBw b3NpdGlvbiBkb2Vzbid0IGNoYW5nZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudDo6bW91c2VEaWRN b3ZlT3ZlckVsZW1lbnQpOgorICAgICAgICAqIHdlYmtpdC93ZWJraXRwcml2YXRlLmg6CisgICAg ICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3 X3F1ZXJ5X3Rvb2x0aXApOgorCiAyMDEwLTExLTE4ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAgYi9XZWJLaXQv Z3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKaW5kZXggZDYzMzE3Yy4uMWI0 MzJkMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRH dGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNw cApAQCAtNTIwLDYgKzUyMCwxMCBAQCB2b2lkIENocm9tZUNsaWVudDo6bW91c2VEaWRNb3ZlT3Zl ckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYgaGl0LCB1bnNpZ25lZCBtbwogICAgICAgICBn X3NpZ25hbF9lbWl0X2J5X25hbWUobV93ZWJWaWV3LCAiaG92ZXJpbmctb3Zlci1saW5rIiwgMCwg MCk7CiAgICAgICAgIG1faG92ZXJlZExpbmtVUkwgPSBLVVJMKCk7CiAgICAgfQorCisgICAgV2Vi S2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSBtX3dlYlZpZXctPnByaXY7CisgICAgTm9kZSogbm9k ZSA9IGhpdC5pbm5lck5vblNoYXJlZE5vZGUoKTsKKyAgICBwcml2LT50b29sdGlwQXJlYSA9IG5v ZGUgPyBub2RlLT5nZXRSZWN0KCkgOiBJbnRSZWN0KCk7CiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50 OjpzZXRUb29sVGlwKGNvbnN0IFN0cmluZyYgdG9vbFRpcCwgVGV4dERpcmVjdGlvbikKZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuaCBiL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHByaXZhdGUuaAppbmRleCA3Mzg1Njc3Li5lMDkwZWQ0IDEwMDY0NAotLS0gYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmgKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0cHJpdmF0ZS5oCkBAIC01NSw2ICs1NSw3IEBACiAjaW5jbHVkZSAiSGlzdG9yeUl0ZW0u aCIKICNpbmNsdWRlICJJbnNwZWN0b3JDbGllbnRHdGsuaCIKICNpbmNsdWRlICJJbnRQb2ludC5o IgorI2luY2x1ZGUgIkludFJlY3QuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgog I2luY2x1ZGUgIkZ1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJOb2RlLmgi CkBAIC0xODEsNiArMTgyLDcgQEAgZXh0ZXJuICJDIiB7CiAgICAgICAgIENTdHJpbmcgbWFpblJl c291cmNlSWRlbnRpZmllcjsKICAgICAgICAgUGxhdGZvcm1SZWZQdHI8R0hhc2hUYWJsZT4gc3Vi UmVzb3VyY2VzOwogICAgICAgICBDU3RyaW5nIHRvb2x0aXBUZXh0OworICAgICAgICBXZWJDb3Jl OjpJbnRSZWN0IHRvb2x0aXBBcmVhOwogCiAgICAgICAgIGludCBjdXJyZW50Q2xpY2tDb3VudDsK ICAgICAgICAgV2ViQ29yZTo6SW50UG9pbnQgcHJldmlvdXNDbGlja1BvaW50OwpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAwZGMxOWYzLi5lZDYxNTE2IDEwMDY0NAotLS0gYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTYzNyw2ICsxNjM3LDEzIEBAIHN0YXRpYyBnYm9vbGVh biB3ZWJraXRfd2ViX3ZpZXdfcXVlcnlfdG9vbHRpcChHdGtXaWRnZXQgKndpZGdldCwgZ2ludCB4 LCBnaW50IHksCiAgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSBXRUJLSVRfV0VCX1ZJ RVdfR0VUX1BSSVZBVEUod2lkZ2V0KTsKIAogICAgIGlmIChwcml2LT50b29sdGlwVGV4dC5sZW5n dGgoKSA+IDApIHsKKyAgICAgICAgaWYgKCFrZXlib2FyZF9tb2RlKSB7CisgICAgICAgICAgICBp ZiAoIXByaXYtPnRvb2x0aXBBcmVhLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgICAgIEdka1Jl Y3RhbmdsZSBhcmVhID0gcHJpdi0+dG9vbHRpcEFyZWE7CisgICAgICAgICAgICAgICAgZ3RrX3Rv b2x0aXBfc2V0X3RpcF9hcmVhKHRvb2x0aXAsICZhcmVhKTsKKyAgICAgICAgICAgIH0gZWxzZQor ICAgICAgICAgICAgICAgIGd0a190b29sdGlwX3NldF90aXBfYXJlYSh0b29sdGlwLCAwKTsKKyAg ICAgICAgfQogICAgICAgICBndGtfdG9vbHRpcF9zZXRfdGV4dCh0b29sdGlwLCBwcml2LT50b29s dGlwVGV4dC5kYXRhKCkpOwogICAgICAgICByZXR1cm4gVFJVRTsKICAgICB9Cg==