49496 2010-11-13 11:57:41 -0800 broken-ideographic-font.html is failing on Mac 2010-11-13 13:17:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hyatt hyatt abarth eric webkit.review.bot oldest_to_newest 308995 0 hyatt 2010-11-13 11:57:41 -0800 broken-ideographic-font.html is failing on Mac. 308996 1 73829 hyatt 2010-11-13 11:58:05 -0800 Created attachment 73829 Patch 308997 2 webkit.review.bot 2010-11-13 12:00:10 -0800 Attachment 73829 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp']" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 308999 3 hyatt 2010-11-13 12:00:45 -0800 Fixed in r71972. 309001 4 73829 mitz 2010-11-13 12:06:04 -0800 Comment on attachment 73829 Patch tabs in the change log 309008 5 webkit.review.bot 2010-11-13 13:17:27 -0800 http://trac.webkit.org/changeset/71972 might have broken SnowLeopard Intel Release (Tests) 73829 2010-11-13 11:58:05 -0800 2010-11-13 12:06:04 -0800 Patch patch.txt text/plain 3118 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTk3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTEtMTMgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBi cm9rZW4taWRlb2dyYXBoaWMtZm9udC5odG1sLiAgSSBoYWQgdGhlIGZvbnQgaW5zdGFsbGVkIGxv Y2FsbHkgb24gbXkgbWFjaGluZSwgYW5kIHRoaXMgY292ZXJlZCB1cAorCXRoZSBmYWN0IHRoYXQg Q29yZVRleHQgd2FzIGltcGxpY2l0bHkgdXNpbmcgaXQgYXMgZmFsbGJhY2sgaW4gdGhlIHZlcnRp Y2FsIGNhc2Ugb25seS4gIFRoZSBib3RzIGRvbid0IGhhdmUKKwl0aGUgZm9udCBpbnN0YWxsZWQg bG9jYWxseSwgYW5kIHNvIHRoZXkgc2hvd2VkIHRoZSBidWcuCisKKyAgICAgICAgTWFrZSBzdXJl IHRoZSBHbHlwaFBhZ2UgaXMgZmlsbGVkIHdpdGggaG9yaXpvbnRhbCBnbHlwaHMgZm9yIGEgYnJv a2VuIGlkZW9ncmFwaCBmb250LCBzbyB0aGF0IENvcmVUZXh0IGlzCisgICAgICAgIHdpbGxpbmcg dG8gZmlsbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250RGF0 YUNvcmVUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUZvbnREYXRhOjpnZXRDRlN0 cmluZ0F0dHJpYnV0ZXMpOgorCiAyMDEwLTExLTEzICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3Jl VGV4dC5jcHAJKHJldmlzaW9uIDcxODUxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDE0ICs2 MCwxNCBAQCBDRkRpY3Rpb25hcnlSZWYgU2ltcGxlRm9udERhdGE6OmdldENGU3RyCiAgICAgICAg IHN0YXRpYyBDRk51bWJlclJlZiBrZXJuaW5nQWRqdXN0bWVudCA9IENGTnVtYmVyQ3JlYXRlKGtD RkFsbG9jYXRvckRlZmF1bHQsIGtDRk51bWJlckZsb2F0VHlwZSwgJmtlcm5pbmdBZGp1c3RtZW50 VmFsdWUpOwogICAgICAgICBzdGF0aWMgY29uc3Qgdm9pZCoga2V5c1dpdGhLZXJuaW5nRGlzYWJs ZWRbXSA9IHsga0NURm9udEF0dHJpYnV0ZU5hbWUsIGtDVEtlcm5BdHRyaWJ1dGVOYW1lLCBrQ1RM aWdhdHVyZUF0dHJpYnV0ZU5hbWUsIGtDVFZlcnRpY2FsRm9ybXNBdHRyaWJ1dGVOYW1lIH07CiAg ICAgICAgIGNvbnN0IHZvaWQqIHZhbHVlc1dpdGhLZXJuaW5nRGlzYWJsZWRbXSA9IHsgcGxhdGZv cm1EYXRhKCkuY3RGb250KCksIGtlcm5pbmdBZGp1c3RtZW50LCBhbGxvd0xpZ2F0dXJlcwotICAg ICAgICAgICAgPyBsaWdhdHVyZXNBbGxvd2VkIDogbGlnYXR1cmVzTm90QWxsb3dlZCwgcGxhdGZv cm1EYXRhKCkub3JpZW50YXRpb24oKSA9PSBWZXJ0aWNhbCA/IGtDRkJvb2xlYW5UcnVlIDoga0NG Qm9vbGVhbkZhbHNlIH07CisgICAgICAgICAgICA/IGxpZ2F0dXJlc0FsbG93ZWQgOiBsaWdhdHVy ZXNOb3RBbGxvd2VkLCBvcmllbnRhdGlvbigpID09IFZlcnRpY2FsID8ga0NGQm9vbGVhblRydWUg OiBrQ0ZCb29sZWFuRmFsc2UgfTsKICAgICAgICAgYXR0cmlidXRlc0RpY3Rpb25hcnkuYWRvcHRD RihDRkRpY3Rpb25hcnlDcmVhdGUoMCwga2V5c1dpdGhLZXJuaW5nRGlzYWJsZWQsIHZhbHVlc1dp dGhLZXJuaW5nRGlzYWJsZWQsCiAgICAgICAgICAgICBzaXplb2Yoa2V5c1dpdGhLZXJuaW5nRGlz YWJsZWQpIC8gc2l6ZW9mKCprZXlzV2l0aEtlcm5pbmdEaXNhYmxlZCksCiAgICAgICAgICAgICAm a0NGQ29weVN0cmluZ0RpY3Rpb25hcnlLZXlDYWxsQmFja3MsICZrQ0ZUeXBlRGljdGlvbmFyeVZh bHVlQ2FsbEJhY2tzKSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8gQnkgb21pdHRpbmcgdGhl IGtDVEtlcm5BdHRyaWJ1dGVOYW1lIGF0dHJpYnV0ZSwgd2UgZ2V0IENvcmUgVGV4dCdzIHN0YW5k YXJkIGtlcm5pbmcuCiAgICAgICAgIHN0YXRpYyBjb25zdCB2b2lkKiBrZXlzV2l0aEtlcm5pbmdF bmFibGVkW10gPSB7IGtDVEZvbnRBdHRyaWJ1dGVOYW1lLCBrQ1RMaWdhdHVyZUF0dHJpYnV0ZU5h bWUsIGtDVFZlcnRpY2FsRm9ybXNBdHRyaWJ1dGVOYW1lIH07Ci0gICAgICAgIGNvbnN0IHZvaWQq IHZhbHVlc1dpdGhLZXJuaW5nRW5hYmxlZFtdID0geyBwbGF0Zm9ybURhdGEoKS5jdEZvbnQoKSwg YWxsb3dMaWdhdHVyZXMgPyBsaWdhdHVyZXNBbGxvd2VkIDogbGlnYXR1cmVzTm90QWxsb3dlZCwg cGxhdGZvcm1EYXRhKCkub3JpZW50YXRpb24oKSA9PSBWZXJ0aWNhbCA/IGtDRkJvb2xlYW5UcnVl IDoga0NGQm9vbGVhbkZhbHNlIH07CisgICAgICAgIGNvbnN0IHZvaWQqIHZhbHVlc1dpdGhLZXJu aW5nRW5hYmxlZFtdID0geyBwbGF0Zm9ybURhdGEoKS5jdEZvbnQoKSwgYWxsb3dMaWdhdHVyZXMg PyBsaWdhdHVyZXNBbGxvd2VkIDogbGlnYXR1cmVzTm90QWxsb3dlZCwgb3JpZW50YXRpb24oKSA9 PSBWZXJ0aWNhbCA/IGtDRkJvb2xlYW5UcnVlIDoga0NGQm9vbGVhbkZhbHNlIH07CiAgICAgICAg IGF0dHJpYnV0ZXNEaWN0aW9uYXJ5LmFkb3B0Q0YoQ0ZEaWN0aW9uYXJ5Q3JlYXRlKDAsIGtleXNX aXRoS2VybmluZ0VuYWJsZWQsIHZhbHVlc1dpdGhLZXJuaW5nRW5hYmxlZCwKICAgICAgICAgICAg IHNpemVvZihrZXlzV2l0aEtlcm5pbmdFbmFibGVkKSAvIHNpemVvZigqa2V5c1dpdGhLZXJuaW5n RW5hYmxlZCksCiAgICAgICAgICAgICAma0NGQ29weVN0cmluZ0RpY3Rpb25hcnlLZXlDYWxsQmFj a3MsICZrQ0ZUeXBlRGljdGlvbmFyeVZhbHVlQ2FsbEJhY2tzKSk7Cg==