49484 2010-11-12 16:28:27 -0800 Some FrameLoader.h Cleanup 2010-11-12 17:40:10 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned abarth ap commit-queue ddkilzer joepeck oldest_to_newest 308831 0 joepeck 2010-11-12 16:28:27 -0800 Cleanup some unimplemented functions and unused variables. 308838 1 73791 joepeck 2010-11-12 16:40:45 -0800 Created attachment 73791 [PATCH] Proposed Change Removed unimplemented functions and an unused debug variable. 308855 2 73791 ap 2010-11-12 16:59:58 -0800 Comment on attachment 73791 [PATCH] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=73791&action=review > WebCore/ChangeLog:23 > + Removed function signatures without any implementation. The functions > + used to exist, and were nicely refactored into PageCache in r60688 and > + the signatures were left behind. > + > + Removed function signature setLoadType. Added in r17238 back when the > + file was named WebFrameLoader, and the implementation was lost during > + the transition from its mm implementation. > + > + Removed function signature updateHistoryAfterClientRedirect. Implementation > + and call points were removed in r18541 but the signature was left behind, > + and jumped files! > + > + Removed unused debug variable m_didDispatchDidCommitLoad. It was added > + and used in Assertions in r28399. It was removed soon after, in r28464 > + because they were, "firing like crazy. Not sure why yet." It was > + never used again. I'd probably put this in the bug, not ChangeLog. But it's nothing compared to the fact that you actually investigated the history in such detail, that's really nice. 308874 3 commit-queue 2010-11-12 17:37:13 -0800 The commit-queue encountered the following flaky tests while processing attachment 73791: http/tests/appcache/insert-html-element-with-manifest-2.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. 308877 4 73791 commit-queue 2010-11-12 17:40:03 -0800 Comment on attachment 73791 [PATCH] Proposed Change Clearing flags on attachment: 73791 Committed r71959: <http://trac.webkit.org/changeset/71959> 308878 5 commit-queue 2010-11-12 17:40:10 -0800 All reviewed patches have been landed. Closing bug. 73791 2010-11-12 16:40:45 -0800 2010-11-12 17:40:03 -0800 [PATCH] Proposed Change cleanup-1.patch text/plain 5929 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjQ0ZTAwZC4uNDI5ZDdkMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzNyBAQAorMjAxMC0xMS0xMiAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNvbWUgRnJhbWVMb2FkZXIuaCBDbGVhbnVwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTQ4NAorCisgICAgICAgIFJl bW92ZWQgZnVuY3Rpb24gc2lnbmF0dXJlcyB3aXRob3V0IGFueSBpbXBsZW1lbnRhdGlvbi4gVGhl IGZ1bmN0aW9ucworICAgICAgICB1c2VkIHRvIGV4aXN0LCBhbmQgd2VyZSBuaWNlbHkgcmVmYWN0 b3JlZCBpbnRvIFBhZ2VDYWNoZSBpbiByNjA2ODggYW5kCisgICAgICAgIHRoZSBzaWduYXR1cmVz IHdlcmUgbGVmdCBiZWhpbmQuCisKKyAgICAgICAgUmVtb3ZlZCBmdW5jdGlvbiBzaWduYXR1cmUg c2V0TG9hZFR5cGUuIEFkZGVkIGluIHIxNzIzOCBiYWNrIHdoZW4gdGhlCisgICAgICAgIGZpbGUg d2FzIG5hbWVkIFdlYkZyYW1lTG9hZGVyLCBhbmQgdGhlIGltcGxlbWVudGF0aW9uIHdhcyBsb3N0 IGR1cmluZworICAgICAgICB0aGUgdHJhbnNpdGlvbiBmcm9tIGl0cyBtbSBpbXBsZW1lbnRhdGlv bi4KKworICAgICAgICBSZW1vdmVkIGZ1bmN0aW9uIHNpZ25hdHVyZSB1cGRhdGVIaXN0b3J5QWZ0 ZXJDbGllbnRSZWRpcmVjdC4gSW1wbGVtZW50YXRpb24KKyAgICAgICAgYW5kIGNhbGwgcG9pbnRz IHdlcmUgcmVtb3ZlZCBpbiByMTg1NDEgYnV0IHRoZSBzaWduYXR1cmUgd2FzIGxlZnQgYmVoaW5k LAorICAgICAgICBhbmQganVtcGVkIGZpbGVzIQorCisgICAgICAgIFJlbW92ZWQgdW51c2VkIGRl YnVnIHZhcmlhYmxlIG1fZGlkRGlzcGF0Y2hEaWRDb21taXRMb2FkLiBJdCB3YXMgYWRkZWQKKyAg ICAgICAgYW5kIHVzZWQgaW4gQXNzZXJ0aW9ucyBpbiByMjgzOTkuIEl0IHdhcyByZW1vdmVkIHNv b24gYWZ0ZXIsIGluIHIyODQ2NAorICAgICAgICBiZWNhdXNlIHRoZXkgd2VyZSwgImZpcmluZyBs aWtlIGNyYXp5LiBOb3Qgc3VyZSB3aHkgeWV0LiIgSXQgd2FzCisgICAgICAgIG5ldmVyIHVzZWQg YWdhaW4uCisKKyAgICAgICAgQWRkZWQgY29uc3QgcXVhbGlmaWVyIGFuZCBtb3ZlZCBpbnRlcnJ1 cHRpb25Gb3JQb2xpY3lDaGFuZ2VFcnJvciB0bworICAgICAgICBiZSBtb3JlIGxpa2UgaXRzIGJ1 ZGRpZXMuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OkZyYW1lTG9hZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l TG9hZGVyOjpjaGVja0xvYWRDb21wbGV0ZUZvclRoaXNGcmFtZSk6CisgICAgICAgIChXZWJDb3Jl OjpGcmFtZUxvYWRlcjo6aW50ZXJydXB0aW9uRm9yUG9saWN5Q2hhbmdlRXJyb3IpOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmRpc3BhdGNoRGlkQ29tbWl0TG9hZCk6CisgICAgICAg ICogbG9hZGVyL0ZyYW1lTG9hZGVyLmg6CisKIDIwMTAtMTAtMTUgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9h ZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBjNDhjYTMwLi5lNDhmMWRiIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVM b2FkZXIuY3BwCkBAIC0yMDIsOSArMjAyLDYgQEAgRnJhbWVMb2FkZXI6OkZyYW1lTG9hZGVyKEZy YW1lKiBmcmFtZSwgRnJhbWVMb2FkZXJDbGllbnQqIGNsaWVudCkKICAgICAsIG1fc3VwcHJlc3NP cGVuZXJJbk5ld0ZyYW1lKGZhbHNlKQogICAgICwgbV9zYW5kYm94RmxhZ3MoU2FuZGJveEFsbCkK ICAgICAsIG1fZm9yY2VkU2FuZGJveEZsYWdzKFNhbmRib3hOb25lKQotI2lmbmRlZiBOREVCVUcK LSAgICAsIG1fZGlkRGlzcGF0Y2hEaWRDb21taXRMb2FkKGZhbHNlKQotI2VuZGlmCiB7CiB9CiAK QEAgLTE1MTEsMTEgKzE1MDgsNiBAQCBib29sIEZyYW1lTG9hZGVyOjp3aWxsTG9hZE1lZGlhRWxl bWVudFVSTChLVVJMJiB1cmwpCiAgICAgcmV0dXJuIGVycm9yLmlzTnVsbCgpOwogfQogCi1SZXNv dXJjZUVycm9yIEZyYW1lTG9hZGVyOjppbnRlcnJ1cHRpb25Gb3JQb2xpY3lDaGFuZ2VFcnJvcihj b25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCi17Ci0gICAgcmV0dXJuIG1fY2xpZW50LT5p bnRlcnJ1cHRGb3JQb2xpY3lDaGFuZ2VFcnJvcihyZXF1ZXN0KTsKLX0KLQogYm9vbCBGcmFtZUxv YWRlcjo6c2hvdWxkUmVsb2FkVG9IYW5kbGVVbnJlYWNoYWJsZVVSTChEb2N1bWVudExvYWRlciog ZG9jTG9hZGVyKQogewogICAgIEtVUkwgdW5yZWFjaGFibGVVUkwgPSBkb2NMb2FkZXItPnVucmVh Y2hhYmxlVVJMKCk7CkBAIC0yNDE4LDkgKzI0MTAsNiBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjaGVj a0xvYWRDb21wbGV0ZUZvclRoaXNGcmFtZSgpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCiAg ICAgICAgICAgICBjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvciA9IGRsLT5tYWluRG9jdW1lbnRF cnJvcigpOwotI2lmbmRlZiBOREVCVUcKLSAgICAgICAgICAgIG1fZGlkRGlzcGF0Y2hEaWRDb21t aXRMb2FkID0gZmFsc2U7Ci0jZW5kaWYKICAgICAgICAgICAgIGlmICghZXJyb3IuaXNOdWxsKCkp CiAgICAgICAgICAgICAgICAgbV9jbGllbnQtPmRpc3BhdGNoRGlkRmFpbExvYWQoZXJyb3IpOwog ICAgICAgICAgICAgZWxzZQpAQCAtMzMwNCw2ICszMjkzLDExIEBAIFJlc291cmNlRXJyb3IgRnJh bWVMb2FkZXI6OmNhbm5vdFNob3dVUkxFcnJvcihjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QpIGNvCiAgICAgcmV0dXJuIG1fY2xpZW50LT5jYW5ub3RTaG93VVJMRXJyb3IocmVxdWVzdCk7 CiB9CiAKK1Jlc291cmNlRXJyb3IgRnJhbWVMb2FkZXI6OmludGVycnVwdGlvbkZvclBvbGljeUNo YW5nZUVycm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkgY29uc3QKK3sKKyAgICBy ZXR1cm4gbV9jbGllbnQtPmludGVycnVwdEZvclBvbGljeUNoYW5nZUVycm9yKHJlcXVlc3QpOwor fQorCiBSZXNvdXJjZUVycm9yIEZyYW1lTG9hZGVyOjpmaWxlRG9lc05vdEV4aXN0RXJyb3IoY29u c3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fY2xp ZW50LT5maWxlRG9lc05vdEV4aXN0RXJyb3IocmVzcG9uc2UpOyAgICAKQEAgLTM0MTgsMTAgKzM0 MTIsNiBAQCB2b2lkIEZyYW1lTG9hZGVyOjpkaXNwYXRjaERpZENvbW1pdExvYWQoKQogICAgIGlm IChtX3N0YXRlTWFjaGluZS5jcmVhdGluZ0luaXRpYWxFbXB0eURvY3VtZW50KCkpCiAgICAgICAg IHJldHVybjsKIAotI2lmbmRlZiBOREVCVUcKLSAgICBtX2RpZERpc3BhdGNoRGlkQ29tbWl0TG9h ZCA9IHRydWU7Ci0jZW5kaWYKLQogICAgIG1fY2xpZW50LT5kaXNwYXRjaERpZENvbW1pdExvYWQo KTsKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5oIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAppbmRleCA5ZWJlZjI5 Li43NmFkOTc3IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCisrKyBi L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKQEAgLTE2Nyw3ICsxNjcsNyBAQCBwdWJsaWM6 CiAgICAgUmVzb3VyY2VFcnJvciBmaWxlRG9lc05vdEV4aXN0RXJyb3IoY29uc3QgUmVzb3VyY2VS ZXNwb25zZSYpIGNvbnN0OwogICAgIFJlc291cmNlRXJyb3IgYmxvY2tlZEVycm9yKGNvbnN0IFJl c291cmNlUmVxdWVzdCYpIGNvbnN0OwogICAgIFJlc291cmNlRXJyb3IgY2Fubm90U2hvd1VSTEVy cm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYpIGNvbnN0OwotICAgIFJlc291cmNlRXJyb3IgaW50 ZXJydXB0aW9uRm9yUG9saWN5Q2hhbmdlRXJyb3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0Jik7Cisg ICAgUmVzb3VyY2VFcnJvciBpbnRlcnJ1cHRpb25Gb3JQb2xpY3lDaGFuZ2VFcnJvcihjb25zdCBS ZXNvdXJjZVJlcXVlc3QmKSBjb25zdDsKIAogICAgIGJvb2wgaXNIb3N0ZWRCeU9iamVjdEVsZW1l bnQoKSBjb25zdDsKICAgICBib29sIGlzTG9hZGluZ01haW5GcmFtZSgpIGNvbnN0OwpAQCAtMzM0 LDEyICszMzQsNiBAQCBwdWJsaWM6CiAgICAgTmV0d29ya2luZ0NvbnRleHQqIG5ldHdvcmtpbmdD b250ZXh0KCkgY29uc3Q7CiAKIHByaXZhdGU6Ci0gICAgYm9vbCBjYW5DYWNoZVBhZ2VDb250YWlu aW5nVGhpc0ZyYW1lKCk7Ci0jaWZuZGVmIE5ERUJVRwotICAgIHZvaWQgbG9nQ2FuQ2FjaGVQYWdl RGVjaXNpb24oKTsKLSAgICBib29sIGxvZ0NhbkNhY2hlRnJhbWVEZWNpc2lvbihpbnQgaW5kZW50 TGV2ZWwpOwotI2VuZGlmCi0KICAgICB2b2lkIGNoZWNrVGltZXJGaXJlZChUaW1lcjxGcmFtZUxv YWRlcj4qKTsKICAgICAKICAgICB2b2lkIG5hdmlnYXRlV2l0aGluRG9jdW1lbnQoSGlzdG9yeUl0 ZW0qKTsKQEAgLTM2NCw4ICszNTgsNiBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBtYWluUmVjZWl2 ZWRFcnJvcihjb25zdCBSZXNvdXJjZUVycm9yJiwgYm9vbCBpc0NvbXBsZXRlKTsKIAotICAgIHZv aWQgc2V0TG9hZFR5cGUoRnJhbWVMb2FkVHlwZSk7Ci0KICAgICBzdGF0aWMgdm9pZCBjYWxsQ29u dGludWVMb2FkQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5KHZvaWQqLCBjb25zdCBSZXNvdXJjZVJlcXVl c3QmLCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGJvb2wgc2hvdWxkQ29udGludWUpOwogICAgIHN0 YXRpYyB2b2lkIGNhbGxDb250aW51ZUxvYWRBZnRlck5ld1dpbmRvd1BvbGljeSh2b2lkKiwgY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiwgUGFzc1JlZlB0cjxGb3JtU3RhdGU+LCBjb25zdCBTdHJpbmcm IGZyYW1lTmFtZSwgY29uc3QgTmF2aWdhdGlvbkFjdGlvbiYsIGJvb2wgc2hvdWxkQ29udGludWUp OwogICAgIHN0YXRpYyB2b2lkIGNhbGxDb250aW51ZUZyYWdtZW50U2Nyb2xsQWZ0ZXJOYXZpZ2F0 aW9uUG9saWN5KHZvaWQqLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBQYXNzUmVmUHRyPEZvcm1T dGF0ZT4sIGJvb2wgc2hvdWxkQ29udGludWUpOwpAQCAtMzg3LDggKzM3OSw2IEBAIHByaXZhdGU6 CiAgICAgdm9pZCBjbG9zZU9sZERhdGFTb3VyY2VzKCk7CiAgICAgdm9pZCBwcmVwYXJlRm9yQ2Fj aGVkUGFnZVJlc3RvcmUoKTsKIAotICAgIHZvaWQgdXBkYXRlSGlzdG9yeUFmdGVyQ2xpZW50UmVk aXJlY3QoKTsKLQogICAgIGJvb2wgc2hvdWxkUmVsb2FkVG9IYW5kbGVVbnJlYWNoYWJsZVVSTChE b2N1bWVudExvYWRlciopOwogCiAgICAgdm9pZCBkaXNwYXRjaERpZENvbW1pdExvYWQoKTsKQEAg LTQxOSw4ICs0MDksNiBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBwcm92aXNpb25hbExvYWRTdGFy dGVkKCk7CiAKLSAgICBib29sIGNhbkNhY2hlUGFnZSgpOwotCiAgICAgYm9vbCBkaWRPcGVuVVJM KGNvbnN0IEtVUkwmKTsKIAogICAgIHZvaWQgc2NoZWR1bGVDaGVja0NvbXBsZXRlZCgpOwpAQCAt NDk2LDEwICs0ODQsNiBAQCBwcml2YXRlOgogICAgIFNhbmRib3hGbGFncyBtX3NhbmRib3hGbGFn czsKICAgICBTYW5kYm94RmxhZ3MgbV9mb3JjZWRTYW5kYm94RmxhZ3M7CiAKLSNpZm5kZWYgTkRF QlVHCi0gICAgYm9vbCBtX2RpZERpc3BhdGNoRGlkQ29tbWl0TG9hZDsKLSNlbmRpZgotCiAgICAg UmVmUHRyPEZyYW1lTmV0d29ya2luZ0NvbnRleHQ+IG1fbmV0d29ya2luZ0NvbnRleHQ7CiB9Owog Cg==