49473 2010-11-12 13:45:23 -0800 WebKitCSSMatrix shouldn't inherit from StyleBase 2010-11-12 13:56:41 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap cmarrin simon.fraser oldest_to_newest 308755 0 ap 2010-11-12 13:45:23 -0800 Because it needn't. See StyleBase.h: // Base class for most CSS DOM objects. // FIXME: We don't need these to all share one base class. // Refactor so they don't any more. 308762 1 73774 ap 2010-11-12 13:49:05 -0800 Created attachment 73774 proposed patch 308763 2 73775 ap 2010-11-12 13:49:05 -0800 Created attachment 73775 308772 3 ap 2010-11-12 13:56:41 -0800 Committed <http://trac.webkit.org/changeset/71947>. 73774 2010-11-12 13:49:05 -0800 2010-11-12 13:50:37 -0800 proposed patch WebKitCSSMatrix.txt text/plain 4189 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTk0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTEtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5NDczCisKKyAgICAgICAg Tm8gY2hhbmdlIGluIGJlaGF2aW9yLCBzbyBubyB0ZXN0cy4KKworICAgICAgICAqIGNzcy9XZWJL aXRDU1NNYXRyaXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViS2l0Q1NTTWF0cml4OjpXZWJL aXRDU1NNYXRyaXgpOiBXZSBkb24ndCBpbmhlcml0IGZyb20gU3R5bGVCYXNlIGFueSBtb3JlLCBz bworICAgICAgICBubyBuZWVkIHRvIGluaXRpYWxpemUgYWx3YXlzLW51bGwgcGFyZW50LgorICAg ICAgICAoV2ViQ29yZTo6V2ViS2l0Q1NTTWF0cml4OjpzZXRNYXRyaXhWYWx1ZSk6IFNpbmNlIHRo ZXJlIHdhcyBuZXZlciBhIHBhcmVudCwgdXNlU3RyaWN0UGFyc2luZygpCisgICAgICAgIGp1c3Qg cmV0dXJuZWQgdHJ1ZS4KKworICAgICAgICAqIGNzcy9XZWJLaXRDU1NNYXRyaXguaDogSnVzdCBp bmhlcml0IGZyb20gUmVmQ291bnRlZDxXZWJLaXRDU1NNYXRyaXg+LiBSZW1vdmVkIHVudXNlZCBk ZWZhdWx0CisgICAgICAgIGNvbnN0cnVjdG9yIGFuZCBjb3B5IGNvbnN0cnVjdG9yLgorCisgICAg ICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0Lmg6IFJlbW92ZWQgYW4gdW5u bmVkZWQgZm9yd2FyZCBkZWNsYXJhdGlvbi4KKwogMjAxMC0xMS0xMiAgSGVsZGVyIENvcnJlaWEg IDxoZWxkZXJAc2VuY2hhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5n LgpJbmRleDogV2ViQ29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2Nzcy9XZWJLaXRDU1NNYXRyaXguY3BwCShyZXZpc2lvbiA3MTc2NSkKKysrIFdlYkNv cmUvY3NzL1dlYktpdENTU01hdHJpeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDI1ICszNiwx MiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLVdlYktpdENTU01hdHJpeDo6V2ViS2l0Q1NT TWF0cml4KCkKLSAgICA6IFN0eWxlQmFzZSgwKQotewotfQotCi1XZWJLaXRDU1NNYXRyaXg6Oldl YktpdENTU01hdHJpeChjb25zdCBXZWJLaXRDU1NNYXRyaXgmIG0pCi0gICAgOiBTdHlsZUJhc2Uo MCkKLSAgICAsIG1fbWF0cml4KG0ubV9tYXRyaXgpCi17Ci19Ci0KIFdlYktpdENTU01hdHJpeDo6 V2ViS2l0Q1NTTWF0cml4KGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JiBtKQotICAgIDogU3R5 bGVCYXNlKDApCi0gICAgLCBtX21hdHJpeChtKQorICAgIDogbV9tYXRyaXgobSkKIHsKIH0KIAog V2ViS2l0Q1NTTWF0cml4OjpXZWJLaXRDU1NNYXRyaXgoY29uc3QgU3RyaW5nJiBzLCBFeGNlcHRp b25Db2RlJiBlYykgCi0gICAgOiBTdHlsZUJhc2UoMCkKIHsKICAgICBzZXRNYXRyaXhWYWx1ZShz LCBlYyk7CiB9CkBAIC02NSw3ICs1Miw3IEBAIFdlYktpdENTU01hdHJpeDo6fldlYktpdENTU01h dHJpeCgpCiAKIHZvaWQgV2ViS2l0Q1NTTWF0cml4OjpzZXRNYXRyaXhWYWx1ZShjb25zdCBTdHJp bmcmIHN0cmluZywgRXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgQ1NTUGFyc2VyIHAodXNlU3Ry aWN0UGFyc2luZygpKTsKKyAgICBDU1NQYXJzZXIgcCh0cnVlKTsKICAgICBSZWZQdHI8Q1NTTXV0 YWJsZVN0eWxlRGVjbGFyYXRpb24+IHN0eWxlRGVjbGFyYXRpb24gPSBDU1NNdXRhYmxlU3R5bGVE ZWNsYXJhdGlvbjo6Y3JlYXRlKCk7CiAgICAgaWYgKHAucGFyc2VWYWx1ZShzdHlsZURlY2xhcmF0 aW9uLmdldCgpLCBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybSwgc3RyaW5nLCB0cnVlKSkgewog ICAgICAgICAvLyBDb252ZXJ0IHRvIFRyYW5zZm9ybU9wZXJhdGlvbnMuIFRoaXMgY2FuIGZhaWwg aWYgYSBwcm9wZXJ0eSAKSW5kZXg6IFdlYkNvcmUvY3NzL1dlYktpdENTU01hdHJpeC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvY3NzL1dlYktpdENTU01hdHJpeC5oCShyZXZpc2lvbiA3MTc2NSkK KysrIFdlYkNvcmUvY3NzL1dlYktpdENTU01hdHJpeC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOCwy MyArMjgsMTMgQEAKIAogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJQbGF0 Zm9ybVN0cmluZy5oIgotI2luY2x1ZGUgIlN0eWxlQmFzZS5oIgogI2luY2x1ZGUgIlRyYW5zZm9y bWF0aW9uTWF0cml4LmgiCi0jaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3 dGYvUmVmUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgV2ViS2l0Q1NTTWF0 cml4IDogcHVibGljIFN0eWxlQmFzZSB7CitjbGFzcyBXZWJLaXRDU1NNYXRyaXggOiBwdWJsaWMg UmVmQ291bnRlZDxXZWJLaXRDU1NNYXRyaXg+IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxXZWJLaXRDU1NNYXRyaXg+IGNyZWF0ZSgpCi0gICAgewotICAgICAgICByZXR1cm4gYWRv cHRSZWYobmV3IFdlYktpdENTU01hdHJpeCgpKTsKLSAgICB9Ci0gICAgc3RhdGljIFBhc3NSZWZQ dHI8V2ViS2l0Q1NTTWF0cml4PiBjcmVhdGUoY29uc3QgV2ViS2l0Q1NTTWF0cml4JiBtKQotICAg IHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBXZWJLaXRDU1NNYXRyaXgobSkpOwotICAg IH0KICAgICBzdGF0aWMgUGFzc1JlZlB0cjxXZWJLaXRDU1NNYXRyaXg+IGNyZWF0ZShjb25zdCBU cmFuc2Zvcm1hdGlvbk1hdHJpeCYgbSkKICAgICB7CiAgICAgICAgIHJldHVybiBhZG9wdFJlZihu ZXcgV2ViS2l0Q1NTTWF0cml4KG0pKTsKQEAgLTEwNCw3ICs5NCw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIHNldE00Myhkb3VibGUgZikgeyBtX21hdHJpeC5zZXRNNDMoZik7IH0KICAgICB2b2lkIHNl dE00NChkb3VibGUgZikgeyBtX21hdHJpeC5zZXRNNDQoZik7IH0KICAKLSAgICB2b2lkIHNldE1h dHJpeFZhbHVlKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBFeGNlcHRpb25Db2RlJik7CisgICAgdm9p ZCBzZXRNYXRyaXhWYWx1ZShjb25zdCBTdHJpbmcmLCBFeGNlcHRpb25Db2RlJik7CiAgICAgCiAg ICAgLy8gVGhlIGZvbGxvd2luZyBtYXRoIGZ1bmN0aW9uIHJldHVybiBhIG5ldyBtYXRyaXggd2l0 aCB0aGUgCiAgICAgLy8gc3BlY2lmaWVkIG9wZXJhdGlvbiBhcHBsaWVkLiBUaGUgdGhpcyB2YWx1 ZSBpcyBub3QgbW9kaWZpZWQuCkBAIC0xNDYsOCArMTM2LDYgQEAgcHVibGljOgogICAgIFN0cmlu ZyB0b1N0cmluZygpIGNvbnN0OwogICAgIAogcHJvdGVjdGVkOgotICAgIFdlYktpdENTU01hdHJp eCgpOwotICAgIFdlYktpdENTU01hdHJpeChjb25zdCBXZWJLaXRDU1NNYXRyaXgmKTsKICAgICBX ZWJLaXRDU1NNYXRyaXgoY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmKTsKICAgICBXZWJLaXRD U1NNYXRyaXgoY29uc3QgU3RyaW5nJiwgRXhjZXB0aW9uQ29kZSYpOwogCkluZGV4OiBXZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgJKHJldmlzaW9uIDcxNzY1KQor KysgV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaAkod29ya2luZyBj b3B5KQpAQCAtNTQsNyArNTQsNiBAQCBjbGFzcyBIVE1MVmlkZW9FbGVtZW50OwogY2xhc3MgSW1h Z2VCdWZmZXI7CiBjbGFzcyBJbWFnZURhdGE7CiBjbGFzcyBJbnRTaXplOwotY2xhc3MgV2ViS2l0 Q1NTTWF0cml4OwogCiBjbGFzcyBXZWJHTFJlbmRlcmluZ0NvbnRleHQgOiBwdWJsaWMgQ2FudmFz UmVuZGVyaW5nQ29udGV4dCB7CiBwdWJsaWM6Cg==