49463 2010-11-12 11:43:20 -0800 [V8] Code generation script error in generating the SVGStaticListPropertyTearOff 2010-11-14 11:13:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Linux RESOLVED FIXED P2 Normal --- 0 webkittenghui webkit-unassigned benm commit-queue jorlow kling steveblock webkittenghui oldest_to_newest 308672 0 webkittenghui 2010-11-12 11:43:20 -0800 When trying to merge the webkit r 71558 to android, we found that the some generated .h file is containing declaration wrongly. When the SVGStaticListPropertyTearOff is expected, SVGListPropertyTearOff is generated. This is caused by the CodeGeneratorV8.pm. 308733 1 webkittenghui 2010-11-12 13:26:37 -0800 BTW, I already have the fix ready , just need to run more tests before submitting the change. 308810 2 73783 webkittenghui 2010-11-12 15:29:51 -0800 Created attachment 73783 proposed patch 308837 3 73783 kling 2010-11-12 16:38:11 -0800 Comment on attachment 73783 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=73783&action=review > WebCore/ChangeLog:5 > + Need a short description and bug URL (OOPS!) Oops indeed, this should be replaced by something like: [V8] Code generation script error in generating the SVGStaticListPropertyTearOff https://bugs.webkit.org/show_bug.cgi?id=49463 > WebCore/ChangeLog:7 > + No new tests. (OOPS!) If you're not adding any tests, this should be replaced by something like: No new tests, this is already covered by X, Y and Z. OR No new tests, this is untestable for reason X. Of course, if it's a compile fix, just remove this line. :-) 308840 4 73792 webkittenghui 2010-11-12 16:43:58 -0800 Created attachment 73792 proposed patch, same as previous one, but better formatted patch file This is essentially the same change as the previous patch. I just update the myNewPmPatch.txt to add more info like bug info and change description. Thanks! 308858 5 73792 kling 2010-11-12 17:01:26 -0800 Comment on attachment 73792 proposed patch, same as previous one, but better formatted patch file r=me 308866 6 73792 commit-queue 2010-11-12 17:18:04 -0800 Comment on attachment 73792 proposed patch, same as previous one, but better formatted patch file Rejecting patch 73792 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73792]" exit_code: 2 Last 500 characters of output: ocessing 1 patch from 1 bug. Processing patch 73792 from bug 49463. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog patch: **** unexpected end of file in patch patching file WebCore/bindings/scripts/CodeGeneratorV8.pm Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/5849005 308869 7 webkittenghui 2010-11-12 17:26:42 -0800 Any hint on what could go wrong with the patch file? Thanks! 308871 8 kling 2010-11-12 17:35:08 -0800 (In reply to comment #7) > Any hint on what could go wrong with the patch file? Thanks! Did you manually edit it the patch after creating it? I would have expected "@@ -1,3 +1,86 @@" to be more like "@@ -1,3 +1,15 @@" 308880 9 webkittenghui 2010-11-12 17:44:22 -0800 I only touch the changelog and the lines starting with a "+". I think that will be pretty safe to change. Maybe I have to try to recreate the patch file again then. 309091 10 kling 2010-11-14 11:13:09 -0800 Committed r71984: <http://trac.webkit.org/changeset/71984> 73783 2010-11-12 15:29:51 -0800 2010-11-12 16:38:10 -0800 proposed patch myPmPatch.txt text/plain 1390 webkittenghui SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTk1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMTIgIFRlbmdodWkgWmh1ICA8enRlbmdodWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG06CisKIDIwMTAtMTEtMTIgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNzE5 MzcpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNTIsOCArMjUyLDggQEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgCiAg ICAgcHVzaChAaGVhZGVyQ29udGVudCwgIlxubmFtZXNwYWNlIFdlYkNvcmUge1xuIik7CiAgICAg cHVzaChAaGVhZGVyQ29udGVudCwgIlxudGVtcGxhdGU8dHlwZW5hbWUgUHJvcGVydHlUeXBlPiBj bGFzcyBTVkdQcm9wZXJ0eVRlYXJPZmY7XG4iKSBpZiAkc3ZnUHJvcGVydHlUeXBlOwotICAgIGlm ICgkc3ZnTGlzdFByb3BlcnR5VHlwZSkgewotICAgICAgICBpZiAoJHN2Z0xpc3RQcm9wZXJ0eVR5 cGUgPX4gL1NWR1N0YXRpY0xpc3RQcm9wZXJ0eVRlYXJPZmYvKSB7CisgICAgaWYgKCRzdmdOYXRp dmVUeXBlKSB7CisgICAgICAgIGlmICgkc3ZnTmF0aXZlVHlwZSA9fiAvU1ZHU3RhdGljTGlzdFBy b3BlcnR5VGVhck9mZi8pIHsKICAgICAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICJcbnRl bXBsYXRlPHR5cGVuYW1lIFByb3BlcnR5VHlwZT4gY2xhc3MgU1ZHU3RhdGljTGlzdFByb3BlcnR5 VGVhck9mZjtcbiIpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgcHVzaChAaGVhZGVy Q29udGVudCwgIlxudGVtcGxhdGU8dHlwZW5hbWUgUHJvcGVydHlUeXBlPiBjbGFzcyBTVkdMaXN0 UHJvcGVydHlUZWFyT2ZmO1xuIik7Cg== 73792 2010-11-12 16:43:58 -0800 2010-11-12 17:18:04 -0800 proposed patch, same as previous one, but better formatted patch file myNewPmPatch.txt text/plain 1594 webkittenghui SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTk1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsODYgQEAKKzIwMTAtMTEtMTIgIFRlbmdodWkgWmh1ICA8enRlbmdodWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb VjhdIENvZGUgZ2VuZXJhdGlvbiBzY3JpcHQgZXJyb3IgaW4gZ2VuZXJhdGluZyB0aGUgU1ZHU3Rh dGljTGlzdFByb3BlcnR5VGVhck9mZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDk0NjMKKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgICBUaGUgc3Zn TmF0aXZlVHlwZSBpcyB0aGUgb25lIGNvbnRhaW5pbmcgdGhlIFNWR1N0YXRpY0xpc3RQcm9wZXJ0 eVRlYXJPZmYgc3RyaW5nLCBub3QgdGhlIHN2Z0xpc3RQcm9wZXJ0eVR5cGUuCisKIDIwMTAtMTEt MTIgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNzE5MzcpCisrKyBXZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yNTIsOCArMjUy LDggQEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgCiAgICAgcHVzaChAaGVhZGVyQ29udGVudCwg IlxubmFtZXNwYWNlIFdlYkNvcmUge1xuIik7CiAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIlxu dGVtcGxhdGU8dHlwZW5hbWUgUHJvcGVydHlUeXBlPiBjbGFzcyBTVkdQcm9wZXJ0eVRlYXJPZmY7 XG4iKSBpZiAkc3ZnUHJvcGVydHlUeXBlOwotICAgIGlmICgkc3ZnTGlzdFByb3BlcnR5VHlwZSkg ewotICAgICAgICBpZiAoJHN2Z0xpc3RQcm9wZXJ0eVR5cGUgPX4gL1NWR1N0YXRpY0xpc3RQcm9w ZXJ0eVRlYXJPZmYvKSB7CisgICAgaWYgKCRzdmdOYXRpdmVUeXBlKSB7CisgICAgICAgIGlmICgk c3ZnTmF0aXZlVHlwZSA9fiAvU1ZHU3RhdGljTGlzdFByb3BlcnR5VGVhck9mZi8pIHsKICAgICAg ICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICJcbnRlbXBsYXRlPHR5cGVuYW1lIFByb3BlcnR5 VHlwZT4gY2xhc3MgU1ZHU3RhdGljTGlzdFByb3BlcnR5VGVhck9mZjtcbiIpOwogICAgICAgICB9 IGVsc2UgewogICAgICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIlxudGVtcGxhdGU8dHlw ZW5hbWUgUHJvcGVydHlUeXBlPiBjbGFzcyBTVkdMaXN0UHJvcGVydHlUZWFyT2ZmO1xuIik7Cg==