49454 2010-11-12 10:35:15 -0800 ASSERTION when converting some WKStringRefs returned from willSubmitForm to CFStringRef 2010-11-12 10:44:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned aroben oldest_to_newest 308634 0 sam 2010-11-12 10:35:15 -0800 You'll hit this assertion in WKStringCopyCFString: ASSERT(!toImpl(stringRef)->string().isNull()); on submitting a form at http://webkit.org/new-bug if you convert the values in the WKDictionaryRef passed in the willSubmitForm callback to CFStringRefs using WKStringCopyCFString due to some of the strings being null WTF::Strings. 308635 1 sam 2010-11-12 10:35:53 -0800 <rdar://problem/8662180> 308636 2 73757 sam 2010-11-12 10:37:04 -0800 Created attachment 73757 Patch 308640 3 sam 2010-11-12 10:40:04 -0800 Fixed in r71930. 308644 4 aroben 2010-11-12 10:44:41 -0800 No test? :-( 73757 2010-11-12 10:37:04 -0800 2010-11-12 10:38:21 -0800 Patch patch.diff text/plain 2917 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTkyOCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMTEtMTIgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NFUlRJ T04gd2hlbiBjb252ZXJ0aW5nIHNvbWUgV0tTdHJpbmdSZWZzIHJldHVybmVkIGZyb20gd2lsbFN1 Ym1pdEZvcm0gdG8gQ0ZTdHJpbmdSZWYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg2NjIxODA+ CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTQ1NAor CisgICAgICAgIEVuZm9yY2UgdGhlIGludmFyaWFudCB0aGF0IGEgV2ViU3RyaW5nIG5ldmVyIGNv bnRhaW5zIGEgbnVsbCBXVEY6OlN0cmluZyBhdCBhCisgICAgICAgIGxvd2VyIGxldmVsLCBpbiB0 aGUgV2ViU3RyaW5nIGNvbnN0cnVjdG9yLCBpbnN0ZWFkIG9mIHJlbHlpbmcgb24gdGhlIGNhbGxl cnMgb2YKKyAgICAgICAgV2ViU3RyaW5nOjpjcmVhdGUgdG8gZG8gaXQuCisKKyAgICAgICAgKiBT aGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0Lmg6CisgICAgICAgIChXZWJLaXQ6OnRvQVBJKToK KyAgICAgICAgKFdlYktpdDo6dG9Db3BpZWRBUEkpOiBSZW1vdmUgbnVsbCBzdHJpbmcgY2hlY2su Li4KKworICAgICAgICAqIFNoYXJlZC9XZWJTdHJpbmcuaDoKKyAgICAgICAgKFdlYktpdDo6V2Vi U3RyaW5nOjpXZWJTdHJpbmcpOiAuLi4gYW5kIG1vdmUgaXQgdG8gdGhlIGNvbnN0cnVjdG9yLgor CisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLVVJMLmNwcDoKKyAgICAgICAgKFdLVVJMQ29weVN0 cmluZyk6IFVzZSB0b0NvcGllZEFQSSgpIGluc3RlYWQgb2YgY2FsbGluZyBXZWJTdHJpbmcgZGly ZWN0bHkKKyAgICAgICAgdG8gbWF0Y2ggb3RoZXIgc2ltaWxhciB1c2VzLgorCiAyMDEwLTExLTEy ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbnRvbmlvIEdvbWVzLgpJbmRleDogV2ViS2l0Mi9TaGFyZWQvV2ViU3RyaW5nLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0Mi9TaGFyZWQvV2ViU3RyaW5nLmgJKHJldmlzaW9uIDcxOTIwKQorKysg V2ViS2l0Mi9TaGFyZWQvV2ViU3RyaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTgxLDcgKzgxLDcg QEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIFdlYlN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmlu ZykKLSAgICAgICAgOiBtX3N0cmluZyhzdHJpbmcpCisgICAgICAgIDogbV9zdHJpbmcoIXN0cmlu Zy5pbXBsKCkgPyBTdHJpbmcoU3RyaW5nSW1wbDo6ZW1wdHkoKSkgOiBzdHJpbmcpCiAgICAgewog ICAgIH0KIApJbmRleDogV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgJKHJldmlz aW9uIDcxOTIwKQorKysgV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgJKHdv cmtpbmcgY29weSkKQEAgLTExNSwxNCArMTE1LDEyIEBAIGlubGluZSB0eXBlbmFtZSBJbXBsVHlw ZUluZm88VD46OkFQSVR5cGUKIAogaW5saW5lIFByb3h5aW5nUmVmUHRyPFdlYlN0cmluZz4gdG9B UEkoU3RyaW5nSW1wbCogc3RyaW5nKQogewotICAgIFN0cmluZ0ltcGwqIGltcGwgPSBzdHJpbmcg PyBzdHJpbmcgOiBTdHJpbmdJbXBsOjplbXB0eSgpOwotICAgIHJldHVybiBQcm94eWluZ1JlZlB0 cjxXZWJTdHJpbmc+KFdlYlN0cmluZzo6Y3JlYXRlKFN0cmluZyhpbXBsKSkpOworICAgIHJldHVy biBQcm94eWluZ1JlZlB0cjxXZWJTdHJpbmc+KFdlYlN0cmluZzo6Y3JlYXRlKHN0cmluZykpOwog fQogCiBpbmxpbmUgV0tTdHJpbmdSZWYgdG9Db3BpZWRBUEkoY29uc3QgU3RyaW5nJiBzdHJpbmcp CiB7Ci0gICAgU3RyaW5nSW1wbCogaW1wbCA9IHN0cmluZy5pbXBsKCkgPyBzdHJpbmcuaW1wbCgp IDogU3RyaW5nSW1wbDo6ZW1wdHkoKTsKLSAgICBSZWZQdHI8V2ViU3RyaW5nPiB3ZWJTdHJpbmcg PSBXZWJTdHJpbmc6OmNyZWF0ZShTdHJpbmcoaW1wbCkpOworICAgIFJlZlB0cjxXZWJTdHJpbmc+ IHdlYlN0cmluZyA9IFdlYlN0cmluZzo6Y3JlYXRlKHN0cmluZyk7CiAgICAgcmV0dXJuIHRvQVBJ KHdlYlN0cmluZy5yZWxlYXNlKCkucmVsZWFzZVJlZigpKTsKIH0KIApJbmRleDogV2ViS2l0Mi9T aGFyZWQvQVBJL2MvV0tVUkwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvU2hhcmVkL0FQSS9j L1dLVVJMLmNwcAkocmV2aXNpb24gNzE5MjApCisrKyBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1VS TC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxLDcgKzQxLDcgQEAgV0tVUkxSZWYgV0tVUkxDcmVh dGVXaXRoVVRGOENTdHJpbmcoY29ucwogCiBXS1N0cmluZ1JlZiBXS1VSTENvcHlTdHJpbmcoV0tV UkxSZWYgdXJsKQogewotICAgIHJldHVybiB0b0FQSShXZWJTdHJpbmc6OmNyZWF0ZSh0b0ltcGwo dXJsKS0+c3RyaW5nKCkpLmxlYWtSZWYoKSk7CisgICAgcmV0dXJuIHRvQ29waWVkQVBJKHRvSW1w bCh1cmwpLT5zdHJpbmcoKSk7CiB9CiAKIGJvb2wgV0tVUkxJc0VxdWFsKFdLVVJMUmVmIGEsIFdL VVJMUmVmIGIpCg==