49451 2010-11-12 09:59:28 -0800 Remove unused code from HTMLMediaElement 2010-11-12 14:43:45 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 308614 0 eric.carlson 2010-11-12 09:59:28 -0800 HTMLMediaElement has several methods for parsing and serializing time offset strings which are not used. They should be removed. 308782 1 73777 eric.carlson 2010-11-12 14:20:52 -0800 Created attachment 73777 Proposed patch 308787 2 eric.carlson 2010-11-12 14:43:45 -0800 http://trac.webkit.org/changeset/71950 73777 2010-11-12 14:20:52 -0800 2010-11-12 14:28:44 -0800 Proposed patch patch_1.txt text/plain 2620 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTkyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMTIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIHVudXNlZCBjb2RlIGZyb20gSFRNTE1lZGlhRWxlbWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk0NTEKKworICAgICAgICAqIGh0 bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6IFJlbW92ZWQgdW51c2VkIGZ1bmN0aW9ucy4KKyAgICAg ICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKwogMjAxMC0xMS0xMSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkg U2VtaWtoYXRza3kuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA3 MTkxNykKKysrIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDQxLDQyICs0NDEsNiBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRUaW1lckZp cmVkKFRpCiAgICAgICAgIGxvYWRJbnRlcm5hbCgpOwogfQogCi1zdGF0aWMgU3RyaW5nIHNlcmlh bGl6ZVRpbWVPZmZzZXQoZmxvYXQgdGltZSkKLXsKLSAgICBTdHJpbmcgdGltZVN0cmluZyA9IFN0 cmluZzo6bnVtYmVyKHRpbWUpOwotICAgIC8vIEZJWE1FIHNlcmlhbGl6ZSB0aW1lIG9mZnNldCB2 YWx1ZXMgcHJvcGVybHkgKGZvcm1hdCBub3Qgc3BlY2lmaWVkIHlldCkKLSAgICB0aW1lU3RyaW5n LmFwcGVuZCgicyIpOwotICAgIHJldHVybiB0aW1lU3RyaW5nOwotfQotCi1zdGF0aWMgZmxvYXQg cGFyc2VUaW1lT2Zmc2V0KGNvbnN0IFN0cmluZyYgdGltZVN0cmluZywgYm9vbCogb2sgPSAwKQot ewotICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gdGltZVN0cmluZy5jaGFyYWN0ZXJzKCk7 Ci0gICAgdW5zaWduZWQgbGVuZ3RoID0gdGltZVN0cmluZy5sZW5ndGgoKTsKLSAgICAKLSAgICBp ZiAobGVuZ3RoICYmIGNoYXJhY3RlcnNbbGVuZ3RoIC0gMV0gPT0gJ3MnKQotICAgICAgICBsZW5n dGgtLTsKLSAgICAKLSAgICAvLyBGSVhNRSBwYXJzZSB0aW1lIG9mZnNldCB2YWx1ZXMgKGZvcm1h dCBub3Qgc3BlY2lmaWVkIHlldCkKLSAgICBmbG9hdCB2YWwgPSBjaGFyYWN0ZXJzVG9GbG9hdChj aGFyYWN0ZXJzLCBsZW5ndGgsIG9rKTsKLSAgICByZXR1cm4gdmFsOwotfQotCi1mbG9hdCBIVE1M TWVkaWFFbGVtZW50OjpnZXRUaW1lT2Zmc2V0QXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUm IG5hbWUsIGZsb2F0IHZhbHVlT25FcnJvcikgY29uc3QKLXsKLSAgICBib29sIG9rOwotICAgIFN0 cmluZyB0aW1lU3RyaW5nID0gZ2V0QXR0cmlidXRlKG5hbWUpOwotICAgIGZsb2F0IHJlc3VsdCA9 IHBhcnNlVGltZU9mZnNldCh0aW1lU3RyaW5nLCAmb2spOwotICAgIGlmIChvaykKLSAgICAgICAg cmV0dXJuIHJlc3VsdDsKLSAgICByZXR1cm4gdmFsdWVPbkVycm9yOwotfQotCi12b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OnNldFRpbWVPZmZzZXRBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYg bmFtZSwgZmxvYXQgdmFsdWUpCi17Ci0gICAgc2V0QXR0cmlidXRlKG5hbWUsIHNlcmlhbGl6ZVRp bWVPZmZzZXQodmFsdWUpKTsKLX0KLQogUGFzc1JlZlB0cjxNZWRpYUVycm9yPiBIVE1MTWVkaWFF bGVtZW50OjplcnJvcigpIGNvbnN0IAogewogICAgIHJldHVybiBtX2Vycm9yOwpJbmRleDogV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5oCShyZXZpc2lvbiA3MTkxNykKKysrIFdlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTE5Nyw5ICsxOTcsNiBAQCBwcml2YXRl OgogICAgIAogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7CiAg ICAgCi0gICAgZmxvYXQgZ2V0VGltZU9mZnNldEF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1l JiwgZmxvYXQgdmFsdWVPbkVycm9yKSBjb25zdDsKLSAgICB2b2lkIHNldFRpbWVPZmZzZXRBdHRy aWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIGZsb2F0IHZhbHVlKTsKLSAgICAKICAgICAvLyBB Y3RpdmVET01PYmplY3QgZnVuY3Rpb25zLgogICAgIHZpcnR1YWwgYm9vbCBjYW5TdXNwZW5kKCkg Y29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHN1c3BlbmQoUmVhc29uRm9yU3VzcGVuc2lvbik7Cg==