49443 2010-11-12 07:16:52 -0800 cpp.py needs some tidying. 2010-11-12 10:21:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin abarth eric hamaji oldest_to_newest 308528 0 levin 2010-11-12 07:16:52 -0800 It probably could use more than what I did, but I just adjusted an area where I've been working. 308530 1 73741 levin 2010-11-12 07:19:02 -0800 Created attachment 73741 Patch 308619 2 73741 abarth 2010-11-12 10:07:48 -0800 Comment on attachment 73741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review Looks good, but there's a typo in you ChangeLog. >:-) > WebKitTools/ChangeLog:9 > + Fix parametere ordering for iteratively_replace_matches_with_char parametere ? > WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:1205 > - if not body_found: > + else: Woah 308625 3 levin 2010-11-12 10:21:06 -0800 (In reply to comment #2) > (From update of attachment 73741 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review > > Looks good, but there's a typo in you ChangeLog. >:-) I can't believe you cq- for that! Oh wait a minute.... Fixed and committed. :) http://trac.webkit.org/changeset/71926 73741 2010-11-12 07:19:02 -0800 2010-11-12 10:07:48 -0800 Patch bug-49443-20101112071901.patch text/plain 4449 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzN2RlOWRlNjU1YWMwNzNlNWJiZDg2ZjdkZjEzY2Q5MzUyYTljMDNkLi5kNTk1M2U2 YzgzYzA3MWI2Y2VjYTFhNzVhZjlkOGM3ZmY3N2Q2ZWYzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTEtMTIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNwcC5weSBuZWVkcyBzb21l IHRpZHlpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00OTQ0MworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHk6CisgICAgICAgICAgRml4IHBhcmFtZXRlcmUgb3JkZXJpbmcgZm9yIGl0ZXJhdGl2ZWx5X3Jl cGxhY2VfbWF0Y2hlc193aXRoX2NoYXIKKyAgICAgICAgICB0byBtaXJyb3Igb3RoZXIgc2ltaWxh ciBmdW5jdGlvbnMgKGFuZCBpbXByb3ZlZCBjb21tZW50cywgZXRjLikKKyAgICAgICAgICBBbHNv LCB1c2VkIGEgcHl0aG9uLWlzbSAoZm9yL2Vsc2UpIHRvIGdldCByaWQgb2YgYSB2YXJpYWJsZSB0 aGF0CisgICAgICAgICAgd2FzIHRoZXJlIHRvIGRldGVybWluZSBpZiBzb21ldGhpbmcgaGFkIGJl ZW4gZm91bmQgaW4gdGhlIGxvb3AuCisKIDIwMTAtMTEtMTEgIERhdmlkIExldmluICA8bGV2aW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNoaW5pY2hpcm8gSGFtYWppLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQppbmRleCBiZTYzZDdmZDhjZDg5OWUzZDQxN2QxYjZjM2YzNGI0NTFmZDBmMTRlLi4xZGNjMDQ3 M2FmZmNmZTlhNjY5MmJkYmRmMGExYjA0NjA2NDU4ZjkzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMTUyLDggKzE1Miw4 IEBAIGRlZiBzdWJuKHBhdHRlcm4sIHJlcGxhY2VtZW50LCBzKToKICAgICByZXR1cm4gX3JlZ2V4 cF9jb21waWxlX2NhY2hlW3BhdHRlcm5dLnN1Ym4ocmVwbGFjZW1lbnQsIHMpCiAKIAotZGVmIGl0 ZXJhdGl2ZWx5X3JlcGxhY2VfbWF0Y2hlc193aXRoX2NoYXIocGF0dGVybiwgcywgY2hhcik6Ci0g ICAgIiIiUmV0dXJucyB0aGUgc3RyaW5nIHdpdGggcmVwbGFjZW1lbnRzLgorZGVmIGl0ZXJhdGl2 ZWx5X3JlcGxhY2VfbWF0Y2hlc193aXRoX2NoYXIocGF0dGVybiwgY2hhcl9yZXBsYWNlbWVudCwg cyk6CisgICAgIiIiUmV0dXJucyB0aGUgc3RyaW5nIHdpdGggcmVwbGFjZW1lbnQgZG9uZS4KIAog ICAgIEV2ZXJ5IGNoYXJhY3RlciBpbiB0aGUgbWF0Y2ggaXMgcmVwbGFjZWQgd2l0aCBjaGFyLgog ICAgIER1ZSB0byB0aGUgaXRlcmF0aXZlIG5hdHVyZSwgcGF0dGVybiBzaG91bGQgbm90IG1hdGNo IGNoYXIgb3IKQEAgLTE2MSwxNCArMTYxLDE1IEBAIGRlZiBpdGVyYXRpdmVseV9yZXBsYWNlX21h dGNoZXNfd2l0aF9jaGFyKHBhdHRlcm4sIHMsIGNoYXIpOgogCiAgICAgRXhhbXBsZToKICAgICAg IHBhdHRlcm4gPSByJzxbXj5dPicgIyB0ZW1wbGF0ZSBwYXJhbWV0ZXJzCisgICAgICBjaGFyX3Jl cGxhY2VtZW50ID0gICdfJwogICAgICAgcyA9ICAgICAnQTxCPEMsIEQ+PicKLSAgICAgIGNoYXIg PSAgJ18nCiAgICAgICBSZXR1cm5zICdBX19fX19fX19fJwogCiAgICAgQXJnczoKLSAgICAgIHBh dHRlcm46IHRoZSByZWdleCB0byBtYXRjaAotICAgICAgczogdGhlIHN0cmluZyBvbiB3aGljaCB0 byBkbyB0aGUgcmVwbGFjZW1lbnRzLgotICAgICAgY2hhcjogdGhlIGNoYXJhY3RlciB0byBwdXQg aW4gdGhlIHBsYWNlIG9mIHRoZSBtYXRjaAorICAgICAgcGF0dGVybjogVGhlIHJlZ2V4IHRvIG1h dGNoLgorICAgICAgY2hhcl9yZXBsYWNlbWVudDogVGhlIGNoYXJhY3RlciB0byBwdXQgaW4gcGxh Y2Ugb2YgZXZlcnkKKyAgICAgICAgICAgICAgICAgICAgICAgIGNoYXJhY3RlciBvZiB0aGUgbWF0 Y2guCisgICAgICBzOiBUaGUgc3RyaW5nIG9uIHdoaWNoIHRvIGRvIHRoZSByZXBsYWNlbWVudHMu CiAKICAgICBSZXR1cm5zOgogICAgICAgVHJ1ZSwgaWYgdGhlIGdpdmVuIGxpbmUgaXMgYmxhbmsu CkBAIC0xODAsNyArMTgxLDcgQEAgZGVmIGl0ZXJhdGl2ZWx5X3JlcGxhY2VfbWF0Y2hlc193aXRo X2NoYXIocGF0dGVybiwgcywgY2hhcik6CiAgICAgICAgIHN0YXJ0X21hdGNoX2luZGV4ID0gbWF0 Y2hlZC5zdGFydCgwKQogICAgICAgICBlbmRfbWF0Y2hfaW5kZXggPSBtYXRjaGVkLmVuZCgwKQog ICAgICAgICBtYXRjaF9sZW5ndGggPSBlbmRfbWF0Y2hfaW5kZXggLSBzdGFydF9tYXRjaF9pbmRl eAotICAgICAgICBzID0gc1s6c3RhcnRfbWF0Y2hfaW5kZXhdICsgY2hhciAqIG1hdGNoX2xlbmd0 aCArIHNbZW5kX21hdGNoX2luZGV4Ol0KKyAgICAgICAgcyA9IHNbOnN0YXJ0X21hdGNoX2luZGV4 XSArIGNoYXJfcmVwbGFjZW1lbnQgKiBtYXRjaF9sZW5ndGggKyBzW2VuZF9tYXRjaF9pbmRleDpd CiAKIAogZGVmIHVwX3RvX3VubWF0Y2hlZF9jbG9zaW5nX3BhcmVuKHMpOgpAQCAtMTE3OCwxOCAr MTE3OSwxNSBAQCBkZWYgY2hlY2tfZm9yX2Z1bmN0aW9uX2xlbmd0aHMoY2xlYW5fbGluZXMsIGxp bmVfbnVtYmVyLCBmdW5jdGlvbl9zdGF0ZSwgZXJyb3IpOgogICAgICAgICAgICAgc3RhcnRpbmdf ZnVuYyA9IFRydWUKIAogICAgIGlmIHN0YXJ0aW5nX2Z1bmM6Ci0gICAgICAgIGJvZHlfZm91bmQg PSBGYWxzZQogICAgICAgICBmb3Igc3RhcnRfbGluZV9udW1iZXIgaW4geHJhbmdlKGxpbmVfbnVt YmVyLCBjbGVhbl9saW5lcy5udW1fbGluZXMoKSk6CiAgICAgICAgICAgICBzdGFydF9saW5lID0g bGluZXNbc3RhcnRfbGluZV9udW1iZXJdCiAgICAgICAgICAgICBqb2luZWRfbGluZSArPSAnICcg KyBzdGFydF9saW5lLmxzdHJpcCgpCiAgICAgICAgICAgICBpZiBzZWFyY2gocicoO3x9KScsIHN0 YXJ0X2xpbmUpOiAgIyBEZWNsYXJhdGlvbnMgYW5kIHRyaXZpYWwgZnVuY3Rpb25zCi0gICAgICAg ICAgICAgICAgYm9keV9mb3VuZCA9IFRydWUKICAgICAgICAgICAgICAgICBicmVhayAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICMgLi4uIGlnbm9yZQogICAgICAgICAgICAgaWYgc2VhcmNo KHIneycsIHN0YXJ0X2xpbmUpOgotICAgICAgICAgICAgICAgIGJvZHlfZm91bmQgPSBUcnVlCiAg ICAgICAgICAgICAgICAgIyBSZXBsYWNlIHRlbXBsYXRlIGNvbnN0cnVjdHMgd2l0aCBfIHNvIHRo YXQgbm8gc3BhY2VzIHJlbWFpbiBpbiB0aGUgZnVuY3Rpb24gbmFtZSwKICAgICAgICAgICAgICAg ICAjIHdoaWxlIGtlZXBpbmcgdGhlIGNvbHVtbiBudW1iZXJzIG9mIG90aGVyIGNoYXJhY3RlcnMg dGhlIHNhbWUgYXMgImxpbmUiLgotICAgICAgICAgICAgICAgIGxpbmVfd2l0aF9ub190ZW1wbGF0 ZXMgPSBpdGVyYXRpdmVseV9yZXBsYWNlX21hdGNoZXNfd2l0aF9jaGFyKHInPFtePD5dKj4nLCBs aW5lLCAiXyIpCisgICAgICAgICAgICAgICAgbGluZV93aXRoX25vX3RlbXBsYXRlcyA9IGl0ZXJh dGl2ZWx5X3JlcGxhY2VfbWF0Y2hlc193aXRoX2NoYXIocic8W148Pl0qPicsICdfJywgbGluZSkK ICAgICAgICAgICAgICAgICBtYXRjaF9mdW5jdGlvbiA9IHNlYXJjaChyJygoXHd8Onw8fD58LHx+ KSopXCgnLCBsaW5lX3dpdGhfbm9fdGVtcGxhdGVzKQogCiAgICAgICAgICAgICAgICAgIyBVc2Ug dGhlIGNvbHVtbiBudW1iZXJzIGZyb20gdGhlIG1vZGlmaWVkIGxpbmUgdG8gZmluZCB0aGUKQEAg LTEyMDQsNyArMTIwMiw3IEBAIGRlZiBjaGVja19mb3JfZnVuY3Rpb25fbGVuZ3RocyhjbGVhbl9s aW5lcywgbGluZV9udW1iZXIsIGZ1bmN0aW9uX3N0YXRlLCBlcnJvcik6CiAgICAgICAgICAgICAg ICAgICAgIGZ1bmN0aW9uICs9ICcoKScKICAgICAgICAgICAgICAgICBmdW5jdGlvbl9zdGF0ZS5i ZWdpbihmdW5jdGlvbikKICAgICAgICAgICAgICAgICBicmVhawotICAgICAgICBpZiBub3QgYm9k eV9mb3VuZDoKKyAgICAgICAgZWxzZToKICAgICAgICAgICAgICMgTm8gYm9keSBmb3IgdGhlIGZ1 bmN0aW9uIChvciBldmlkZW5jZSBvZiBhIG5vbi1mdW5jdGlvbikgd2FzIGZvdW5kLgogICAgICAg ICAgICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9mbl9zaXplJywgNSwKICAgICAg ICAgICAgICAgICAgICdMaW50IGZhaWxlZCB0byBmaW5kIHN0YXJ0IG9mIGZ1bmN0aW9uIGJvZHku JykK