49439 2010-11-12 04:57:22 -0800 Web Inspector: [refactoring] do not use absolute positioning for tabbed panes 2010-11-12 05:34:48 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 308490 0 caseq 2010-11-12 04:57:22 -0800 Tabbed panes currently use absolute positioning to put them right under the header with tabs. This is inconvenient from maintenance prospective and requires additional CSS rules. Ideally, the contents of a tabbed pane should not depend on whether it is displayed within a tab or outside of it. 308492 1 73728 caseq 2010-11-12 05:04:51 -0800 Created attachment 73728 patch 308497 2 73728 commit-queue 2010-11-12 05:34:43 -0800 Comment on attachment 73728 patch Clearing flags on attachment: 73728 Committed r71906: <http://trac.webkit.org/changeset/71906> 308498 3 commit-queue 2010-11-12 05:34:48 -0800 All reviewed patches have been landed. Closing bug. 73728 2010-11-12 05:04:51 -0800 2010-11-12 05:34:43 -0800 patch tabbed-pane.diff text/plain 4711 caseq ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTNkN2QyYi4uY2E3ZmQ0NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMS0xMiAgQW5kcmV5IEtvc3lh a292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtyZWZhY3RvcmluZ10gZG8gbm90IHVz ZSBhYnNvbHV0ZSBwb3NpdGlvbmluZyBmb3IgdGFiYmVkIHBhbmVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTQzOQorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJl ZFBhbmUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmUucHJvdG90eXBlLmFwcGVu ZFRhYik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzOgorICAg ICAgICAoLnJlc291cmNlLXZpZXcudmlzaWJsZSk6CisgICAgICAgICgucmVzb3VyY2UtdmlldyAu dGFiYmVkLXBhbmUtaGVhZGVyKToKKyAgICAgICAgKC5yZXNvdXJjZS12aWV3LWNvb2tpZXMpOgor ICAgICAgICAoLnRhYmJlZC1wYW5lKToKKyAgICAgICAgKC50YWJiZWQtcGFuZS1jb250ZW50KToK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3M6CisKIDIwMTAt MTEtMTEgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGFiYmVkUGFuZS5qcwppbmRleCBkZWMzYTBiLi4xYzdiOWIwIDEwMDY0NAotLS0gYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcworKysgYi9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcwpAQCAtMzEsMTAgKzMxLDkgQEAKIFdlYkluc3Bl Y3Rvci5UYWJiZWRQYW5lID0gZnVuY3Rpb24oZWxlbWVudCkKIHsKICAgICB0aGlzLmVsZW1lbnQg PSBlbGVtZW50IHx8IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwotCi0gICAgdGhpcy50 YWJzRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwotICAgIHRoaXMudGFi c0VsZW1lbnQuY2xhc3NOYW1lID0gInRhYmJlZC1wYW5lLWhlYWRlciI7Ci0gICAgdGhpcy5lbGVt ZW50LmFwcGVuZENoaWxkKHRoaXMudGFic0VsZW1lbnQpOworICAgIHRoaXMuZWxlbWVudC5hZGRT dHlsZUNsYXNzKCJ0YWJiZWQtcGFuZSIpOworICAgIHRoaXMudGFic0VsZW1lbnQgPSB0aGlzLmVs ZW1lbnQuY3JlYXRlQ2hpbGQoImRpdiIsICJ0YWJiZWQtcGFuZS1oZWFkZXIiKTsKKyAgICB0aGlz LmNvbnRlbnRFbGVtZW50ID0gdGhpcy5lbGVtZW50LmNyZWF0ZUNoaWxkKCJkaXYiLCAidGFiYmVk LXBhbmUtY29udGVudCIpOwogCiAgICAgdGhpcy5fdGFiT2JqZWN0cyA9IHt9OwogfQpAQCAtNDYs NyArNDUsNyBAQCBXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAg IHRhYkVsZW1lbnQudGV4dENvbnRlbnQgPSB0YWJUaXRsZTsKICAgICAgICAgdGFiRWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRhYkNsaWNrTGlzdGVuZXIsIGZhbHNlKTsKICAgICAg ICAgdGhpcy50YWJzRWxlbWVudC5hcHBlbmRDaGlsZCh0YWJFbGVtZW50KTsKLSAgICAgICAgdGhp cy5lbGVtZW50LmFwcGVuZENoaWxkKGNvbnRlbnRFbGVtZW50KTsKKyAgICAgICAgdGhpcy5jb250 ZW50RWxlbWVudC5hcHBlbmRDaGlsZChjb250ZW50RWxlbWVudCk7CiAgICAgICAgIHRoaXMuX3Rh Yk9iamVjdHNbaWRdID0ge3RhYjogdGFiRWxlbWVudCwgY29udGVudDogY29udGVudEVsZW1lbnR9 OwogICAgIH0sCiAgICAgCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv aW5zcGVjdG9yLmNzcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3Nz CmluZGV4IDZiZjY5ZmUuLmZkZjc0NWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuY3NzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuY3NzCkBAIC04MTMsMTYgKzgxMywxMiBAQCBib2R5LnBsYXRmb3JtLWxpbnV4IC5t b25vc3BhY2UsIGJvZHkucGxhdGZvcm0tbGludXggLnNvdXJjZS1jb2RlIHsKIH0KIAogLnJlc291 cmNlLXZpZXcudmlzaWJsZSB7Ci0gICAgZGlzcGxheTogYmxvY2s7CisgICAgZGlzcGxheTogLXdl YmtpdC1ib3g7CiB9CiAKIC5yZXNvdXJjZS12aWV3IC50YWJiZWQtcGFuZS1oZWFkZXIgewogICAg IGRpc3BsYXk6IG5vbmU7Ci0gICAgcG9zaXRpb246IGFic29sdXRlOwogICAgIGhlaWdodDogMjBw eDsKLSAgICB0b3A6IDA7Ci0gICAgbGVmdDogMDsKLSAgICByaWdodDogMDsKICAgICBiYWNrZ3Jv dW5kOiAtd2Via2l0LWdyYWRpZW50KGxpbmVhciwgMCUgMCUsIDAlIDEwMCUsIGZyb20ocmdiKDIz NiwgMjM2LCAyMzYpKSwgdG8ocmdiKDIxNywgMjE3LCAyMTcpKSk7CiAgICAgYm9yZGVyLWJvdHRv bTogMXB4IHNvbGlkIHJnYigxNjMsIDE2MywgMTYzKTsKIH0KQEAgLTg0NywxMCArODQzLDYgQEAg Ym9keS5wbGF0Zm9ybS1saW51eCAubW9ub3NwYWNlLCBib2R5LnBsYXRmb3JtLWxpbnV4IC5zb3Vy Y2UtY29kZSB7CiAgICAgb3ZlcmZsb3c6IGF1dG87CiB9CiAKLS5yZXNvdXJjZS12aWV3LmhlYWRl cnMtdmlzaWJsZSAucmVzb3VyY2Utdmlldy1oZWFkZXJzIHsKLSAgICB0b3A6IDIwcHg7Ci19Ci0K IC5yZXNvdXJjZS12aWV3LWhlYWRlcnMgLm91dGxpbmUtZGlzY2xvc3VyZSAucGFyZW50IHsKICAg ICAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lOwogICAgIGZvbnQtd2VpZ2h0OiBib2xkOwpAQCAt ODk0LDExICs4ODYsNyBAQCBib2R5LnBsYXRmb3JtLWxpbnV4IC5tb25vc3BhY2UsIGJvZHkucGxh dGZvcm0tbGludXggLnNvdXJjZS1jb2RlIHsKICAgICBvdmVyZmxvdzogYXV0bzsKIH0KIAotLnJl c291cmNlLXZpZXcuaGVhZGVycy12aXNpYmxlIC5yZXNvdXJjZS12aWV3LWNvbnRlbnQgewotICAg IHRvcDogMjBweDsKLX0KLQotLnJlc291cmNlLXZpZXcgLnJlc291cmNlLXZpZXctY29va2llcyB7 CisucmVzb3VyY2Utdmlldy1jb29raWVzIHsKICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAg dG9wOiAwOwogICAgIHJpZ2h0OiAwOwpAQCAtOTA2LDEwICs4OTQsNyBAQCBib2R5LnBsYXRmb3Jt LWxpbnV4IC5tb25vc3BhY2UsIGJvZHkucGxhdGZvcm0tbGludXggLnNvdXJjZS1jb2RlIHsKICAg ICBib3R0b206IDA7CiAgICAgb3ZlcmZsb3c6IGF1dG87CiAgICAgcGFkZGluZzogMTJweDsKLX0K LQotLnJlc291cmNlLXZpZXcuaGVhZGVycy12aXNpYmxlIC5yZXNvdXJjZS12aWV3LWNvb2tpZXMg ewotICAgIHRvcDogMjBweDsKKyAgICBoZWlnaHQ6IDEwMCU7CiB9CiAKIC5yZXNvdXJjZS12aWV3 LWNvb2tpZXMudGFibGUgLmRhdGEtZ3JpZCB7CkBAIC0yNjU2LDYgKzI2NDEsMTYgQEAgYnV0dG9u LmVuYWJsZS10b2dnbGUtc3RhdHVzLWJhci1pdGVtLnRvZ2dsZWQtb24gLmdseXBoIHsKICAgICBt YXJnaW4tdG9wOiAxcHg7CiB9CiAKKy50YWJiZWQtcGFuZSB7CisgICAgLXdlYmtpdC1ib3gtb3Jp ZW50OiB2ZXJ0aWNhbDsKKyAgICBoZWlnaHQ6IDEwMCU7Cit9CisKKy50YWJiZWQtcGFuZS1jb250 ZW50IHsKKyAgICAtd2Via2l0LWJveC1mbGV4OiAxOworICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsK K30KKwogLnRhYmJlZC1wYW5lLWhlYWRlciB7CiAgICAgaGVpZ2h0OiAyM3B4OwogICAgIHBhZGRp bmc6IDAgMTBweDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3 b3JrUGFuZWwuY3NzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5j c3MKaW5kZXggMWUwZTgxMy4uNmI2YWViZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3MKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL25ldHdvcmtQYW5lbC5jc3MKQEAgLTYyNCwyMCArNjI0LDYgQEAKICAgICBwYWRkaW5nLXRv cDogNXB4OwogfQogCi0jbmV0d29yay12aWV3cyAucmVzb3VyY2Utdmlldy1oZWFkZXJzLAotI25l dHdvcmstdmlld3MgLnJlc291cmNlLXZpZXctY29udGVudCwKLSNuZXR3b3JrLXZpZXdzIC5yZXNv dXJjZS12aWV3LWNvb2tpZXMKLXsKLSAgICB0b3A6IDMxcHg7Ci19Ci0KLSNuZXR3b3JrLXZpZXdz LnNtYWxsIC5yZXNvdXJjZS12aWV3LWhlYWRlcnMsCi0jbmV0d29yay12aWV3cy5zbWFsbCAucmVz b3VyY2Utdmlldy1jb250ZW50LAotI25ldHdvcmstdmlld3Muc21hbGwgLnJlc291cmNlLXZpZXct Y29va2llcwotewotICAgIHRvcDogMjNweDsKLX0KLQogLm5ldHdvcmsucGFuZWw6bm90KC52aWV3 aW5nLXJlc291cmNlKSAuZGF0YS1ncmlkIHRyLnNlbGVjdGVkIHsKICAgICBiYWNrZ3JvdW5kLWNv bG9yOiB0cmFuc3BhcmVudDsKICAgICBjb2xvcjogYmxhY2s7Cg==