49429 2010-11-11 23:58:15 -0800 [Qt] script-clone tests added in r71895 fails on Qt platform 2010-11-12 12:19:49 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 rniwa webkit-qt-unassigned benjamin commit-queue darin hausmann kling ossy tonikitoo oldest_to_newest 308415 0 rniwa 2010-11-11 23:58:15 -0800 The failure is due to the fact Qt platform use its own XML parser, and this parser was not fixed in http://trac.webkit.org/changeset/71895. 308420 1 73708 rniwa 2010-11-12 00:13:36 -0800 Created attachment 73708 Patch 308421 2 rniwa 2010-11-12 00:16:01 -0800 I made this patch without building or running tests on qt platform. Please build & run the tests (particularly the ones I'm enabling) before you r+ this patch. 308428 3 73708 ossy 2010-11-12 00:36:51 -0800 Comment on attachment 73708 Patch It works for me, r=me 308434 4 73708 commit-queue 2010-11-12 01:27:18 -0800 Comment on attachment 73708 Patch Clearing flags on attachment: 73708 Committed r71899: <http://trac.webkit.org/changeset/71899> 308435 5 commit-queue 2010-11-12 01:27:24 -0800 All reviewed patches have been landed. Closing bug. 308487 6 ossy 2010-11-12 04:15:06 -0800 Reopen, because unfortunately r71895 broke a Qt API test too: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/23620/steps/API%20tests/logs/stdio FAIL! : tst_QWebFrame::javaScriptWindowObjectCleared(with <script>) Compared values are not the same Actual (spy.count()): 0 Expected (signalCount): 1 Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2405)] 308621 7 rniwa 2010-11-12 10:13:37 -0800 Test content: 2396 void tst_QWebFrame::javaScriptWindowObjectCleared() 2397 { 2398 QWebPage page; 2399 QWebFrame* frame = page.mainFrame(); 2400 QSignalSpy spy(frame, SIGNAL(javaScriptWindowObjectCleared())); 2401 QFETCH(QString, html); 2402 frame->setHtml(html); 2403 2404 QFETCH(int, signalCount); 2405 QCOMPARE(spy.count(), signalCount); 2406 } I don't really understand what this test is testing though. Can someone explain what it's testing? This test is added in http://trac.webkit.org/changeset/48166. 308630 8 kling 2010-11-12 10:29:10 -0800 (In reply to comment #7) > I don't really understand what this test is testing though. Can someone explain what it's testing? http://doc.qt.nokia.com/4.7/qwebframe.html#javaScriptWindowObjectCleared "This signal is emitted whenever the global window object of the JavaScript environment is cleared, e.g., before starting a new load." We emit this signal when FrameLoader::dispatchDidClearWindowObjectInWorld() is called. The failing test checks that loading the following HTML causes one emission of that signal: "<html><body><script></script><p>hello world</p></body></html>" 308665 9 rniwa 2010-11-12 11:25:53 -0800 On Mac, dispatchDidClearWindowObjectInWorld is called when loading: <html><body><script></script><p>hello world</p></body></html> #0 0x101865b54 in WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds at FrameLoader.cpp:3348 #1 0x101869ac6 in WebCore::FrameLoader::receivedFirstData at FrameLoader.cpp:617 #2 0x101869cee in WebCore::FrameLoader::willSetEncoding at FrameLoader.cpp:1089 #3 0x101710989 in WebCore::DocumentWriter::setEncoding at DocumentWriter.cpp:236 #4 0x1017016d0 in WebCore::DocumentLoader::commitData at DocumentLoader.cpp:306 #5 0x100f34f76 in -[WebFrame(WebInternal) _commitData:] at WebFrame.mm:957 #6 0x100f5d8d6 in -[WebHTMLRepresentation receivedData:withDataSource:] at WebHTMLRepresentation.mm:173 #7 0x100f1d8c8 in -[WebDataSource(WebInternal) _receivedData:] at WebDataSource.mm:239 #8 0x100f407eb in WebFrameLoaderClient::committedLoad at WebFrameLoaderClient.mm:856 #9 0x101701825 in WebCore::DocumentLoader::commitLoad at DocumentLoader.cpp:293 #10 0x10170187e in WebCore::DocumentLoader::receivedData at DocumentLoader.cpp:320 #11 0x101d61d2e in WebCore::MainResourceLoader::addData at MainResourceLoader.cpp:157 #12 0x101f762c4 in WebCore::ResourceLoader::didReceiveData at ResourceLoader.cpp:276 #13 0x101d6147f in WebCore::MainResourceLoader::didReceiveData at MainResourceLoader.cpp:436 #14 0x101f75ab6 in WebCore::ResourceLoader::didReceiveData at ResourceLoader.cpp:429 308690 10 rniwa 2010-11-12 12:17:20 -0800 Let's file another bug for the API test. 308694 11 rniwa 2010-11-12 12:19:49 -0800 API test failure filed as https://bugs.webkit.org/show_bug.cgi?id=49466, closing this bug. 73708 2010-11-12 00:13:36 -0800 2010-11-12 01:27:18 -0800 Patch bug-49429-20101112001334.patch text/plain 2750 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTg5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3F0 XSBzY3JpcHQtY2xvbmUgdGVzdHMgYWRkZWQgaW4gcjcxODk1IGZhaWxzIG9uIHF0IHBsYXRmb3Jt CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTQyOQor CisgICAgICAgIEZpeGVkIHBhcnNlRW5kRWxlbWVudCB0byBjYWxsIFNjcmlwdEVsZW1lbnQncyBl eGVjdXRlU2NyaXB0IGFzIHN1cHBvc2VkIHRvIHRoYXQgb2YgU2NyaXB0Q29udHJvbGxlci4KKwor ICAgICAgICAqIGRvbS9YTUxEb2N1bWVudFBhcnNlclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlhNTERvY3VtZW50UGFyc2VyOjpwYXJzZUVuZEVsZW1lbnQpOgorCiAyMDEwLTExLTExICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAJKHJldmlzaW9uIDcx ODk3KQorKysgV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTYxMSw3ICs2MTEsNyBAQCB2b2lkIFhNTERvY3VtZW50UGFyc2VyOjpwYXJzZUVuZEVs ZW1lbnQoCiAgICAgICAgICAgICB9IGVsc2UKICAgICAgICAgICAgICAgICBtX3NjcmlwdEVsZW1l bnQgPSAwOwogICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIG1fdmlldy0+ZnJhbWUoKS0+c2Ny aXB0KCktPmV4ZWN1dGVTY3JpcHQoU2NyaXB0U291cmNlQ29kZShzY3JpcHRFbGVtZW50LT5zY3Jp cHRDb250ZW50KCksIGRvY3VtZW50KCktPnVybCgpLCBtX3NjcmlwdFN0YXJ0UG9zaXRpb24pKTsK KyAgICAgICAgICAgIHNjcmlwdEVsZW1lbnQtPmV4ZWN1dGVTY3JpcHQoU2NyaXB0U291cmNlQ29k ZShzY3JpcHRFbGVtZW50LT5zY3JpcHRDb250ZW50KCksIGRvY3VtZW50KCktPnVybCgpLCBtX3Nj cmlwdFN0YXJ0UG9zaXRpb24pKTsKICAgICB9CiAgICAgbV9yZXF1ZXN0aW5nU2NyaXB0ID0gZmFs c2U7CiAgICAgcG9wQ3VycmVudE5vZGUoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcxODk3KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTAtMTEtMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3F0XSBzY3JpcHQtY2xvbmUgdGVz dHMgYWRkZWQgaW4gcjcxODk1IGZhaWxzIG9uIHF0IHBsYXRmb3JtCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTQyOQorCisgICAgICAgIEVuYWJsZWQg ZmFzdC9kb20vc2NyaXB0LWNsb25lLXJlcnVuLXNlbGYuaHRtbCBhbmQgZmFzdC9kb20vc2NyaXB0 LWNsb25lLXJlcnVuLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIw MTAtMTEtMTEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4gRGlzYWJsZSBTVkcgdGVzdHMgYWRkZWQgYnkgcjcxODk1IGJlY2F1c2UgUXQgaGFz IGl0cyBvd24gWE1MIHBhcnNlciwKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNp b24gNzE4OTcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNv cHkpCkBAIC0xNTA4LDEwICsxNTA4LDYgQEAgc3ZnL2RvbS9TVkdSZWN0RWxlbWVudC9yZWN0LW1v ZGlmeS1yeC5zdgogc3ZnL2hpeGllL2R5bmFtaWMvMDAyLnhtbAogc3ZnL2hpeGllL21peGVkLzAw Ny54bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5NjYK LXN2Zy9kb20vU1ZHU2NyaXB0RWxlbWVudC9zY3JpcHQtY2xvbmUtcmVydW4tc2VsZi5zdmcKLXN2 Zy9kb20vU1ZHU2NyaXB0RWxlbWVudC9zY3JpcHQtY2xvbmUtcmVydW4uc3ZnCi0KICMgPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0gIwogIyBmYWlsaW5nIGFuaW1hdGlvbnMgdGVzdHMKICMgPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0gIwo=