49363 2010-11-10 20:04:17 -0800 fix missing 'pid' argument for http lockfile checking on win32 2010-11-11 14:52:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth aroben eric galpeter michaeln ossy rgabor tony oldest_to_newest 307702 0 dpranke 2010-11-10 20:04:17 -0800 fix missing 'pid' argument for http lockfile checking on win32 307703 1 73574 dpranke 2010-11-10 20:04:51 -0800 Created attachment 73574 Patch 307726 2 73574 eric 2010-11-10 21:43:11 -0800 Comment on attachment 73574 Patch Makes sense. :) Can't we test this though? Or was it already failing a test on win32? 308102 3 dpranke 2010-11-11 13:33:16 -0800 I haven't actually tried this on windows, but there is an existing test in executive_unittest that should've keeled over. Of course, we can't run much of test-webkitpy on windows, so this test may not actually be running. I will verify it locally. 308105 4 michaeln 2010-11-11 13:37:49 -0800 I've run this patch on windows. Definitely fixes a problem with starting the http server when running layout tests. 308126 5 dpranke 2010-11-11 13:56:56 -0800 Okay, I've verified that the test did fail prior to the patch and does pass post-patch. Given that Michael has verified that it actually fixes NRWT as well :), we're good to go. 308179 6 73574 dpranke 2010-11-11 14:52:50 -0800 Comment on attachment 73574 Patch Clearing flags on attachment: 73574 Committed r71854: <http://trac.webkit.org/changeset/71854> 308180 7 dpranke 2010-11-11 14:52:55 -0800 All reviewed patches have been landed. Closing bug. 73574 2010-11-10 20:04:51 -0800 2010-11-11 14:52:50 -0800 Patch bug-49363-20101110200450.patch text/plain 1514 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYzY2N2VmYzU0MjllNjlmZDhmOGU3YWNlZmFiNWQzMThlNmVmZjFhLi4xMTk5ZmIz MTY5YTJlZDZmNjU2MzE4ZmE5MWM0MmJkZjljMzYzNjAyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTEtMTAgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZml4IG1pc3NpbmcgJ3Bp ZCcgYXJndW1lbnQgZm9yIGh0dHAgbG9ja2ZpbGUgY2hlY2tpbmcgb24gd2luMzIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MzYzCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5OgorCiAyMDEwLTEx LTEwICBDaHJpcyBHdWlsbG9yeSAgPGNocmlzLmd1aWxsb3J5QGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRmxlaXphY2guCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQppbmRleCAzN2Y0ZTUz ZjcxY2FkN2I5NTM0ZTJlY2ZmM2MyZDY2OGRkMGU4N2U2Li44NWE2ODNhODYzNTg5YmQwN2I4MGQ5 YmQ3MGMwY2U4Yzk3ZTI5OTEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKQEAgLTIwMSw3ICsyMDEsNyBAQCBj bGFzcyBFeGVjdXRpdmUob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuCiAgICAg ICAgICAgICAgICAgcmFpc2UKIAotICAgIGRlZiBfd2luMzJfY2hlY2tfcnVubmluZ19waWQoc2Vs Zik6CisgICAgZGVmIF93aW4zMl9jaGVja19ydW5uaW5nX3BpZChzZWxmLCBwaWQpOgogCiAgICAg ICAgIGNsYXNzIFBST0NFU1NFTlRSWTMyKGN0eXBlcy5TdHJ1Y3R1cmUpOgogICAgICAgICAgICAg X2ZpZWxkc18gPSBbKCJkd1NpemUiLCBjdHlwZXMuY191bG9uZyksCkBAIC0yNDYsNyArMjQ2LDcg QEAgY2xhc3MgRXhlY3V0aXZlKG9iamVjdCk6CiAgICAgICAgICAgICBleGNlcHQgT1NFcnJvcjoK ICAgICAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgZWxpZiBzeXMucGxhdGZvcm0g PT0gJ3dpbjMyJzoKLSAgICAgICAgICAgIHJldHVybiBzZWxmLl93aW4zMl9jaGVja19ydW5uaW5n X3BpZCgpCisgICAgICAgICAgICByZXR1cm4gc2VsZi5fd2luMzJfY2hlY2tfcnVubmluZ19waWQo cGlkKQogCiAgICAgICAgIGFzc2VydChGYWxzZSkKIAo=