49359 2010-11-10 19:22:50 -0800 [chromium] Missing adoptPtr in GraphicsContext3DSkia.cpp 2010-11-11 14:03:12 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth dglazkov eric fishd jamesr japhet webkit.review.bot oldest_to_newest 307690 0 kbr 2010-11-10 19:22:50 -0800 There's a missing adoptPtr in GraphicsContext3DSkia.cpp (GraphicsContext3D::getImageData) causing build failures in some situations. 307692 1 73570 kbr 2010-11-10 19:26:39 -0800 Created attachment 73570 Patch 308080 2 73570 jamesr 2010-11-11 13:01:27 -0800 Comment on attachment 73570 Patch R=me 308082 3 kbr 2010-11-11 13:05:50 -0800 Committed r71847: <http://trac.webkit.org/changeset/71847> 308133 4 webkit.review.bot 2010-11-11 14:03:12 -0800 http://trac.webkit.org/changeset/71847 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/workers/storage/interrupt-database-sync.html 73570 2010-11-10 19:26:39 -0800 2010-11-11 13:01:27 -0800 Patch bug-49359-20101110192638.patch text/plain 1568 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTc5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMTAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gTWlzc2luZyBhZG9wdFB0ciBpbiBHcmFwaGljc0NvbnRleHQzRFNraWEuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTM1OQorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHQzRFNraWEuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdlRGF0YSk6CisK IDIwMTAtMTAtMTUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHQzRFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHQzRFNraWEuY3BwCShyZXZp c2lvbiA3MTc5MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0Nv bnRleHQzRFNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw4IEBACiAjaW5jbHVk ZSAiSW1hZ2UuaCIKICNpbmNsdWRlICJJbWFnZVNvdXJjZS5oIgogI2luY2x1ZGUgIk5hdGl2ZUlt YWdlU2tpYS5oIgorI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRlIDx3dGYvUGFzc093 blB0ci5oPgogCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogCkBAIC01NSw3ICs1Nyw3IEBAIGJvb2wg R3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdlRGF0YShJbWEKICAgICAgICAgaWYgKCFkZWNvZGVy LmZyYW1lQ291bnQoKSB8fCAhZGVjb2Rlci5mcmFtZUlzQ29tcGxldGVBdEluZGV4KDApKQogICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBib29sIGhhc0FscGhhID0gZGVjb2Rlci5m cmFtZUhhc0FscGhhQXRJbmRleCgwKTsKLSAgICAgICAgcGl4ZWxzID0gZGVjb2Rlci5jcmVhdGVG cmFtZUF0SW5kZXgoMCk7CisgICAgICAgIHBpeGVscyA9IGFkb3B0UHRyKGRlY29kZXIuY3JlYXRl RnJhbWVBdEluZGV4KDApKTsKICAgICAgICAgaWYgKCFwaXhlbHMuZ2V0KCkgfHwgIXBpeGVscy0+ aXNEYXRhQ29tcGxldGUoKSB8fCAhcGl4ZWxzLT53aWR0aCgpIHx8ICFwaXhlbHMtPmhlaWdodCgp KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBTa0JpdG1hcDo6Q29uZmlnIHNr aWFDb25maWcgPSBwaXhlbHMtPmNvbmZpZygpOwo=