49338 2010-11-10 12:44:45 -0800 plugins/npruntime/enumerate.html shouldn't depend on object enumeration order 2010-11-10 16:22:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony abarth commit-queue dglazkov eric victorw webkit.review.bot oldest_to_newest 307496 0 tony 2010-11-10 12:44:45 -0800 plugins/npruntime/enumerate.html shouldn't depend on object enumeration order 307497 1 73528 tony 2010-11-10 12:47:08 -0800 Created attachment 73528 Patch 307513 2 73528 darin 2010-11-10 13:14:54 -0800 Comment on attachment 73528 Patch I suggest sorting as a solution to this sort of thing, rather than the set equality approach. 307533 3 73537 tony 2010-11-10 13:58:05 -0800 Created attachment 73537 Patch for landing 307534 4 tony 2010-11-10 13:58:45 -0800 (In reply to comment #2) > (From update of attachment 73528 [details]) > I suggest sorting as a solution to this sort of thing, rather than the set equality approach. Good idea. Done. 307588 5 commit-queue 2010-11-10 15:06:52 -0800 The commit-queue encountered the following flaky tests while processing attachment 73537: compositing/iframes/overlapped-nested-iframes.html Please file bugs against the tests. These tests were authored by simon.fraser@apple.com. The commit-queue is continuing to process your patch. 307589 6 73537 commit-queue 2010-11-10 15:08:25 -0800 Comment on attachment 73537 Patch for landing Clearing flags on attachment: 73537 Committed r71776: <http://trac.webkit.org/changeset/71776> 307590 7 commit-queue 2010-11-10 15:08:30 -0800 All reviewed patches have been landed. Closing bug. 307614 8 webkit.review.bot 2010-11-10 16:22:11 -0800 http://trac.webkit.org/changeset/71776 might have broken Leopard Intel Debug (Tests) 73528 2010-11-10 12:47:08 -0800 2010-11-10 13:57:58 -0800 Patch bug-49338-20101110124740.patch text/plain 3704 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNDAyNjhkN2U4NDM4MWE3MGUzNzAxNGViNTc0M2RhYWUxYjhhZDYxLi4xNDEyOTlk MjZmNzg5NjJlMDVhZDQwOGUzZWVlMTQ5NjNlNWM2ODRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTEtMTAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwbHVnaW5zL25wcnVudGltZS9l bnVtZXJhdGUuaHRtbCBzaG91bGRuJ3QgZGVwZW5kIG9uIG9iamVjdCBlbnVtZXJhdGlvbiBvcmRl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMzgK KworICAgICAgICBUaGUgRVMgc3BlYyBkb2Vzbid0IHNwZWNpZnkgdGhlIG9yZGVyLCBzbyB0aGUg dGVzdCBzaG91bGRuJ3QgZGVwZW5kIG9uIGl0LgorICAgICAgICBVbmZvcnR1bmF0ZWx5LCB0aGUg dGVzdCBzdGlsbCBmYWlscyBpbiBDaHJvbWl1bS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKyAgICAgICAgKiBwbHVnaW5zL25wcnVudGltZS9l bnVtZXJhdGUuaHRtbDoKKwogMjAxMC0xMS0xMCAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNv QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dAppbmRleCAzOTJiYjljZmYxZDRiNDQ1YTk2ZjhkNjkxNDgyNmZjOTNlMTVkM2UyLi42ZjgwNWYz MjI4NzBhN2M3YTFiODcxMmFmN2MxMmJhMTE3OTA2Y2IzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC03MTUsOSArNzE1 LDggQEAgQlVHSkFNRVNSIFdJTiBMSU5VWCA6IGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctaGFz c3BlbGxpbmdtYXJrZXIuaHRtbCA9IFRFWFQKIC8vIExvdyBwcmlvcml0eSwgdW5jbGVhciBpZiB0 ZXN0IGV4cGVjdGF0aW9ucyBhcmUgY29ycmVjdCAoc2VlIGJ1ZykKIEJVRzYxMzkgOiBmYXN0L2Zv cm1zL3NlbGVjdC13cml0aW5nLWRpcmVjdGlvbi1uYXR1cmFsLmh0bWwgPSBGQUlMCiAKLS8vIFdl IGRvbid0IHN1cHBvcnQgTlBOX0VudW1lcmF0ZSwgYnV0IGRvbid0IGtub3cgb2YgYW55IHBsdWdp bgotLy8gd2hpY2ggZGVwZW5kcyBvbiB0aGF0IGZ1bmN0aW9uYWxpdHkuICBTbyB3ZSBpZ25vcmUg dGhpcyBmb3IgYmV0YS4KLUJVRzIxOTAxIDogcGx1Z2lucy9ucHJ1bnRpbWUvZW51bWVyYXRlLmh0 bWwgPSBGQUlMCisvLyBPYmplY3Qua2V5cyBvbiBhbiBOUE9iamVjdCBwcm9kdWNlcyB0aGUgd3Jv bmcgb3V0cHV0LgorQlVHMjE5MDEgOiBwbHVnaW5zL25wcnVudGltZS9lbnVtZXJhdGUuaHRtbCA9 IFRFWFQKIAogLy8gRXhwZWN0YXRpb25zIGZvciB0aGlzIHRlc3QgY2hhbmdlZCB1cHN0cmVhbS4g V2Ugc2hvdWxkIGZpeCB0aGlzIHRlc3QsIGJ1dAogLy8gaXQgZG9lc24ndCBuZWVkIHRvIGJsb2Nr IHRoZSBjdXJyZW50IHJlbGVhc2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsdWdpbnMvbnBy dW50aW1lL2VudW1lcmF0ZS5odG1sIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9ucHJ1bnRpbWUvZW51 bWVyYXRlLmh0bWwKaW5kZXggYWU1NWJjZmRhMmU0ZWM5MTExOGUyODUwZjJmMDMxNDZhZDc3Y2Q4 Yi4uMzFhMDMyMDRlYTEwMDg3MTFjNDE2NjZmY2JmZWE2OGY0OTJlZDk5OCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGx1Z2lucy9ucHJ1bnRpbWUvZW51bWVyYXRlLmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvcGx1Z2lucy9ucHJ1bnRpbWUvZW51bWVyYXRlLmh0bWwKQEAgLTEsMTkgKzEsMzAgQEAK IDxodG1sPgogPHNjcmlwdD4KK2Z1bmN0aW9uIHNldHNBcmVFcXVhbChhcnJheTEsIGFycmF5MikK K3sKKyAgICBpZiAoYXJyYXkxLmxlbmd0aCAhPSBhcnJheTIubGVuZ3RoKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBhcnJheTEubGVuZ3RoOyArK2kpIHsK KyAgICAgICAgaWYgKGFycmF5Mi5pbmRleE9mKGFycmF5MVtpXSkgPT0gLTEpCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgfQorICAgIHJldHVybiB0cnVlOworfQorCiBmdW5jdGlvbiBy dW5UZXN0KCkKIHsKICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Ci0gICAgICAgIAorCiAgICAgdmFy IHBsdWdpbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0UGx1Z2luIik7CiAgICAgdmFy IHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKTsKLSAgICAKKwogICAg IC8vIEZpcnN0IHRlc3QgTlBOX0VudW1lcmF0ZSBmcm9tIHRoZSBwbHVnaW4ncyBzaWRlCiAgICAg dmFyIHRlc3RPYmplY3QgPSB7ICJvbmUiIDogMSwgInR3byIgOiAyLCAidGhyZWUiIDogMywgNCA6 IDQgfQogICAgIHZhciBvdXRBcnJheSA9IFtdOyAgICAKICAgICBwbHVnaW4udGVzdEVudW1lcmF0 ZSh0ZXN0T2JqZWN0LCBvdXRBcnJheSk7CiAKLSAgICBpZiAob3V0QXJyYXkudG9TdHJpbmcoKSAh PSAnb25lLHR3byx0aHJlZSw0JykgeworICAgIGlmICghc2V0c0FyZUVxdWFsKG91dEFycmF5LCBb J29uZScsICd0d28nLCAndGhyZWUnLCAnNCddKSkgewogICAgICAgICByZXN1bHQuaW5uZXJIVE1M ID0gJ0ZBSUxVUkU6IEFycmF5IHJldHVybmVkIGZyb20gcGx1Z2luIHdhcyAnICsgb3V0QXJyYXku dG9TdHJpbmcoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTI0LDE0ICszNSwxNCBAQCBm dW5jdGlvbiBydW5UZXN0KCkKICAgICAgICAgcHJvcE5hbWVzLnB1c2godik7CiAgICAgfQogICAg IAotICAgIGlmIChwcm9wTmFtZXMudG9TdHJpbmcoKSAhPSAnZm9vLGJhcicpIHsKKyAgICBpZiAo IXNldHNBcmVFcXVhbChwcm9wTmFtZXMsIFsnZm9vJywgJ2JhciddKSkgewogICAgICAgICByZXN1 bHQuaW5uZXJIVE1MID0gJ0ZBSUxVUkU6IFBsdWdpbiBvYmplY3QgcHJvcGVydGllcyB3YXMgJyAr IHByb3BOYW1lcy50b1N0cmluZygpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgLy8g Tm93IHRyeSBlbnVtZXJhdGluZyBhIHBsdWdpbiBvYmplY3QncyBwcm9wZXJ0aWVzIHVzaW5nIE9i amVjdC5rZXlzCiAgICAgdmFyIGtleXMgPSBPYmplY3Qua2V5cyhwbHVnaW4udGVzdE9iamVjdCk7 Ci0gICAgaWYgKGtleXMudG9TdHJpbmcoKSAhPSAnZm9vLGJhcicpIHsKKyAgICBpZiAoIXNldHNB cmVFcXVhbChrZXlzLCBbJ2ZvbycsICdiYXInXSkpIHsKICAgICAgICAgcmVzdWx0LmlubmVySFRN TCA9ICdGQUlMVVJFOiBQbHVnaW4gb2JqZWN0IHByb3BlcnRpZXMgcmV0dXJuZWQgYnkgT2JqZWN0 LmtleXMgd2VyZSAnICsga2V5cy50b1N0cmluZygpOwogICAgICAgICByZXR1cm47CiAgICAgfQo= 73537 2010-11-10 13:58:05 -0800 2010-11-10 15:08:25 -0800 Patch for landing bug-49338-20101110135804.patch text/plain 3428 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0YmZmNmUyYjg0MzgyOTc0Zjk4NjdkODRjNzdjNmQ2ZDU5YjQwODhlLi45ZjFjMjY1 Nzg4NDkzMDRmNzcwMzVhMjQwZGM0OTAxOTkzNzYzZDFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTEtMTAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBwbHVnaW5zL25wcnVudGltZS9lbnVt ZXJhdGUuaHRtbCBzaG91bGRuJ3QgZGVwZW5kIG9uIG9iamVjdCBlbnVtZXJhdGlvbiBvcmRlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMzgKKwor ICAgICAgICBUaGUgRVMgc3BlYyBkb2Vzbid0IHNwZWNpZnkgdGhlIG9yZGVyLCBzbyB0aGUgdGVz dCBzaG91bGRuJ3QgZGVwZW5kIG9uIGl0LgorICAgICAgICBVbmZvcnR1bmF0ZWx5LCB0aGUgdGVz dCBzdGlsbCBmYWlscyBpbiBDaHJvbWl1bS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKyAgICAgICAgKiBwbHVnaW5zL25wcnVudGltZS9lbnVt ZXJhdGUuaHRtbDoKKwogMjAxMC0xMS0xMCAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkOyB1cGRhdGVkIHRlc3QgYmFzZWxpbmVz LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0CmluZGV4IDNjNjU4MzFlZDIxZjdmNjE3YjVjZjgxNDQzNzhkYjI5ZTJmNjUzNGMuLjlh YzJjNDJlNTVjMzk1MWE5YTI1NTAwYzA4Zjk2YWQ0OGE0Y2M5MDEgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTcxNSw5 ICs3MTUsOCBAQCBCVUdKQU1FU1IgV0lOIExJTlVYIDogZWRpdGluZy9zcGVsbGluZy9zcGVsbGlu Zy1oYXNzcGVsbGluZ21hcmtlci5odG1sID0gVEVYVAogLy8gTG93IHByaW9yaXR5LCB1bmNsZWFy IGlmIHRlc3QgZXhwZWN0YXRpb25zIGFyZSBjb3JyZWN0IChzZWUgYnVnKQogQlVHNjEzOSA6IGZh c3QvZm9ybXMvc2VsZWN0LXdyaXRpbmctZGlyZWN0aW9uLW5hdHVyYWwuaHRtbCA9IEZBSUwKIAot Ly8gV2UgZG9uJ3Qgc3VwcG9ydCBOUE5fRW51bWVyYXRlLCBidXQgZG9uJ3Qga25vdyBvZiBhbnkg cGx1Z2luCi0vLyB3aGljaCBkZXBlbmRzIG9uIHRoYXQgZnVuY3Rpb25hbGl0eS4gIFNvIHdlIGln bm9yZSB0aGlzIGZvciBiZXRhLgotQlVHMjE5MDEgOiBwbHVnaW5zL25wcnVudGltZS9lbnVtZXJh dGUuaHRtbCA9IEZBSUwKKy8vIE9iamVjdC5rZXlzIG9uIGFuIE5QT2JqZWN0IHByb2R1Y2VzIHRo ZSB3cm9uZyBvdXRwdXQuCitCVUcyMTkwMSA6IHBsdWdpbnMvbnBydW50aW1lL2VudW1lcmF0ZS5o dG1sID0gVEVYVAogCiAvLyBFeHBlY3RhdGlvbnMgZm9yIHRoaXMgdGVzdCBjaGFuZ2VkIHVwc3Ry ZWFtLiBXZSBzaG91bGQgZml4IHRoaXMgdGVzdCwgYnV0CiAvLyBpdCBkb2Vzbid0IG5lZWQgdG8g YmxvY2sgdGhlIGN1cnJlbnQgcmVsZWFzZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lu cy9ucHJ1bnRpbWUvZW51bWVyYXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL25wcnVudGlt ZS9lbnVtZXJhdGUuaHRtbAppbmRleCBhZTU1YmNmZGEyZTRlYzkxMTE4ZTI4NTBmMmYwMzE0NmFk NzdjZDhiLi42YTBmNWQyZGMyN2Q3Y2U1YTQzMWU4YTI4NDJjYWNkYTA0N2M5YmVkIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbHVnaW5zL25wcnVudGltZS9lbnVtZXJhdGUuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9wbHVnaW5zL25wcnVudGltZS9lbnVtZXJhdGUuaHRtbApAQCAtNCwxNiArNCwx NiBAQCBmdW5jdGlvbiBydW5UZXN0KCkKIHsKICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Ci0gICAg ICAgIAorCiAgICAgdmFyIHBsdWdpbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0UGx1 Z2luIik7CiAgICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQn KTsKLSAgICAKKwogICAgIC8vIEZpcnN0IHRlc3QgTlBOX0VudW1lcmF0ZSBmcm9tIHRoZSBwbHVn aW4ncyBzaWRlCiAgICAgdmFyIHRlc3RPYmplY3QgPSB7ICJvbmUiIDogMSwgInR3byIgOiAyLCAi dGhyZWUiIDogMywgNCA6IDQgfQogICAgIHZhciBvdXRBcnJheSA9IFtdOyAgICAKICAgICBwbHVn aW4udGVzdEVudW1lcmF0ZSh0ZXN0T2JqZWN0LCBvdXRBcnJheSk7CiAKLSAgICBpZiAob3V0QXJy YXkudG9TdHJpbmcoKSAhPSAnb25lLHR3byx0aHJlZSw0JykgeworICAgIGlmIChvdXRBcnJheS5z b3J0KCkudG9TdHJpbmcoKSAhPSAnNCxvbmUsdGhyZWUsdHdvJykgewogICAgICAgICByZXN1bHQu aW5uZXJIVE1MID0gJ0ZBSUxVUkU6IEFycmF5IHJldHVybmVkIGZyb20gcGx1Z2luIHdhcyAnICsg b3V0QXJyYXkudG9TdHJpbmcoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTI0LDE0ICsy NCwxNCBAQCBmdW5jdGlvbiBydW5UZXN0KCkKICAgICAgICAgcHJvcE5hbWVzLnB1c2godik7CiAg ICAgfQogICAgIAotICAgIGlmIChwcm9wTmFtZXMudG9TdHJpbmcoKSAhPSAnZm9vLGJhcicpIHsK KyAgICBpZiAocHJvcE5hbWVzLnNvcnQoKS50b1N0cmluZygpICE9ICdiYXIsZm9vJykgewogICAg ICAgICByZXN1bHQuaW5uZXJIVE1MID0gJ0ZBSUxVUkU6IFBsdWdpbiBvYmplY3QgcHJvcGVydGll cyB3YXMgJyArIHByb3BOYW1lcy50b1N0cmluZygpOwogICAgICAgICByZXR1cm47CiAgICAgfQog CiAgICAgLy8gTm93IHRyeSBlbnVtZXJhdGluZyBhIHBsdWdpbiBvYmplY3QncyBwcm9wZXJ0aWVz IHVzaW5nIE9iamVjdC5rZXlzCiAgICAgdmFyIGtleXMgPSBPYmplY3Qua2V5cyhwbHVnaW4udGVz dE9iamVjdCk7Ci0gICAgaWYgKGtleXMudG9TdHJpbmcoKSAhPSAnZm9vLGJhcicpIHsKKyAgICBp ZiAoa2V5cy5zb3J0KCkudG9TdHJpbmcoKSAhPSAnYmFyLGZvbycpIHsKICAgICAgICAgcmVzdWx0 LmlubmVySFRNTCA9ICdGQUlMVVJFOiBQbHVnaW4gb2JqZWN0IHByb3BlcnRpZXMgcmV0dXJuZWQg YnkgT2JqZWN0LmtleXMgd2VyZSAnICsga2V5cy50b1N0cmluZygpOwogICAgICAgICByZXR1cm47 CiAgICAgfQo=