49336 2010-11-10 12:30:38 -0800 [chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl 2010-11-12 13:39:47 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr zmo enne jamesr zmo oldest_to_newest 307482 0 kbr 2010-11-10 12:30:38 -0800 In https://bugs.webkit.org/show_bug.cgi?id=48282 I missed a few places where m_isGLES2 should be tested instead of calling gfx::GetGLImplementation(). 307483 1 73524 kbr 2010-11-10 12:33:48 -0800 Created attachment 73524 Patch 307488 2 73524 jamesr 2010-11-10 12:38:41 -0800 Comment on attachment 73524 Patch R=me 307686 3 kbr 2010-11-10 19:10:01 -0800 Committed r71793: <http://trac.webkit.org/changeset/71793> 308648 4 zmo 2010-11-12 10:54:51 -0800 There is a regression in this patch that causes worlds of webgl render incorrectly in in-process-webgl 308656 5 73762 zmo 2010-11-12 11:08:26 -0800 Created attachment 73762 patch: simple fix for the regression point-size.html should have detected this regression, only unfortunately due to mesa backend issues, this test is ignored in chromium bots. 308736 6 73762 kling 2010-11-12 13:30:31 -0800 Comment on attachment 73762 patch: simple fix for the regression r=me 308747 7 zmo 2010-11-12 13:39:47 -0800 Committed r71942: <http://trac.webkit.org/changeset/71942> 73524 2010-11-10 12:33:48 -0800 2010-11-10 12:38:41 -0800 Patch bug-49336-20101110123347.patch text/plain 2913 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzE3NjEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMTAgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQ2xlYW4gdXAgZ2Z4OjpHZXRHTEltcGxl bWVudGF0aW9uIGNhbGxzIGluIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MzM2CisKKyAgICAg ICAgKiBzcmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6OmluaXRpYWxpemUpOgorICAg ICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjpyZXNoYXBlKToK KyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6cmVhZEJh Y2tGcmFtZWJ1ZmZlcik6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNERGVm YXVsdEltcGw6OmdldEludGVnZXJ2KToKKwogMjAxMC0xMS0xMCAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEh5YXR0LgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdyYXBoaWNzQ29udGV4 dDNERGVmYXVsdEltcGwuY3BwCShyZXZpc2lvbiA3MTc2MSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE3MCw3ICsxNzAsOSBAQCBib29sIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6Omlu CiAKICAgICB2YWxpZGF0ZUF0dHJpYnV0ZXMoKTsKIAotICAgIGlmIChnZng6OkdldEdMSW1wbGVt ZW50YXRpb24oKSAhPSBnZng6OmtHTEltcGxlbWVudGF0aW9uRUdMR0xFUzIpIHsKKyAgICBtX2lz R0xFUzIgPSBnZng6OkdldEdMSW1wbGVtZW50YXRpb24oKSA9PSBnZng6OmtHTEltcGxlbWVudGF0 aW9uRUdMR0xFUzI7CisKKyAgICBpZiAobV9pc0dMRVMyKSB7CiAgICAgICAgIGdsRW5hYmxlKEdM X1ZFUlRFWF9QUk9HUkFNX1BPSU5UX1NJWkUpOwogICAgICAgICBnbEVuYWJsZShHTF9QT0lOVF9T UFJJVEUpOwogICAgIH0KQEAgLTE4Myw3ICsxODUsNiBAQCBib29sIFdlYkdyYXBoaWNzQ29udGV4 dDNERGVmYXVsdEltcGw6OmluCiAgICAgZ2xHZW5GcmFtZWJ1ZmZlcnNFWFQoMSwgJm1fY29weVRl eHR1cmVUb1BhcmVudFRleHR1cmVGQk8pOwogCiAgICAgbV9pbml0aWFsaXplZCA9IHRydWU7Ci0g ICAgbV9pc0dMRVMyID0gZ2Z4OjpHZXRHTEltcGxlbWVudGF0aW9uKCkgPT0gZ2Z4OjprR0xJbXBs ZW1lbnRhdGlvbkVHTEdMRVMyOwogICAgIHJldHVybiB0cnVlOwogfQogCkBAIC0zNjAsNyArMzYx LDcgQEAgdm9pZCBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjpyZQogICAgICAgICBp ZiAobV9hdHRyaWJ1dGVzLnN0ZW5jaWwgJiYgbV9hdHRyaWJ1dGVzLmRlcHRoKQogICAgICAgICAg ICAgaW50ZXJuYWxEZXB0aFN0ZW5jaWxGb3JtYXQgPSBHTF9ERVBUSDI0X1NURU5DSUw4X0VYVDsK ICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBpZiAoZ2Z4OjpHZXRHTEltcGxlbWVudGF0aW9u KCkgPT0gZ2Z4OjprR0xJbXBsZW1lbnRhdGlvbkVHTEdMRVMyKQorICAgICAgICAgICAgaWYgKG1f aXNHTEVTMikKICAgICAgICAgICAgICAgICBpbnRlcm5hbERlcHRoU3RlbmNpbEZvcm1hdCA9IEdM X0RFUFRIX0NPTVBPTkVOVDE2OwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIGlu dGVybmFsRGVwdGhTdGVuY2lsRm9ybWF0ID0gR0xfREVQVEhfQ09NUE9ORU5UOwpAQCAtNTQwLDcg KzU0MSw3IEBAIGJvb2wgV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6cmUKICAgICAg ICAgbXVzdFJlc3RvcmVQYWNrQWxpZ25tZW50ID0gdHJ1ZTsKICAgICB9CiAKLSAgICBpZiAoZ2Z4 OjpHZXRHTEltcGxlbWVudGF0aW9uKCkgPT0gZ2Z4OjprR0xJbXBsZW1lbnRhdGlvbkVHTEdMRVMy KSB7CisgICAgaWYgKG1faXNHTEVTMikgewogICAgICAgICAvLyBGSVhNRTogY29uc2lkZXIgdGVz dGluZyBmb3IgcHJlc2VuY2Ugb2YgR0xfT0VTX3JlYWRfZm9ybWF0CiAgICAgICAgIC8vIGFuZCBH TF9FWFRfcmVhZF9mb3JtYXRfYmdyYSwgYW5kIHVzaW5nIEdMX0JHUkFfRVhUIGhlcmUKICAgICAg ICAgLy8gZGlyZWN0bHkuCkBAIC05OTAsNyArOTkxLDcgQEAgdm9pZCBXZWJHcmFwaGljc0NvbnRl eHQzRERlZmF1bHRJbXBsOjpnZQogdm9pZCBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBs OjpnZXRJbnRlZ2Vydih1bnNpZ25lZCBsb25nIHBuYW1lLCBpbnQqIHZhbHVlKQogewogICAgIG1h a2VDb250ZXh0Q3VycmVudCgpOwotICAgIGlmIChnZng6OkdldEdMSW1wbGVtZW50YXRpb24oKSA9 PSBnZng6OmtHTEltcGxlbWVudGF0aW9uRUdMR0xFUzIpIHsKKyAgICBpZiAobV9pc0dMRVMyKSB7 CiAgICAgICAgIGdsR2V0SW50ZWdlcnYocG5hbWUsIHZhbHVlKTsKICAgICAgICAgcmV0dXJuOwog ICAgIH0K 73762 2010-11-12 11:08:26 -0800 2010-11-12 13:30:31 -0800 patch: simple fix for the regression fix.patch text/plain 1274 zmo SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzE5MzEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMTIgIFpoZW55 YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsIGRvZXMgbm90 IHJ1biBvbiB0b3Agb2YgT3BlbkdMIEVTIDIuMCBpbXBsZW1lbnRhdGlvbnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MjgyCisKKyAgICAgICAgU2lt cGxlIGZpeCBmb3IgYSByZWdyZXNzaW9uIGludHJvZHVjZWQgaW4gcjcxNzkzLgorCisgICAgICAg ICogc3JjL1dlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjppbml0aWFsaXplKToKKwogMjAx MC0xMS0xMiAgSWx5YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJH cmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwuY3BwCShyZXZpc2lvbiA3 MTkzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0 SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Miw3ICsxNzIsNyBAQCBib29sIFdlYkdyYXBo aWNzQ29udGV4dDNERGVmYXVsdEltcGw6OmluCiAKICAgICBtX2lzR0xFUzIgPSBnZng6OkdldEdM SW1wbGVtZW50YXRpb24oKSA9PSBnZng6OmtHTEltcGxlbWVudGF0aW9uRUdMR0xFUzI7CiAKLSAg ICBpZiAobV9pc0dMRVMyKSB7CisgICAgaWYgKCFtX2lzR0xFUzIpIHsKICAgICAgICAgZ2xFbmFi bGUoR0xfVkVSVEVYX1BST0dSQU1fUE9JTlRfU0laRSk7CiAgICAgICAgIGdsRW5hYmxlKEdMX1BP SU5UX1NQUklURSk7CiAgICAgfQo=