49329 2010-11-10 10:51:36 -0800 Do not allow access to session and local storage when in private browsing mode 2010-12-01 09:18:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.6 RESOLVED FIXED P2 Normal --- 1 adauria webkit-unassigned abarth adauria andersca beidson commit-queue darin ddkilzer eric joepeck kdecker webkit.review.bot oldest_to_newest 307428 0 adauria 2010-11-10 10:51:36 -0800 WebKit shouldn't allow read or write access to session and local storage when in private browsing mode. 307435 1 73510 adauria 2010-11-10 10:59:00 -0800 Created attachment 73510 [PATCH] checks privateBrowsingEnabled() on local/session storage access Check privateBrowsingEnabled() on local/session storage reads from WebCore::Storage. WebCore::StorageAreaImpl checks the privateBrowsingEnabled setting on writes, so perhaps this patch should be in StorageAreaImpl, though that would require a change to the interface to pass down a frame pointer. I would actually prefer moving all the checks to WebCore::Storage. If the reviewer thinks we should deny access at the same level, -r this patch. 307641 2 73510 darin 2010-11-10 17:04:39 -0800 Comment on attachment 73510 [PATCH] checks privateBrowsingEnabled() on local/session storage access Patch looks good, but it’s missing a change log entry. review- because of lack of ChangeLog 307653 3 73561 adauria 2010-11-10 17:31:26 -0800 Created attachment 73561 [PATCH] Do not allow access to session and local storage when in private browsing mode (with ChangeLog) Now includes ChangeLog. 307657 4 73561 darin 2010-11-10 17:35:25 -0800 Comment on attachment 73561 [PATCH] Do not allow access to session and local storage when in private browsing mode (with ChangeLog) View in context: https://bugs.webkit.org/attachment.cgi?id=73561&action=review > WebCore/storage/Storage.cpp:59 > - if (!m_frame) > + if (!m_frame || m_frame->page()->settings()->privateBrowsingEnabled()) We need to null-check page too. It’s possible for a frame to outlive its page and thus have 0 for a page. But settings is guaranteed to be non-zero for any page. Sorry, I missed that earlier. 307661 5 73563 adauria 2010-11-10 17:51:40 -0800 Created attachment 73563 [PATCH] Deny local storage access in private browsing (page null check before checking settings) Adding Page pointer null check before checking private browsing setting. 307899 6 73563 darin 2010-11-11 07:12:09 -0800 Comment on attachment 73563 [PATCH] Deny local storage access in private browsing (page null check before checking settings) Could also have done the early return was page was 0, but this should be OK. 307963 7 commit-queue 2010-11-11 09:30:35 -0800 The commit-queue encountered the following flaky tests while processing attachment 73563: storage/domstorage/localstorage/private-browsing-affects-storage.html media/video-reverse-play-duration.html Please file bugs against the tests. These tests were authored by beidson@apple.com, eric.carlson@apple.com, and mrowe@apple.com. The commit-queue is continuing to process your patch. 308008 8 73563 commit-queue 2010-11-11 11:14:28 -0800 Comment on attachment 73563 [PATCH] Deny local storage access in private browsing (page null check before checking settings) Rejecting patch 73563 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ...................... printing/css2.1 ......... scrollbars .................. security .... storage .................................. storage/domstorage ...... storage/domstorage/events ..... storage/domstorage/localstorage ..... storage/domstorage/localstorage/private-browsing-affects-storage.html -> failed Exiting early after 1 failures. 18370 tests run. 465.07s total testing time 18369 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/5469115 309542 9 73951 adauria 2010-11-15 18:34:26 -0800 Created attachment 73951 Adding layout test update 309660 10 73563 eric 2010-11-16 03:20:46 -0800 Comment on attachment 73563 [PATCH] Deny local storage access in private browsing (page null check before checking settings) Cleared Darin Adler's review+ from obsolete attachment 73563 so that this bug does not appear in http://webkit.org/pending-commit. 315483 11 73951 kdecker 2010-11-30 19:10:14 -0800 Comment on attachment 73951 Adding layout test update r=me 315506 12 commit-queue 2010-11-30 20:45:37 -0800 The commit-queue encountered the following flaky tests while processing attachment 73951: fast/dom/onerror-img.html fast/preloader/script.html Please file bugs against the tests. These tests were authored by abarth@webkit.org. The commit-queue is continuing to process your patch. 315586 13 commit-queue 2010-12-01 03:29:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 73951: fast/workers/storage/use-same-database-in-page-and-workers.html animations/dynamic-stylesheet-loading.html Please file bugs against the tests. These tests were authored by cmarrin@apple.com and dumi@chromium.org. The commit-queue is continuing to process your patch. 315592 14 73951 commit-queue 2010-12-01 04:05:47 -0800 Comment on attachment 73951 Adding layout test update Clearing flags on attachment: 73951 Committed r73015: <http://trac.webkit.org/changeset/73015> 315593 15 commit-queue 2010-12-01 04:05:53 -0800 All reviewed patches have been landed. Closing bug. 315595 16 commit-queue 2010-12-01 04:19:21 -0800 The commit-queue encountered the following flaky tests while processing attachment 73951: fast/preloader/script.html animations/dynamic-stylesheet-loading.html Please file bugs against the tests. These tests were authored by abarth@webkit.org and cmarrin@apple.com. The commit-queue is continuing to process your patch. 315683 17 webkit.review.bot 2010-12-01 09:18:16 -0800 http://trac.webkit.org/changeset/73015 might have broken GTK Linux 32-bit Debug 73510 2010-11-10 10:59:00 -0800 2010-11-10 17:31:26 -0800 [PATCH] checks privateBrowsingEnabled() on local/session storage access private_browsing_local_storage.patch text/plain 1390 adauria ZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNwcCBiL1dlYkNvcmUvc3RvcmFn ZS9TdG9yYWdlLmNwcAppbmRleCAwYThlZWQ3Li5hYTdkNTdiIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3N0b3JhZ2UvU3RvcmFnZS5jcHAKKysrIGIvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2UuY3BwCkBA IC0yOCw2ICsyOCw5IEBACiAKICNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCiAKKyNpbmNsdWRlICJG cmFtZS5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKKyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1 ZGUgIlN0b3JhZ2VBcmVhLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKICNpbmNsdWRl IDx3dGYvUGFzc1JlZlB0ci5oPgpAQCAtNTMsNyArNTYsNyBAQCBTdG9yYWdlOjp+U3RvcmFnZSgp CiAKIHVuc2lnbmVkIFN0b3JhZ2U6Omxlbmd0aCgpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX2ZyYW1l KQorICAgIGlmICghbV9mcmFtZSB8fCBtX2ZyYW1lLT5wYWdlKCktPnNldHRpbmdzKCktPnByaXZh dGVCcm93c2luZ0VuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICByZXR1cm4gbV9z dG9yYWdlQXJlYS0+bGVuZ3RoKCk7CkBAIC02MSw3ICs2NCw3IEBAIHVuc2lnbmVkIFN0b3JhZ2U6 Omxlbmd0aCgpIGNvbnN0CiAKIFN0cmluZyBTdG9yYWdlOjprZXkodW5zaWduZWQgaW5kZXgpIGNv bnN0CiB7Ci0gICAgaWYgKCFtX2ZyYW1lKQorICAgIGlmICghbV9mcmFtZSB8fCBtX2ZyYW1lLT5w YWdlKCktPnNldHRpbmdzKCktPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKICAgICAgICAgcmV0 dXJuIFN0cmluZygpOwogCiAgICAgcmV0dXJuIG1fc3RvcmFnZUFyZWEtPmtleShpbmRleCk7CkBA IC02OSw3ICs3Miw3IEBAIFN0cmluZyBTdG9yYWdlOjprZXkodW5zaWduZWQgaW5kZXgpIGNvbnN0 CiAKIFN0cmluZyBTdG9yYWdlOjpnZXRJdGVtKGNvbnN0IFN0cmluZyYga2V5KSBjb25zdAogewot ICAgIGlmICghbV9mcmFtZSkKKyAgICBpZiAoIW1fZnJhbWUgfHwgbV9mcmFtZS0+cGFnZSgpLT5z ZXR0aW5ncygpLT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAgICAgICAgIHJldHVybiBTdHJp bmcoKTsKIAogICAgIHJldHVybiBtX3N0b3JhZ2VBcmVhLT5nZXRJdGVtKGtleSk7CkBAIC0xMDIs NyArMTA1LDcgQEAgdm9pZCBTdG9yYWdlOjpjbGVhcigpCiAKIGJvb2wgU3RvcmFnZTo6Y29udGFp bnMoY29uc3QgU3RyaW5nJiBrZXkpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX2ZyYW1lKQorICAgIGlm ICghbV9mcmFtZSB8fCBtX2ZyYW1lLT5wYWdlKCktPnNldHRpbmdzKCktPnByaXZhdGVCcm93c2lu Z0VuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmV0dXJuIG1fc3RvcmFn ZUFyZWEtPmNvbnRhaW5zKGtleSk7Cg== 73561 2010-11-10 17:31:26 -0800 2010-11-10 17:51:40 -0800 [PATCH] Do not allow access to session and local storage when in private browsing mode (with ChangeLog) private_local_storage_ChangeLog.diff text/plain 2035 adauria ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWQwMjVlNS4uZTgyNDc3YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0xMCAgQW50b24gRCdBdXJp YSAgPGFkYXVyaWFAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERlbnkgYWNjZXNzIHRvIGxvY2FsIGFuZCBzZXNzaW9uIHN0b3JhZ2Ug aW4gcHJpdmF0ZSBicm93c2luZyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMjkKKworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlOjpsZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6 U3RvcmFnZTo6a2V5KToKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2U6OmdldEl0ZW0pOgorICAg ICAgICAoV2ViQ29yZTo6U3RvcmFnZTo6Y29udGFpbnMpOgorCiAyMDEwLTExLTEwICBQYXNjYWwg TWFzc2ltaW5vICA8cGFzY2FsLm1hc3NpbWlub0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNw cCBiL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNwcAppbmRleCAwYThlZWQ3Li5hYTdkNTdiIDEw MDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZS5jcHAKKysrIGIvV2ViQ29yZS9zdG9y YWdlL1N0b3JhZ2UuY3BwCkBAIC0yOCw2ICsyOCw5IEBACiAKICNpZiBFTkFCTEUoRE9NX1NUT1JB R0UpCiAKKyNpbmNsdWRlICJGcmFtZS5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKKyNpbmNsdWRlICJT ZXR0aW5ncy5oIgogI2luY2x1ZGUgIlN0b3JhZ2VBcmVhLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1T dHJpbmcuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgpAQCAtNTMsNyArNTYsNyBAQCBT dG9yYWdlOjp+U3RvcmFnZSgpCiAKIHVuc2lnbmVkIFN0b3JhZ2U6Omxlbmd0aCgpIGNvbnN0CiB7 Ci0gICAgaWYgKCFtX2ZyYW1lKQorICAgIGlmICghbV9mcmFtZSB8fCBtX2ZyYW1lLT5wYWdlKCkt PnNldHRpbmdzKCktPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIDA7 CiAKICAgICByZXR1cm4gbV9zdG9yYWdlQXJlYS0+bGVuZ3RoKCk7CkBAIC02MSw3ICs2NCw3IEBA IHVuc2lnbmVkIFN0b3JhZ2U6Omxlbmd0aCgpIGNvbnN0CiAKIFN0cmluZyBTdG9yYWdlOjprZXko dW5zaWduZWQgaW5kZXgpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX2ZyYW1lKQorICAgIGlmICghbV9m cmFtZSB8fCBtX2ZyYW1lLT5wYWdlKCktPnNldHRpbmdzKCktPnByaXZhdGVCcm93c2luZ0VuYWJs ZWQoKSkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogCiAgICAgcmV0dXJuIG1fc3RvcmFnZUFy ZWEtPmtleShpbmRleCk7CkBAIC02OSw3ICs3Miw3IEBAIFN0cmluZyBTdG9yYWdlOjprZXkodW5z aWduZWQgaW5kZXgpIGNvbnN0CiAKIFN0cmluZyBTdG9yYWdlOjpnZXRJdGVtKGNvbnN0IFN0cmlu ZyYga2V5KSBjb25zdAogewotICAgIGlmICghbV9mcmFtZSkKKyAgICBpZiAoIW1fZnJhbWUgfHwg bV9mcmFtZS0+cGFnZSgpLT5zZXR0aW5ncygpLT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAg ICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAogICAgIHJldHVybiBtX3N0b3JhZ2VBcmVhLT5nZXRJ dGVtKGtleSk7CkBAIC0xMDIsNyArMTA1LDcgQEAgdm9pZCBTdG9yYWdlOjpjbGVhcigpCiAKIGJv b2wgU3RvcmFnZTo6Y29udGFpbnMoY29uc3QgU3RyaW5nJiBrZXkpIGNvbnN0CiB7Ci0gICAgaWYg KCFtX2ZyYW1lKQorICAgIGlmICghbV9mcmFtZSB8fCBtX2ZyYW1lLT5wYWdlKCktPnNldHRpbmdz KCktPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAg ICAgcmV0dXJuIG1fc3RvcmFnZUFyZWEtPmNvbnRhaW5zKGtleSk7Cg== 73563 2010-11-10 17:51:40 -0800 2010-11-16 03:20:46 -0800 [PATCH] Deny local storage access in private browsing (page null check before checking settings) private_local_storage_ChangeLog_pageNullCheck.diff text/plain 2119 adauria ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWQwMjVlNS4uMWUzNTFhYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0xMCAgQW50b24gRCdBdXJp YSAgPGFkYXVyaWFAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERlbnkgYWNjZXNzIHRvIGxvY2FsIGFuZCBzZXNzaW9uIHN0b3JhZ2Ug aW4gcHJpdmF0ZSBicm93c2luZyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMjkKKworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlOjpsZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6 U3RvcmFnZTo6a2V5KToKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2U6OmdldEl0ZW0pOgorICAg ICAgICAoV2ViQ29yZTo6U3RvcmFnZTo6Y29udGFpbnMpOgorCiAyMDEwLTExLTEwICBQYXNjYWwg TWFzc2ltaW5vICA8cGFzY2FsLm1hc3NpbWlub0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNw cCBiL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNwcAppbmRleCAwYThlZWQ3Li5kZGE1ZTY5IDEw MDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZS5jcHAKKysrIGIvV2ViQ29yZS9zdG9y YWdlL1N0b3JhZ2UuY3BwCkBAIC0yOCw2ICsyOCw5IEBACiAKICNpZiBFTkFCTEUoRE9NX1NUT1JB R0UpCiAKKyNpbmNsdWRlICJGcmFtZS5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKKyNpbmNsdWRlICJT ZXR0aW5ncy5oIgogI2luY2x1ZGUgIlN0b3JhZ2VBcmVhLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1T dHJpbmcuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgpAQCAtNTMsNyArNTYsNyBAQCBT dG9yYWdlOjp+U3RvcmFnZSgpCiAKIHVuc2lnbmVkIFN0b3JhZ2U6Omxlbmd0aCgpIGNvbnN0CiB7 Ci0gICAgaWYgKCFtX2ZyYW1lKQorICAgIGlmICghbV9mcmFtZSB8fCAobV9mcmFtZS0+cGFnZSgp ICYmIG1fZnJhbWUtPnBhZ2UoKS0+c2V0dGluZ3MoKS0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgp KSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICByZXR1cm4gbV9zdG9yYWdlQXJlYS0+bGVuZ3Ro KCk7CkBAIC02MSw3ICs2NCw3IEBAIHVuc2lnbmVkIFN0b3JhZ2U6Omxlbmd0aCgpIGNvbnN0CiAK IFN0cmluZyBTdG9yYWdlOjprZXkodW5zaWduZWQgaW5kZXgpIGNvbnN0CiB7Ci0gICAgaWYgKCFt X2ZyYW1lKQorICAgIGlmICghbV9mcmFtZSB8fCAobV9mcmFtZS0+cGFnZSgpICYmIG1fZnJhbWUt PnBhZ2UoKS0+c2V0dGluZ3MoKS0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKSkKICAgICAgICAg cmV0dXJuIFN0cmluZygpOwogCiAgICAgcmV0dXJuIG1fc3RvcmFnZUFyZWEtPmtleShpbmRleCk7 CkBAIC02OSw3ICs3Miw3IEBAIFN0cmluZyBTdG9yYWdlOjprZXkodW5zaWduZWQgaW5kZXgpIGNv bnN0CiAKIFN0cmluZyBTdG9yYWdlOjpnZXRJdGVtKGNvbnN0IFN0cmluZyYga2V5KSBjb25zdAog ewotICAgIGlmICghbV9mcmFtZSkKKyAgICBpZiAoIW1fZnJhbWUgfHwgKG1fZnJhbWUtPnBhZ2Uo KSAmJiBtX2ZyYW1lLT5wYWdlKCktPnNldHRpbmdzKCktPnByaXZhdGVCcm93c2luZ0VuYWJsZWQo KSkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAogICAgIHJldHVybiBtX3N0b3JhZ2VBcmVh LT5nZXRJdGVtKGtleSk7CkBAIC0xMDIsNyArMTA1LDcgQEAgdm9pZCBTdG9yYWdlOjpjbGVhcigp CiAKIGJvb2wgU3RvcmFnZTo6Y29udGFpbnMoY29uc3QgU3RyaW5nJiBrZXkpIGNvbnN0CiB7Ci0g ICAgaWYgKCFtX2ZyYW1lKQorICAgIGlmICghbV9mcmFtZSB8fCAobV9mcmFtZS0+cGFnZSgpICYm IG1fZnJhbWUtPnBhZ2UoKS0+c2V0dGluZ3MoKS0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmV0dXJuIG1fc3RvcmFnZUFyZWEtPmNvbnRh aW5zKGtleSk7Cg== 73951 2010-11-15 18:34:26 -0800 2010-12-01 04:05:47 -0800 Adding layout test update private_local_storage_LayoutTests.diff text/plain 4779 adauria ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZDk2ZjFhLi5hNzU3YjBjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEt MTUgIEFudG9uIEQnQXVyaWEgIDxhZGF1cmlhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcml2YXRlIGJyb3dzaW5nIGRlbmllcyBy ZWFkIGFjY2VzcyB0byBsb2NhbCBhbmQgc2Vzc2lvbiBzdG9yYWdlLAorICAgICAgICBzbyB1cGRh dGluZyBleHBlY3RlZCB0ZXN0IHJlc3VsdHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MzI5CisKKyAgICAgICAgKiBzdG9yYWdlL2RvbXN0b3Jh Z2UvbG9jYWxzdG9yYWdlL3ByaXZhdGUtYnJvd3NpbmctYWZmZWN0cy1zdG9yYWdlLWV4cGVjdGVk LnR4dDoKKyAgICAgICAgKiBzdG9yYWdlL2RvbXN0b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2UvcHJpdmF0 ZS1icm93c2luZy1hZmZlY3RzLXN0b3JhZ2UtZXhwZWN0ZWQudHh0OgorCiAyMDEwLTExLTE1ICBa aGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgc2tpcCBm YWlsaW5nIFdlYkdMIHRlc3QuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2RvbXN0 b3JhZ2UvbG9jYWxzdG9yYWdlL3ByaXZhdGUtYnJvd3NpbmctYWZmZWN0cy1zdG9yYWdlLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3JhZ2UvcHJp dmF0ZS1icm93c2luZy1hZmZlY3RzLXN0b3JhZ2UtZXhwZWN0ZWQudHh0CmluZGV4IDZkZTQyOTYu LjJmZWEwNjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvZG9tc3RvcmFnZS9sb2Nh bHN0b3JhZ2UvcHJpdmF0ZS1icm93c2luZy1hZmZlY3RzLXN0b3JhZ2UtZXhwZWN0ZWQudHh0Cisr KyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3JhZ2UvcHJpdmF0ZS1i cm93c2luZy1hZmZlY3RzLXN0b3JhZ2UtZXhwZWN0ZWQudHh0CkBAIC0xLDcgKzEsNyBAQAogVGhp cyBpcyBhIHRlc3QgdG8gbWFrZSBzdXJlIHRoYXQgd2hlbiBwcml2YXRlIGJyb3dzaW5nIGlzIG9u IGFueSBhdHRlbXB0IHRvIGNoYW5nZSB0aGUgbG9jYWxTdG9yYWdlIGFyZWEgZmFpbC4KLUluaXRp YWwgdmFsdWUgb2YgdGVzdEl0ZW0gaXM6IEluaXRpYWxWYWx1ZQorSW5pdGlhbCB2YWx1ZSBvZiB0 ZXN0SXRlbSBpczogbnVsbAogQ2F1Z2h0IGV4Y2VwdGlvbiB0cnlpbmcgdG8gY2hhbmdlIGl0ZW06 IEVycm9yOiBRVU9UQV9FWENFRURFRF9FUlI6IERPTSBFeGNlcHRpb24gMjIKLUFmdGVyIGNoYW5n ZSBhdHRlbXB0LCB0ZXN0SXRlbSBpczogSW5pdGlhbFZhbHVlCi1BZnRlciByZW1vdmUgYXR0ZW1w dCwgdGVzdEl0ZW0gaXM6IEluaXRpYWxWYWx1ZQotQWZ0ZXIgY2xlYXIgYXR0ZW1wdCwgdGVzdEl0 ZW0gaXM6IEluaXRpYWxWYWx1ZQorQWZ0ZXIgY2hhbmdlIGF0dGVtcHQsIHRlc3RJdGVtIGlzOiBu dWxsCitBZnRlciByZW1vdmUgYXR0ZW1wdCwgdGVzdEl0ZW0gaXM6IG51bGwKK0FmdGVyIGNsZWFy IGF0dGVtcHQsIHRlc3RJdGVtIGlzOiBudWxsCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0 b3JhZ2UvZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9wcml2YXRlLWJyb3dzaW5nLWFmZmVjdHMt c3RvcmFnZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2RvbXN0b3JhZ2Uvc2Vz c2lvbnN0b3JhZ2UvcHJpdmF0ZS1icm93c2luZy1hZmZlY3RzLXN0b3JhZ2UtZXhwZWN0ZWQudHh0 CmluZGV4IGVkMjAxN2EuLjU4Yzk5ZjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2Uv ZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9wcml2YXRlLWJyb3dzaW5nLWFmZmVjdHMtc3RvcmFn ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9kb21zdG9yYWdlL3Nlc3Np b25zdG9yYWdlL3ByaXZhdGUtYnJvd3NpbmctYWZmZWN0cy1zdG9yYWdlLWV4cGVjdGVkLnR4dApA QCAtMSw3ICsxLDcgQEAKIFRoaXMgaXMgYSB0ZXN0IHRvIG1ha2Ugc3VyZSB0aGF0IHdoZW4gcHJp dmF0ZSBicm93c2luZyBpcyBvbiBhbnkgYXR0ZW1wdCB0byBjaGFuZ2UgdGhlIHNlc3Npb25TdG9y YWdlIGFyZWEgZmFpbC4KLUluaXRpYWwgdmFsdWUgb2YgdGVzdEl0ZW0gaXM6IEluaXRpYWxWYWx1 ZQorSW5pdGlhbCB2YWx1ZSBvZiB0ZXN0SXRlbSBpczogbnVsbAogQ2F1Z2h0IGV4Y2VwdGlvbiB0 cnlpbmcgdG8gY2hhbmdlIGl0ZW06IEVycm9yOiBRVU9UQV9FWENFRURFRF9FUlI6IERPTSBFeGNl cHRpb24gMjIKLUFmdGVyIGNoYW5nZSBhdHRlbXB0LCB0ZXN0SXRlbSBpczogSW5pdGlhbFZhbHVl Ci1BZnRlciByZW1vdmUgYXR0ZW1wdCwgdGVzdEl0ZW0gaXM6IEluaXRpYWxWYWx1ZQotQWZ0ZXIg Y2xlYXIgYXR0ZW1wdCwgdGVzdEl0ZW0gaXM6IEluaXRpYWxWYWx1ZQorQWZ0ZXIgY2hhbmdlIGF0 dGVtcHQsIHRlc3RJdGVtIGlzOiBudWxsCitBZnRlciByZW1vdmUgYXR0ZW1wdCwgdGVzdEl0ZW0g aXM6IG51bGwKK0FmdGVyIGNsZWFyIGF0dGVtcHQsIHRlc3RJdGVtIGlzOiBudWxsCiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQyNWQ0 Ny4uZWFjNmEwZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0xNSAgQW50b24gRCdBdXJpYSAgPGFk YXVyaWFAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIERlbnkgYWNjZXNzIHRvIGxvY2FsIGFuZCBzZXNzaW9uIHN0b3JhZ2UgaW4gcHJp dmF0ZSBicm93c2luZyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDkzMjkKKworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdG9yYWdlOjpsZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFn ZTo6a2V5KToKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2U6OmdldEl0ZW0pOgorICAgICAgICAo V2ViQ29yZTo6U3RvcmFnZTo6Y29udGFpbnMpOgorCiAyMDEwLTExLTE1ICBLZW5uZXRoIFJ1c3Nl bGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNv bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlLmNwcCBiL1dlYkNvcmUvc3Rv cmFnZS9TdG9yYWdlLmNwcAppbmRleCAwYThlZWQ3Li4wMjU5Y2E0IDEwMDY0NAotLS0gYS9XZWJD b3JlL3N0b3JhZ2UvU3RvcmFnZS5jcHAKKysrIGIvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2UuY3Bw CkBAIC0yOCw2ICsyOCw5IEBACiAKICNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCiAKKyNpbmNsdWRl ICJGcmFtZS5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKKyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2lu Y2x1ZGUgIlN0b3JhZ2VBcmVhLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKICNpbmNs dWRlIDx3dGYvUGFzc1JlZlB0ci5oPgpAQCAtNTMsNyArNTYsNyBAQCBTdG9yYWdlOjp+U3RvcmFn ZSgpCiAKIHVuc2lnbmVkIFN0b3JhZ2U6Omxlbmd0aCgpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX2Zy YW1lKQorICAgIGlmICghbV9mcmFtZSB8fCAhbV9mcmFtZS0+cGFnZSgpIHx8IG1fZnJhbWUtPnBh Z2UoKS0+c2V0dGluZ3MoKS0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKQogICAgICAgICByZXR1 cm4gMDsKIAogICAgIHJldHVybiBtX3N0b3JhZ2VBcmVhLT5sZW5ndGgoKTsKQEAgLTYxLDcgKzY0 LDcgQEAgdW5zaWduZWQgU3RvcmFnZTo6bGVuZ3RoKCkgY29uc3QKIAogU3RyaW5nIFN0b3JhZ2U6 OmtleSh1bnNpZ25lZCBpbmRleCkgY29uc3QKIHsKLSAgICBpZiAoIW1fZnJhbWUpCisgICAgaWYg KCFtX2ZyYW1lIHx8ICFtX2ZyYW1lLT5wYWdlKCkgfHwgbV9mcmFtZS0+cGFnZSgpLT5zZXR0aW5n cygpLT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsK IAogICAgIHJldHVybiBtX3N0b3JhZ2VBcmVhLT5rZXkoaW5kZXgpOwpAQCAtNjksNyArNzIsNyBA QCBTdHJpbmcgU3RvcmFnZTo6a2V5KHVuc2lnbmVkIGluZGV4KSBjb25zdAogCiBTdHJpbmcgU3Rv cmFnZTo6Z2V0SXRlbShjb25zdCBTdHJpbmcmIGtleSkgY29uc3QKIHsKLSAgICBpZiAoIW1fZnJh bWUpCisgICAgaWYgKCFtX2ZyYW1lIHx8ICFtX2ZyYW1lLT5wYWdlKCkgfHwgbV9mcmFtZS0+cGFn ZSgpLT5zZXR0aW5ncygpLT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAgICAgICAgIHJldHVy biBTdHJpbmcoKTsKIAogICAgIHJldHVybiBtX3N0b3JhZ2VBcmVhLT5nZXRJdGVtKGtleSk7CkBA IC0xMDIsNyArMTA1LDcgQEAgdm9pZCBTdG9yYWdlOjpjbGVhcigpCiAKIGJvb2wgU3RvcmFnZTo6 Y29udGFpbnMoY29uc3QgU3RyaW5nJiBrZXkpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX2ZyYW1lKQor ICAgIGlmICghbV9mcmFtZSB8fCAhbV9mcmFtZS0+cGFnZSgpIHx8IG1fZnJhbWUtPnBhZ2UoKS0+ c2V0dGluZ3MoKS0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAKICAgICByZXR1cm4gbV9zdG9yYWdlQXJlYS0+Y29udGFpbnMoa2V5KTsK