49324 2010-11-10 09:40:48 -0800 document.createTouch and document.createTouchList should specify EnabledAtRuntime 2010-11-11 05:49:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 benm benm commit-queue fishd levin steveblock oldest_to_newest 307386 0 benm 2010-11-10 09:40:48 -0800 As document.createTouch and document.createTouchList use touch events (that are enabled at runtime, not compile time with Chrome/V8), the IDL needs to specify that. Just a compile time guard is not enough. Patch coming. 307442 1 73512 benm 2010-11-10 11:05:57 -0800 Created attachment 73512 Patch 307861 2 73512 commit-queue 2010-11-11 05:49:26 -0800 Comment on attachment 73512 Patch Clearing flags on attachment: 73512 Committed r71813: <http://trac.webkit.org/changeset/71813> 307862 3 commit-queue 2010-11-11 05:49:32 -0800 All reviewed patches have been landed. Closing bug. 73512 2010-11-10 11:05:57 -0800 2010-11-11 05:49:26 -0800 Patch 49324.txt text/plain 3376 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTc1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMTEtMTAgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGRvY3Vt ZW50LmNyZWF0ZVRvdWNoIGFuZCBkb2N1bWVudC5jcmVhdGVUb3VjaExpc3Qgc2hvdWxkIHNwZWNp ZnkgRW5hYmxlZEF0UnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDkzMjQKKworICAgICAgICBUaGUgY3JlYXRlVG91Y2ggYW5kIGNyZWF0ZVRv dWNoTGlzdCBBUElzIGFkZGVkIHRvIERvY3VtZW50LmlkbCBpbgorICAgICAgICBodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC83MDA0NyBzaG91bGQgaGF2ZSBFbmFibGVkQXRSdW50aW1l CisgICAgICAgIHNwZWNpZmllZCBhcyB0b3VjaCByZWxhdGVkIGZlYXR1cmVzIGFyZSBjb250cm9s bGVkIGJ5IGEKKyAgICAgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlIGZsYWcgaW4gYWRkaXRpb24g dG8gYSBjb21waWxlIHRpbWUgZ3VhcmQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHNo b3VsZCBoYXZlIGJlZW4gcGFydCBvZiByNzAwNDcgYW5kIAorICAgICAgICB0aGF0IHJldmlzaW9u IHByb3ZpZGVkIGFkZXF1YXRlIHRlc3RzIG9mIHRoZSBuZXcgZmVhdHVyZS4KKworICAgICAgICAq IGJpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgorICAgICAgICAoV2Vi Q29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6Y3JlYXRlVG91Y2hFbmFibGVkKToKKyAgICAg ICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmNyZWF0ZVRvdWNoTGlzdEVuYWJs ZWQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5pZGw6IEFkZCBFbmFibGVkQXRSdW50aW1lIHNw ZWNpZmllciB0byB0aGUKKyAgICAgICAgICAgIGlkbCBtZXRob2RzLgorCiAyMDEwLTExLTEwICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVu YWJsZWRGZWF0dXJlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9S dW50aW1lRW5hYmxlZEZlYXR1cmVzLmgJKHJldmlzaW9uIDcxNzQ4KQorKysgV2ViQ29yZS9iaW5k aW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAkod29ya2luZyBjb3B5KQpAQCAt MTI0LDYgKzEyNCw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBvbnRvdWNobW92ZUVuYWJs ZWQoKSB7IHJldHVybiBpc1RvdWNoRW5hYmxlZDsgfQogICAgIHN0YXRpYyBib29sIG9udG91Y2hl bmRFbmFibGVkKCkgeyByZXR1cm4gaXNUb3VjaEVuYWJsZWQ7IH0KICAgICBzdGF0aWMgYm9vbCBv bnRvdWNoY2FuY2VsRW5hYmxlZCgpIHsgcmV0dXJuIGlzVG91Y2hFbmFibGVkOyB9CisgICAgc3Rh dGljIGJvb2wgY3JlYXRlVG91Y2hFbmFibGVkKCkgeyByZXR1cm4gaXNUb3VjaEVuYWJsZWQ7IH0K KyAgICBzdGF0aWMgYm9vbCBjcmVhdGVUb3VjaExpc3RFbmFibGVkKCkgeyByZXR1cm4gaXNUb3Vj aEVuYWJsZWQ7IH0KICNlbmRpZgogCiAgICAgc3RhdGljIHZvaWQgc2V0RGV2aWNlTW90aW9uRW5h YmxlZChib29sIGlzRW5hYmxlZCkgeyBpc0RldmljZU1vdGlvbkVuYWJsZWQgPSBpc0VuYWJsZWQ7 IH0KSW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2RvbS9Eb2N1bWVudC5pZGwJKHJldmlzaW9uIDcxNzQ4KQorKysgV2ViQ29yZS9kb20vRG9jdW1l bnQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMjUsMTUgKzMyNSwxNSBAQCBtb2R1bGUgY29yZSB7 CiAjZW5kaWYKIAogI2lmIGRlZmluZWQoRU5BQkxFX1RPVUNIX0VWRU5UUykgJiYgRU5BQkxFX1RP VUNIX0VWRU5UUwotICAgICAgICBbUmV0dXJuc05ld10gVG91Y2ggY3JlYXRlVG91Y2goaW4gRE9N V2luZG93IHdpbmRvdywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlu IEV2ZW50VGFyZ2V0IHRhcmdldCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGluIGxvbmcgaWRlbnRpZmllciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGluIGxvbmcgcGFnZVgsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBpbiBsb25nIHBhZ2VZLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW4gbG9uZyBTY3JlZW5YLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW4gbG9uZyBzY3JlZW5ZKQorICAgICAgICBbUmV0dXJuc05ldywgRW5hYmxlZEF0UnVudGlt ZV0gVG91Y2ggY3JlYXRlVG91Y2goaW4gRE9NV2luZG93IHdpbmRvdywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIEV2ZW50VGFyZ2V0 IHRhcmdldCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGluIGxvbmcgaWRlbnRpZmllciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIGxvbmcgcGFnZVgsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbiBsb25nIHBh Z2VZLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaW4gbG9uZyBTY3JlZW5YLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW4gbG9uZyBzY3JlZW5ZKQogICAgICAgICAgICAgcmFp c2VzIChET01FeGNlcHRpb24pOwotICAgICAgICBbUmV0dXJuc05ld10gVG91Y2hMaXN0IGNyZWF0 ZVRvdWNoTGlzdCgpCisgICAgICAgIFtSZXR1cm5zTmV3LCBFbmFibGVkQXRSdW50aW1lXSBUb3Vj aExpc3QgY3JlYXRlVG91Y2hMaXN0KCkKICAgICAgICAgICAgIHJhaXNlcyAoRE9NRXhjZXB0aW9u KTsKICNlbmRpZgogCg==