49306 2010-11-10 00:42:57 -0800 Fix autofill popup height computation 2010-11-13 01:47:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 isherman webkit-unassigned commit-queue dglazkov dhollowa fishd hamaji isherman krit tkent zimmermann oldest_to_newest 307218 0 isherman 2010-11-10 00:42:57 -0800 Fix autofill popup height computation 307224 1 73467 isherman 2010-11-10 00:45:50 -0800 Created attachment 73467 Patch 307231 2 73467 tkent 2010-11-10 01:00:52 -0800 Comment on attachment 73467 Patch looks ok. 307233 3 73467 hamaji 2010-11-10 01:02:19 -0800 Comment on attachment 73467 Patch Clearing r+ and cq+ . Please wait a sec... I'm guessing this patch needs a bit more works. 307239 4 73467 hamaji 2010-11-10 01:16:11 -0800 Comment on attachment 73467 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review It's nice if we can add a test (maybe manual test, unfortunately) for this change. > WebCore/platform/chromium/PopupMenuChromium.cpp:1301 > + int y = 0; I think we can just reuse windowHeight and we don't need this variable? > WebCore/platform/chromium/PopupMenuChromium.cpp:1307 > + y += rowHeight; Could you check if this test http://trac.webkit.org/browser/trunk/WebCore/manual-tests/display-none-option.html?rev=71727 still works? I guess we need if (!m_popupClient->itemStyle(i).isDisplayNone()) here. 307256 5 73475 isherman 2010-11-10 01:54:53 -0800 Created attachment 73475 Patch 307257 6 73475 hamaji 2010-11-10 01:58:39 -0800 Comment on attachment 73475 Patch Sorry, my last concern was a false alarm. 307258 7 isherman 2010-11-10 02:00:18 -0800 (In reply to comment #4) > (From update of attachment 73467 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review > > It's nice if we can add a test (maybe manual test, unfortunately) for this change. AFAIK this code is used only be Chromium autofill, and there is no good way to add a test for this from within WebKit -- even a manual one. Eventually I'd like to add a way to test this popup more generally, but that's outside the scope of this patch. > > > WebCore/platform/chromium/PopupMenuChromium.cpp:1301 > > + int y = 0; > > I think we can just reuse windowHeight and we don't need this variable? Good call =) > > WebCore/platform/chromium/PopupMenuChromium.cpp:1307 > > + y += rowHeight; > > Could you check if this test http://trac.webkit.org/browser/trunk/WebCore/manual-tests/display-none-option.html?rev=71727 still works? Seems to work -- pretty sure the <select> popup is independent of this code. > I guess we need > > if (!m_popupClient->itemStyle(i).isDisplayNone()) > > here. This is handled internally to getRowHeight(). 307265 8 73475 commit-queue 2010-11-10 02:21:44 -0800 Comment on attachment 73475 Patch Rejecting patch 73475 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73475]" exit_code: 1 Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=73475&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=49306&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 73475 from bug 49306. ERROR: /Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/5528079 307269 9 73476 isherman 2010-11-10 02:39:38 -0800 Created attachment 73476 Patch 307311 10 commit-queue 2010-11-10 05:38:12 -0800 The commit-queue encountered the following flaky tests while processing attachment 73476: animations/suspend-resume-animation.html media/video-seek-past-end-paused.html Please file bugs against the tests. These tests were authored by cmarrin@apple.com, eric.carlson@apple.com, hclam@google.com, and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 307317 11 73476 commit-queue 2010-11-10 05:54:28 -0800 Comment on attachment 73476 Patch Clearing flags on attachment: 73476 Committed r71734: <http://trac.webkit.org/changeset/71734> 307318 12 commit-queue 2010-11-10 05:54:34 -0800 All reviewed patches have been landed. Closing bug. 308927 13 73809 isherman 2010-11-12 22:26:16 -0800 Created attachment 73809 Patch 308928 14 73809 isherman 2010-11-12 22:30:41 -0800 Comment on attachment 73809 Patch (In reply to comment #7) > (In reply to comment #4) > > (From update of attachment 73467 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review > > > > It's nice if we can add a test (maybe manual test, unfortunately) for this change. > > AFAIK this code is used only be Chromium autofill, and there is no good way to add a test for this from within WebKit -- even a manual one. Eventually I'd like to add a way to test this popup more generally, but that's outside the scope of this patch. Looks like I was dead wrong here -- this code is indeed used by both <select> elements and autofill popups. The previous patch broken <select> elements that needed scroll bars; this patch should fix that. 308929 15 isherman 2010-11-12 22:32:33 -0800 Marking as "unconfirmed" because there was a regression; and I don't have privileges to mark as "reopened". 308941 16 73809 hamaji 2010-11-13 01:23:29 -0800 Comment on attachment 73809 Patch Looks good. 308942 17 73809 commit-queue 2010-11-13 01:47:47 -0800 Comment on attachment 73809 Patch Clearing flags on attachment: 73809 Committed r71963: <http://trac.webkit.org/changeset/71963> 308943 18 commit-queue 2010-11-13 01:47:53 -0800 All reviewed patches have been landed. Closing bug. 73467 2010-11-10 00:45:50 -0800 2010-11-10 01:54:49 -0800 Patch bug-49306-20101110004549.patch text/plain 1936 isherman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjY0MTQ0NjQ1Yzg1NTNlZmRlNGRhYTJkZmNiMzc3ZTI3ZGIwMzY5My4uZGFiNGQ5OTdiNGVlYjg3 MzMwMWNjZjNmMGEyODg5MjIxZGFjZmYwZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0xMCAgSWx5 YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhdXRvZmlsbCBwb3B1cCBoZWlnaHQgY29t cHV0YXRpb24gLS0gdGFrZSBpY29uIGhlaWdodHMgaW50byBhY2NvdW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMDYKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBvcHVwTGlzdEJveDo6bGF5b3V0KToKKwogMjAxMC0xMS0wOSAgQWJoaXNoZWsgQXJ5YSAgPGlu ZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCmlu ZGV4IDA2NDkyODViNDdmMTEzM2Y4YzAxMzgzNTZiN2EwMDA5ZTQ5OGQxOGUuLjA0OWFmZDZiNzQ5 ZWM3NTkxMzQ2MjNhZDFjYTRjZDhjZDk2YzA0MWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCkBAIC0xMjU1LDE0ICsxMjU1LDEwIEBAIHZv aWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogICAgIC8vIFNpemUgb3VyIGNoaWxkIGl0ZW1zLgog ICAgIGludCBiYXNlV2lkdGggPSAwOwogICAgIGludCBwYWRkaW5nV2lkdGggPSAwOwotICAgIGlu dCB5ID0gMDsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bUl0ZW1zKCk7ICsraSkgewotICAg ICAgICAvLyBQbGFjZSB0aGUgaXRlbSB2ZXJ0aWNhbGx5LgotICAgICAgICBtX2l0ZW1zW2ldLT55 T2Zmc2V0ID0geTsKICAgICAgICAgaWYgKG1fcG9wdXBDbGllbnQtPml0ZW1TdHlsZShpKS5pc0Rp c3BsYXlOb25lKCkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgRm9udCBpdGVtRm9u dCA9IGdldFJvd0ZvbnQoaSk7Ci0gICAgICAgIHkgKz0gaXRlbUZvbnQuaGVpZ2h0KCk7CiAKICAg ICAgICAgLy8gRW5zdXJlIHRoZSBwb3B1cCBpcyB3aWRlIGVub3VnaCB0byBmaXQgdGhpcyBpdGVt LgogICAgICAgICBTdHJpbmcgdGV4dCA9IG1fcG9wdXBDbGllbnQtPml0ZW1UZXh0KGkpOwpAQCAt MTMwMiw4ICsxMjk4LDE0IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQogICAgIG1fdmlz aWJsZVJvd3MgPSBtaW4obnVtSXRlbXMoKSwga01heFZpc2libGVSb3dzKTsKICNlbmRpZgogCisg ICAgaW50IHkgPSAwOwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbV92aXNpYmxlUm93czsgKytp KSB7CiAgICAgICAgIGludCByb3dIZWlnaHQgPSBnZXRSb3dIZWlnaHQoaSk7CisKKyAgICAgICAg Ly8gUGxhY2UgdGhlIGl0ZW0gdmVydGljYWxseS4KKyAgICAgICAgbV9pdGVtc1tpXS0+eU9mZnNl dCA9IHk7CisgICAgICAgIHkgKz0gcm93SGVpZ2h0OworCiAjaWYgIU9TKERBUldJTikKICAgICAg ICAgLy8gT25seSBjbGlwIHRoZSB3aW5kb3cgaGVpZ2h0IGZvciBub24tTWFjIHBsYXRmb3Jtcy4K ICAgICAgICAgaWYgKHdpbmRvd0hlaWdodCArIHJvd0hlaWdodCA+IG1fbWF4SGVpZ2h0KSB7Cg== 73475 2010-11-10 01:54:53 -0800 2010-11-10 02:39:34 -0800 Patch bug-49306-20101110015452.patch text/plain 2001 isherman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2YyN2E5YzNjOTMzNmJlZWRjZGM5OTMzOTFiOTZkMzRhZjM1Y2EwOS4uZWE3NjU2ZTcxN2JmNzMz MDEwY2RlNzYyYTM1NzljNzhjZWFlMDAxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTI0LDYgKzI0LDE2IEBACiAgICAgICAgIEFmZmlu ZVRyYW5zZm9ybSdzIG9wZXJhdG9yKiBpbXBsZW1lbnRhdGlvbiB0aGUgb3JkZXIgb2YgYXJndW1l bnRzIGlzCiAgICAgICAgIHJldmVyc2VkIChzZWUgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDgwMzEpLgogCisyMDEwLTExLTEwICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1h bkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IGF1dG9maWxsIHBvcHVwIGhlaWdodCBjb21wdXRhdGlvbiAtLSB0YWtlIGlj b24gaGVpZ2h0cyBpbnRvIGFjY291bnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00OTMwNgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9w dXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94OjpsYXlv dXQpOgorCiAyMDEwLTExLTA5ICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKaW5kZXggMDY0OTI4NWI0N2YxMTMz ZjhjMDEzODM1NmI3YTAwMDllNDk4ZDE4ZS4uZDc4OTliYWI2MzRmM2VmM2FhOWI2MjIyNGY3NjQw NGQ2ZTFlYWJlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1l bnVDaHJvbWl1bS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVD aHJvbWl1bS5jcHAKQEAgLTEyNTUsMTQgKzEyNTUsMTAgQEAgdm9pZCBQb3B1cExpc3RCb3g6Omxh eW91dCgpCiAgICAgLy8gU2l6ZSBvdXIgY2hpbGQgaXRlbXMuCiAgICAgaW50IGJhc2VXaWR0aCA9 IDA7CiAgICAgaW50IHBhZGRpbmdXaWR0aCA9IDA7Ci0gICAgaW50IHkgPSAwOwogICAgIGZvciAo aW50IGkgPSAwOyBpIDwgbnVtSXRlbXMoKTsgKytpKSB7Ci0gICAgICAgIC8vIFBsYWNlIHRoZSBp dGVtIHZlcnRpY2FsbHkuCi0gICAgICAgIG1faXRlbXNbaV0tPnlPZmZzZXQgPSB5OwogICAgICAg ICBpZiAobV9wb3B1cENsaWVudC0+aXRlbVN0eWxlKGkpLmlzRGlzcGxheU5vbmUoKSkKICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICBGb250IGl0ZW1Gb250ID0gZ2V0Um93Rm9udChpKTsK LSAgICAgICAgeSArPSBpdGVtRm9udC5oZWlnaHQoKTsKIAogICAgICAgICAvLyBFbnN1cmUgdGhl IHBvcHVwIGlzIHdpZGUgZW5vdWdoIHRvIGZpdCB0aGlzIGl0ZW0uCiAgICAgICAgIFN0cmluZyB0 ZXh0ID0gbV9wb3B1cENsaWVudC0+aXRlbVRleHQoaSk7CkBAIC0xMzAzLDcgKzEyOTksMTAgQEAg dm9pZCBQb3B1cExpc3RCb3g6OmxheW91dCgpCiAjZW5kaWYKIAogICAgIGZvciAoaW50IGkgPSAw OyBpIDwgbV92aXNpYmxlUm93czsgKytpKSB7CisgICAgICAgIC8vIFBsYWNlIHRoZSBpdGVtIHZl cnRpY2FsbHkuCiAgICAgICAgIGludCByb3dIZWlnaHQgPSBnZXRSb3dIZWlnaHQoaSk7CisgICAg ICAgIG1faXRlbXNbaV0tPnlPZmZzZXQgPSB3aW5kb3dIZWlnaHQ7CisKICNpZiAhT1MoREFSV0lO KQogICAgICAgICAvLyBPbmx5IGNsaXAgdGhlIHdpbmRvdyBoZWlnaHQgZm9yIG5vbi1NYWMgcGxh dGZvcm1zLgogICAgICAgICBpZiAod2luZG93SGVpZ2h0ICsgcm93SGVpZ2h0ID4gbV9tYXhIZWln aHQpIHsK 73476 2010-11-10 02:39:38 -0800 2010-11-12 22:26:13 -0800 Patch bug-49306-20101110023937.patch text/plain 1879 isherman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2YyN2E5YzNjOTMzNmJlZWRjZGM5OTMzOTFiOTZkMzRhZjM1Y2EwOS4uZDVlNjlhODEzZGUyYzky NzU3NzU1YzA3MTU5MzU3ODM3N2M3ODkyOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0xMCAgSWx5 YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhdXRvZmlsbCBwb3B1cCBoZWlnaHQgY29t cHV0YXRpb24gLS0gdGFrZSBpY29uIGhlaWdodHMgaW50byBhY2NvdW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMDYKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBvcHVwTGlzdEJveDo6bGF5b3V0KToKKwogMjAxMC0xMS0xMCAgU2hpbmljaGlybyBIYW1hamkg IDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZGluZyBhIG1hbnVhbCB0ZXN0IHdo aWNoIEkgZm9yZ290IHRvIGFkZCBpbiByNzE2MTguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCmluZGV4IDA2NDkyODViNDdmMTEzM2Y4YzAxMzgz NTZiN2EwMDA5ZTQ5OGQxOGUuLmQ3ODk5YmFiNjM0ZjNlZjNhYTliNjIyMjRmNzY0MDRkNmUxZWFi ZTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21p dW0uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCkBAIC0xMjU1LDE0ICsxMjU1LDEwIEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpsYXlvdXQoKQog ICAgIC8vIFNpemUgb3VyIGNoaWxkIGl0ZW1zLgogICAgIGludCBiYXNlV2lkdGggPSAwOwogICAg IGludCBwYWRkaW5nV2lkdGggPSAwOwotICAgIGludCB5ID0gMDsKICAgICBmb3IgKGludCBpID0g MDsgaSA8IG51bUl0ZW1zKCk7ICsraSkgewotICAgICAgICAvLyBQbGFjZSB0aGUgaXRlbSB2ZXJ0 aWNhbGx5LgotICAgICAgICBtX2l0ZW1zW2ldLT55T2Zmc2V0ID0geTsKICAgICAgICAgaWYgKG1f cG9wdXBDbGllbnQtPml0ZW1TdHlsZShpKS5pc0Rpc3BsYXlOb25lKCkpCiAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgRm9udCBpdGVtRm9udCA9IGdldFJvd0ZvbnQoaSk7Ci0gICAgICAg IHkgKz0gaXRlbUZvbnQuaGVpZ2h0KCk7CiAKICAgICAgICAgLy8gRW5zdXJlIHRoZSBwb3B1cCBp cyB3aWRlIGVub3VnaCB0byBmaXQgdGhpcyBpdGVtLgogICAgICAgICBTdHJpbmcgdGV4dCA9IG1f cG9wdXBDbGllbnQtPml0ZW1UZXh0KGkpOwpAQCAtMTMwMyw3ICsxMjk5LDEwIEBAIHZvaWQgUG9w dXBMaXN0Qm94OjpsYXlvdXQoKQogI2VuZGlmCiAKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1f dmlzaWJsZVJvd3M7ICsraSkgeworICAgICAgICAvLyBQbGFjZSB0aGUgaXRlbSB2ZXJ0aWNhbGx5 LgogICAgICAgICBpbnQgcm93SGVpZ2h0ID0gZ2V0Um93SGVpZ2h0KGkpOworICAgICAgICBtX2l0 ZW1zW2ldLT55T2Zmc2V0ID0gd2luZG93SGVpZ2h0OworCiAjaWYgIU9TKERBUldJTikKICAgICAg ICAgLy8gT25seSBjbGlwIHRoZSB3aW5kb3cgaGVpZ2h0IGZvciBub24tTWFjIHBsYXRmb3Jtcy4K ICAgICAgICAgaWYgKHdpbmRvd0hlaWdodCArIHJvd0hlaWdodCA+IG1fbWF4SGVpZ2h0KSB7Cg== 73809 2010-11-12 22:26:16 -0800 2010-11-13 01:47:47 -0800 Patch bug-49306-20101112222615.patch text/plain 3125 isherman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTExNDNiZTZkNGI1NjA2ZDg2M2ZhYjFmNzk0OTQ2MmE4OTY2NDU5Yi4uZTQyYzc0YjI1OWVhZTVk NTg5MzRmNmZhNTAwNGQ0NTA1MjA3ZmNkMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0xMiAgSWx5 YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIHJlZ3Jlc3Npb24gZnJvbSBwcmV2aW91 cyBwYXRjaCAtLSBjb21wdXRlcyB5IG9mZnNldHMgZm9yIGVsZW1lbnRzCisgICAgICAgIHRoYXQg YXJlIHNjcm9sbGVkIG91dCBvZiB0aGUgd2luZG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkzMDYKKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9z ZWxlY3Qtc2Nyb2xsLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Bv cHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6bGF5 b3V0KToKKwogMjAxMC0xMS0xMiAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQg YS9XZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3Qtc2Nyb2xsLmh0bWwgYi9XZWJDb3JlL21hbnVh bC10ZXN0cy9zZWxlY3Qtc2Nyb2xsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTViOGE1YThkNGYwYTc3ZjBi NjVlOWYwZDQ4Y2MxZmJjMWU3NWQ1NgotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFs LXRlc3RzL3NlbGVjdC1zY3JvbGwuaHRtbApAQCAtMCwwICsxLDM0IEBACis8cD4KK1doZW4geW91 IGNsaWNrIHRoZSBmb2xsb3dpbmcgJmx0O3NlbGVjdCZndDssIHlvdSBzaG91bGQgc2VlIGEgc2Ny b2xsYmFyLAorYW5kIHNob3VsZCBiZSBhYmxlIHRvIHNjcm9sbCBkb3duIHRvIHNlZSAiWiIgYXMg dGhlIGxhc3Qgb3B0aW9uLgorU2VlIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00OTMwNiI+QnVnIDQ5MzA2PC9hPiBmb3IgZGV0YWlsLgorCis8cD4KKzxz ZWxlY3Q+CisgPG9wdGlvbj5BPC9vcHRpb24+CisgPG9wdGlvbj5CPC9vcHRpb24+CisgPG9wdGlv bj5DPC9vcHRpb24+CisgPG9wdGlvbj5EPC9vcHRpb24+CisgPG9wdGlvbj5FPC9vcHRpb24+Cisg PG9wdGlvbj5GPC9vcHRpb24+CisgPG9wdGlvbj5HPC9vcHRpb24+CisgPG9wdGlvbj5IPC9vcHRp b24+CisgPG9wdGlvbj5JPC9vcHRpb24+CisgPG9wdGlvbj5KPC9vcHRpb24+CisgPG9wdGlvbj5L PC9vcHRpb24+CisgPG9wdGlvbj5MPC9vcHRpb24+CisgPG9wdGlvbj5NPC9vcHRpb24+CisgPG9w dGlvbj5OPC9vcHRpb24+CisgPG9wdGlvbj5PPC9vcHRpb24+CisgPG9wdGlvbj5QPC9vcHRpb24+ CisgPG9wdGlvbj5RPC9vcHRpb24+CisgPG9wdGlvbj5SPC9vcHRpb24+CisgPG9wdGlvbj5TPC9v cHRpb24+CisgPG9wdGlvbj5UPC9vcHRpb24+CisgPG9wdGlvbj5VPC9vcHRpb24+CisgPG9wdGlv bj5WPC9vcHRpb24+CisgPG9wdGlvbj5XPC9vcHRpb24+CisgPG9wdGlvbj5YPC9vcHRpb24+Cisg PG9wdGlvbj5ZPC9vcHRpb24+CisgPG9wdGlvbj5aPC9vcHRpb24+Cis8L3NlbGVjdD4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKaW5kZXggNTZh NWFhOTZjYjlmZDc2ZjlmY2QzOGM2NDYzZTIxNDg4YzVkYThhMC4uODBjNWJjODEzNDMwOTVjMjRm MzI4YTczNTIxMDYxNmIzOWExMGE1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKQEAgLTEyNTUsMTIgKzEyNTUsMTYgQEAgdm9pZCBQb3B1 cExpc3RCb3g6OmxheW91dCgpCiAgICAgLy8gU2l6ZSBvdXIgY2hpbGQgaXRlbXMuCiAgICAgaW50 IGJhc2VXaWR0aCA9IDA7CiAgICAgaW50IHBhZGRpbmdXaWR0aCA9IDA7CisgICAgaW50IHkgPSAw OwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtSXRlbXMoKTsgKytpKSB7CisgICAgICAgIC8v IFBsYWNlIHRoZSBpdGVtIHZlcnRpY2FsbHkuCisgICAgICAgIG1faXRlbXNbaV0tPnlPZmZzZXQg PSB5OwogICAgICAgICBpZiAobV9wb3B1cENsaWVudC0+aXRlbVN0eWxlKGkpLmlzRGlzcGxheU5v bmUoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBGb250IGl0ZW1Gb250ID0gZ2V0 Um93Rm9udChpKTsKKyAgICAgICAgeSArPSBnZXRSb3dIZWlnaHQoaSk7CiAKICAgICAgICAgLy8g RW5zdXJlIHRoZSBwb3B1cCBpcyB3aWRlIGVub3VnaCB0byBmaXQgdGhpcyBpdGVtLgorICAgICAg ICBGb250IGl0ZW1Gb250ID0gZ2V0Um93Rm9udChpKTsKICAgICAgICAgU3RyaW5nIHRleHQgPSBt X3BvcHVwQ2xpZW50LT5pdGVtVGV4dChpKTsKICAgICAgICAgU3RyaW5nIGxhYmVsID0gbV9wb3B1 cENsaWVudC0+aXRlbUxhYmVsKGkpOwogICAgICAgICBTdHJpbmcgaWNvbiA9IG1fcG9wdXBDbGll bnQtPml0ZW1JY29uKGkpOwpAQCAtMTI5OSw5ICsxMzAzLDcgQEAgdm9pZCBQb3B1cExpc3RCb3g6 OmxheW91dCgpCiAjZW5kaWYKIAogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbV92aXNpYmxlUm93 czsgKytpKSB7Ci0gICAgICAgIC8vIFBsYWNlIHRoZSBpdGVtIHZlcnRpY2FsbHkuCiAgICAgICAg IGludCByb3dIZWlnaHQgPSBnZXRSb3dIZWlnaHQoaSk7Ci0gICAgICAgIG1faXRlbXNbaV0tPnlP ZmZzZXQgPSB3aW5kb3dIZWlnaHQ7CiAKICNpZiAhT1MoREFSV0lOKQogICAgICAgICAvLyBPbmx5 IGNsaXAgdGhlIHdpbmRvdyBoZWlnaHQgZm9yIG5vbi1NYWMgcGxhdGZvcm1zLgo=