49302 2010-11-09 23:41:05 -0800 Add a test for form submission by <input type=image> 2010-11-11 00:27:44 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 48317 1 tkent tkent darin hamaji oldest_to_newest 307191 0 tkent 2010-11-09 23:41:05 -0800 Add a test for form submission by <input type=image> We have no tests about it! 307192 1 73461 tkent 2010-11-09 23:42:42 -0800 Created attachment 73461 Patch 307202 2 73461 hamaji 2010-11-10 00:12:06 -0800 Comment on attachment 73461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73461&action=review Adding more tests is nice :) I've put two minor comments, please apply them if you like. > LayoutTests/fast/forms/input-image-submit.html:37 > + gc(); I think the reason why we need to run gc here isn't so clear. Could you write a few comments? > LayoutTests/fast/forms/input-image-submit.html:72 > + testFailed('Normal submission failed: ' + query); I'd add a function which calls both testFailed and notifyDone. 307762 3 tkent 2010-11-11 00:27:29 -0800 Thanks for reviewing. I have committed the patch with the following changes as http://trac.webkit.org/changeset/71799 (In reply to comment #2) > > LayoutTests/fast/forms/input-image-submit.html:37 > > + gc(); > > I think the reason why we need to run gc here isn't so clear. Could you write a few comments? I added a comment. > > LayoutTests/fast/forms/input-image-submit.html:72 > > + testFailed('Normal submission failed: ' + query); > > I'd add a function which calls both testFailed and notifyDone. I made a function for it. 73461 2010-11-09 23:42:42 -0800 2010-11-11 00:27:44 -0800 Patch bug-49302-20101110164241.patch text/plain 5815 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1ZmZjNzRmZDQ5ZGFlZTA5MDEwOThlYjE3NDRhNzAyMzExOTg5ZDA1Li42YTYzMzY3 ZjkzZGMxYjQ5MjYzNGRhYzdlMWM3ZTFkYjdiZWJlZDYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIGZv cm0gc3VibWlzc2lvbiBieSA8aW5wdXQgdHlwZT1pbWFnZT4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MzAyCisKKyAgICAgICAgKiBmYXN0L2Zvcm1z L2lucHV0LWltYWdlLXN1Ym1pdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Zm9ybXMvaW5wdXQtaW1hZ2Utc3VibWl0Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTExLTA5ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFlldCBhbm90aGVyIHVucmV2 aWV3ZWQgQ2hyb21pdW0gcmViYXNlbGluZXMgZm9yIHI3MTQ2NS4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtaW1hZ2Utc3VibWl0LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtaW1hZ2Utc3VibWl0LWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4xN2ZlN2RiOGJiMzQyZTMzZDk5NzUxZGU0OWE0ZGRmNmFkZDkzYWE2Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1pbWFnZS1zdWJtaXQtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorCitQQVNTIEFsbCB0ZXN0cyBwYXNzZWQuCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtaW1hZ2Utc3VibWl0Lmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWltYWdlLXN1Ym1pdC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjQxNGFhYzk5MDFhNzRiN2IzNDk2NjQ4YjhlMWMxODE1NWQ3MjUxYWUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWltYWdlLXN1Ym1pdC5odG1sCkBAIC0w LDAgKzEsMTI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9 InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUu Y3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InN0YXJ0VGVzdHMoKSI+CisKKzxm b3JtIGFjdGlvbj0iaW5wdXQtaW1hZ2Utc3VibWl0Lmh0bWwiIG1ldGhvZD1HRVQgaWQ9Zm9ybT4K KzxpbnB1dCB0eXBlPWhpZGRlbiBuYW1lPXN0YXRlIGlkPXN0YXRlIHZhbHVlPXN0ZXAxPgorPGlu cHV0IHR5cGU9aW1hZ2UgbmFtZT1pbWFnZSBpZD1pbWFnZSBzcmM9cmVzb3VyY2VzL2FwcGxlLmdp ZiB2YWx1ZT12YWx1ZT4KKzwvZm9ybT4KKworPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2Ny aXB0PgorZnVuY3Rpb24gZ2MoKSB7CisgICAgaWYgKHdpbmRvdy5HQ0NvbnRyb2xsZXIpCisgICAg ICAgIHJldHVybiBHQ0NvbnRyb2xsZXIuY29sbGVjdCgpOworCisgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCAxMDAwMDsgaSsrKQorICAgICAgICB2YXIgcyA9IG5ldyBTdHJpbmcoIiIpOworfQorCitm dW5jdGlvbiBub3RpZnlEb25lKCkgeworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKworZnVu Y3Rpb24gaGFuZGxlU3VibWl0KCkgeworICAgIGlmIChzdGF0ZS52YWx1ZSA9PSAndG8tdGV4dC1v bi1zdWJtaXQnKSB7CisgICAgICAgIGltYWdlLnR5cGUgPSAndGV4dCc7CisgICAgfSBlbHNlIGlm IChzdGF0ZS52YWx1ZSA9PSAndG8taW1hZ2Utb24tc3VibWl0JykgeworICAgICAgICBpbWFnZS50 eXBlID0gJ2ltYWdlJzsKKyAgICB9IGVsc2UgaWYgKHN0YXRlLnZhbHVlID09ICdyZW1vdmUtaW5w dXQtb24tc3VibWl0JykgeworICAgICAgICBpbWFnZS5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKGlt YWdlKTsKKyAgICAgICAgaW1hZ2UgPSBudWxsOworICAgICAgICBnYygpOworICAgIH0KK30KKwor ZnVuY3Rpb24gaGFuZGxlQ2xpY2soKSB7CisgICAgaWYgKHN0YXRlLnZhbHVlID09ICd0by1pbWFn ZS1vbi1jbGljaycpIHsKKyAgICAgICAgaW1hZ2UudHlwZSA9ICdpbWFnZScKKyAgICB9Cit9CisK K2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOworCit2YXIgc3RhdGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnc3RhdGUnKTsKK3ZhciBpbWFnZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpbWFnZScp OworaW1hZ2UuYWRkRXZlbnRMaXN0ZW5lcignY2xpY2snLCBoYW5kbGVDbGljaywgZmFsc2UpOwor dmFyIGZvcm0gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZm9ybScpOworZm9ybS5hZGRFdmVu dExpc3RlbmVyKCdzdWJtaXQnLCBoYW5kbGVTdWJtaXQsIGZhbHNlKTsKKworZnVuY3Rpb24gc3Rh cnRUZXN0cygpIHsKKyAgICB2YXIgeCA9IGltYWdlLm9mZnNldExlZnQgKyA3OworICAgIHZhciB5 ID0gaW1hZ2Uub2Zmc2V0VG9wICsgMTE7CisgICAgdmFyIGNsaWNrRXZlbnQgPSBkb2N1bWVudC5j cmVhdGVFdmVudCgnTW91c2VFdmVudCcpOworICAgIGNsaWNrRXZlbnQuaW5pdE1vdXNlRXZlbnQo J2NsaWNrJywgdHJ1ZSwgZmFsc2UsIGRvY3VtZW50LmRlZmF1bHRWaWV3LCAxLCB4LCB5LCB4LCB5 LCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgMCwgZG9jdW1lbnQpOworICAgIHZhciBlbnRl ckV2ZW50ID0gZG9jdW1lbnQuY3JlYXRlRXZlbnQoJ1RleHRFdmVudCcpOworICAgIGVudGVyRXZl bnQuaW5pdFRleHRFdmVudCgidGV4dElucHV0IiwgdHJ1ZSwgdHJ1ZSwgZG9jdW1lbnQuZGVmYXVs dFZpZXcsICJcbiIpOworICAgIHZhciBxdWVyeSA9IHdpbmRvdy5sb2NhdGlvbi5zZWFyY2g7CisK KyAgICBpZiAocXVlcnkuaW5kZXhPZignc3RhdGU9JykgPT0gLTEpIHsKKyAgICAgICAgLy8gU3Rl cCAxOiBOb3JtYWwgc3VibWlzc2lvbiB3aXRoIHR5cGU9aW1hZ2UKKyAgICAgICAgc3RhdGUudmFs dWUgPSAnbm9ybWFsJzsKKyAgICAgICAgaW1hZ2UuZGlzcGF0Y2hFdmVudChjbGlja0V2ZW50KTsK KyAgICB9IGVsc2UgaWYgKHF1ZXJ5LmluZGV4T2YoJ3N0YXRlPW5vcm1hbCcpICE9IC0xKSB7Cisg ICAgICAgIC8vIFNob3VsZCBoYXZlIGltYWdlLng9NyZpbWFnZS55PTExJmltYWdlPXZhbHVlLgor ICAgICAgICBpZiAocXVlcnkuaW5kZXhPZignaW1hZ2UueD03JmltYWdlLnk9MTEmaW1hZ2U9dmFs dWUnKSA9PSAtMSkgeworICAgICAgICAgICAgdGVzdEZhaWxlZCgnTm9ybWFsIHN1Ym1pc3Npb24g ZmFpbGVkOiAnICsgcXVlcnkpOworICAgICAgICAgICAgbm90aWZ5RG9uZSgpOworICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgLy8gU3RlcCAyOiBDaGFuZ2UgdGhlIHR5 cGUgdG8gdGV4dCBvbiAnc3VibWl0JyBldmVudAorICAgICAgICBzdGF0ZS52YWx1ZSA9ICd0by10 ZXh0LW9uLXN1Ym1pdCc7CisgICAgICAgIGltYWdlLmRpc3BhdGNoRXZlbnQoY2xpY2tFdmVudCk7 CisgICAgfSBlbHNlIGlmIChxdWVyeS5pbmRleE9mKCdzdGF0ZT10by10ZXh0LW9uLXN1Ym1pdCcp ICE9IC0xKSB7CisgICAgICAgIC8vIFNob3VsZCBoYXZlIG9ubHkgaW1hZ2U9dmFsdWUuCisgICAg ICAgIGlmIChxdWVyeS5pbmRleE9mKCdpbWFnZT12YWx1ZScpID09IC0xKSB7CisgICAgICAgICAg ICB0ZXN0RmFpbGVkKCdDaGFuZ2luZyB0byB0ZXh0IG9uIHN1Ym1pdCBmYWlsZWQ6ICcgKyBxdWVy eSk7CisgICAgICAgICAgICBub3RpZnlEb25lKCk7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KKworICAgICAgICAvLyBTdGVwIDM6IENoYW5nZSB0aGUgdHlwZSB0byBpbWFnZSBvbiAn c3VibWl0JyBldmVudAorICAgICAgICBzdGF0ZS52YWx1ZSA9ICd0by1pbWFnZS1vbi1zdWJtaXQn OworICAgICAgICBpbWFnZS50eXBlID0gJ3RleHQnOworICAgICAgICBpbWFnZS5mb2N1cygpOwor ICAgICAgICBpbWFnZS5kaXNwYXRjaEV2ZW50KGVudGVyRXZlbnQpOworICAgIH0gZWxzZSBpZiAo cXVlcnkuaW5kZXhPZignc3RhdGU9dG8taW1hZ2Utb24tc3VibWl0JykgIT0gLTEpIHsKKyAgICAg ICAgLy8gU2hvdWxkIGhhdmUgaW1hZ2UueCBhbmQgaW1hZ2UueSwgYnV0IHRoZWlyIHZhbHVlcyBh cmUgMC4KKyAgICAgICAgaWYgKHF1ZXJ5LmluZGV4T2YoJ2ltYWdlLng9MCZpbWFnZS55PTAmaW1h Z2U9dmFsdWUnKSA9PSAtMSkgeworICAgICAgICAgICAgdGVzdEZhaWxlZCgnQ2hhbmdpbmcgdG8g aW1hZ2Ugb24gc3VibWl0IGZhaWxlZDogJyArIHF1ZXJ5KTsKKyAgICAgICAgICAgIG5vdGlmeURv bmUoKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIC8vIFN0ZXAg NDogQ2hhbmdlIHRoZSB0eXBlIHRvIGltYWdlIG9uICdjbGljaycgZXZlbnQKKyAgICAgICAgc3Rh dGUudmFsdWUgPSAndG8taW1hZ2Utb24tY2xpY2snOworICAgICAgICBpbWFnZS50eXBlID0gJ3Rl eHQnOworICAgICAgICBpbWFnZS5kaXNwYXRjaEV2ZW50KGNsaWNrRXZlbnQpOworICAgIH0gZWxz ZSBpZiAocXVlcnkuaW5kZXhPZignc3RhdGU9dG8taW1hZ2Utb24tY2xpY2snKSAhPSAtMSkgewor ICAgICAgICAvLyBTYW1lIGFzIHRoZSBub3JtYWwgc3VibWlzc2lvbi4KKyAgICAgICAgaWYgKHF1 ZXJ5LmluZGV4T2YoJ2ltYWdlLng9NyZpbWFnZS55PTExJmltYWdlPXZhbHVlJykgPT0gLTEpIHsK KyAgICAgICAgICAgIHRlc3RGYWlsZWQoJ0NoYW5naW5nIHRvIGltYWdlIG9uIGNsaWNrIGZhaWxl ZDogJyArIHF1ZXJ5KTsKKyAgICAgICAgICAgIG5vdGlmeURvbmUoKTsKKyAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgfQorCisgICAgICAgIC8vIFN0ZXAgNTogUmVtb3ZlZCB0aGUgaW1hZ2Ug YnV0dG9uIG9uICdzdWJtaXQnIGV2ZW50CisgICAgICAgIHN0YXRlLnZhbHVlID0gJ3JlbW92ZS1p bnB1dC1vbi1zdWJtaXQnOworICAgICAgICBpbWFnZS5kaXNwYXRjaEV2ZW50KGNsaWNrRXZlbnQp OworICAgIH0gZWxzZSBpZiAocXVlcnkuaW5kZXhPZignc3RhdGU9cmVtb3ZlLWlucHV0LW9uLXN1 Ym1pdCcpICE9IC0xKSB7CisgICAgICAgIC8vIFNob3VsZCBoYXZlIG5vdGhpbmcgYWJvdXQgaW1h Z2UuCisgICAgICAgIGlmIChxdWVyeS5pbmRleE9mKCdpbWFnZS54PScpICE9IC0xIHx8IHF1ZXJ5 LmluZGV4T2YoJ2ltYWdlPXZhbHVlJykgIT0gLTEpCisgICAgICAgICAgICB0ZXN0RmFpbGVkKCdS ZW1vdmluZyB0aGUgaW5wdXQgb24gc3VibWl0IGZhaWxlZDogJyArIHF1ZXJ5KTsKKyAgICAgICAg ZWxzZQorICAgICAgICAgICAgdGVzdFBhc3NlZCgnQWxsIHRlc3RzIHBhc3NlZC4nKTsKKyAgICAg ICAgbm90aWZ5RG9uZSgpOworICAgIH0KK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgor Cg==