49290 2010-11-09 17:21:38 -0800 [Chromium] Fix mouse-up clickCount on the Mac, and in plugins 2010-11-17 02:02:41 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 stuartmorgan stuartmorgan commit-queue dglazkov oldest_to_newest 307071 0 73441 stuartmorgan 2010-11-09 17:21:38 -0800 Created attachment 73441 Fix clickCount for mouse-up This fixes two issues with clickCount on mouseup (for http://crbug.com/62348): - clickCount was never set for any mouse up event on the Mac during the conversion from native NSEvent objects - clickCount was not being passed down into WebKit internals for events dispatched by the plugin mouse capture system 307605 1 73551 stuartmorgan 2010-11-10 16:00:30 -0800 Created attachment 73551 Fix clickCount for mouse-up (correct patch format) Now with ChangeLog 309787 2 73551 dglazkov 2010-11-16 09:59:10 -0800 Comment on attachment 73551 Fix clickCount for mouse-up (correct patch format) Good catch, thanks for the patch. All you need now is add a test here: http://google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/WebKit/chromium/tests/PopupMenuTest.cpp&exact_package=chromium 309825 3 stuartmorgan 2010-11-16 11:02:20 -0800 It's unclear to me how to test this in the current infrastructure. - The plugin-level is problematic because Mac plugins have two different event models, and only one of them provides clickCount. So, changing the test plugin to log clickCount doesn't seem like an option, since the logging would change based on the event model (which is currently not the case; it's deliberately normalized between the two) - The factory-level requires an actual NSEvent. The tests that I see fabricate events using one of the WebKit-internal structures, not actual OS events. 309830 4 dglazkov 2010-11-16 11:08:12 -0800 (In reply to comment #3) > It's unclear to me how to test this in the current infrastructure. > - The plugin-level is problematic because Mac plugins have two different event models, and only one of them provides clickCount. So, changing the test plugin to log clickCount doesn't seem like an option, since the logging would change based on the event model (which is currently not the case; it's deliberately normalized between the two) > - The factory-level requires an actual NSEvent. The tests that I see fabricate events using one of the WebKit-internal structures, not actual OS events. Ok. Given that this is a pretty clear oversight in a rarely-changing code, I am happy to file a bug on this and r+ the patch. 309833 5 73551 dglazkov 2010-11-16 11:09:24 -0800 Comment on attachment 73551 Fix clickCount for mouse-up (correct patch format) View in context: https://bugs.webkit.org/attachment.cgi?id=73551&action=review Please file a bug on test infrastructure. > WebKit/chromium/ChangeLog:13 > + (WebKit::WebViewImpl::handleInputEvent): For your future WebKit patches, it's a good form to specify here what changed. 310180 6 73551 commit-queue 2010-11-17 02:02:35 -0800 Comment on attachment 73551 Fix clickCount for mouse-up (correct patch format) Clearing flags on attachment: 73551 Committed r72181: <http://trac.webkit.org/changeset/72181> 310181 7 commit-queue 2010-11-17 02:02:41 -0800 All reviewed patches have been landed. Closing bug. 73441 2010-11-09 17:21:38 -0800 2010-11-10 16:00:30 -0800 Fix clickCount for mouse-up click-count-fix.patch text/plain 1379 stuartmorgan SW5kZXg6IHNyYy9tYWMvV2ViSW5wdXRFdmVudEZhY3RvcnkubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3Jj L21hYy9XZWJJbnB1dEV2ZW50RmFjdG9yeS5tbQkocmV2aXNpb24gNzE2NTcpCisrKyBzcmMvbWFj L1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDE2LDE0ICsxMDE2 LDE3IEBACiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgTlNMZWZ0TW91c2VVcDoKICAgICAgICAg cmVzdWx0LnR5cGUgPSBXZWJJbnB1dEV2ZW50OjpNb3VzZVVwOworICAgICAgICByZXN1bHQuY2xp Y2tDb3VudCA9IFtldmVudCBjbGlja0NvdW50XTsKICAgICAgICAgcmVzdWx0LmJ1dHRvbiA9IFdl Yk1vdXNlRXZlbnQ6OkJ1dHRvbkxlZnQ7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgTlNPdGhl ck1vdXNlVXA6CiAgICAgICAgIHJlc3VsdC50eXBlID0gV2ViSW5wdXRFdmVudDo6TW91c2VVcDsK KyAgICAgICAgcmVzdWx0LmNsaWNrQ291bnQgPSBbZXZlbnQgY2xpY2tDb3VudF07CiAgICAgICAg IHJlc3VsdC5idXR0b24gPSBXZWJNb3VzZUV2ZW50OjpCdXR0b25NaWRkbGU7CiAgICAgICAgIGJy ZWFrOwogICAgIGNhc2UgTlNSaWdodE1vdXNlVXA6CiAgICAgICAgIHJlc3VsdC50eXBlID0gV2Vi SW5wdXRFdmVudDo6TW91c2VVcDsKKyAgICAgICAgcmVzdWx0LmNsaWNrQ291bnQgPSBbZXZlbnQg Y2xpY2tDb3VudF07CiAgICAgICAgIHJlc3VsdC5idXR0b24gPSBXZWJNb3VzZUV2ZW50OjpCdXR0 b25SaWdodDsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBOU01vdXNlTW92ZWQ6CkluZGV4OiBz cmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNyYy9XZWJWaWV3SW1wbC5jcHAJKHJl dmlzaW9uIDcxNjU3KQorKysgc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTEwMCw3ICsxMTAwLDcgQEAKIAogICAgICAgICBub2RlLT5kaXNwYXRjaE1vdXNlRXZlbnQoCiAg ICAgICAgICAgICAgIFBsYXRmb3JtTW91c2VFdmVudEJ1aWxkZXIobWFpbkZyYW1lSW1wbCgpLT5m cmFtZVZpZXcoKSwgKnN0YXRpY19jYXN0PGNvbnN0IFdlYk1vdXNlRXZlbnQqPigmaW5wdXRFdmVu dCkpLAotICAgICAgICAgICAgICBldmVudFR5cGUpOworICAgICAgICAgICAgICBldmVudFR5cGUs IHN0YXRpY19jYXN0PGNvbnN0IFdlYk1vdXNlRXZlbnQqPigmaW5wdXRFdmVudCktPmNsaWNrQ291 bnQpOwogICAgICAgICBtX2N1cnJlbnRJbnB1dEV2ZW50ID0gMDsKICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgfQo= 73551 2010-11-10 16:00:30 -0800 2010-11-17 02:02:35 -0800 Fix clickCount for mouse-up (correct patch format) 49290.patch text/plain 2421 stuartmorgan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzE3NzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMTAgIFN0dWFy dCBNb3JnYW4gIDxzdHVhcnRtb3JnYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjbGljayBjb3VudCBmb3IgbW91c2Ut dXAgZXZlbnRzLgorICAgICAgICAtIGNsaWNrQ291bnQgZm9yIG1vdXNlIHVwIHdhcyBsb3N0IGlu IGNvbnZlcnNpb24gZnJvbSBOU0V2ZW50CisgICAgICAgIC0gY2xpY2tDb3VudCB3YXMgYWxzbyBs b3N0IHdoZW4gZGlzcHRhY2hpbmcgZXZlbnRzIHRocm91Z2ggdGhlCisgICAgICAgIHBsdWdpbiBt b3VzZSBjYXB0dXJlIGV2ZW50IGNvZGVwYXRoLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTI5MAorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmhhbmRsZUlucHV0RXZlbnQpOgor ICAgICAgICAqIHNyYy9tYWMvV2ViSW5wdXRFdmVudEZhY3RvcnkubW06CisgICAgICAgIChXZWJL aXQ6OldlYklucHV0RXZlbnRGYWN0b3J5Ojptb3VzZUV2ZW50KToKKwogMjAxMC0xMS0xMCAgRXZh biBTdGFkZSAgPGVzdGFkZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9u eSBDaGFuZy4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA3 MDA3MikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMDg2LDcgKzEwODYsNyBAQCBib29sIFdlYlZpZXdJbXBsOjpoYW5kbGVJbnB1dEV2 ZW50KGNvbnN0CiAKICAgICAgICAgbm9kZS0+ZGlzcGF0Y2hNb3VzZUV2ZW50KAogICAgICAgICAg ICAgICBQbGF0Zm9ybU1vdXNlRXZlbnRCdWlsZGVyKG1haW5GcmFtZUltcGwoKS0+ZnJhbWVWaWV3 KCksICpzdGF0aWNfY2FzdDxjb25zdCBXZWJNb3VzZUV2ZW50Kj4oJmlucHV0RXZlbnQpKSwKLSAg ICAgICAgICAgICAgZXZlbnRUeXBlKTsKKyAgICAgICAgICAgICAgZXZlbnRUeXBlLCBzdGF0aWNf Y2FzdDxjb25zdCBXZWJNb3VzZUV2ZW50Kj4oJmlucHV0RXZlbnQpLT5jbGlja0NvdW50KTsKICAg ICAgICAgbV9jdXJyZW50SW5wdXRFdmVudCA9IDA7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAg IH0KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0 b3J5Lm1tCShyZXZpc2lvbiA3MDA3MikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklu cHV0RXZlbnRGYWN0b3J5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDE0LDE0ICsxMDE0LDE3IEBA IFdlYk1vdXNlRXZlbnQgV2ViSW5wdXRFdmVudEZhY3Rvcnk6Om1vdXMKICAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBOU0xlZnRNb3VzZVVwOgogICAgICAgICByZXN1bHQudHlwZSA9IFdlYklucHV0 RXZlbnQ6Ok1vdXNlVXA7CisgICAgICAgIHJlc3VsdC5jbGlja0NvdW50ID0gW2V2ZW50IGNsaWNr Q291bnRdOwogICAgICAgICByZXN1bHQuYnV0dG9uID0gV2ViTW91c2VFdmVudDo6QnV0dG9uTGVm dDsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBOU090aGVyTW91c2VVcDoKICAgICAgICAgcmVz dWx0LnR5cGUgPSBXZWJJbnB1dEV2ZW50OjpNb3VzZVVwOworICAgICAgICByZXN1bHQuY2xpY2tD b3VudCA9IFtldmVudCBjbGlja0NvdW50XTsKICAgICAgICAgcmVzdWx0LmJ1dHRvbiA9IFdlYk1v dXNlRXZlbnQ6OkJ1dHRvbk1pZGRsZTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBOU1JpZ2h0 TW91c2VVcDoKICAgICAgICAgcmVzdWx0LnR5cGUgPSBXZWJJbnB1dEV2ZW50OjpNb3VzZVVwOwor ICAgICAgICByZXN1bHQuY2xpY2tDb3VudCA9IFtldmVudCBjbGlja0NvdW50XTsKICAgICAgICAg cmVzdWx0LmJ1dHRvbiA9IFdlYk1vdXNlRXZlbnQ6OkJ1dHRvblJpZ2h0OwogICAgICAgICBicmVh azsKICAgICBjYXNlIE5TTW91c2VNb3ZlZDoK